[lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

From: Aditya Kali The new function kernfs_path_from_node() generates and returns kernfs path of a given kernfs_node relative to a given parent kernfs_node. Signed-off-by: Aditya Kali Signed-off-by: Serge E. Hallyn

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

Hello, Serge. On Tue, Dec 22, 2015 at 10:23:22PM -0600, serge.hal...@ubuntu.com wrote: > @@ -164,18 +286,39 @@ void pr_cont_kernfs_name(struct kernfs_node *kn) > void pr_cont_kernfs_path(struct kernfs_node *kn) > { > unsigned long flags; > - char *p; > + char *p = NULL; > +

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

On Wed, Dec 23, 2015 at 11:24:33AM -0500, Tejun Heo wrote: > On Tue, Dec 22, 2015 at 10:23:22PM -0600, serge.hal...@ubuntu.com wrote: > > From: Aditya Kali > > > > The new function kernfs_path_from_node() generates and returns kernfs > > path of a given kernfs_node

[lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

From: Aditya Kali The new function kernfs_path_from_node() generates and returns kernfs path of a given kernfs_node relative to a given parent kernfs_node. Signed-off-by: Aditya Kali Signed-off-by: Serge E. Hallyn ---

[lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

From: Aditya Kali The new function kernfs_path_from_node() generates and returns kernfs path of a given kernfs_node relative to a given parent kernfs_node. Signed-off-by: Aditya Kali Signed-off-by: Serge E. Hallyn ---

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

Hey, On Wed, Dec 09, 2015 at 10:13:27PM +, Serge Hallyn wrote: > we can rename kn_root to from here if you think that's clearer (and > change the order here as well). I think it'd be better for them to be consistent and in the same order - the target and then the optional base. > > Was

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

Quoting Tejun Heo (t...@kernel.org): > Hello, Serge. > > On Wed, Dec 09, 2015 at 01:28:54PM -0600, serge.hal...@ubuntu.com wrote: > > +/* kernfs_node_depth - compute depth from @from to @to */ > > +static size_t kernfs_depth(struct kernfs_node *from, struct kernfs_node > > *to) > ... > > +char

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

Hello, Serge. On Wed, Dec 09, 2015 at 01:28:54PM -0600, serge.hal...@ubuntu.com wrote: > +/* kernfs_node_depth - compute depth from @from to @to */ > +static size_t kernfs_depth(struct kernfs_node *from, struct kernfs_node *to) ... > +char *kernfs_path(struct kernfs_node *kn, char *buf, size_t

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

On Wed, Dec 09, 2015 at 05:36:51PM -0500, Tejun Heo wrote: > Hey, > > On Wed, Dec 09, 2015 at 10:13:27PM +, Serge Hallyn wrote: > > we can rename kn_root to from here if you think that's clearer (and > > change the order here as well). > > I think it'd be better for them to be consistent and

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

On Wed, Dec 09, 2015 at 05:36:51PM -0500, Tejun Heo wrote: > Hey, > > On Wed, Dec 09, 2015 at 10:13:27PM +, Serge Hallyn wrote: > > we can rename kn_root to from here if you think that's clearer (and > > change the order here as well). > > I think it'd be better for them to be consistent and

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

Hello, On Thu, Nov 26, 2015 at 11:25:11PM -0600, Serge E. Hallyn wrote: > > > + /* Short-circuit the easy case - kn_to is the root node. */ > > > + if ((kn_from == kn_to) || (!kn_from && !kn_to->parent)) { > > > + *p = '/'; > > > + *(p + 1) = '\0'; > > > > Hmm... so if kn_from ==

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

On Mon, Nov 30, 2015 at 10:11:47AM -0500, Tejun Heo wrote: > Hello, > > On Thu, Nov 26, 2015 at 11:25:11PM -0600, Serge E. Hallyn wrote: > > > > + /* Short-circuit the easy case - kn_to is the root node. */ > > > > + if ((kn_from == kn_to) || (!kn_from && !kn_to->parent)) { > > > > +

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

Hello, Serge. On Mon, Nov 30, 2015 at 12:37:58PM -0600, Serge E. Hallyn wrote: > > Yeah, I agree but the name is kinda misleading tho. The output isn't > > really a relative path but rather absolute path against the specified > > root. Maybe updating the function and parameter names would be >

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

On Tue, Nov 24, 2015 at 11:16:30AM -0500, Tejun Heo wrote: > Hello, > > On Mon, Nov 16, 2015 at 01:51:38PM -0600, se...@hallyn.com wrote: > > +static char * __must_check kernfs_path_from_node_locked( (Note I've rewritten this to find a common ancestor and walk back to and from that, as you

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

On Tue, Nov 24, 2015 at 11:17:09AM -0500, Tejun Heo wrote: > Oops, also please cc Greg Kroah-Hartman > on kernfs changes. Will do. Thank you for all the feedback. I'll send out a new set when I get it all addressed. ___

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

Oops, also please cc Greg Kroah-Hartman on kernfs changes. Thanks. -- tejun ___ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel

Re: [lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

Hello, On Mon, Nov 16, 2015 at 01:51:38PM -0600, se...@hallyn.com wrote: > +static char * __must_check kernfs_path_from_node_locked( > + struct kernfs_node *kn_from, > + struct kernfs_node *kn_to, > + char *buf, > + size_t buflen) > +{ > + char *p = buf; > + struct

[lxc-devel] [PATCH 1/8] kernfs: Add API to generate relative kernfs path

From: Aditya Kali The new function kernfs_path_from_node() generates and returns kernfs path of a given kernfs_node relative to a given parent kernfs_node. Signed-off-by: Aditya Kali Acked-by: Serge E. Hallyn ---