Re: [lxc-devel] [PATCH 2/2] daemon: remove pidfile when daemon container is stopped

2014-01-20 Thread Qiang Huang
Hi Stéphane, On 2014/1/21 0:07, Stéphane Graber wrote: On Mon, Jan 20, 2014 at 03:22:31PM +0800, Qiang Huang wrote: On 2014/1/19 8:57, Stéphane Graber wrote: On Sat, Jan 18, 2014 at 03:00:00PM +0800, Qiang Huang wrote: This is for bug: https://github.com/lxc/lxc/issues/89 When start

Re: [lxc-devel] [PATCH 2/2] daemon: remove pidfile when daemon container is stopped

2014-01-20 Thread Stéphane Graber
On Tue, Jan 21, 2014 at 10:54:50AM +0800, Qiang Huang wrote: Hi Stéphane, On 2014/1/21 0:07, Stéphane Graber wrote: On Mon, Jan 20, 2014 at 03:22:31PM +0800, Qiang Huang wrote: On 2014/1/19 8:57, Stéphane Graber wrote: On Sat, Jan 18, 2014 at 03:00:00PM +0800, Qiang Huang wrote: This

Re: [lxc-devel] [PATCH 2/2] daemon: remove pidfile when daemon container is stopped

2014-01-20 Thread Qiang Huang
On 2014/1/21 11:20, Stéphane Graber wrote: On Tue, Jan 21, 2014 at 10:54:50AM +0800, Qiang Huang wrote: Hi Stéphane, I'm not sure I understand this. In my understanding, anything using the API to control an already running backgrounded container will use lxc_container_new to create a new

Re: [lxc-devel] [PATCH 2/2] daemon: remove pidfile when daemon container is stopped

2014-01-20 Thread Stéphane Graber
On Tue, Jan 21, 2014 at 11:33:42AM +0800, Qiang Huang wrote: On 2014/1/21 11:20, Stéphane Graber wrote: On Tue, Jan 21, 2014 at 10:54:50AM +0800, Qiang Huang wrote: Hi Stéphane, I'm not sure I understand this. In my understanding, anything using the API to control an already running

Re: [lxc-devel] [PATCH 2/2] daemon: remove pidfile when daemon container is stopped

2014-01-18 Thread Stéphane Graber
On Sat, Jan 18, 2014 at 03:00:00PM +0800, Qiang Huang wrote: This is for bug: https://github.com/lxc/lxc/issues/89 When start container with daemon model, the daemon process's father will return back to main in start time, and pidfile is removed then, that's not right. So we store pidfile

[lxc-devel] [PATCH 2/2] daemon: remove pidfile when daemon container is stopped

2014-01-17 Thread Qiang Huang
This is for bug: https://github.com/lxc/lxc/issues/89 When start container with daemon model, the daemon process's father will return back to main in start time, and pidfile is removed then, that's not right. So we store pidfile to lxc_container, and remove it when lxc_container_free.