Re: [lxc-devel] lxc-create: file-based capabilities are lost

2017-07-31 Thread Harald Dunkel
On Sat, 29 Jul 2017 14:06:17 +0200 Christian Brauner wrote: > Merged the patch today. Thanks guys! > Would it be possible to merge this change into the 2.0 branch as well? Thanx very much Harri ___ lxc-devel mailing list lxc-devel@lists.linuxconta

Re: [lxc-devel] lxc-create: file-based capabilities are lost

2017-07-29 Thread Christian Brauner
Merged the patch today. Thanks guys!___ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel

Re: [lxc-devel] lxc-create: file-based capabilities are lost

2017-07-28 Thread Serge Hallyn
I really don’t know what happened to that patch, sorry about that. I’ve proposed it now as pull request #1717 into master. Thanks, -serge > On Jul 28, 2017, at 4:13 AM, Harald Dunkel wrote: > > PS: > > On Thu, 27 Jul 2017 08:45:49 -0500 > "Serge E. Hallyn" wrote: > >> >> It looks like the

Re: [lxc-devel] lxc-create: file-based capabilities are lost

2017-07-28 Thread Serge Hallyn
I see the patch in my archives now. I’ll get it pushed. Thanks. Serge > On Jul 28, 2017, at 4:13 AM, Harald Dunkel wrote: > > PS: > > On Thu, 27 Jul 2017 08:45:49 -0500 > "Serge E. Hallyn" wrote: > >> >> It looks like these were done by commit >> 44d397891e691ab994a69766cc72e57265b62da1,

Re: [lxc-devel] lxc-create: file-based capabilities are lost

2017-07-28 Thread Serge Hallyn
I'm sure I'm just being dense. Can you point to your fix? I'll follow up. Serge   Original Message   From: Harald Dunkel Sent: Friday, July 28, 2017 5:13 AM To: Serge E. Hallyn Cc: LXC development mailing-list Subject: Re: [lxc-devel] lxc-create: file-based capabilities are lost

Re: [lxc-devel] lxc-create: file-based capabilities are lost

2017-07-28 Thread Harald Dunkel
PS: On Thu, 27 Jul 2017 08:45:49 -0500 "Serge E. Hallyn" wrote: > > It looks like these were done by commit > 44d397891e691ab994a69766cc72e57265b62da1, > and lxc-2.0.0 does have that commit. > 44d397891e691ab994a69766cc72e57265b62da1 was created on Mon Dec 3 09:53:10 2012, i.e. about 18 mon

Re: [lxc-devel] lxc-create: file-based capabilities are lost

2017-07-28 Thread Harald Dunkel
I verified this on github: % cd /tmp % git clone git://github.com/lxc/lxc Cloning into 'lxc'... remote: Counting objects: 38059, done. remote: Compressing objects: 100% (30/30), done. remote: Total 38059 (delta 19), reused 31 (delta 14), pack-reused 38015 Receiving objects: 100% (38059/38059), 13.

Re: [lxc-devel] lxc-create: file-based capabilities are lost

2017-07-27 Thread Serge E. Hallyn
On Thu, Jul 27, 2017 at 02:48:28PM +0200, Harald Dunkel wrote: > Hi Serge, > > apparently all these fixes have been lost on the 2.0 branch: Hm. are you sure? When I get diff lxc-2.0.0.. templates/lxc-altlinux.in, rsync does not show up. It looks like these were done by commit 44d397891e691ab99

Re: [lxc-devel] lxc-create: file-based capabilities are lost

2017-07-27 Thread Harald Dunkel
Hi Serge, apparently all these fixes have been lost on the 2.0 branch: {hdunkel@dpcl082:lxc (stable-2.0) 507} grep rsync templates/* | grep rootfs templates/lxc-altlinux.in:rsync -Ha $cache/rootfs/ $rootfs_path/ templates/lxc-centos.in:rsync -a $cache/rootfs/ $rootfs_path/ templates/lxc-d

Re: [lxc-devel] lxc-create: file-based capabilities are lost

2016-06-17 Thread Serge E. Hallyn
Quoting Harald Dunkel (ha...@afaics.de): > Hi Serge, > > On 06/15/16 19:00, Serge E. Hallyn wrote: > > Quoting Harald Dunkel (harald.dun...@aixigo.de): > >> > >> Using "rsync -SHaAX" in lxc-debian it works (on Jessie). > >> Attached you can find a suggested patch for all (lxc 1.1.5). > > > > Than

Re: [lxc-devel] lxc-create: file-based capabilities are lost

2016-06-16 Thread Harald Dunkel
Hi Serge, On 06/15/16 19:00, Serge E. Hallyn wrote: > Quoting Harald Dunkel (harald.dun...@aixigo.de): >> >> Using "rsync -SHaAX" in lxc-debian it works (on Jessie). >> Attached you can find a suggested patch for all (lxc 1.1.5). > > Thanks this looks good. Do you mind sending a signed-off-by? >

Re: [lxc-devel] lxc-create: file-based capabilities are lost

2016-06-15 Thread Serge E. Hallyn
Quoting Harald Dunkel (harald.dun...@aixigo.de): > Hi Serge, > > On 06/14/16 17:10, Serge E. Hallyn wrote: > > > > Well I notice that copy_debian() rsyncs without -X. Does > > adding -X fix it for you? > > Using "rsync -SHaAX" in lxc-debian it works (on Jessie). > Attached you can find a sugges

Re: [lxc-devel] lxc-create: file-based capabilities are lost

2016-06-15 Thread Harald Dunkel
Hi Serge, On 06/14/16 17:10, Serge E. Hallyn wrote: > > Well I notice that copy_debian() rsyncs without -X. Does > adding -X fix it for you? Using "rsync -SHaAX" in lxc-debian it works (on Jessie). Attached you can find a suggested patch for all (lxc 1.1.5). Thanx for your help Harri Index:

Re: [lxc-devel] lxc-create: file-based capabilities are lost

2016-06-14 Thread Serge E. Hallyn
On Tue, Jun 14, 2016 at 10:59:51AM +0200, Harald Dunkel wrote: > Hi folks, > > Problem: A container setup with "lxc-create -t debian" has > lost its file-based capabilities (used by systemd, ping, > iputils, ...). I didn't check other template scripts, but > since the major suspect is tar (used fo

[lxc-devel] lxc-create: file-based capabilities are lost

2016-06-14 Thread Harald Dunkel
Hi folks, Problem: A container setup with "lxc-create -t debian" has lost its file-based capabilities (used by systemd, ping, iputils, ...). I didn't check other template scripts, but since the major suspect is tar (used for creating a cache) I would assume that this problem is not restricted to D