[LyX/master] Make WordList noncopyable

commit 7baaeb3fd2d12928f79e32821b6c01784b99b2a6 Author: Georg Baum b...@lyx.org Date: Fri Jul 4 21:15:21 2014 +0200 Make WordList noncopyable To avoid unwanted double deletion of d. diff --git a/src/WordList.h b/src/WordList.h index f57f20b..d21f9c8 100644 --- a/src/WordList.h +++

[LyX/master] Don't guess whether autosave succeeded

commit 50467f3f554129b6ff532f4433da27e9b76aff55 Author: Georg Baum b...@lyx.org Date: Fri Jul 4 21:06:49 2014 +0200 Don't guess whether autosave succeeded writeFile() tells whether it could save the file, so use the return value instead of guessing. diff --git a/src/Buffer.cpp

[LyX/master] Fix bug #9162: Missing \use_indices

commit 22dcdd6d8ff39206bcb627ea6ce4de8c6c07417f Author: Georg Baum b...@lyx.org Date: Fri Jul 4 19:55:44 2014 +0200 Fix bug #9162: Missing \use_indices The lyx2lyx conversion for format 352 was incomplete: It should have been added the \use_indices setting, but it relied on the

[LyX/master] Make theWordList() thread safe.

commit cf89851374163be2e8a390dd917d7ef435978979 Author: Georg Baum b...@lyx.org Date: Fri Jul 4 22:19:43 2014 +0200 Make theWordList() thread safe. Without this, you get crashes in a few second when you set the autosave interval to one second and edit quickly (typing new words

[LyX/master] Make preview filename generation threadsafe

commit 79e79ed5480883ac1fd77c11a24e1185690f4354 Author: Georg Baum b...@lyx.org Date: Sat Jul 5 11:19:34 2014 +0200 Make preview filename generation threadsafe Threadsafety is ensured by the atomic file name generation in TempFile. diff --git a/src/graphics/PreviewLoader.cpp

[LyX/master] Fix Tabular::CellData::operator=()

commit 0092b523c7d3c1735b6854bcbdb4e65ec782f092 Author: Georg Baum b...@lyx.org Date: Sat Jul 5 11:44:13 2014 +0200 Fix Tabular::CellData::operator=() Don't create an intermediate copy (found by Jean-Marc). I doubt that this has anything to do with the mystery crash, but it

[LyX/master] Make Formats::isZippedFile() threadsafe

commit 4a2250a5d1dd551f43f75e54942ecbf0d5702080 Author: Georg Baum b...@lyx.org Date: Sat Jul 5 11:55:35 2014 +0200 Make Formats::isZippedFile() threadsafe In this case I use a mutex, so the zip status of files is shared between threads. This is possible because a deadlock

[LyX/master] Make include and bibitem insets threadsafe

commit 50929b5b8a294079de7b81617a119a51dcb3142c Author: Georg Baum b...@lyx.org Date: Sat Jul 5 12:09:49 2014 +0200 Make include and bibitem insets threadsafe Using a mutex to ensure that the generated filenames and ids are still unique. diff --git a/src/insets/InsetBibitem.cpp

[LyX/master] Make DocFileName::mangledFileName() threadsafe

commit 0de4bc224af34b6f519afb7ab38f190e634b4c7c Author: Georg Baum b...@lyx.org Date: Sat Jul 5 12:22:08 2014 +0200 Make DocFileName::mangledFileName() threadsafe diff --git a/src/support/FileName.cpp b/src/support/FileName.cpp index 95880a0..05492f6 100644 --- a/src/support/FileName.cpp

[LyX/master] Make createBufferTmpDir() threadsafe

commit 4bfca60359825cf51b09f0a6b35a91e2858df374 Author: Georg Baum b...@lyx.org Date: Sat Jul 5 12:31:12 2014 +0200 Make createBufferTmpDir() threadsafe This must not use thread local storage, since the generated directories are all in the same parent directory which is unique

[LyX/master] Make BufferParams::auto_packages() threadsafe

commit e7c41b5f56e48670ed6415edac1811167a1e177b Author: Georg Baum b...@lyx.org Date: Sat Jul 5 12:39:59 2014 +0200 Make BufferParams::auto_packages() threadsafe diff --git a/src/BufferParams.cpp b/src/BufferParams.cpp index 49c55aa..792f148 100644 --- a/src/BufferParams.cpp +++

[LyX/master] Make BufferList::fileNames() threadsafe

commit 922d48da27b4371a089fabc5bc1b6c660ad0f598 Author: Georg Baum b...@lyx.org Date: Sat Jul 5 12:51:40 2014 +0200 Make BufferList::fileNames() threadsafe Using a static variable here was premature optimization: fileNames() is only called from GuiRef (directly or indirectly),

[LyX/master] Make newUnnamedFile() threadsafe

commit 5c431b9335e7e698f866f516665a2c604e7be396 Author: Georg Baum b...@lyx.org Date: Sat Jul 5 12:58:22 2014 +0200 Make newUnnamedFile() threadsafe diff --git a/src/buffer_funcs.cpp b/src/buffer_funcs.cpp index 3f64b90..03ecc90 100644 --- a/src/buffer_funcs.cpp +++ b/src/buffer_funcs.cpp

[LyX/master] Support for Swiss German (old spelling)

commit 0c3b88e3cb817cd030163c534db91ec94f886953 Author: Juergen Spitzmueller sp...@lyx.org Date: Sat Jul 5 13:38:55 2014 +0200 Support for Swiss German (old spelling) diff --git a/lib/languages b/lib/languages index 92387a9..e4c0dd5 100644 --- a/lib/languages +++ b/lib/languages @@ -491,17

[LyX/master] Make LaTeX export threadsafe.

commit 5a8b8ba8e11360a716465b9c6c7c0dc48f37f552 Author: Georg Baum b...@lyx.org Date: Sat Jul 5 14:23:43 2014 +0200 Make LaTeX export threadsafe. This is one of the more important threadsafety issues because of export in thread and simultanous view source. The solution is ugly,

[LyX/master] Fix LaTeXFeatures::useLayout() recursion test

commit 5093893b59938ab3cb59612a90580d4b7956cfec Author: Georg Baum b...@lyx.org Date: Sat Jul 5 14:37:55 2014 +0200 Fix LaTeXFeatures::useLayout() recursion test It was broken in two ways: It was not threadsafe, and it did never detect any recursion, since the counter was

[LyX/master] Fix uncodable author warning

commit 2a677592a5fbbc369dc4199b1c4b3a0c84fb068a Author: Georg Baum b...@lyx.org Date: Sat Jul 5 14:49:51 2014 +0200 Fix uncodable author warning The old code was not threadsafe, and the restriction to one message box per author name did not work if more than two authors were

[LyX/master] Make GraphicsConverter threadsafe

commit 5a01424bf0dbb939cbff1c72ecd99359803a4675 Author: Georg Baum b...@lyx.org Date: Sat Jul 5 15:11:24 2014 +0200 Make GraphicsConverter threadsafe build_script() was already threadsafe, since it used a TempFile, and the counter was basically not needed, but the new solution

[LyX/master] Mark some singletons with FIXME THREAD

commit b88f6ea3aa1c39849a1d295d106ba7bb491e013b Author: Georg Baum b...@lyx.org Date: Sat Jul 5 15:20:54 2014 +0200 Mark some singletons with FIXME THREAD diff --git a/src/ConverterCache.cpp b/src/ConverterCache.cpp index 1451f6e..820eb06 100644 --- a/src/ConverterCache.cpp +++

[LyX/master] Fix typo spotted by cppcheck

commit 8715bab65cc87272dd0d701e31b37363d43d6e95 Author: Jean-Marc lasgout...@lyx.org Date: Sat Jul 5 18:01:19 2014 +0200 Fix typo spotted by cppcheck diff --git a/src/support/lstrings.cpp b/src/support/lstrings.cpp index 8508e4e..ea1ba59 100644 --- a/src/support/lstrings.cpp +++

[LyX/master] Fix possible bug spotted by cppcheck

commit 1cdbb94ff53ba2e73d60aecd53c7b9b44b042701 Author: Jean-Marc lasgout...@lyx.org Date: Sat Jul 5 19:12:09 2014 +0200 Fix possible bug spotted by cppcheck I am not sure what this locking is really about, but the new code seems to be the right thing to do. diff --git

[LyX/master] Fix a bunch of small performance issues spotted by cppcheck

commit 93a43742a5f1db8a632233c15e2b8d61b4835f3a Author: Jean-Marc lasgout...@lyx.org Date: Sat Jul 5 19:13:10 2014 +0200 Fix a bunch of small performance issues spotted by cppcheck Most of these are about passing const strings parameters as references. diff --git a/src/Buffer.cpp

[LyX/master] Make WordList noncopyable

commit 7baaeb3fd2d12928f79e32821b6c01784b99b2a6 Author: Georg Baum Date: Fri Jul 4 21:15:21 2014 +0200 Make WordList noncopyable To avoid unwanted double deletion of d. diff --git a/src/WordList.h b/src/WordList.h index f57f20b..d21f9c8 100644 --- a/src/WordList.h

[LyX/master] Don't guess whether autosave succeeded

commit 50467f3f554129b6ff532f4433da27e9b76aff55 Author: Georg Baum Date: Fri Jul 4 21:06:49 2014 +0200 Don't guess whether autosave succeeded writeFile() tells whether it could save the file, so use the return value instead of guessing. diff --git

[LyX/master] Fix bug #9162: Missing \use_indices

commit 22dcdd6d8ff39206bcb627ea6ce4de8c6c07417f Author: Georg Baum Date: Fri Jul 4 19:55:44 2014 +0200 Fix bug #9162: Missing \use_indices The lyx2lyx conversion for format 352 was incomplete: It should have been added the \use_indices setting, but it relied on

[LyX/master] Make theWordList() thread safe.

commit cf89851374163be2e8a390dd917d7ef435978979 Author: Georg Baum Date: Fri Jul 4 22:19:43 2014 +0200 Make theWordList() thread safe. Without this, you get crashes in a few second when you set the autosave interval to one second and edit quickly (typing new

[LyX/master] Make preview filename generation threadsafe

commit 79e79ed5480883ac1fd77c11a24e1185690f4354 Author: Georg Baum Date: Sat Jul 5 11:19:34 2014 +0200 Make preview filename generation threadsafe Threadsafety is ensured by the atomic file name generation in TempFile. diff --git a/src/graphics/PreviewLoader.cpp

[LyX/master] Fix Tabular::CellData::operator=()

commit 0092b523c7d3c1735b6854bcbdb4e65ec782f092 Author: Georg Baum Date: Sat Jul 5 11:44:13 2014 +0200 Fix Tabular::CellData::operator=() Don't create an intermediate copy (found by Jean-Marc). I doubt that this has anything to do with the mystery crash, but it

[LyX/master] Make Formats::isZippedFile() threadsafe

commit 4a2250a5d1dd551f43f75e54942ecbf0d5702080 Author: Georg Baum Date: Sat Jul 5 11:55:35 2014 +0200 Make Formats::isZippedFile() threadsafe In this case I use a mutex, so the zip status of files is shared between threads. This is possible because a deadlock

[LyX/master] Make include and bibitem insets threadsafe

commit 50929b5b8a294079de7b81617a119a51dcb3142c Author: Georg Baum Date: Sat Jul 5 12:09:49 2014 +0200 Make include and bibitem insets threadsafe Using a mutex to ensure that the generated filenames and ids are still unique. diff --git a/src/insets/InsetBibitem.cpp

[LyX/master] Make DocFileName::mangledFileName() threadsafe

commit 0de4bc224af34b6f519afb7ab38f190e634b4c7c Author: Georg Baum Date: Sat Jul 5 12:22:08 2014 +0200 Make DocFileName::mangledFileName() threadsafe diff --git a/src/support/FileName.cpp b/src/support/FileName.cpp index 95880a0..05492f6 100644 --- a/src/support/FileName.cpp

[LyX/master] Make createBufferTmpDir() threadsafe

commit 4bfca60359825cf51b09f0a6b35a91e2858df374 Author: Georg Baum Date: Sat Jul 5 12:31:12 2014 +0200 Make createBufferTmpDir() threadsafe This must not use thread local storage, since the generated directories are all in the same parent directory which is

[LyX/master] Make BufferParams::auto_packages() threadsafe

commit e7c41b5f56e48670ed6415edac1811167a1e177b Author: Georg Baum Date: Sat Jul 5 12:39:59 2014 +0200 Make BufferParams::auto_packages() threadsafe diff --git a/src/BufferParams.cpp b/src/BufferParams.cpp index 49c55aa..792f148 100644 --- a/src/BufferParams.cpp +++

[LyX/master] Make BufferList::fileNames() threadsafe

commit 922d48da27b4371a089fabc5bc1b6c660ad0f598 Author: Georg Baum Date: Sat Jul 5 12:51:40 2014 +0200 Make BufferList::fileNames() threadsafe Using a static variable here was premature optimization: fileNames() is only called from GuiRef (directly or

[LyX/master] Make newUnnamedFile() threadsafe

commit 5c431b9335e7e698f866f516665a2c604e7be396 Author: Georg Baum Date: Sat Jul 5 12:58:22 2014 +0200 Make newUnnamedFile() threadsafe diff --git a/src/buffer_funcs.cpp b/src/buffer_funcs.cpp index 3f64b90..03ecc90 100644 --- a/src/buffer_funcs.cpp +++

[LyX/master] Support for Swiss German (old spelling)

commit 0c3b88e3cb817cd030163c534db91ec94f886953 Author: Juergen Spitzmueller Date: Sat Jul 5 13:38:55 2014 +0200 Support for Swiss German (old spelling) diff --git a/lib/languages b/lib/languages index 92387a9..e4c0dd5 100644 --- a/lib/languages +++ b/lib/languages @@

[LyX/master] Make LaTeX export threadsafe.

commit 5a8b8ba8e11360a716465b9c6c7c0dc48f37f552 Author: Georg Baum Date: Sat Jul 5 14:23:43 2014 +0200 Make LaTeX export threadsafe. This is one of the more important threadsafety issues because of export in thread and simultanous view source. The solution is

[LyX/master] Fix LaTeXFeatures::useLayout() recursion test

commit 5093893b59938ab3cb59612a90580d4b7956cfec Author: Georg Baum Date: Sat Jul 5 14:37:55 2014 +0200 Fix LaTeXFeatures::useLayout() recursion test It was broken in two ways: It was not threadsafe, and it did never detect any recursion, since the counter was

[LyX/master] Fix uncodable author warning

commit 2a677592a5fbbc369dc4199b1c4b3a0c84fb068a Author: Georg Baum Date: Sat Jul 5 14:49:51 2014 +0200 Fix uncodable author warning The old code was not threadsafe, and the restriction to one message box per author name did not work if more than two authors were

[LyX/master] Make GraphicsConverter threadsafe

commit 5a01424bf0dbb939cbff1c72ecd99359803a4675 Author: Georg Baum Date: Sat Jul 5 15:11:24 2014 +0200 Make GraphicsConverter threadsafe build_script() was already threadsafe, since it used a TempFile, and the counter was basically not needed, but the new

[LyX/master] Mark some singletons with FIXME THREAD

commit b88f6ea3aa1c39849a1d295d106ba7bb491e013b Author: Georg Baum Date: Sat Jul 5 15:20:54 2014 +0200 Mark some singletons with FIXME THREAD diff --git a/src/ConverterCache.cpp b/src/ConverterCache.cpp index 1451f6e..820eb06 100644 --- a/src/ConverterCache.cpp +++

[LyX/master] Fix typo spotted by cppcheck

commit 8715bab65cc87272dd0d701e31b37363d43d6e95 Author: Jean-Marc Date: Sat Jul 5 18:01:19 2014 +0200 Fix typo spotted by cppcheck diff --git a/src/support/lstrings.cpp b/src/support/lstrings.cpp index 8508e4e..ea1ba59 100644 --- a/src/support/lstrings.cpp +++

[LyX/master] Fix possible bug spotted by cppcheck

commit 1cdbb94ff53ba2e73d60aecd53c7b9b44b042701 Author: Jean-Marc Date: Sat Jul 5 19:12:09 2014 +0200 Fix possible bug spotted by cppcheck I am not sure what this locking is really about, but the new code seems to be the right thing to do. diff --git

[LyX/master] Fix a bunch of small performance issues spotted by cppcheck

commit 93a43742a5f1db8a632233c15e2b8d61b4835f3a Author: Jean-Marc Date: Sat Jul 5 19:13:10 2014 +0200 Fix a bunch of small performance issues spotted by cppcheck Most of these are about passing const strings parameters as references. diff --git