commit 2bf77561966c87c0a410a743b2307d955e2135e9
Author: Stephan Witt <sw...@lyx.org>
Date:   Thu Feb 20 08:12:08 2020 +0100

    Avoid potential leak of memory pointed to by QTreeWidgetItem catItem
---
 src/frontends/qt/GuiLyXFiles.cpp |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/frontends/qt/GuiLyXFiles.cpp b/src/frontends/qt/GuiLyXFiles.cpp
index 6a59e6e..096a390 100644
--- a/src/frontends/qt/GuiLyXFiles.cpp
+++ b/src/frontends/qt/GuiLyXFiles.cpp
@@ -418,8 +418,9 @@ void GuiLyXFiles::updateContents()
                                        
qstring_to_ucs4(guiString(catsave.mid(catsave.indexOf('/') + 1)))));
                }
                cat =  
toqstr(translateIfPossible(qstring_to_ucs4(guiString(cat))));
-               QTreeWidgetItem * catItem = new QTreeWidgetItem();
+               QTreeWidgetItem * catItem;
                if (!cats.contains(cat)) {
+                       catItem = new QTreeWidgetItem();
                        catItem->setText(0, cat);
                        catItem->setFont(0, capfont);
                        filesLW->insertTopLevelItem(0, catItem);
-- 
lyx-cvs mailing list
lyx-cvs@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-cvs

Reply via email to