Re: r36663 - lyx-devel/trunk/src

2010-12-03 Thread Andre Poenitz
On Thu, Dec 02, 2010 at 05:09:48PM -0500, Richard Heck wrote: > On 12/02/2010 04:54 PM, Vincent van Ravesteijn wrote: > >>I read somewhere that stacks are best implemented as deques. Don't ask me > >>why now, > >>but I think they are slightly cheaper. (I'm sure Andre would have a view > >>about thi

Re: r36663 - lyx-devel/trunk/src

2010-12-02 Thread Vincent van Ravesteijn
See also output_xhtml.h: typedef std::deque TagDeque; /// typedef std::vector TagStack; /// holds start tags until we know there is content in them. TagDeque pending_tags_; /// remembers the history, so we can make sure we nest properly. TagS

Re: r36663 - lyx-devel/trunk/src

2010-12-02 Thread Vincent van Ravesteijn
> I read somewhere that stacks are best implemented as deques. Don't ask me > why now, > but I think they are slightly cheaper. (I'm sure Andre would have a view > about this.) Some googling gives me: The C++ Standard, in section 23.1.1, offers some advice on which containers to prefer. It says:

Re: r36663 - lyx-devel/trunk/src

2010-12-02 Thread Vincent van Ravesteijn
> -       /// Call then when existing things like footnotes. > +       /// Call this when existing things like footnotes. >        void restoreLastLayout() { layout_stack_.pop_back(); } exiting ? Besides, why are counter_stack_ and layout_stack_ deque's ? >/// Used to keep track of active counte

r36663 - lyx-devel/trunk/src

2010-12-02 Thread rgheck
Author: rgheck Date: Thu Dec 2 21:22:10 2010 New Revision: 36663 URL: http://www.lyx.org/trac/changeset/36663 Log: Some cleanup of the counters code. Modified: lyx-devel/trunk/src/Counters.cpp lyx-devel/trunk/src/Counters.h Modified: lyx-devel/trunk/src/Counters.cpp ==