[LyX/master] Small cleanup to LayoutBox and CategorizedCombo

2017-03-10 Thread Jean-Marc Lasgouttes
commit 0f220503ff9f0b571ce3d3f8ee5941cf344edff7 Author: Jean-Marc Lasgouttes Date: Fri Mar 10 15:54:27 2017 +0100 Small cleanup to LayoutBox and CategorizedCombo Coverity does not find it obvious that p is never negative. Normally it is the case (because the items have been

[LyX/master] Experiment: limit size of strings read from lib/symbols

2017-03-10 Thread Jean-Marc Lasgouttes
commit 9a013637bbe7c35dc90cb28ff874da99133a1f8b Author: Jean-Marc Lasgouttes Date: Fri Mar 10 16:29:09 2017 +0100 Experiment: limit size of strings read from lib/symbols Coverity complains that we might read strings that are arbitrary large, and that this can be a security

[LyX/2.2.x] Fix crash when adding newline at the end of a paragraph

2017-03-11 Thread Jean-Marc Lasgouttes
commit 7808a20e5cd8bb2f80af36bab3036fad7053e6f0 Author: Jean-Marc Lasgouttes Date: Fri Mar 10 19:54:15 2017 +0100 Fix crash when adding newline at the end of a paragraph This is a regression at b0673bd1. The code referred to row.pit(), which was not correctly initialized in

[LyX/master] Limit the size of strings we read from RCS

2017-03-11 Thread Jean-Marc Lasgouttes
commit d6d412c49e47027a38698d906f6ad853c8674582 Author: Jean-Marc Lasgouttes Date: Sat Mar 11 20:46:32 2017 +0100 Limit the size of strings we read from RCS This calms down Coverity which fears than an evil RCS repository would break LyX. --- src/VCBackend.cpp |2 ++ 1 files

[LyX/master] Compilation fix

2017-03-11 Thread Jean-Marc Lasgouttes
commit 5d8918f68f0a2e54f1a13e6345eec63ad27ffc71 Author: Jean-Marc Lasgouttes Date: Sat Mar 11 20:51:39 2017 +0100 Compilation fix It is actually better to compile code before pushing changes... --- src/VCBackend.cpp |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

[LyX/master] Do not use the global variable `formats' in Formats class

2017-03-13 Thread Jean-Marc Lasgouttes
commit a2bfe0042d740da64c1daf60f145211cfc1396ed Author: Jean-Marc Lasgouttes Date: Mon Mar 13 11:39:26 2017 +0100 Do not use the global variable `formats' in Formats class Using this global variable in the class is clearly a bug. If we wanted to avoid doing it by mistake

[LyX/master] Make InsetMathNest::editXY more robust

2017-03-13 Thread Jean-Marc Lasgouttes
commit a69bae0c99e1d365b1fe59693274ba7f608e1829 Author: Jean-Marc Lasgouttes Date: Fri Feb 24 23:58:53 2017 +0100 Make InsetMathNest::editXY more robust If no reasonable cell has been found to put the cursor in (maybe because the cell exist but is not in the cache), exit

[LyX/master] Remove optimization that avoids drawing some math inset cells.

2017-03-13 Thread Jean-Marc Lasgouttes
commit b8c08914276b8b7803bf0fdc8ce75fa8ed15eda9 Author: Jean-Marc Lasgouttes Date: Fri Feb 24 23:25:40 2017 +0100 Remove optimization that avoids drawing some math inset cells. It is not clear that the optimization is a gain, but it is clear that it has a cost: some elements

[LyX/master] Use FileName::lastModified() intead of stat() in DepTable

2017-03-13 Thread Jean-Marc Lasgouttes
commit 591f5780e47f9e555462de7dc78d918fcafe6efa Author: Jean-Marc Lasgouttes Date: Fri Mar 10 11:23:55 2017 +0100 Use FileName::lastModified() intead of stat() in DepTable This patch removes explicit calls to stat() in the DepTable code. The original motivation was to get read

[LyX/master] Only accept non-negative lyxscale parameters

2017-03-14 Thread Jean-Marc Lasgouttes
commit 7d4b8b76068160afe9acd09896866cd46912104d Author: Jean-Marc Lasgouttes Date: Mon Mar 13 18:16:27 2017 +0100 Only accept non-negative lyxscale parameters Since lyxscale is unsigned, a negative value would lead to a very large positive value. Spotted by coverity

[LyX/master] Fixup commit 50060053

2017-03-14 Thread Jean-Marc Lasgouttes
commit 7a124ab8614efa113cc08205c47aeb720b2e2b9e Author: Jean-Marc Lasgouttes Date: Tue Mar 14 14:26:26 2017 +0100 Fixup commit 50060053 Fix two instances where theFormats() was used instead of a local parameter. Fix layout test. --- src/Converter.cpp

[LyX/master] Another forgotten unreachable `return' that is not needed

2017-03-14 Thread Jean-Marc Lasgouttes
commit c6213b1b20f93172e983734359b5b96dcaa02ce0 Author: Jean-Marc Lasgouttes Date: Tue Mar 14 14:46:02 2017 +0100 Another forgotten unreachable `return' that is not needed The compilers we use now do not care, but coverity complains. --- src/insets/InsetListingsParams.cpp |

[LyX/master] Output debug message when creating bad length

2017-03-14 Thread Jean-Marc Lasgouttes
commit 5d29527916f74bcde767edf73dd9751775814b13 Author: Jean-Marc Lasgouttes Date: Tue Mar 14 15:20:09 2017 +0100 Output debug message when creating bad length Coverity is right to say that we should check the return value. --- src/Length.cpp |6 +++--- 1 files changed, 3

[LyX/master] Fix compilation warning in DepTable.cpp

2017-03-20 Thread Jean-Marc Lasgouttes
commit 167eea3990a1a2b5e64ab05ebb26986e76c3b160 Author: Jean-Marc Lasgouttes Date: Mon Mar 20 15:03:09 2017 +0100 Fix compilation warning in DepTable.cpp --- src/DepTable.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/DepTable.h b/src/DepTable.h index

[LyX/master] Linearize macros in box edit mode too.

2017-03-23 Thread Jean-Marc Lasgouttes
commit a48581f48c93b3981ffd3e058f57e3ed95b53641 Author: Jean-Marc Lasgouttes Date: Wed Feb 8 16:42:14 2017 +0100 Linearize macros in box edit mode too. The special mode used by macros where the macro name is displayed as grey text in a box is now one of the possible marker

[LyX/master] Reduce horizontal spacing for simple inline equations

2017-03-24 Thread Jean-Marc Lasgouttes
commit f5fe3c17be0a66b32085585962877dfc2dae9140 Author: Jean-Marc Lasgouttes Date: Thu Nov 17 16:17:49 2016 +0100 Reduce horizontal spacing for simple inline equations --- src/mathed/InsetMathHull.cpp | 18 ++ src/mathed/InsetMathHull.h |6 ++ 2 files changed

[LyX/master] Pass big parameters by address

2017-03-24 Thread Jean-Marc Lasgouttes
commit 72af7f340ca8ee81c7e51633afbb3f9bd435356a Author: Jean-Marc Lasgouttes Date: Fri Mar 24 15:06:13 2017 +0100 Pass big parameters by address Spotted by coverity. --- src/frontends/qt4/GuiCitation.cpp |2 +- src/frontends/qt4/GuiCitation.h |2 +- src/tex2lyx

[LyX/master] Two places where coverity urges us to limit string length

2017-03-24 Thread Jean-Marc Lasgouttes
commit 4ea0fd6af41beffc3eea1efcf8a0427a9d122b9c Author: Jean-Marc Lasgouttes Date: Fri Mar 24 15:25:42 2017 +0100 Two places where coverity urges us to limit string length These two issues make sense, but there are probably others. --- src/insets/InsetTabular.cpp |3 +++ src

[LyX/master] Check return value of regex_match instead of looking at first match

2017-03-24 Thread Jean-Marc Lasgouttes
commit b4fad55fd732c097ac44cf7a3428281376cc5dcc Author: Jean-Marc Lasgouttes Date: Fri Mar 24 15:51:26 2017 +0100 Check return value of regex_match instead of looking at first match Spotted by coverity. --- src/insets/ExternalTransforms.cpp | 11 +++ 1 files changed, 3

[LyX/master] Try alternative syntax for signaling false positive

2017-03-24 Thread Jean-Marc Lasgouttes
commit d7dfa275749c4dde6aac4ce55e8e3f92d9362d8a Author: Jean-Marc Lasgouttes Date: Fri Mar 24 15:54:16 2017 +0100 Try alternative syntax for signaling false positive --- src/lyxfind.cpp |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/lyxfind.cpp b/src

[LyX/master] Fix coverity issues about exceptions

2017-03-24 Thread Jean-Marc Lasgouttes
commit 2a0e4c199c4f18d80ec5a2ab452f3cf18eafc56c Author: Jean-Marc Lasgouttes Date: Fri Mar 24 16:44:14 2017 +0100 Fix coverity issues about exceptions There a some exceptions related to the fact that BOOST_ASSERT throws an unhandled exception, which is fait enough. This is

[LyX/master] Handle properly exception that can be thrown by to_local8bit

2017-03-27 Thread Jean-Marc Lasgouttes
commit 522f3517e1d7f61ed2bbcafe0632f50cb3e8ae2f Author: Jean-Marc Lasgouttes Date: Mon Mar 27 16:08:22 2017 +0200 Handle properly exception that can be thrown by to_local8bit Remove the use of this function in GuiAlert. This was spotted by coverity --- src/frontends/qt4

Re: [LyX/master] Handle properly exception that can be thrown by to_local8bit

2017-03-27 Thread Jean-Marc Lasgouttes
Le 27/03/2017 à 16:17, Jean-Marc Lasgouttes a écrit : commit 522f3517e1d7f61ed2bbcafe0632f50cb3e8ae2f Author: Jean-Marc Lasgouttes Date: Mon Mar 27 16:08:22 2017 +0200 Handle properly exception that can be thrown by to_local8bit Remove the use of this function in GuiAlert. This

[LyX/master] When running latex one needs to have a proper buffer

2017-03-27 Thread Jean-Marc Lasgouttes
commit f7768c994dc6aa6c79c32a8eee77eaa41662f9a4 Author: Jean-Marc Lasgouttes Date: Mon Mar 27 17:43:18 2017 +0200 When running latex one needs to have a proper buffer Calms down coverity --- src/Converter.cpp |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff

[LyX/master] Try a simpler way to tell coverity that we do not care about the result

2017-03-28 Thread Jean-Marc Lasgouttes
commit f58d7dfe7b86ebaca38301747643c4fb460365fe Author: Jean-Marc Lasgouttes Date: Tue Mar 28 10:52:59 2017 +0200 Try a simpler way to tell coverity that we do not care about the result --- src/TextClass.cpp |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src

[LyX/master] Use convert instead of a stream to read LFUN_REPEAT count

2017-03-28 Thread Jean-Marc Lasgouttes
commit 5c03cb340c2214a3142f254622b0efaaa654ec44 Author: Jean-Marc Lasgouttes Date: Tue Mar 28 11:02:21 2017 +0200 Use convert instead of a stream to read LFUN_REPEAT count At least coverity should find it safer. --- src/frontends/qt4/GuiApplication.cpp |5 + 1 files

[LyX/master] Limit the amount of derivatives in external CAS

2017-03-28 Thread Jean-Marc Lasgouttes
commit bc7704a78e32e67253847fdd3d163005fa615209 Author: Jean-Marc Lasgouttes Date: Tue Mar 28 11:17:35 2017 +0200 Limit the amount of derivatives in external CAS The (arbitrary) limit is 1000. Pointed out by coverity. A bad value could lock LyX. --- src/mathed

[LyX/master] Make LFUN_REPEAT more robust by limiting to 10000 iterations

2017-03-28 Thread Jean-Marc Lasgouttes
commit 4488c45d090d84107cc6684f26e0bba1db271818 Author: Jean-Marc Lasgouttes Date: Tue Mar 28 11:30:18 2017 +0200 Make LFUN_REPEAT more robust by limiting to 1 iterations --- src/LyXAction.cpp|1 + src/frontends/qt4/GuiApplication.cpp | 11 +-- 2

[LyX/master] Limit multirow to 100 columns in mathed

2017-03-28 Thread Jean-Marc Lasgouttes
commit 31cd421bcd26647cb7edbb694b05473271fe9153 Author: Jean-Marc Lasgouttes Date: Tue Mar 28 11:41:27 2017 +0200 Limit multirow to 100 columns in mathed Spotted by coverity, this avoids a blocking loop when parsing. --- src/mathed/MathParser.cpp |3 ++- 1 files changed, 2

[LyX/master] Add possibility for command inset to inherit enclosing font

2017-03-28 Thread Jean-Marc Lasgouttes
commit 555338048d417d4532fe954239a0e9e29dd5ee6d Author: Jean-Marc Lasgouttes Date: Thu Jun 23 19:45:10 2016 +0200 Add possibility for command inset to inherit enclosing font The RenderButton object now has this property. It is set depending on the value of inheritFont() method

[LyX/master] Missing initialization in 555338048

2017-03-29 Thread Jean-Marc Lasgouttes
commit f043541ebd0f12f3b97ba834d09528386668af4c Author: Jean-Marc Lasgouttes Date: Wed Mar 29 12:03:57 2017 +0200 Missing initialization in 555338048 Thanks to coverity. --- src/insets/RenderButton.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src

[LyX/master] Annotate destructors to please coverity

2017-03-31 Thread Jean-Marc Lasgouttes
commit e10db6c7dd971f060d1bdeaa16f20f5450e74a9b Author: Jean-Marc Lasgouttes Date: Mon Mar 27 16:18:14 2017 +0200 Annotate destructors to please coverity Coverity flags this code as not handling exception that may happen in buffer(). My own analysis is that this can

[LyX/master] When destructing a workarea, ignore buffer exceptions

2017-03-31 Thread Jean-Marc Lasgouttes
commit 5890e9b831fcac8bc52189612ed0c37d813af4f3 Author: Jean-Marc Lasgouttes Date: Fri Mar 31 11:16:08 2017 +0200 When destructing a workarea, ignore buffer exceptions Spotted by coverity, but probably harmless. --- src/frontends/qt4/GuiWorkArea.cpp |5 - 1 files changed

[LyX/master] Followup to e10db6c7: handle InsetCitation too.

2017-03-31 Thread Jean-Marc Lasgouttes
commit 08561eba3f61204aef7d83940c13712e5b872d1a Author: Jean-Marc Lasgouttes Date: Fri Mar 31 11:23:28 2017 +0200 Followup to e10db6c7: handle InsetCitation too. --- src/insets/InsetBibitem.cpp |2 +- src/insets/InsetBibtex.cpp |2 +- src/insets/InsetCitation.cpp |3

[LyX/master] Tell coverity that LAPPERR kills LyX too.

2017-03-31 Thread Jean-Marc Lasgouttes
commit 21ecd4528a05510c3c1c2ebbbf9d0804e041e5c9 Author: Jean-Marc Lasgouttes Date: Fri Mar 31 11:31:44 2017 +0200 Tell coverity that LAPPERR kills LyX too. --- development/coverity_modeling.cpp |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/development

[LyX/master] When scanning CVS skip unreadable lines

2017-03-31 Thread Jean-Marc Lasgouttes
commit d54578a95166e0b1007ff3e388bd88f809fa76bd Author: Jean-Marc Lasgouttes Date: Fri Mar 31 11:33:34 2017 +0200 When scanning CVS skip unreadable lines Spotted by coverity. --- src/VCBackend.cpp |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src

[LyX/master] A better way to tell coverity that we do not care about result

2017-03-31 Thread Jean-Marc Lasgouttes
commit cb888293d40b08192a04f287b689580b39c35bde Author: Jean-Marc Lasgouttes Date: Fri Mar 31 11:38:30 2017 +0200 A better way to tell coverity that we do not care about result --- src/lyxfind.cpp |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src

[LyX/master] Replace coverity annotation by assertions

2017-03-31 Thread Jean-Marc Lasgouttes
commit 6b2444a7df3674be08d401d4a9381d420a0c0faa Author: Jean-Marc Lasgouttes Date: Fri Mar 31 11:47:47 2017 +0200 Replace coverity annotation by assertions --- src/frontends/qt4/GuiView.cpp |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/frontends/qt4

[LyX/master] Handle exception thrown by Buffer::emergencyWrite

2017-03-31 Thread Jean-Marc Lasgouttes
commit f14ce3f2ef0d7117636fec92bc3a0c4d6a36fe81 Author: Jean-Marc Lasgouttes Date: Fri Mar 31 13:38:35 2017 +0200 Handle exception thrown by Buffer::emergencyWrite Spotted by coverity --- src/Buffer.cpp |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a

[LyX/master] Play again with coverity annotation

2017-03-31 Thread Jean-Marc Lasgouttes
commit ba39d2de04ebe3754f944692a454b91eef4e6177 Author: Jean-Marc Lasgouttes Date: Fri Mar 31 13:59:29 2017 +0200 Play again with coverity annotation The documentation is scarce and it is difficult to see what notation is right. --- src/insets/InsetBibitem.cpp |2 +- src

[LyX/master] Catch another exception

2017-03-31 Thread Jean-Marc Lasgouttes
commit ad20dac17f561743d1e2dc6a6d9a43d6ece59452 Author: Jean-Marc Lasgouttes Date: Fri Mar 31 14:00:46 2017 +0200 Catch another exception Spotted by coverity. --- src/graphics/GraphicsLoader.cpp |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src

[LyX/master] Model lyx_exit() to tell coverity what it does

2017-03-31 Thread Jean-Marc Lasgouttes
commit db7054da9f56d2dc574299e42370cc8cb53cf67a Author: Jean-Marc Lasgouttes Date: Fri Mar 31 16:51:02 2017 +0200 Model lyx_exit() to tell coverity what it does --- development/coverity_modeling.cpp |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/development

[LyX/master] Work around bug in QTextLine::xToCursor

2017-03-31 Thread Jean-Marc Lasgouttes
commit da590925cd6749587b9f500ecdaa457e34bc0f4a Author: Jean-Marc Lasgouttes Date: Fri Mar 31 16:56:06 2017 +0200 Work around bug in QTextLine::xToCursor With RtL text, the method can be non-monotonic wrt x value (which is a Qt bug). To work around this, we check whether

[LyX/master] Improve drawing of math roots (\sqrt and \root)

2017-03-31 Thread Jean-Marc Lasgouttes
commit 758de9577dcf3ff912c794dc4dffa13e138ffd41 Author: Jean-Marc Lasgouttes Date: Fri Mar 31 18:50:14 2017 +0200 Improve drawing of math roots (\sqrt and \root) This is preliminary work to make roots look more like in TeX output: * correct font size for root order

[LyX/master] When converting, indicate clearly when buffer should exist

2017-04-03 Thread Jean-Marc Lasgouttes
commit 0005876d1716328d0eb8c95916024efe09a40202 Author: Jean-Marc Lasgouttes Date: Mon Apr 3 12:25:17 2017 +0200 When converting, indicate clearly when buffer should exist This makes coverity happy, and makes out code a tiny tiny bit better commented. --- src/Converter.cpp

[LyX/master] Possible fix for bug #10295.

2017-04-03 Thread Jean-Marc Lasgouttes
commit 9b0b45dc81e8f1bc5cf370f0a9a8f60b8d93f4e6 Author: Richard Heck Date: Sun Apr 2 20:59:23 2017 -0400 Possible fix for bug #10295. As it was, the comparison buffer was sharing a DocumentClass with one of the compared buffers. I don't fully understand why this was causing

[LyX/master] Revert "Possible fix for bug #10295."

2017-04-03 Thread Jean-Marc Lasgouttes
commit 91b58cc633934eb72589dfb519ebf079b78462aa Author: Jean-Marc Lasgouttes Date: Mon Apr 3 12:29:09 2017 +0200 Revert "Possible fix for bug #10295." This reverts commit 9b0b45dc81e8f1bc5cf370f0a9a8f60b8d93f4e6. (committed by mistake) --- src/Compare.

[LyX/master] Try another way of convincing coverity that everything is fine

2017-04-04 Thread Jean-Marc Lasgouttes
commit aa62b1ad495517f5f966cb27146d17639e669230 Author: Jean-Marc Lasgouttes Date: Tue Apr 4 09:35:55 2017 +0200 Try another way of convincing coverity that everything is fine We have a false positive here, but annotating with coverity[] comments is not very convenient. Let&#

[LyX/master] Replace coverity annotation by an assertion

2017-04-05 Thread Jean-Marc Lasgouttes
commit abc0aaec12dfe8c78cb32f28f6455ca9ec4ef6c2 Author: Jean-Marc Lasgouttes Date: Wed Apr 5 10:20:01 2017 +0200 Replace coverity annotation by an assertion And reorganize the code a bit. --- src/frontends/qt4/GuiWorkArea.cpp | 17 + 1 files changed, 9

[LyX/master] Check both lower and upper bound for tainted loop limit

2017-04-05 Thread Jean-Marc Lasgouttes
commit 7b0e732eebd1951d8845c578c459dce60e98ce66 Author: Jean-Marc Lasgouttes Date: Wed Apr 5 10:22:52 2017 +0200 Check both lower and upper bound for tainted loop limit In these cases, the lower bound is not that important, but coverity insists on it. --- src/mathed

[LyX/master] Use assertions to declare things we know for sure

2017-04-05 Thread Jean-Marc Lasgouttes
commit 60810e0ae20030cd7d34765e58ec89f0c6fb60bb Author: Jean-Marc Lasgouttes Date: Wed Apr 5 11:53:17 2017 +0200 Use assertions to declare things we know for sure Doing it that way makes coverity happy. --- src/frontends/qt4/GuiView.cpp |6 +- 1 files changed, 5

[LyX/master] Make it clear that current_view_ is available when needed

2017-04-06 Thread Jean-Marc Lasgouttes
commit 3bd49d1f75d4d48c03165cd93479a19d9d7d1ab3 Author: Jean-Marc Lasgouttes Date: Wed Apr 5 17:10:13 2017 +0200 Make it clear that current_view_ is available when needed In particular the LATTEST in createView tells coverity that creating a view sets it as current_view_

[LyX/master] Require automake 1.14 and autoconf 2.65

2017-04-06 Thread Jean-Marc Lasgouttes
commit 86ae7dad3fc1cad3744663d0da8034625dc9ffb1 Author: Jean-Marc Lasgouttes Date: Thu Apr 6 13:48:32 2017 +0200 Require automake 1.14 and autoconf 2.65 This allows to fix distclean properly, since we know that subdir-objects is used. When it is the case, it is not a good idea

[LyX/master] editXY: make cursor positionning correct over non editable inset

2017-04-06 Thread Jean-Marc Lasgouttes
commit 6a0c1c65734e0f25eb4fcbfb8926c98b77117c29 Author: Jean-Marc Lasgouttes Date: Thu Apr 6 15:08:50 2017 +0200 editXY: make cursor positionning correct over non editable inset Instead of using complicated (and wrong) code, it is better to use getPosNearX here. Also

[LyX/master] Row::Element::x2pos: go to nearest point also over insets

2017-04-06 Thread Jean-Marc Lasgouttes
commit 8769c0fb750a8c46e6f053c5f73b3991393dcd73 Author: Jean-Marc Lasgouttes Date: Thu Apr 6 15:13:24 2017 +0200 Row::Element::x2pos: go to nearest point also over insets getPosNearX, which is the only user of x2pos, should always return the nearest position. In

[LyX/master] Set boundary correctly in getPosNearX

2017-04-06 Thread Jean-Marc Lasgouttes
commit e3d252cd6256b32745b93c0cb0fd5170f448f91c Author: Jean-Marc Lasgouttes Date: Thu Apr 6 15:05:19 2017 +0200 Set boundary correctly in getPosNearX The code that looks whether neighbor block has a different direction should look to the left or to the right depending on the

[LyX/master] Revert "When selecting text with the mouse, inset selection happens in the middle"

2017-04-06 Thread Jean-Marc Lasgouttes
commit 01f0ab64a76a422ad7a7b916f3564b37e8feab94 Author: Jean-Marc Lasgouttes Date: Sat Apr 1 13:09:23 2017 +0200 Revert "When selecting text with the mouse, inset selection happens in the middle" This reverts commit eb4a2a190f2640d2a6ab7146cfcc347e70b57044. --- s

[LyX/master] Avoid using theServer() for no reason

2017-04-07 Thread Jean-Marc Lasgouttes
commit b925728591829af96552f39cabea229efb1d6fdb Author: Jean-Marc Lasgouttes Date: Fri Apr 7 11:02:36 2017 +0200 Avoid using theServer() for no reason All it brings us is threatening to throw an exception to scare coverity off. --- src/LyX.cpp |2 +- 1 files changed, 1

[LyX/master] Avoid using buffer() which might throw an exception

2017-04-07 Thread Jean-Marc Lasgouttes
commit 61cafeb4d263c279dc43a0475fc1e16a5de38dea Author: Jean-Marc Lasgouttes Date: Fri Apr 7 12:04:02 2017 +0200 Avoid using buffer() which might throw an exception Actually buffer_ is always valid on this codepath, but coverity is not able to see that. --- src/insets

[LyX/master] Better implementation for corssOutLines

2017-04-10 Thread Jean-Marc Lasgouttes
commit 94114fd1218df7d2d99888bd18bc5fee394ff515 Author: Jean-Marc Lasgouttes Date: Mon Apr 10 10:27:08 2017 +0200 Better implementation for corssOutLines When trying to do implement a LaTeX feature on screen, it is always good to see how LaTeX does it, just in case it is easy

[LyX/master] Try to preserve small details from eb4a2a19

2017-04-10 Thread Jean-Marc Lasgouttes
commit 20696ecb7ee335dedcc8a1b0d24e4cc56736d81f Author: Jean-Marc Lasgouttes Date: Mon Apr 10 11:21:29 2017 +0200 Try to preserve small details from eb4a2a19 Part of ticket #10569 --- src/Row.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src

[LyX/master] Set encoding correctly when reading layout files

2017-04-10 Thread Jean-Marc Lasgouttes
commit e19b2a717efe5b223d34aaa7e354eb7fa93cc55d Author: Jean-Marc Lasgouttes Date: Mon Apr 10 15:06:14 2017 +0200 Set encoding correctly when reading layout files Patch from Enrico. --- lib/configure.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib

[LyX/master] Cleanup parindent support

2017-04-17 Thread Jean-Marc Lasgouttes
commit fc4ca364033b65e232b6867e9518d6e6d00c3ace Author: Jean-Marc Lasgouttes Date: Thu Apr 13 22:51:48 2017 +0200 Cleanup parindent support Rename (g|s)etter to (get|set)ParIndent(), and rename member variables accordingly. Do not rely on HSpace anymore, since Length

[LyX/master] Autotools: use silent rule for moc in src/support.

2017-04-18 Thread Jean-Marc Lasgouttes
commit b250eb5a4696c7809d5c1cf83ccc015f707d993c Author: Jean-Marc Lasgouttes Date: Tue Apr 18 14:45:05 2017 +0200 Autotools: use silent rule for moc in src/support. --- src/support/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/support

[LyX/master] Fixes to ParIndent support

2017-04-18 Thread Jean-Marc Lasgouttes
commit e7c3354a871f6f693948bf4c8381dd22ba3a0f13 Author: Jean-Marc Lasgouttes Date: Tue Apr 18 18:06:35 2017 +0200 Fixes to ParIndent support - remove quotes around length - use "default" for default parindent, instead of an empty string - Fix the constructor Len

[LyX/master] Make top/bottom margin value DPI-dependent

2017-04-20 Thread Jean-Marc Lasgouttes
commit b2e759d8b23f9db6b8703b91971f0ccc5ccf8c3d Author: Jean-Marc Lasgouttes Date: Thu Apr 20 18:05:04 2017 +0200 Make top/bottom margin value DPI-dependent One less hardcoded pixel value. Use thisoccasion to set the left/right margin in inches too, since it is easier

[LyX/master] Rewrite mathindent without HSpace class

2017-04-20 Thread Jean-Marc Lasgouttes
commit df6b2f447085bb390ef74d0f6bcdd21b6d633204 Author: Jean-Marc Lasgouttes Date: Wed Apr 19 17:49:11 2017 +0200 Rewrite mathindent without HSpace class Use Length instead of HSpace for math_indentation and rename it to mathindent. Get rid of the string version

[LyX/master] Revert "BufferParams: get rid of the HSpace class for mathindent as requested by JMarc"

2017-04-20 Thread Jean-Marc Lasgouttes
commit d86954eb815b8018eb216bfbc1ab344c45e18ebe Author: Jean-Marc Lasgouttes Date: Wed Apr 19 16:19:18 2017 +0200 Revert "BufferParams: get rid of the HSpace class for mathindent as requested by JMarc" This reverts commit d9a2a4026800865b15da186620ffab4c6b409765.

[LyX/master] Mover.h: let move be defined

2017-04-24 Thread Jean-Marc Lasgouttes
commit 62c9d0f64009be17ed8508c27181b143d2d0a99b Author: Guillaume MM Date: Mon Apr 3 00:31:37 2017 +0200 Mover.h: let move be defined We cannot use default for ~Mover() because gcc 4.6 cannot cope with it. --- src/Mover.h | 10 +++--- 1 files changed, 7 insertions(+), 3 dele

[LyX/master] Configure options cleanup

2017-04-24 Thread Jean-Marc Lasgouttes
commit cd48fb8ae734e2a5a60b281772f4b28f11d25bc8 Author: Jean-Marc Lasgouttes Date: Fri Apr 21 15:52:24 2017 +0200 Configure options cleanup The default build type (computed from LyX version) is now displayed in configure help. Change a little bit the help text of

[LyX/master] Remove unused autoconf macro

2017-04-25 Thread Jean-Marc Lasgouttes
commit fb8148b8c4c1d64cab929e8fb8a0304ab4fa4d26 Author: Jean-Marc Lasgouttes Date: Tue Apr 25 11:50:29 2017 +0200 Remove unused autoconf macro --- config/lyxinclude.m4 | 20 1 files changed, 0 insertions(+), 20 deletions(-) diff --git a/config/lyxinclude.m4 b

[LyX/master] Amend b3fbe4edfd

2017-04-25 Thread Jean-Marc Lasgouttes
commit 91507284cb6f23fe56db3e03e8cabe6e3a7fa7b2 Author: Jean-Marc Lasgouttes Date: Tue Apr 25 19:03:20 2017 +0200 Amend b3fbe4edfd It is better to enumerate all possibilities. Now we have a list of special characters that do not have a tooltip. --- src/insets

Re: [LyX/master] Silence coverity warning.

2017-04-25 Thread Jean-Marc Lasgouttes
Le 25/04/2017 à 18:43, Günter Milde a écrit : commit b3fbe4edfd65b6c7acce4f0df9e51673d9958192 Author: Günter Milde Date: Tue Apr 25 18:42:55 2017 +0200 Silence coverity warning. Er, you meant compile warning, right? + default: + break; I still pre

[LyX/master] Define new inPixels helper in BufferView

2017-04-28 Thread Jean-Marc Lasgouttes
commit de990f72e1ba856ed5f8e5c617c17cdf382ab3a7 Author: Jean-Marc Lasgouttes Date: Fri Apr 28 15:06:30 2017 +0200 Define new inPixels helper in BufferView Length::inPixels(MetricsBase const &) and VSpace::inPixels(BufferView const &) should be moved respectuvely to Met

[LyX/master] Compilation fix

2017-05-03 Thread Jean-Marc Lasgouttes
commit fa146a0ffe431ce239851fc20986e3052127f33a Author: Jean-Marc Lasgouttes Date: Wed May 3 09:39:30 2017 +0200 Compilation fix --- src/LyXAction.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/LyXAction.cpp b/src/LyXAction.cpp index 16efb26..3804fad

[LyX/master] Show properly on screen "indented" maths.

2017-05-03 Thread Jean-Marc Lasgouttes
commit fa2dcd37a2ce34a7202477cc529f007d2503 Author: Jean-Marc Lasgouttes Date: Tue Apr 11 13:03:34 2017 +0200 Show properly on screen "indented" maths. This is done by two things: 1/ the equation returns LefAlign as display() value 2/ Inset::indent(

[LyX/master] Fix compiler warning (gcc 7)

2017-05-03 Thread Jean-Marc Lasgouttes
commit a2cf919f187f8ef6c89157b6f20bf91ffd8f0255 Author: Jean-Marc Lasgouttes Date: Wed May 3 14:51:03 2017 +0200 Fix compiler warning (gcc 7) --- src/insets/InsetIPAMacro.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/insets/InsetIPAMacro.cpp b/src

[LyX/master] Do not pass list of columns parameter by value

2024-01-12 Thread Jean-Marc Lasgouttes
commit 952851a9bcbe6801e73aacc86de0b40bab7d192b Author: Jean-Marc Lasgouttes Date: Fri Jan 12 12:16:31 2024 +0100 Do not pass list of columns parameter by value There is no need for copying this information. Noticed by coverity scan. --- src/insets/InsetTabular.cpp

[LyX/master] Pass strings as reference

2024-01-12 Thread Jean-Marc Lasgouttes
commit 765c380a5b4c67a6fdbc611b445b7229e609dd2a Author: Jean-Marc Lasgouttes Date: Fri Jan 12 14:34:45 2024 +0100 Pass strings as reference Spotted by coverity. --- src/mathed/InsetMathMacroTemplate.cpp | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff

[LyX/master] Pass a two parameters parameter by reference

2024-01-12 Thread Jean-Marc Lasgouttes
commit 1599c503df11b0c73b60e5c239f3cde9dcf73801 Author: Jean-Marc Lasgouttes Date: Fri Jan 12 15:28:39 2024 +0100 Pass a two parameters parameter by reference Note that there is also a vector parameter that is passed by value. However it is modified as a local copy and I do

[LyX/master] Pass two string parameters as reference

2024-01-12 Thread Jean-Marc Lasgouttes
commit 8dd9cfcf5c24f7f3f15980494ef699f338ed0a00 Author: Jean-Marc Lasgouttes Date: Fri Jan 12 16:02:36 2024 +0100 Pass two string parameters as reference Spotted by coverity --- src/insets/InsetIndex.cpp |2 +- src/insets/InsetIndex.h |2 +- 2 files changed, 2

[LyX/master] Initialize members correctly.

2024-01-22 Thread Jean-Marc Lasgouttes
commit b08cb7fb30c2dfae0f04db9d474f22c5fbc56114 Author: Jean-Marc Lasgouttes Date: Mon Jan 22 11:20:06 2024 +0100 Initialize members correctly. Spotted by coverity. --- src/insets/InsetIndex.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src

[LyX/master] Do not error out with too new autoconf/automake

2024-02-01 Thread Jean-Marc Lasgouttes
commit 510b2cfd64b1bca443ba3f4756b1bae0610e98fd Author: Jean-Marc Lasgouttes Date: Fri Feb 2 08:34:51 2024 +0100 Do not error out with too new autoconf/automake The tests are not useful, since the configure.ac file checks for minimal version anyway. --- autogen.sh | 22

[LyX/2.3.x] Do not error out with too new autoconf/automake

2024-02-05 Thread Jean-Marc Lasgouttes
commit 29f2a7ed66c3eddbd1697556aa375ed2263fdf26 Author: Jean-Marc Lasgouttes Date: Fri Feb 2 08:34:51 2024 +0100 Do not error out with too new autoconf/automake The tests are not useful, since the configure.ac file checks for minimal version anyway. (cherry picked

[LyX/2.3.x] Fix a number of issues that were stopping compilation with MSVC 19.

2024-02-05 Thread Jean-Marc Lasgouttes
commit 5969f0e7d113734b7859ab89e5edd05233afc8d1 Author: Richard Kimberly Heck Date: Mon May 4 19:41:18 2020 -0400 Fix a number of issues that were stopping compilation with MSVC 19. Patch from Thibaut Cuvelier, modified slightly by me (mostly for style). (cherry picked fro

[LyX master] bar

2024-02-08 Thread Jean-Marc Lasgouttes
The branch, master, has been updated. - Log - commit a2665dcd5d84fd020515afb7cfa1ac2255aff800 Author: Jean-Marc Lasgouttes Date: Fri Feb 9 00:55:54 2024 +0100 bar diff --git a/bar b/bar new file mode 100644 index 000

[LyX bettertest] baz

2024-02-08 Thread Jean-Marc Lasgouttes
The branch, bettertest, has been created. at 5dd58188940a03e8e0dd3098d02b4b3bb401325a (commit) - Log - commit 5dd58188940a03e8e0dd3098d02b4b3bb401325a Author: Jean-Marc Lasgouttes Date: Fri Feb 9 00:58:57 2024 +0100

[LyX/master] Avoid crash when inserting macro template in tabular inset

2024-02-27 Thread Jean-Marc Lasgouttes
commit 97cf2b6aef1e0d7bc88e863b5d1d9e2920be0dd2 Author: Jean-Marc Lasgouttes Date: Tue Feb 27 18:09:42 2024 +0100 Avoid crash when inserting macro template in tabular inset The issue here is that macro templates are forbidden in InsetTabular (why? I do not know) and Text

[LyX/master] fixup 97cf2b6a: avoid leak

2024-02-27 Thread Jean-Marc Lasgouttes
commit 789a886af8064a8daadffe06cd1515a747e4dda6 Author: Jean-Marc Lasgouttes Date: Tue Feb 27 18:37:07 2024 +0100 fixup 97cf2b6a: avoid leak --- src/Text.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Text.cpp b/src/Text.cpp index 9fb59b5ec9..e1c8830dc3

[LyX/master] Fix compilation on ubuntu 18.04

2024-02-28 Thread Jean-Marc Lasgouttes
commit 23105b2eddd5bb547f3a960c63dc05a8b69a4e28 Author: Jean-Marc Lasgouttes Date: Wed Feb 28 16:58:35 2024 +0100 Fix compilation on ubuntu 18.04 One of Qt 5.9 or gcc 7.5 does not like the or-ing of several enum flags. --- src/frontends/qt/FindAndReplace.cpp | 2 +- 1 file

[LyX/master] Fix support for screen fractional scaling with Wayland

2024-02-29 Thread Jean-Marc Lasgouttes
commit 8f61b0859c9bcb8da71f43f94dcf62da41b84ea4 Author: Jean-Marc Lasgouttes Date: Sun Feb 25 20:17:31 2024 +0100 Fix support for screen fractional scaling with Wayland The display was wrong when a backing store is in use (which is the case with Wayland). To fix this in

[LyX/master] Fixup 71d9f6e9: swap two tests to avoid line breaking issues

2024-02-29 Thread Jean-Marc Lasgouttes
commit 677a2c2cd14d4e607648be41c9b90b42eda9a764 Author: Jean-Marc Lasgouttes Date: Wed Feb 28 11:27:52 2024 +0100 Fixup 71d9f6e9: swap two tests to avoid line breaking issues The new approach to line breaking introduced in 71d9f6e9 is correct, but the newly introduced

[LyX/master] typo

2024-03-21 Thread Jean-Marc Lasgouttes
commit b659d7e3bdb26ed9c862cdb6dcfeb6dcb8cfb89b Author: Jean-Marc Lasgouttes Date: Thu Mar 21 22:40:19 2024 +0100 typo --- INSTALL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/INSTALL b/INSTALL index 8f2836c742..7a44ad8896 100644 --- a/INSTALL +++ b/INSTALL @@ -60,7

[LyX/master] fix documentation of --enable-cxx-mode

2024-03-21 Thread Jean-Marc Lasgouttes
commit 44c0b4e4cc1827d38dcc5284513a62cc62a54362 Author: Jean-Marc Lasgouttes Date: Thu Mar 21 22:50:38 2024 +0100 fix documentation of --enable-cxx-mode --- INSTALL | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/INSTALL b/INSTALL index 7a44ad8896..5c9c4d7489

[LyX/master] Fix display of a math hull inset in a tight inset

2024-03-22 Thread Jean-Marc Lasgouttes
commit 4dfebbe9da27ff500b8245858322f1baeb00100b Author: Jean-Marc Lasgouttes Date: Fri Jul 14 02:13:18 2023 +0200 Fix display of a math hull inset in a tight inset This is a kind of hack. This allows InsetMathHull to state that it needs some elbow room beyond its width, in

[LyX/master] Revert "Fix display of a math hull inset in a tight inset"

2024-03-22 Thread Jean-Marc Lasgouttes
commit 6d62d8009f3c41874cf84aa6577aae3293ebb5e6 Author: Jean-Marc Lasgouttes Date: Fri Mar 22 15:08:26 2024 +0100 Revert "Fix display of a math hull inset in a tight inset" This commit will be replaed by a better solution. Part of ticket #12320. Th

[LyX/master] Typo in doc

2024-03-25 Thread Jean-Marc Lasgouttes
commit 43b1234a98c645bee29e3c9bcca9e4c1bcc46d22 Author: Jean-Marc Lasgouttes Date: Mon Mar 25 22:32:17 2024 +0100 Typo in doc Thanks to Peter J. Puchyr for noticing it. --- lib/doc/LaTeXConfig.lyx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/doc

[LyX/2.3.x] Typo in doc

2024-03-25 Thread Jean-Marc Lasgouttes
commit 0f583c11ea44913bfd1acbf70f569649f89639fa Author: Jean-Marc Lasgouttes Date: Mon Mar 25 22:35:09 2024 +0100 Typo in doc Thanks to Peter J. Puchyr for noticing it. --- lib/doc/LaTeXConfig.lyx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/doc

[LyX/master] Compilation fix with Qt < 5.7

2024-04-03 Thread Jean-Marc Lasgouttes
commit 6260689fd552a5e83d2970dcfd4d5ba7e09443e7 Author: Jean-Marc Lasgouttes Date: Wed Apr 3 12:39:09 2024 +0200 Compilation fix with Qt < 5.7 Qt::ImAnchorRectangle has only been introduced in Qt 5.7. Since it is used to answer a query from the IM machinery, there is no n

[LyX/master] fix typo in fr/Intro.lyx

2024-04-04 Thread Jean-Marc Lasgouttes
commit b28655e91ec64b7fb063d8bfea548f82d5d4cc5b Author: Jean-Marc Lasgouttes Date: Thu Apr 4 17:16:06 2024 +0200 fix typo in fr/Intro.lyx --- lib/doc/fr/Intro.lyx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/doc/fr/Intro.lyx b/lib/doc/fr/Intro.lyx index

<    1   2   3   4   5   6   7   8   9   10   >