[LyX features/biginset] Text::dispatch: ignore single par update when there is a full update

2024-06-08 Thread Jean-Marc Lasgouttes
commit cd3453ec453f811e4204eaad8d4df73fde7fa9c9 Author: Jean-Marc Lasgouttes Date: Fri Jun 7 16:49:25 2024 +0200 Text::dispatch: ignore single par update when there is a full update Reorder the tests so that, when the flag Update::SinglePar has been specified, it does not take

[LyX/2.4.1-devel] Do not draw appendix lines below en of document

2024-06-09 Thread Jean-Marc Lasgouttes
commit 13a6be1f9c4668dd661bc197df226b20e420e24b Author: Jean-Marc Lasgouttes Date: Thu Jun 6 14:32:00 2024 +0200 Do not draw appendix lines below en of document This bug is pretty old, but it was not visible because the grey area below the document would overwrite it

[LyX/2.4.1-devel] Fixup 39c7199a: the code did not do what it was supposed to

2024-06-09 Thread Jean-Marc Lasgouttes
commit 312dacb7f32ce5465e1fe3d5d7ac5e0b9b51e045 Author: Jean-Marc Lasgouttes Date: Wed Jun 5 23:05:22 2024 +0200 Fixup 39c7199a: the code did not do what it was supposed to (cherry picked from commit 92ef555abde86466b7ca3c3401ab8132258fc497) --- src/insets/InsetLayout.h | 2 +- 1

[LyX/master] Remove debug code that is not very useful as it is.

2024-06-10 Thread Jean-Marc Lasgouttes
commit 30338ec6b36f654e32a6ac5fc85e8d3716d42abf Author: Jean-Marc Lasgouttes Date: Mon Jun 10 20:32:47 2024 +0200 Remove debug code that is not very useful as it is. --- src/insets/InsetIndex.cpp | 4 1 file changed, 4 deletions(-) diff --git a/src/insets/InsetIndex.cpp b/src/insets

[LyX/2.4.x] Enable Update::SinglePar in nested insets too

2024-06-10 Thread Jean-Marc Lasgouttes
commit 13c7fd78c6c4876330598e89146ef4c7e44998bd Author: Jean-Marc Lasgouttes Date: Mon Jul 17 14:43:29 2023 +0200 Enable Update::SinglePar in nested insets too The idea of single par update is to try to re-break only the paragraph containing the cursor (if this paragraph

[LyX/2.4.x] In the no-draw phase, do not cache the positions of not visible insets

2024-06-10 Thread Jean-Marc Lasgouttes
commit 5e1c414a21cd5d3345e7d3ff9181d7fa08c86830 Author: Jean-Marc Lasgouttes Date: Mon Jul 24 17:53:16 2023 +0200 In the no-draw phase, do not cache the positions of not visible insets This can make a big difference for a very large branch that contains lots of equations

[LyX/2.4.x] Introduce new helpers ParagraphMetrics::top/bottom

2024-06-10 Thread Jean-Marc Lasgouttes
commit b1a0983570b01348685fbcb3070fc071f1b40c15 Author: Jean-Marc Lasgouttes Date: Tue Jul 25 16:31:13 2023 +0200 Introduce new helpers ParagraphMetrics::top/bottom This avoids code with position/ascent/descent that is difficult to follow. No change in function intended

[LyX/2.4.x] Do not compute metrics at each preview when loading file

2024-06-10 Thread Jean-Marc Lasgouttes
commit 15eef6a2c7cdca128a3476f2109371f35b372eba Author: Jean-Marc Lasgouttes Date: Thu Dec 21 16:33:06 2023 +0100 Do not compute metrics at each preview when loading file With the branch-test.lyx file from #12297, loading takes forever when previews are activated. This is

[LyX/2.4.x] Implement quick scroll

2024-06-10 Thread Jean-Marc Lasgouttes
commit 2434a3a28848669f7d8463bef70c668e0d6e615a Author: Jean-Marc Lasgouttes Date: Mon Jul 24 23:23:40 2023 +0200 Implement quick scroll Replace flag parameter for updateMetrics() by a `force' boolean. When it is false, the method keeps the metrics of paragraphs that are

[LyX/2.4.x] Remove some redundant calls to updatePosCache

2024-06-10 Thread Jean-Marc Lasgouttes
commit e51f9d9f885bdf76ba6a20671d0f730d6be87483 Author: Jean-Marc Lasgouttes Date: Mon Jul 24 15:35:16 2023 +0200 Remove some redundant calls to updatePosCache The setting of insets positions was done twice in updateMetrics. When one of the paragraph is a huge branch, this can

[LyX/2.4.x] Always repaint the gray area below main inset

2024-06-10 Thread Jean-Marc Lasgouttes
commit c9f5f34fd703117981cc198ba910328b93e43e99 Author: Jean-Marc Lasgouttes Date: Tue Apr 16 23:55:24 2024 +0200 Always repaint the gray area below main inset Now that SingleParUpdate does not always lead to a full screen update when the height of the paragraph changes (see

[LyX/2.4.x] Improve the code that limits scrolling at top/bottom

2024-06-10 Thread Jean-Marc Lasgouttes
commit e5aaa64b63ab0a0090df90b034925decd1c84061 Author: Jean-Marc Lasgouttes Date: Fri Nov 17 18:30:37 2023 +0100 Improve the code that limits scrolling at top/bottom The most visible part of this commit is the move of part of BufferView::updateMetrics to a new TextMetrics

[LyX/2.4.x] Document biginset branch

2024-06-10 Thread Jean-Marc Lasgouttes
commit 9b4b05e64ea0e692035052e5c5797545a6915b5a Author: Jean-Marc Lasgouttes Date: Sun Apr 21 22:26:41 2024 +0200 Document biginset branch --- status.24x | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/status.24x b/status.24x index 350e94d4da..78494339b1 100644

[LyX/2.4.x] Sanitize cursors after a buffer has been reloaded

2024-06-10 Thread Jean-Marc Lasgouttes
commit 21096f696a0de7a95b0a12b1d9530c3b4aa399e7 Author: Jean-Marc Lasgouttes Date: Tue Apr 16 11:45:09 2024 +0200 Sanitize cursors after a buffer has been reloaded When a buffer is reloaded, its content may remain the same, but the memory allocation is new, so that the inset

[LyX/2.4.x] Set buffer_ correctly when inseting a math macro over a selection

2024-06-10 Thread Jean-Marc Lasgouttes
commit 13a34d6cd1bbf2a93d5b51624de7085d594cf8fa Author: Jean-Marc Lasgouttes Date: Thu Apr 25 14:28:10 2024 +0200 Set buffer_ correctly when inseting a math macro over a selection The code that handles this special macro insertion (in Cursor::mathMacroClose())) is very weird

[LyX/2.4.x] Try to make sure that math insets have a properly set buffer_ member

2024-06-10 Thread Jean-Marc Lasgouttes
commit 76188dcdf11e06e8772e900de04ccbfb079bafac Author: Jean-Marc Lasgouttes Date: Fri Oct 14 22:42:21 2022 +0200 Try to make sure that math insets have a properly set buffer_ member Set the buffer of contents that is added to a MathData object through MathData::insert() (both

[LyX/2.4.x] Set buffer when creating a MathData from parts of another one

2024-06-10 Thread Jean-Marc Lasgouttes
commit 2699a58cd7c98e54cb5cfbaf3f6cdf2621651a64 Author: Jean-Marc Lasgouttes Date: Thu Apr 25 17:13:15 2024 +0200 Set buffer when creating a MathData from parts of another one This is triggered by selecting part of an equation under Xcb platform (x11). Indeed, the current

[LyX/master] Add "full" drawing strategy

2024-06-11 Thread Jean-Marc Lasgouttes
commit f48cf461010daa8aceb220a6762cb50c1192db0d Author: Jean-Marc Lasgouttes Date: Sat Jul 15 11:46:25 2023 +0200 Add "full" drawing strategy With this patch, 3 draw strategies (set in prefs with \draw_strategy partial|backingstore|full) are available:

[LyX/master] InsetMathMacoTemplate: recompute metrics on editXY too

2024-06-11 Thread Jean-Marc Lasgouttes
commit b54d3520753f79231c9f09a45f4efd9c8ac2d90a Author: Jean-Marc Lasgouttes Date: Tue Jun 11 17:04:58 2024 +0200 InsetMathMacoTemplate: recompute metrics on editXY too This inset can change dimensions when edited (like macros can). Therefore Update::SinglePar should be set

[LyX features/biginset] InsetMathMacoTemplate: recompute metrics on editXY too

2024-06-11 Thread Jean-Marc Lasgouttes
commit b2b565e6cbfda5c62b22610617fef0b6d5472c62 Author: Jean-Marc Lasgouttes Date: Tue Jun 11 17:04:58 2024 +0200 InsetMathMacoTemplate: recompute metrics on editXY too This inset can change dimensions when edited (like macros can). Therefore Update::SinglePar should be set

[LyX/master] Fix depth bar optics

2024-06-14 Thread Jean-Marc Lasgouttes
commit 92aeaf5d73923af03b6ab0e1711b157375d4c8e4 Author: Daniel Ramoeller Date: Thu Aug 13 16:36:15 2020 +0200 Fix depth bar optics --- src/RowPainter.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/RowPainter.cpp b/src/RowPainter.cpp index 19d83c13a3..e84343

[LyX/master] Support qmake with Qt5 too

2024-06-17 Thread Jean-Marc Lasgouttes
commit 5d76b4bb8f7b59a9c7baf6d457de6c05f5a07f47 Author: Jean-Marc Lasgouttes Date: Fri Jun 14 19:17:27 2024 +0200 Support qmake with Qt5 too This extends the support of qmake to Qt5. Currently, the other configuration methods are tried if qmake fails, but a message is

[LyX/master] Move DrawStrategy enum to update_flags.h.

2024-06-18 Thread Jean-Marc Lasgouttes
commit c263463cadc92a9e5b29df97a825328c9300b76a Author: Jean-Marc Lasgouttes Date: Tue Jun 18 14:28:28 2024 +0200 Move DrawStrategy enum to update_flags.h. Introduce new drawStrategy() and drawStrategyDescription() methods to frontend::Application. Show the current

[LyX/master] Add missing override keyword

2024-06-19 Thread Jean-Marc Lasgouttes
commit b78d2a4edae4da0d20ea413c508e6420bf5eeac3 Author: Jean-Marc Lasgouttes Date: Wed Jun 19 15:05:04 2024 +0200 Add missing override keyword --- src/frontends/qt/GuiApplication.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/frontends/qt/GuiApplication.h b

[LyX/master] Remove trailing underscore on members x and y of Point class.

2024-06-20 Thread Jean-Marc Lasgouttes
commit c7c16fe9fa304e2adf68b4cc0ca85e19eaf36404 Author: Jean-Marc Lasgouttes Date: Thu Jun 20 14:28:45 2024 +0200 Remove trailing underscore on members x and y of Point class. These members are not private. --- src/BufferView.cpp | 74

[LyX/master] Remove useless cursor parameter to global undo actions

2024-06-20 Thread Jean-Marc Lasgouttes
commit f6430577798b604a11616c2191e664d56efa7cfb Author: Jean-Marc Lasgouttes Date: Thu Jun 20 17:25:25 2024 +0200 Remove useless cursor parameter to global undo actions Add a Cursor-less version of Undo::recordUndoBufferParams (we don't use an optional arument to

[LyX/master] Add a constructor of UndoGroupHelper that uses a CursorData parameter

2024-06-20 Thread Jean-Marc Lasgouttes
commit e7b1ee47eadc35b75862baf6127a5207412bcf36 Author: Jean-Marc Lasgouttes Date: Thu Jun 20 17:52:19 2024 +0200 Add a constructor of UndoGroupHelper that uses a CursorData parameter This aloows to se the the `before' cursor of the undo group. Not used for now. ---

[LyX/master] Fix cursor when undoing accept/reject all changes

2024-06-20 Thread Jean-Marc Lasgouttes
commit c4531741a9184fa0684d3b1d25c72877bf623da8 Author: Jean-Marc Lasgouttes Date: Thu Jun 20 18:00:13 2024 +0200 Fix cursor when undoing accept/reject all changes Before this change, the whole document would remain selected. This relies on the new UndoGroupHelper

[LyX/master] Rename DocumentCLass:plainInsetLayout() to InsetLayout::undefined()

2024-06-20 Thread Jean-Marc Lasgouttes
commit 608929a857de98c0ca7af4edb79e5c0a017ede35 Author: Jean-Marc Lasgouttes Date: Thu Jun 20 18:26:50 2024 +0200 Rename DocumentCLass:plainInsetLayout() to InsetLayout::undefined() This makes the code easier to understand. --- src/CutAndPaste.cpp| 4 ++-- src

[LyX/master] redoParagraph: avoid extra cache accesses

2024-06-21 Thread Jean-Marc Lasgouttes
commit 45dce93af73845471ca986731fd31da468a42360 Author: Jean-Marc Lasgouttes Date: Fri Jun 21 17:02:13 2024 +0200 redoParagraph: avoid extra cache accesses To this end, CoordCacheBase::add returns true when a change was made. This uses the return value of std::unordered_map

[LyX/master] fix comment

2024-06-25 Thread Jean-Marc Lasgouttes
commit e653907b84298d09d18dab330758a0808b148654 Author: Jean-Marc Lasgouttes Date: Tue Jun 25 12:01:05 2024 +0200 fix comment --- src/mathed/MathStream.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mathed/MathStream.h b/src/mathed/MathStream.h index ca7543101f

Re: [LyX/master] Cmake build: Require std >= 17 for compilation of QT6

2024-06-25 Thread Jean-Marc Lasgouttes
Le 25/06/2024 à 13:45, Kornel Benko a écrit : commit 5ee53450bbef83b60edde401b075f2e1d51ce5b7 Author: Kornel Benko Date: Tue Jun 25 13:50:32 2024 +0200 Cmake build: Require std >= 17 for compilation of QT6 else() + if (CMAKE_CXX_STANDARD LESS 11) +

[LyX/master] Avoid crash when InsetBibitem::updateCommand shows a dialog

2024-07-02 Thread Jean-Marc Lasgouttes
commit c84c59eaecf19b1eb8227f9aadc7f5be187b3856 Author: Jean-Marc Lasgouttes Date: Tue Jul 2 14:49:34 2024 +0200 Avoid crash when InsetBibitem::updateCommand shows a dialog This is one of the places where a dialog is shown (indicating that some bibtems have been renamed) while

[LyX/master] Make sure paragraph positions are updated when scrolling

2024-07-02 Thread Jean-Marc Lasgouttes
commit 6e0ea4269ae792225bb4e0d0f0ffcb3236c3c5c9 Author: Jean-Marc Lasgouttes Date: Wed Jul 3 00:22:55 2024 +0200 Make sure paragraph positions are updated when scrolling Sometimes quick selection-scrolling could cause a crash because the position of some paragraphs is not

[LyX/master] fix comment

2024-07-03 Thread Jean-Marc Lasgouttes
commit 29597f600ee84425d2832cc7598752405787c53e Author: Jean-Marc Lasgouttes Date: Wed Jul 3 15:42:54 2024 +0200 fix comment --- src/insets/Inset.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/insets/Inset.h b/src/insets/Inset.h index 04eb42ce73..ea8f00e38c

[LyX/master] comment

2024-07-03 Thread Jean-Marc Lasgouttes
commit a7204098cfd3839110724ed254a73d338e9eb418 Author: Jean-Marc Lasgouttes Date: Wed Jul 3 16:23:30 2024 +0200 comment --- src/Cursor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Cursor.cpp b/src/Cursor.cpp index c53a7307bf..76f4be407e 100644 --- a/src

[LyX/master] Remove useless SinglePar update when scrolling in text

2024-07-03 Thread Jean-Marc Lasgouttes
commit 2bdd691130e5507fc5cc2ca81e71eef189e90fc5 Author: Jean-Marc Lasgouttes Date: Wed Jul 3 17:31:38 2024 +0200 Remove useless SinglePar update when scrolling in text Using SinglePar does not majke sense here since the paragraph is not modified and it might even not have a

[LyX/master] Make BufferView::singeParUpdate more robust

2024-07-03 Thread Jean-Marc Lasgouttes
commit 89ab9eb569ec0eea87d9a8c269eb87507934e1c5 Author: Jean-Marc Lasgouttes Date: Mon Jul 1 23:56:33 2024 +0200 Make BufferView::singeParUpdate more robust In some cases, it might happen that this method is called in cases where no metrics is know for the current paragraph or

[LyX/2.4.x] Force a Buffer * argument to math insets constructor

2024-07-05 Thread Jean-Marc Lasgouttes
commit b39fb173167cbe4d5e2c72d0dcdb74adae7c26a6 Author: Jean-Marc Lasgouttes Date: Wed Apr 24 15:07:15 2024 +0200 Force a Buffer * argument to math insets constructor Make sure that math insets have a proper buffer. To this end, make the Buffer* parameter of InsetMath

[LyX/2.4.x] Force a Buffer * argument to MathData constructor

2024-07-05 Thread Jean-Marc Lasgouttes
commit 6b546613173e9b562c7d8648e798d5cfbb44eadb Author: Jean-Marc Lasgouttes Date: Wed Apr 24 12:04:23 2024 +0200 Force a Buffer * argument to MathData constructor In order to ensure that MathData objects have a valid buffer, the default MathData() constructor is deleted. This

[LyX/2.4.x] Remove setBuffer call in Cursor::push.

2024-07-05 Thread Jean-Marc Lasgouttes
commit 46d1d6e0d384bea969a55426bef22e03bc231bf8 Author: Richard Kimberly Heck Date: Sat Jun 1 12:06:13 2024 -0400 Remove setBuffer call in Cursor::push. This is potentially slow. It also should be unnecessary after some of JMarc's recent commits. See bug #13050. (cherr

[LyX/master] Fix display of page references when language is not specified

2024-07-05 Thread Jean-Marc Lasgouttes
commit 6f6d9b631d110fb71fcd99351b4f40d58451700a Author: Jean-Marc Lasgouttes Date: Fri Jul 5 16:10:17 2024 +0200 Fix display of page references when language is not specified Using translateIfPossible with null language does not make sense (and gives an error on console

[LyX/master] Fixup 145af7c2: remove unused method

2024-07-10 Thread Jean-Marc Lasgouttes
commit 8bc3799b354908f22270f9d96b2cce43ebd96d66 Author: Jean-Marc Lasgouttes Date: Wed Jul 10 13:42:57 2024 +0200 Fixup 145af7c2: remove unused method TextMetrics::firstVisible(), introduced in this commit, is actually unused. --- src/TextMetrics.cpp | 11 --- src

[LyX/2.4.x] Fix display of page references when language is not specified

2024-07-10 Thread Jean-Marc Lasgouttes
commit f64349db8d544bbce835d958371a39acf67adf41 Author: Jean-Marc Lasgouttes Date: Fri Jul 5 16:10:17 2024 +0200 Fix display of page references when language is not specified Using translateIfPossible with null language does not make sense (and gives an error on console

[LyX/2.4.x] Handle metrics of not visible paragraphs

2024-07-10 Thread Jean-Marc Lasgouttes
commit 10b8861d103490e4598582608ac60407d6b0b711 Author: Jean-Marc Lasgouttes Date: Fri May 17 15:42:08 2024 +0200 Handle metrics of not visible paragraphs The code is not ready for situations where some paragraphs that are not visible have metrics available. In

[LyX/2.4.x] Make sure paragraph positions are updated when scrolling

2024-07-10 Thread Jean-Marc Lasgouttes
commit 288684356016f5cca7959462735f6153cd1adab2 Author: Jean-Marc Lasgouttes Date: Wed Jul 3 00:22:55 2024 +0200 Make sure paragraph positions are updated when scrolling Sometimes quick selection-scrolling could cause a crash because the position of some paragraphs is not

[LyX/2.4.x] Remove useless SinglePar update when scrolling in text

2024-07-10 Thread Jean-Marc Lasgouttes
commit f4364c7593a66c63a7a2b588ff60c3350353d89c Author: Jean-Marc Lasgouttes Date: Wed Jul 3 17:31:38 2024 +0200 Remove useless SinglePar update when scrolling in text Using SinglePar does not majke sense here since the paragraph is not modified and it might even not have a

[LyX/2.4.x] Make BufferView::singeParUpdate more robust

2024-07-10 Thread Jean-Marc Lasgouttes
commit aadf3d8a5da69a5a0a21f4f4420407ce0da37691 Author: Jean-Marc Lasgouttes Date: Mon Jul 1 23:56:33 2024 +0200 Make BufferView::singeParUpdate more robust In some cases, it might happen that this method is called with no metrics or position known for the current paragraph

[LyX/master] Add explicit check for EGREP in configure.ac

2024-07-12 Thread Jean-Marc Lasgouttes
commit 31cde7247638a50c2302744984732064505b7d85 Author: Jean-Marc Lasgouttes Date: Fri Jul 12 16:02:53 2024 +0200 Add explicit check for EGREP in configure.ac It is used in lib/Makefile.am and we were relying some autoconf macros to define it as a side-effect. This is not the

[LyX/master] missing quote in message

2024-07-12 Thread Jean-Marc Lasgouttes
commit ed2e5554d8a1165d284ca75bf6ed191b2427c047 Author: Jean-Marc Lasgouttes Date: Fri Jul 12 19:04:18 2024 +0200 missing quote in message --- src/LyXRC.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/LyXRC.cpp b/src/LyXRC.cpp index feda5110c0..fb9eb8f303

[LyX/master] Sort entries in src/Makefile.am

2024-07-15 Thread Jean-Marc Lasgouttes
commit 281744d24f999eb8896a88c5c0829469a0afa13c Author: Jean-Marc Lasgouttes Date: Mon Jul 15 12:10:08 2024 +0200 Sort entries in src/Makefile.am Remove also STANDALONEFILES variable, which is a remain of monolithic builds. --- src/Makefile.am | 111

[LyX/2.4.x] Add explicit check for EGREP in configure.ac

2024-07-15 Thread Jean-Marc Lasgouttes
commit 2882bed1abcce146107b936f81d77ecd0f051bc0 Author: Jean-Marc Lasgouttes Date: Fri Jul 12 16:02:53 2024 +0200 Add explicit check for EGREP in configure.ac It is used in lib/Makefile.am and we were relying some autoconf macros to define it as a side-effect. This is not the

[LyX/master] Fix faulty undo recording

2024-07-16 Thread Jean-Marc Lasgouttes
commit 82f387dabc2b18de6a9917192f4304e92bff8bc1 Author: Jean-Marc Lasgouttes Date: Tue Jul 16 15:43:11 2024 +0200 Fix faulty undo recording The recordUndo() call is very wrong, since we may be inserting over a selection covering several paragraphs (undo itself works at

[LyX/2.4.x] Fix faulty undo recording

2024-07-18 Thread Jean-Marc Lasgouttes
commit e57ccede186fa3705578a4908cbf8f96f5b9f5b5 Author: Jean-Marc Lasgouttes Date: Tue Jul 16 15:43:11 2024 +0200 Fix faulty undo recording The recordUndo() call is very wrong, since we may be inserting over a selection covering several paragraphs (undo itself works at

[LyX/master] Fixup 2bdd691130: remove two more Update::SinglePar instances

2024-07-20 Thread Jean-Marc Lasgouttes
commit 485f5afc21ba553fd16465231de7570b0c631298 Author: Jean-Marc Lasgouttes Date: Sat Jul 20 17:12:09 2024 +0200 Fixup 2bdd691130: remove two more Update::SinglePar instances They do not do what the author(s) of these lines thought it would do, and can create crashes

[LyX/master] Use background to make math comments more visible

2024-07-20 Thread Jean-Marc Lasgouttes
commit 3040eb0fa2930ae117b9166217ddb8089997c5aa Author: Jean-Marc Lasgouttes Date: Wed Jun 5 10:41:47 2024 +0200 Use background to make math comments more visible --- src/mathed/InsetMathComment.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mathed/InsetMathComment.cpp

[LyX/2.4.x] Fixup f4364c75: remove two more Update::SinglePar instances

2024-07-20 Thread Jean-Marc Lasgouttes
commit 0867aaf5c59ee91871dca51bd1c46942ea6c3379 Author: Jean-Marc Lasgouttes Date: Sat Jul 20 17:12:09 2024 +0200 Fixup f4364c75: remove two more Update::SinglePar instances They do not do what the author(s) of these lines thought it would do, and can create crashes

[LyX/master] Store spellchecker_esc_chars as a docstring

2024-07-21 Thread Jean-Marc Lasgouttes
commit 23379bb1d596359a0922b9d14e6f83c003ecd14d Author: Jean-Marc Lasgouttes Date: Sun Jul 21 21:33:01 2024 +0200 Store spellchecker_esc_chars as a docstring This is a minor optimization to avoid calling from_utf8() repeatedly on a hot path. --- src/LyXRC.cpp

[LyX/master] Remove alpha component of system colors

2024-07-22 Thread Jean-Marc Lasgouttes
commit 095bb18331f8eb4653691a64520d89d4a2d60fc4 Author: Jean-Marc Lasgouttes Date: Mon Jul 22 20:36:20 2024 +0200 Remove alpha component of system colors When using system colors it may happen (on windows 11 in particular) that the background color is actually translucid. This

[LyX/master] Revert "Fix bug #13069."

2024-07-22 Thread Jean-Marc Lasgouttes
commit d7ba7bceb300c49ed1c3edb9b129810bb8a5160b Author: Jean-Marc Lasgouttes Date: Fri Jul 19 14:22:10 2024 +0200 Revert "Fix bug #13069." This reverts commit fafe3ea5d7be1c06fb734e3bc621c551d617a6f7. --- config/qt.m4| 13 +++ src/mathed/InsetMathBo

[LyX/master] Revert "Cmake build: Add Qt?Xml modules to build."

2024-07-22 Thread Jean-Marc Lasgouttes
commit cd4d54f76af59b3fba9e1d5565e463c28493f8cb Author: Jean-Marc Lasgouttes Date: Fri Jul 19 14:20:53 2024 +0200 Revert "Cmake build: Add Qt?Xml modules to build." This reverts commit 01160486974a69e62e0b21490454e8dc2e0a4c8e. --- src/frontends/qt/CMakeLists.txt | 8 +

[LyX/master] Cleanup MathMLStream

2024-07-22 Thread Jean-Marc Lasgouttes
commit fbd4b0a13fae4263cc88aa76bc4fbba5178b15fa Author: Jean-Marc Lasgouttes Date: Fri Jul 19 14:57:58 2024 +0200 Cleanup MathMLStream This is preparatory work for fixing ticket #13069. Remove direct accesses to the underlying stream of MathMLStream in InsetMathChar

[LyX/master] Fix crash when generating MathML with InsetMathBox

2024-07-22 Thread Jean-Marc Lasgouttes
commit 216a6fb348dedac3230f651287a0ccfb48b88818 Author: Jean-Marc Lasgouttes Date: Sat Jul 20 12:15:32 2024 +0200 Fix crash when generating MathML with InsetMathBox Instead of generating code and parsing it to add ... at the right spots, this commit honors the text mode

[LyX/master] Make scrolling-by-selection smoother

2024-07-22 Thread Jean-Marc Lasgouttes
commit 1cc1f0ba27d1846ba244507529d4795ecfa29a39 Author: Jean-Marc Lasgouttes Date: Sat Jul 20 19:47:32 2024 +0200 Make scrolling-by-selection smoother This trivial patch makes scrolling-by-selection smoother by dividing the step size and the time between steps by 8 when

[LyX/2.4.x] Cleanup MathMLStream

2024-07-22 Thread Jean-Marc Lasgouttes
commit 17bc6d05b327034c2034087978c2ebf9f8d9e469 Author: Jean-Marc Lasgouttes Date: Fri Jul 19 14:57:58 2024 +0200 Cleanup MathMLStream This is preparatory work for fixing ticket #13069. Remove direct accesses to the underlying stream of MathMLStream in InsetMathChar

[LyX/2.4.x] Fix crash when generating MathML with InsetMathBox

2024-07-22 Thread Jean-Marc Lasgouttes
commit b29b3eb1fcbc30aad3c5e2800a9db61b823f65ae Author: Jean-Marc Lasgouttes Date: Sat Jul 20 12:15:32 2024 +0200 Fix crash when generating MathML with InsetMathBox Instead of generating code and parsing it to add ... at the right spots, this commit honors the text mode

[LyX/master] Fixup 216a6fb3: fix broken xml syntax

2024-07-23 Thread Jean-Marc Lasgouttes
commit a268fe096a58a7818554a7da4da85896bb289c81 Author: Jean-Marc Lasgouttes Date: Tue Jul 23 15:04:49 2024 +0200 Fixup 216a6fb3: fix broken xml syntax This commit addresses two issues: 1/ the embarassing one: the member SetMode::old_text_level_ was declared as

[LyX/master] Fixup 216a6fb348: close when quitting text mode

2024-07-23 Thread Jean-Marc Lasgouttes
commit 1385f0fddd0229770496b1e50b76782892032d18 Author: Jean-Marc Lasgouttes Date: Tue Jul 23 22:02:50 2024 +0200 Fixup 216a6fb348: close when quitting text mode This fixes malformed documents on UserGuide export. Related to bug #13069. --- src/mathed/MathStream.cpp | 1

[LyX/master] Do not export the content of InsetMathBoxed as text in MathML

2024-07-23 Thread Jean-Marc Lasgouttes
commit 1186d90edf9a6702573f296d5642c5e61ceaaedf Author: Jean-Marc Lasgouttes Date: Tue Jul 23 23:44:58 2024 +0200 Do not export the content of InsetMathBoxed as text in MathML \boxed{} is the only box in LaTeX that contains math. It is amusing that the example file that we had

[LyX/master] Rewrite statistics code

2024-07-24 Thread Jean-Marc Lasgouttes
commit 6e81f317229a585e4d74b68af967873acd1f74ae Author: Jean-Marc Lasgouttes Date: Sun Jul 21 22:09:28 2024 +0200 Rewrite statistics code The statistics code is known to be very slow, because it relies on DocIterator to go through the buffer. This commit introduces a

[LyX/2.4.x] Fixup b29b3eb1: fix broken xml syntax

2024-07-24 Thread Jean-Marc Lasgouttes
commit 8ea0987644eae6f6ec2e5eff308feded4ef51f3e Author: Jean-Marc Lasgouttes Date: Tue Jul 23 15:04:49 2024 +0200 Fixup b29b3eb1: fix broken xml syntax This commit addresses two issues: 1/ the embarassing one: the member SetMode::old_text_level_ was declared as

[LyX/2.4.x] Fixup b29b3eb1: close when quitting text mode

2024-07-24 Thread Jean-Marc Lasgouttes
commit 458ce0fdba19094f97b96b7747a2d7b82d4d7087 Author: Jean-Marc Lasgouttes Date: Tue Jul 23 22:02:50 2024 +0200 Fixup b29b3eb1: close when quitting text mode This fixes malformed documents on UserGuide export. Related to bug #13069. (cherry picked from commit

[LyX/2.4.x] Do not export the content of InsetMathBoxed as text in MathML

2024-07-24 Thread Jean-Marc Lasgouttes
commit 2baa292314cad5255f6779339de3f646dc9d8a2a Author: Jean-Marc Lasgouttes Date: Tue Jul 23 23:44:58 2024 +0200 Do not export the content of InsetMathBoxed as text in MathML \boxed{} is the only box in LaTeX that contains math. It is amusing that the example file that we had

[LyX/master] Do not run updateMacros if the buffer has not changed

2024-07-24 Thread Jean-Marc Lasgouttes
commit 999fb37ebb1aecfda9889fa6a2b2fbb15133f2aa Author: Jean-Marc Lasgouttes Date: Sat Jul 20 22:31:34 2024 +0200 Do not run updateMacros if the buffer has not changed Each buffer now has an id which is increased when it is marked dirty (or when one of its relatives is marked

[LyX/master] Fixup 6e81f317: cut and paste error

2024-07-24 Thread Jean-Marc Lasgouttes
commit 393f65c737b7857ba2cc610b15fe085d34dfb231 Author: Jean-Marc Lasgouttes Date: Wed Jul 24 18:51:35 2024 +0200 Fixup 6e81f317: cut and paste error --- src/BufferView.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BufferView.cpp b/src/BufferView.cpp index

[LyX/master] fix warning

2024-07-24 Thread Jean-Marc Lasgouttes
commit a042d6a9d2a2762f78c51891dc3e6263bc28a126 Author: Jean-Marc Lasgouttes Date: Wed Jul 24 21:08:53 2024 +0200 fix warning --- src/insets/InsetTabular.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/insets/InsetTabular.h b/src/insets/InsetTabular.h index

[LyX/master] Do not update statisitics if buffer has not changed

2024-07-24 Thread Jean-Marc Lasgouttes
commit 0d50a8417f059f7bffc86b562817042564970c05 Author: Jean-Marc Lasgouttes Date: Wed Jul 24 22:19:32 2024 +0200 Do not update statisitics if buffer has not changed Rely on the newly-introduced Buffer::id() to skip statistics computation if the id is the same as last time

[LyX/2.4.x] Make scrolling-by-selection smoother

2024-07-25 Thread Jean-Marc Lasgouttes
commit 73bfef16f3d5a9fe1064dfb8b2782bf82111e4c0 Author: Jean-Marc Lasgouttes Date: Sat Jul 20 19:47:32 2024 +0200 Make scrolling-by-selection smoother This trivial patch makes scrolling-by-selection smoother by dividing the step size and the time between steps by 8 when

[LyX/master] Fixup 999fb37e: always run updateMacros when in batch mode

2024-07-25 Thread Jean-Marc Lasgouttes
commit fe1a3b57df2cd6adf1bd4752d05b1aae40a4e5b7 Author: Jean-Marc Lasgouttes Date: Thu Jul 25 18:30:38 2024 +0200 Fixup 999fb37e: always run updateMacros when in batch mode The optimization is useful in GUI mode only, and it turns out that it creates weird crashes otherwise

Re: [LyX/master] Transform InsetNomenclature to a collapsible

2024-08-12 Thread Jean-Marc Lasgouttes
Le 12/08/2024 à 12:35, Juergen Spitzmueller a écrit : commit a5841b3312d549bb7984ea8382afe490129c0750 Author: Juergen Spitzmueller Date: Mon Aug 12 12:33:16 2024 +0200 Transform InsetNomenclature to a collapsible Looks like a good move! JMarc Fixes: #10460, #12595, #6353

[LyX/master] Force a metrics update of buffer after reload

2024-08-26 Thread Jean-Marc Lasgouttes
commit 52ec69a1af7f8c860d6f1d6ed6337db58d5ce163 Author: Jean-Marc Lasgouttes Date: Tue Aug 27 00:09:04 2024 +0200 Force a metrics update of buffer after reload It makes reload more robust and is in any case good enough to avoid crash in #139091. Fixes bug #13091

[LyX/2.4.x] Force a metrics update of buffer after reload

2024-08-27 Thread Jean-Marc Lasgouttes
commit f06de64047f5b9d3e3033ed208c832c263779497 Author: Jean-Marc Lasgouttes Date: Tue Aug 27 00:09:04 2024 +0200 Force a metrics update of buffer after reload It makes reload more robust and is in any case good enough to avoid crash in #139091. Fixes bug #13091

[LyX/2.4.x] Do not run updateMacros if the buffer has not changed

2024-08-30 Thread Jean-Marc Lasgouttes
commit e2cf6731c0ca3a3d4edec19a24754a8ddcbd3284 Author: Jean-Marc Lasgouttes Date: Sat Jul 20 22:31:34 2024 +0200 Do not run updateMacros if the buffer has not changed Each buffer now has an id which is increased when it is marked dirty (or when one of its relatives is marked

[LyX/master] Streamline -geometry command-line option support

2024-08-30 Thread Jean-Marc Lasgouttes
commit ce9de28f06eb770ae440992fb8ca8b98a07c1cfd Author: Jean-Marc Lasgouttes Date: Thu Aug 29 11:10:31 2024 +0200 Streamline -geometry command-line option support Instead of baking our own support for -geometry command line option on Windows (Qt only does that for Xcb), use

[LyX/master] Get rid of QPA_XCB define

2024-08-30 Thread Jean-Marc Lasgouttes
commit 18c310a8cf60ebc8cab27aeea6fc0a6e1fcc7fcc Author: Jean-Marc Lasgouttes Date: Thu Aug 29 11:15:26 2024 +0200 Get rid of QPA_XCB define Since the platform is selected at run time (e.g. xcb vs. Wayland), it is not a good idea to decide at compile time what code is run

[LyX/master] Remove legacy code to compute geometry

2024-08-30 Thread Jean-Marc Lasgouttes
commit 3c59a9a23cdcae77fd0b85dc2d66d86fe611d051 Author: Jean-Marc Lasgouttes Date: Fri Aug 30 14:31:47 2024 +0200 Remove legacy code to compute geometry This code is not necessary anymore after the fix to #13069. Remove the first QString argument to createView(). Set the

[LyX/master] update comments

2024-08-30 Thread Jean-Marc Lasgouttes
commit 53c8e0b77d2fbc62bf7d895714977d906122657f Author: Jean-Marc Lasgouttes Date: Fri Aug 30 14:53:07 2024 +0200 update comments --- src/Buffer.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Buffer.h b/src/Buffer.h index 2cd1495796..d4e8db8748 100644 --- a

[LyX/master] Fixup 999fb37e: fix thinko

2024-08-30 Thread Jean-Marc Lasgouttes
commit 2eb4e3d3ca063d12371695282ae0bc3d9609ab06 Author: Jean-Marc Lasgouttes Date: Fri Aug 30 15:07:03 2024 +0200 Fixup 999fb37e: fix thinko The current buffer is part of allRelatives(), contrary to what I thought. Therefore updateId() increased the buffer id by two. --- src

[LyX/2.4.x] Fixup e2cf6731: fix thinko

2024-08-30 Thread Jean-Marc Lasgouttes
commit 76ef192214237a5ac11edfd9c09062131eabde12 Author: Jean-Marc Lasgouttes Date: Fri Aug 30 15:07:03 2024 +0200 Fixup e2cf6731: fix thinko The current buffer is part of allRelatives(), contrary to what I thought. Therefore updateId() increased the buffer id by two

[LyX/master] Fix update of cursor in tab-delete when there is a selection

2024-08-30 Thread Jean-Marc Lasgouttes
commit 16be88ca18719a98a555ced268431ca1040658b7 Author: Jean-Marc Lasgouttes Date: Fri Aug 30 16:56:16 2024 +0200 Fix update of cursor in tab-delete when there is a selection The position of the cursor should not be decreased if it is already at the start of the paragraph

[LyX/2.4.x] Avoid missing updates after some operations on selection

2024-08-31 Thread Jean-Marc Lasgouttes
commit 4d46f766ea3f24608b8b7b418893054bfa7495dd Author: Jean-Marc Lasgouttes Date: Fri Aug 30 17:26:48 2024 +0200 Avoid missing updates after some operations on selection The logic at the end of Text::dispatch failed when needsUpdate and singleParUpdate were true at the same

[LyX/2.4.x] Fix update of cursor in tab-delete when there is a selection

2024-08-31 Thread Jean-Marc Lasgouttes
commit 5ca48a7a39e7211bf9f55487d8de38821c8613e6 Author: Jean-Marc Lasgouttes Date: Fri Aug 30 16:56:16 2024 +0200 Fix update of cursor in tab-delete when there is a selection The position of the cursor should not be decreased if it is already at the start of the paragraph

[LyX/2.4.x] Get rid of QPA_XCB define

2024-08-31 Thread Jean-Marc Lasgouttes
commit d7e2ca377f9fab169431e41e820973fad49224b5 Author: Jean-Marc Lasgouttes Date: Thu Aug 29 11:15:26 2024 +0200 Get rid of QPA_XCB define Since the platform is selected at run time (e.g. xcb vs. Wayland), it is not a good idea to decide at compile time what code is run

[LyX/2.4.x] Streamline -geometry command-line option support

2024-08-31 Thread Jean-Marc Lasgouttes
commit 390f45812202a80d80b27a2191c1b8e1ce5f0190 Author: Jean-Marc Lasgouttes Date: Thu Aug 29 11:10:31 2024 +0200 Streamline -geometry command-line option support Instead of baking our own support for -geometry command line option on Windows (Qt only does that for Xcb), use

[LyX/master] Simplify greatly Buffer::scroll/Up/Down methods

2024-09-03 Thread Jean-Marc Lasgouttes
commit 86d2313ce323fd20fadd63f103625e15704ae527 Author: Jean-Marc Lasgouttes Date: Tue Sep 3 15:55:34 2024 +0200 Simplify greatly Buffer::scroll/Up/Down methods The code there that checks whether we scroll beyond the top/bottom of document is not needed anymore, this is

[LyX/master] Streamline BufferView::scrollToCursor

2024-09-03 Thread Jean-Marc Lasgouttes
commit f52842d289d1434c44ffb4c9971279a8e56af612 Author: Jean-Marc Lasgouttes Date: Tue Sep 3 16:21:32 2024 +0200 Streamline BufferView::scrollToCursor There are two parts in this patch : 1/ in the part where the cursor is already visible, replace calls to scroll

[LyX/master] Get rid of BufferView::scrollUp/Down

2024-09-05 Thread Jean-Marc Lasgouttes
commit 439b7bb9c97ba2f267a4ccc9ae3d9af5eab100f9 Author: Jean-Marc Lasgouttes Date: Tue Sep 3 18:13:02 2024 +0200 Get rid of BufferView::scrollUp/Down LFUN_SCROLL was the last user, change it to use only scroll(). Take this opportunity to improve a bit this dispatch code

[LyX/master] Cleanup Page Up/Down code

2024-09-05 Thread Jean-Marc Lasgouttes
commit 9c443d965114318dacbb67db68f5a3fd9b1b8fc2 Author: Jean-Marc Lasgouttes Date: Wed Sep 4 15:48:38 2024 +0200 Cleanup Page Up/Down code Since BufferView::scroll() does not correct scrolling amount at top/bottom anymore, remove its return value and add a new one to

[LyX/master] Add ScrollType BOTTOM and TOGGLE for BufferView::scrollToCursor()

2024-09-06 Thread Jean-Marc Lasgouttes
commit 6c20e5db7db662239e8c2bd47fe28d18b27bd729 Author: Jean-Marc Lasgouttes Date: Thu Sep 5 22:05:38 2024 +0200 Add ScrollType BOTTOM and TOGGLE for BufferView::scrollToCursor() BOTTOM shows the paragraph containing the cursor at the bottom of the work area. TOGGLE

[LyX/master] Remove handling of dispatched() property in BufferView::dispatch

2024-09-06 Thread Jean-Marc Lasgouttes
commit e5c31699b4d8fd13c71212158d835c7fa750100f Author: Jean-Marc Lasgouttes Date: Fri Sep 6 16:21:47 2024 +0200 Remove handling of dispatched() property in BufferView::dispatch As indicated in DispatchResult.h, this is only needed in insets' doDispatch() methods, where

<    3   4   5   6   7   8   9   10   11   12   >