[LyX/master] Handle properly exception that can be thrown by to_local8bit

commit 522f3517e1d7f61ed2bbcafe0632f50cb3e8ae2f Author: Jean-Marc Lasgouttes Date: Mon Mar 27 16:08:22 2017 +0200 Handle properly exception that can be thrown by to_local8bit Remove the use of this function in GuiAlert. This was spotted by coverity --- src/frontends/qt4

Re: [LyX/master] Handle properly exception that can be thrown by to_local8bit

Le 27/03/2017 à 16:17, Jean-Marc Lasgouttes a écrit : commit 522f3517e1d7f61ed2bbcafe0632f50cb3e8ae2f Author: Jean-Marc Lasgouttes Date: Mon Mar 27 16:08:22 2017 +0200 Handle properly exception that can be thrown by to_local8bit Remove the use of this function in GuiAlert. This

[LyX/master] When running latex one needs to have a proper buffer

commit f7768c994dc6aa6c79c32a8eee77eaa41662f9a4 Author: Jean-Marc Lasgouttes Date: Mon Mar 27 17:43:18 2017 +0200 When running latex one needs to have a proper buffer Calms down coverity --- src/Converter.cpp |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff

[LyX/master] Try a simpler way to tell coverity that we do not care about the result

commit f58d7dfe7b86ebaca38301747643c4fb460365fe Author: Jean-Marc Lasgouttes Date: Tue Mar 28 10:52:59 2017 +0200 Try a simpler way to tell coverity that we do not care about the result --- src/TextClass.cpp |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src

[LyX/master] Use convert instead of a stream to read LFUN_REPEAT count

commit 5c03cb340c2214a3142f254622b0efaaa654ec44 Author: Jean-Marc Lasgouttes Date: Tue Mar 28 11:02:21 2017 +0200 Use convert instead of a stream to read LFUN_REPEAT count At least coverity should find it safer. --- src/frontends/qt4/GuiApplication.cpp |5 + 1 files

[LyX/master] Limit the amount of derivatives in external CAS

commit bc7704a78e32e67253847fdd3d163005fa615209 Author: Jean-Marc Lasgouttes Date: Tue Mar 28 11:17:35 2017 +0200 Limit the amount of derivatives in external CAS The (arbitrary) limit is 1000. Pointed out by coverity. A bad value could lock LyX. --- src/mathed

[LyX/master] Make LFUN_REPEAT more robust by limiting to 10000 iterations

commit 4488c45d090d84107cc6684f26e0bba1db271818 Author: Jean-Marc Lasgouttes Date: Tue Mar 28 11:30:18 2017 +0200 Make LFUN_REPEAT more robust by limiting to 1 iterations --- src/LyXAction.cpp|1 + src/frontends/qt4/GuiApplication.cpp | 11 +-- 2

[LyX/master] Limit multirow to 100 columns in mathed

commit 31cd421bcd26647cb7edbb694b05473271fe9153 Author: Jean-Marc Lasgouttes Date: Tue Mar 28 11:41:27 2017 +0200 Limit multirow to 100 columns in mathed Spotted by coverity, this avoids a blocking loop when parsing. --- src/mathed/MathParser.cpp |3 ++- 1 files changed, 2

[LyX/master] Add possibility for command inset to inherit enclosing font

commit 555338048d417d4532fe954239a0e9e29dd5ee6d Author: Jean-Marc Lasgouttes Date: Thu Jun 23 19:45:10 2016 +0200 Add possibility for command inset to inherit enclosing font The RenderButton object now has this property. It is set depending on the value of inheritFont() method

[LyX/master] Missing initialization in 555338048

commit f043541ebd0f12f3b97ba834d09528386668af4c Author: Jean-Marc Lasgouttes Date: Wed Mar 29 12:03:57 2017 +0200 Missing initialization in 555338048 Thanks to coverity. --- src/insets/RenderButton.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src

[LyX/master] Annotate destructors to please coverity

commit e10db6c7dd971f060d1bdeaa16f20f5450e74a9b Author: Jean-Marc Lasgouttes Date: Mon Mar 27 16:18:14 2017 +0200 Annotate destructors to please coverity Coverity flags this code as not handling exception that may happen in buffer(). My own analysis is that this can

[LyX/master] When destructing a workarea, ignore buffer exceptions

commit 5890e9b831fcac8bc52189612ed0c37d813af4f3 Author: Jean-Marc Lasgouttes Date: Fri Mar 31 11:16:08 2017 +0200 When destructing a workarea, ignore buffer exceptions Spotted by coverity, but probably harmless. --- src/frontends/qt4/GuiWorkArea.cpp |5 - 1 files changed

[LyX/master] Followup to e10db6c7: handle InsetCitation too.

commit 08561eba3f61204aef7d83940c13712e5b872d1a Author: Jean-Marc Lasgouttes Date: Fri Mar 31 11:23:28 2017 +0200 Followup to e10db6c7: handle InsetCitation too. --- src/insets/InsetBibitem.cpp |2 +- src/insets/InsetBibtex.cpp |2 +- src/insets/InsetCitation.cpp |3

[LyX/master] Tell coverity that LAPPERR kills LyX too.

commit 21ecd4528a05510c3c1c2ebbbf9d0804e041e5c9 Author: Jean-Marc Lasgouttes Date: Fri Mar 31 11:31:44 2017 +0200 Tell coverity that LAPPERR kills LyX too. --- development/coverity_modeling.cpp |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/development

[LyX/master] When scanning CVS skip unreadable lines

commit d54578a95166e0b1007ff3e388bd88f809fa76bd Author: Jean-Marc Lasgouttes Date: Fri Mar 31 11:33:34 2017 +0200 When scanning CVS skip unreadable lines Spotted by coverity. --- src/VCBackend.cpp |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src

[LyX/master] A better way to tell coverity that we do not care about result

commit cb888293d40b08192a04f287b689580b39c35bde Author: Jean-Marc Lasgouttes Date: Fri Mar 31 11:38:30 2017 +0200 A better way to tell coverity that we do not care about result --- src/lyxfind.cpp |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src

[LyX/master] Replace coverity annotation by assertions

commit 6b2444a7df3674be08d401d4a9381d420a0c0faa Author: Jean-Marc Lasgouttes Date: Fri Mar 31 11:47:47 2017 +0200 Replace coverity annotation by assertions --- src/frontends/qt4/GuiView.cpp |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/frontends/qt4

[LyX/master] Handle exception thrown by Buffer::emergencyWrite

commit f14ce3f2ef0d7117636fec92bc3a0c4d6a36fe81 Author: Jean-Marc Lasgouttes Date: Fri Mar 31 13:38:35 2017 +0200 Handle exception thrown by Buffer::emergencyWrite Spotted by coverity --- src/Buffer.cpp |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a

[LyX/master] Play again with coverity annotation

commit ba39d2de04ebe3754f944692a454b91eef4e6177 Author: Jean-Marc Lasgouttes Date: Fri Mar 31 13:59:29 2017 +0200 Play again with coverity annotation The documentation is scarce and it is difficult to see what notation is right. --- src/insets/InsetBibitem.cpp |2 +- src

[LyX/master] Catch another exception

commit ad20dac17f561743d1e2dc6a6d9a43d6ece59452 Author: Jean-Marc Lasgouttes Date: Fri Mar 31 14:00:46 2017 +0200 Catch another exception Spotted by coverity. --- src/graphics/GraphicsLoader.cpp |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src

[LyX/master] Model lyx_exit() to tell coverity what it does

commit db7054da9f56d2dc574299e42370cc8cb53cf67a Author: Jean-Marc Lasgouttes Date: Fri Mar 31 16:51:02 2017 +0200 Model lyx_exit() to tell coverity what it does --- development/coverity_modeling.cpp |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/development

[LyX/master] Work around bug in QTextLine::xToCursor

commit da590925cd6749587b9f500ecdaa457e34bc0f4a Author: Jean-Marc Lasgouttes Date: Fri Mar 31 16:56:06 2017 +0200 Work around bug in QTextLine::xToCursor With RtL text, the method can be non-monotonic wrt x value (which is a Qt bug). To work around this, we check whether

[LyX/master] Improve drawing of math roots (\sqrt and \root)

commit 758de9577dcf3ff912c794dc4dffa13e138ffd41 Author: Jean-Marc Lasgouttes Date: Fri Mar 31 18:50:14 2017 +0200 Improve drawing of math roots (\sqrt and \root) This is preliminary work to make roots look more like in TeX output: * correct font size for root order

[LyX/master] When converting, indicate clearly when buffer should exist

commit 0005876d1716328d0eb8c95916024efe09a40202 Author: Jean-Marc Lasgouttes Date: Mon Apr 3 12:25:17 2017 +0200 When converting, indicate clearly when buffer should exist This makes coverity happy, and makes out code a tiny tiny bit better commented. --- src/Converter.cpp

[LyX/master] Possible fix for bug #10295.

commit 9b0b45dc81e8f1bc5cf370f0a9a8f60b8d93f4e6 Author: Richard Heck Date: Sun Apr 2 20:59:23 2017 -0400 Possible fix for bug #10295. As it was, the comparison buffer was sharing a DocumentClass with one of the compared buffers. I don't fully understand why this was causing

[LyX/master] Revert "Possible fix for bug #10295."

commit 91b58cc633934eb72589dfb519ebf079b78462aa Author: Jean-Marc Lasgouttes Date: Mon Apr 3 12:29:09 2017 +0200 Revert "Possible fix for bug #10295." This reverts commit 9b0b45dc81e8f1bc5cf370f0a9a8f60b8d93f4e6. (committed by mistake) --- src/Compare.

[LyX/master] Try another way of convincing coverity that everything is fine

commit aa62b1ad495517f5f966cb27146d17639e669230 Author: Jean-Marc Lasgouttes Date: Tue Apr 4 09:35:55 2017 +0200 Try another way of convincing coverity that everything is fine We have a false positive here, but annotating with coverity[] comments is not very convenient. Let&#

[LyX/master] Replace coverity annotation by an assertion

commit abc0aaec12dfe8c78cb32f28f6455ca9ec4ef6c2 Author: Jean-Marc Lasgouttes Date: Wed Apr 5 10:20:01 2017 +0200 Replace coverity annotation by an assertion And reorganize the code a bit. --- src/frontends/qt4/GuiWorkArea.cpp | 17 + 1 files changed, 9

[LyX/master] Check both lower and upper bound for tainted loop limit

commit 7b0e732eebd1951d8845c578c459dce60e98ce66 Author: Jean-Marc Lasgouttes Date: Wed Apr 5 10:22:52 2017 +0200 Check both lower and upper bound for tainted loop limit In these cases, the lower bound is not that important, but coverity insists on it. --- src/mathed

[LyX/master] Use assertions to declare things we know for sure

commit 60810e0ae20030cd7d34765e58ec89f0c6fb60bb Author: Jean-Marc Lasgouttes Date: Wed Apr 5 11:53:17 2017 +0200 Use assertions to declare things we know for sure Doing it that way makes coverity happy. --- src/frontends/qt4/GuiView.cpp |6 +- 1 files changed, 5

[LyX/master] Make it clear that current_view_ is available when needed

commit 3bd49d1f75d4d48c03165cd93479a19d9d7d1ab3 Author: Jean-Marc Lasgouttes Date: Wed Apr 5 17:10:13 2017 +0200 Make it clear that current_view_ is available when needed In particular the LATTEST in createView tells coverity that creating a view sets it as current_view_

[LyX/master] Require automake 1.14 and autoconf 2.65

commit 86ae7dad3fc1cad3744663d0da8034625dc9ffb1 Author: Jean-Marc Lasgouttes Date: Thu Apr 6 13:48:32 2017 +0200 Require automake 1.14 and autoconf 2.65 This allows to fix distclean properly, since we know that subdir-objects is used. When it is the case, it is not a good idea

[LyX/master] editXY: make cursor positionning correct over non editable inset

commit 6a0c1c65734e0f25eb4fcbfb8926c98b77117c29 Author: Jean-Marc Lasgouttes Date: Thu Apr 6 15:08:50 2017 +0200 editXY: make cursor positionning correct over non editable inset Instead of using complicated (and wrong) code, it is better to use getPosNearX here. Also

[LyX/master] Row::Element::x2pos: go to nearest point also over insets

commit 8769c0fb750a8c46e6f053c5f73b3991393dcd73 Author: Jean-Marc Lasgouttes Date: Thu Apr 6 15:13:24 2017 +0200 Row::Element::x2pos: go to nearest point also over insets getPosNearX, which is the only user of x2pos, should always return the nearest position. In

[LyX/master] Set boundary correctly in getPosNearX

commit e3d252cd6256b32745b93c0cb0fd5170f448f91c Author: Jean-Marc Lasgouttes Date: Thu Apr 6 15:05:19 2017 +0200 Set boundary correctly in getPosNearX The code that looks whether neighbor block has a different direction should look to the left or to the right depending on the

[LyX/master] Revert "When selecting text with the mouse, inset selection happens in the middle"

commit 01f0ab64a76a422ad7a7b916f3564b37e8feab94 Author: Jean-Marc Lasgouttes Date: Sat Apr 1 13:09:23 2017 +0200 Revert "When selecting text with the mouse, inset selection happens in the middle" This reverts commit eb4a2a190f2640d2a6ab7146cfcc347e70b57044. --- s

[LyX/master] Avoid using theServer() for no reason

commit b925728591829af96552f39cabea229efb1d6fdb Author: Jean-Marc Lasgouttes Date: Fri Apr 7 11:02:36 2017 +0200 Avoid using theServer() for no reason All it brings us is threatening to throw an exception to scare coverity off. --- src/LyX.cpp |2 +- 1 files changed, 1

[LyX/master] Avoid using buffer() which might throw an exception

commit 61cafeb4d263c279dc43a0475fc1e16a5de38dea Author: Jean-Marc Lasgouttes Date: Fri Apr 7 12:04:02 2017 +0200 Avoid using buffer() which might throw an exception Actually buffer_ is always valid on this codepath, but coverity is not able to see that. --- src/insets

[LyX/master] Better implementation for corssOutLines

commit 94114fd1218df7d2d99888bd18bc5fee394ff515 Author: Jean-Marc Lasgouttes Date: Mon Apr 10 10:27:08 2017 +0200 Better implementation for corssOutLines When trying to do implement a LaTeX feature on screen, it is always good to see how LaTeX does it, just in case it is easy

[LyX/master] Try to preserve small details from eb4a2a19

commit 20696ecb7ee335dedcc8a1b0d24e4cc56736d81f Author: Jean-Marc Lasgouttes Date: Mon Apr 10 11:21:29 2017 +0200 Try to preserve small details from eb4a2a19 Part of ticket #10569 --- src/Row.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src

[LyX/master] Set encoding correctly when reading layout files

commit e19b2a717efe5b223d34aaa7e354eb7fa93cc55d Author: Jean-Marc Lasgouttes Date: Mon Apr 10 15:06:14 2017 +0200 Set encoding correctly when reading layout files Patch from Enrico. --- lib/configure.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib

[LyX/master] Cleanup parindent support

commit fc4ca364033b65e232b6867e9518d6e6d00c3ace Author: Jean-Marc Lasgouttes Date: Thu Apr 13 22:51:48 2017 +0200 Cleanup parindent support Rename (g|s)etter to (get|set)ParIndent(), and rename member variables accordingly. Do not rely on HSpace anymore, since Length

[LyX/master] Autotools: use silent rule for moc in src/support.

commit b250eb5a4696c7809d5c1cf83ccc015f707d993c Author: Jean-Marc Lasgouttes Date: Tue Apr 18 14:45:05 2017 +0200 Autotools: use silent rule for moc in src/support. --- src/support/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/support

[LyX/master] Fixes to ParIndent support

commit e7c3354a871f6f693948bf4c8381dd22ba3a0f13 Author: Jean-Marc Lasgouttes Date: Tue Apr 18 18:06:35 2017 +0200 Fixes to ParIndent support - remove quotes around length - use "default" for default parindent, instead of an empty string - Fix the constructor Len

[LyX/master] Make top/bottom margin value DPI-dependent

commit b2e759d8b23f9db6b8703b91971f0ccc5ccf8c3d Author: Jean-Marc Lasgouttes Date: Thu Apr 20 18:05:04 2017 +0200 Make top/bottom margin value DPI-dependent One less hardcoded pixel value. Use thisoccasion to set the left/right margin in inches too, since it is easier

[LyX/master] Rewrite mathindent without HSpace class

commit df6b2f447085bb390ef74d0f6bcdd21b6d633204 Author: Jean-Marc Lasgouttes Date: Wed Apr 19 17:49:11 2017 +0200 Rewrite mathindent without HSpace class Use Length instead of HSpace for math_indentation and rename it to mathindent. Get rid of the string version

[LyX/master] Revert "BufferParams: get rid of the HSpace class for mathindent as requested by JMarc"

commit d86954eb815b8018eb216bfbc1ab344c45e18ebe Author: Jean-Marc Lasgouttes Date: Wed Apr 19 16:19:18 2017 +0200 Revert "BufferParams: get rid of the HSpace class for mathindent as requested by JMarc" This reverts commit d9a2a4026800865b15da186620ffab4c6b409765.

[LyX/master] Mover.h: let move be defined

commit 62c9d0f64009be17ed8508c27181b143d2d0a99b Author: Guillaume MM Date: Mon Apr 3 00:31:37 2017 +0200 Mover.h: let move be defined We cannot use default for ~Mover() because gcc 4.6 cannot cope with it. --- src/Mover.h | 10 +++--- 1 files changed, 7 insertions(+), 3 dele

[LyX/master] Configure options cleanup

commit cd48fb8ae734e2a5a60b281772f4b28f11d25bc8 Author: Jean-Marc Lasgouttes Date: Fri Apr 21 15:52:24 2017 +0200 Configure options cleanup The default build type (computed from LyX version) is now displayed in configure help. Change a little bit the help text of

[LyX/master] Remove unused autoconf macro

commit fb8148b8c4c1d64cab929e8fb8a0304ab4fa4d26 Author: Jean-Marc Lasgouttes Date: Tue Apr 25 11:50:29 2017 +0200 Remove unused autoconf macro --- config/lyxinclude.m4 | 20 1 files changed, 0 insertions(+), 20 deletions(-) diff --git a/config/lyxinclude.m4 b

[LyX/master] Amend b3fbe4edfd

commit 91507284cb6f23fe56db3e03e8cabe6e3a7fa7b2 Author: Jean-Marc Lasgouttes Date: Tue Apr 25 19:03:20 2017 +0200 Amend b3fbe4edfd It is better to enumerate all possibilities. Now we have a list of special characters that do not have a tooltip. --- src/insets

Re: [LyX/master] Silence coverity warning.

Le 25/04/2017 à 18:43, Günter Milde a écrit : commit b3fbe4edfd65b6c7acce4f0df9e51673d9958192 Author: Günter Milde Date: Tue Apr 25 18:42:55 2017 +0200 Silence coverity warning. Er, you meant compile warning, right? + default: + break; I still pre

[LyX/master] Define new inPixels helper in BufferView

commit de990f72e1ba856ed5f8e5c617c17cdf382ab3a7 Author: Jean-Marc Lasgouttes Date: Fri Apr 28 15:06:30 2017 +0200 Define new inPixels helper in BufferView Length::inPixels(MetricsBase const &) and VSpace::inPixels(BufferView const &) should be moved respectuvely to Met

[LyX/master] Compilation fix

commit fa146a0ffe431ce239851fc20986e3052127f33a Author: Jean-Marc Lasgouttes Date: Wed May 3 09:39:30 2017 +0200 Compilation fix --- src/LyXAction.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/LyXAction.cpp b/src/LyXAction.cpp index 16efb26..3804fad

[LyX/master] Show properly on screen "indented" maths.

commit fa2dcd37a2ce34a7202477cc529f007d2503 Author: Jean-Marc Lasgouttes Date: Tue Apr 11 13:03:34 2017 +0200 Show properly on screen "indented" maths. This is done by two things: 1/ the equation returns LefAlign as display() value 2/ Inset::indent(

[LyX/master] Fix compiler warning (gcc 7)

commit a2cf919f187f8ef6c89157b6f20bf91ffd8f0255 Author: Jean-Marc Lasgouttes Date: Wed May 3 14:51:03 2017 +0200 Fix compiler warning (gcc 7) --- src/insets/InsetIPAMacro.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/insets/InsetIPAMacro.cpp b/src

[LyX/master] Change ordering of function codes

commit 4bbcc4c563ff470b455f3c3b11a32b756ef66f43 Author: Jean-Marc Lasgouttes Date: Tue May 9 16:26:08 2017 +0200 Change ordering of function codes Fixup e575e7ee so that func code numbers are still correct. --- src/FuncCode.h |2 +- 1 files changed, 1 insertions(+), 1

Re: [LyX/master] python3: fix the preview framework to work with both python 2 and 3

Le 09/05/2017 à 12:21, José Matos a écrit : commit 11f2a59ce90b406537ff3379276d5e0bb1bf6c37 Author: José Matos Date: Tue May 9 11:20:34 2017 +0100 python3: fix the preview framework to work with both python 2 and 3 I just got the following. Is it related? File "/home/lasgoutt/src/lyx/m

[LyX/master] Never, never use a string for something that has 3 values

commit d4685f2806683849002e0fb77b8e0335ed998092 Author: Jean-Marc Lasgouttes Date: Fri May 12 11:57:17 2017 +0200 Never, never use a string for something that has 3 values This commit replaces the string math_number_before by a proper math_number enum. Note that the

Re: [LyX/master] Never, never use a string for something that has 3 values

Le 12/05/2017 à 12:01, Jean-Marc Lasgouttes a écrit : commit d4685f2806683849002e0fb77b8e0335ed998092 Author: Jean-Marc Lasgouttes Date: Fri May 12 11:57:17 2017 +0200 Never, never use a string for something that has 3 values This commit replaces the string math_number_before by a

Re: [LyX/master] Never, never use a string for something that has 3 values

Le 12/05/2017 à 12:01, Jean-Marc Lasgouttes a écrit : Note that the _before naming was misleading. It was chosen at a time when we were not sure whether leqno was always left or could be right in RtL documents. Now that I think more about it, the variable could be renamed to

[LyX/master] Proper GUI feedback for leqno option

commit f1dd80f464b46f6112f6c9a64a70dd3da76cbe7f Author: Jean-Marc Lasgouttes Date: Fri May 12 15:07:02 2017 +0200 Proper GUI feedback for leqno option With these changes, equation numbers are shown properly on screen. When setting is default, we guess the side using these two

[LyX/master] Cache QTextLayout objects with Qt/Mac

commit 5354c64b273eac7b869ca44436db7088d8c73bb4 Author: Jean-Marc Lasgouttes Date: Tue Apr 18 14:02:31 2017 +0200 Cache QTextLayout objects with Qt/Mac It seems that the internal Qt5 caching does not work well here, especially in the case of Herbrew documents. --- src

[LyX/master] Fix compilation failure

commit 676ce147da9f5873b4177a0cc3dd706005dd0690 Author: Jean-Marc Lasgouttes Date: Mon May 15 10:29:09 2017 +0200 Fix compilation failure --- src/frontends/qt4/qt_helpers.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/frontends/qt4/qt_helpers.h b/src

[LyX/2.2.x] Work around bug in QTextLine::xToCursor

commit db9f41c03975654254cc10c7628ec8173dbc7f13 Author: Jean-Marc Lasgouttes Date: Fri Mar 31 16:56:06 2017 +0200 Work around bug in QTextLine::xToCursor With RtL text, the method can be non-monotonic wrt x value (which is a Qt bug). To work around this, we check whether

[LyX/2.2.x] editXY: make cursor positionning correct over non editable inset

commit bafc40b857b5fc3341031365bf2f4cb3a4a13e45 Author: Jean-Marc Lasgouttes Date: Thu Apr 6 15:08:50 2017 +0200 editXY: make cursor positionning correct over non editable inset Instead of using complicated (and wrong) code, it is better to use getPosNearX here. Also

[LyX/2.2.x] Set boundary correctly in getPosNearX

commit ff9732462114b939f330f88689ba36d61fde3b8f Author: Jean-Marc Lasgouttes Date: Thu Apr 6 15:05:19 2017 +0200 Set boundary correctly in getPosNearX The code that looks whether neighbor block has a different direction should look to the left or to the right depending on the

[LyX/2.2.x] Row::Element::x2pos: go to nearest point also over insets

commit b82137ef185d95505180f39e1d8d67a9ca3a4f49 Author: Jean-Marc Lasgouttes Date: Thu Apr 6 15:13:24 2017 +0200 Row::Element::x2pos: go to nearest point also over insets getPosNearX, which is the only user of x2pos, should always return the nearest position. In

[LyX/master] Revert "Add possibility for command inset to inherit enclosing font"

commit 3f34ebbaf932ea645e584a17d643c9b7f19b2a86 Author: Jean-Marc Lasgouttes Date: Tue May 23 16:50:53 2017 +0200 Revert "Add possibility for command inset to inherit enclosing font" The new method was badly named, it was not supposed to override the existing i

[LyX/master] Let command inset honor inheritFont() on screen

commit b58dcff836f9eb4507df81abffd83e2bfac2b3d0 Author: Jean-Marc Lasgouttes Date: Wed May 24 11:28:08 2017 +0200 Let command inset honor inheritFont() on screen The RenderButton object now has a inherit_font_ property. It is set depending on the value of Inset::inheritFont

[LyX/master] Revert "InsetHyperlink: inherit font (#10677)"

commit 0516af0c99e333ce67996d6f0fdc8446d778853f Author: Jean-Marc Lasgouttes Date: Tue May 23 17:05:51 2017 +0200 Revert "InsetHyperlink: inherit font (#10677)" This will be replaced with a better fix (see #10682). This reve

[LyX/master] Take in account end of paragraph marker for inset width

commit 91f3b21e42c7b3b2028ec8f66460440e9ddadcbf Author: Jean-Marc Lasgouttes Date: Wed May 24 14:05:06 2017 +0200 Take in account end of paragraph marker for inset width When an inset wants to use the whole available width, it is necessary to take into account that some of

[LyX/2.2.x] Take in account end of paragraph marker for inset width

commit 413de12adfb82953669e0d7f3e9128a891cc6b1e Author: Jean-Marc Lasgouttes Date: Wed May 24 14:05:06 2017 +0200 Take in account end of paragraph marker for inset width When an inset wants to use the whole available width, it is necessary to take into account that some of

[LyX/2.2.x] Cache QTextLayout objects with Qt/Mac

commit 04350ad288e2147d4874ca4efc57f38a957ba82c Author: Jean-Marc Lasgouttes Date: Tue Apr 18 14:02:31 2017 +0200 Cache QTextLayout objects with Qt/Mac It seems that the internal Qt5 caching does not work well here, especially in the case of ancient Hebrew documents

[LyX/master] Output default mathindent value as "default"

commit 83cd3f4293a3a17f09abfbe55fd4a30418a6ba9d Author: Jean-Marc Lasgouttes Date: Wed May 24 15:40:36 2017 +0200 Output default mathindent value as "default" This is like parindent now. The old code would avoid outputing the value when it was empty (default i

[LyX/master] Fix warning about signed/unsigned

commit a98df5853719256139977e5de0146f3604af9975 Author: Jean-Marc Lasgouttes Date: Wed Jun 7 11:05:29 2017 +0200 Fix warning about signed/unsigned --- src/insets/InsetListings.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/insets/InsetListings.cpp b/src

[LyX/master] Fix drawing of collpsable insets

commit 18fb9cd7f9886295dbae66eb6ac060f9ac367f2d Author: Jean-Marc Lasgouttes Date: Wed Jun 7 12:20:33 2017 +0200 Fix drawing of collpsable insets This is a follow-up to e194c9ce. There was actually no reason to let InsetCollapsable and InsetText draw their own background. It

[LyX/master] Revert "Fix drawing of collpsable insets"

commit 48144c474b9ac006e93413482dbcab06e4dd4caf Author: Jean-Marc Lasgouttes Date: Wed Jun 7 16:01:11 2017 +0200 Revert "Fix drawing of collpsable insets" This patch cuses unintended issues (see #10587). This reverts commit 18fb9cd7f9886295dbae66eb6ac060

[LyX/master] Properly use top/bottom edit marker for grid inset

commit 29fbd062cc58eabfa846e6a18c7f66ef08cae8d3 Author: Jean-Marc Lasgouttes Date: Thu Jun 8 16:03:14 2017 +0200 Properly use top/bottom edit marker for grid inset This was an oversight when marker() was introduced. Fixes part of #10688. --- src/mathed/InsetMathGrid.h

[LyX/master] Fix bad cursor positioning when entering an inset

commit 7ca7873112314963c3a43987f32484749ec3af58 Author: Jean-Marc Lasgouttes Date: Thu Jun 8 11:35:05 2017 +0200 Fix bad cursor positioning when entering an inset The test added at 359aef92 was incorrect. Actually, Inset::editXY returns the inset when it is edited and also

[LyX/master] Give a 2 pixels space for markers around math objects

commit 5a3962958f2a2c5370b302d6dfea0967343b9a46 Author: Jean-Marc Lasgouttes Date: Thu Jun 8 15:22:03 2017 +0200 Give a 2 pixels space for markers around math objects --- src/mathed/MathRow.cpp | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src

[LyX/master] Fix drawing of collpsable insets

commit 6fc72a1a1ffc6abb321ce1b7921eed5655302b40 Author: Jean-Marc Lasgouttes Date: Wed Jun 7 12:20:33 2017 +0200 Fix drawing of collpsable insets This is a follow-up to e194c9ce. There was actually no reason to let InsetCollapsable and InsetText draw their own background. It

[LyX/master] Revert "Give a 2 pixels space for markers around math objects"

commit 1538a8352ca82914bc131f2bf98b0ef4f55c1e2d Author: Jean-Marc Lasgouttes Date: Thu Jun 8 16:46:19 2017 +0200 Revert "Give a 2 pixels space for markers around math objects" This is not ready yet. This reverts commit 5a3962958f2a2c5370b302d6dfea0967343b9a46

[LyX/master] Revert "Fix bad cursor positioning when entering an inset"

commit a33b633111f2c23a0f479bbc72f466b222fd8df4 Author: Jean-Marc Lasgouttes Date: Thu Jun 8 16:46:49 2017 +0200 Revert "Fix bad cursor positioning when entering an inset" This is not ready yet. This reverts commit 7ca7873112314963c3a43987f32484749ec3af58

[LyX/master] Revert "Fix drawing of collpsable insets"

commit cb5464ea2b9ba25c515aa638c5bed620c7d887c3 Author: Jean-Marc Lasgouttes Date: Thu Jun 8 16:47:26 2017 +0200 Revert "Fix drawing of collpsable insets" This was definitely not meant to be pushed, especially since I reverted it recently. Sorry folks. Th

[LyX/master] Give a 2 pixels space for markers around math objects

commit 183c97d8a8a0e864c4341976615673457e8e8335 Author: Jean-Marc Lasgouttes Date: Thu Jun 8 15:22:03 2017 +0200 Give a 2 pixels space for markers around math objects This is necessary when markers are nested. Ideally this should only be done when there is risk of nesting

[LyX/master] Fix bad cursor positioning when entering an inset

commit c9fefd5a2cf5eb97fb23279e5b5e2f4c3a19b22e Author: Jean-Marc Lasgouttes Date: Thu Jun 8 11:35:05 2017 +0200 Fix bad cursor positioning when entering an inset The test added at 359aef92 was incorrect. Actually, Inset::editXY returns the inset when it is edited and also

[LyX/master] Avoid rounding issue when painting selection

commit 71563835c7943ea987a5d967b79ec90cb2b3c26e Author: Jean-Marc Lasgouttes Date: Mon Jun 12 14:39:03 2017 +0200 Avoid rounding issue when painting selection This is the same issue that was addressed in the all_sel case at 695b0cc3. The rounding issue only happens at specific

[LyX/2.2.x] Fix bad cursor positioning when entering an inset

commit 04efc84abceb49e2042e357583a84b07847c1a5a Author: Jean-Marc Lasgouttes Date: Thu Jun 8 11:35:05 2017 +0200 Fix bad cursor positioning when entering an inset The test added at 359aef92 was incorrect. Actually, Inset::editXY returns the inset when it is edited and also

[LyX/2.2.x] Avoid rounding issue when painting selection

commit 8fef81a37371fa5cc7961fc669d340bed2105866 Author: Jean-Marc Lasgouttes Date: Mon Jun 12 14:39:03 2017 +0200 Avoid rounding issue when painting selection This issue was already addressed in the all_sel case. It only happens at specific zoom and jusification values

[LyX/master] Use proper markers for display version of the math macro template.

commit f6b0ccf99c1f2e3eb836883dc574e861ca84194f Author: Jean-Marc Lasgouttes Date: Mon Jun 12 15:14:23 2017 +0200 Use proper markers for display version of the math macro template. This avoids ghost white corners when the macro does not have a display version. Part of

[LyX/master] Improvements to inset edit markers

commit 95c678111201b671146f9d9fc0e8d17b24f11781 Author: Jean-Marc Lasgouttes Date: Mon Jun 12 17:09:58 2017 +0200 Improvements to inset edit markers Draw also upper markers when editing macros in MACRO_EDIT_INLINE_BOX mode. Use MARKER2 for inline editing of macros

[LyX/master] Set cursor properly after double/triple click in mathed

commit 5d7dae9e382f0b01800f5652e673e12fa6923740 Author: Jean-Marc Lasgouttes Date: Mon Jun 12 18:00:43 2017 +0200 Set cursor properly after double/triple click in mathed Without this setCurrentFont() is not correctly called on the BufferView cursor and the cursor could appear

[LyX/master] Add lower corners for BOX_MARKER too

commit cc7917c55c045f22064a81887509f4f8ef815a4b Author: Jean-Marc Lasgouttes Date: Tue Jun 13 12:17:21 2017 +0200 Add lower corners for BOX_MARKER too Let's see whether this helps Guillaume. Part of bug #8883. --- src/mathed/MathRow.cpp | 15 ++- 1

[LyX/master] When entering an inset by cursor, reset boundary

commit 2e84b8030e69f209d6565d11b4ae84f01d450d0d Author: Jean-Marc Lasgouttes Date: Wed Jun 14 15:08:27 2017 +0200 When entering an inset by cursor, reset boundary This happesn when cursor-left/right enters an inset. Fixes bug #10630. --- src/Text2.cpp |2 ++ 1 files

[LyX/master] Give 4 edit markers to all Frac-like insets

commit 939962869b4670ac5214152204d5814ebcd00fc8 Author: Jean-Marc Lasgouttes Date: Wed Jun 14 15:38:47 2017 +0200 Give 4 edit markers to all Frac-like insets Part of bug #10688. --- src/mathed/InsetMathFrac.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[LyX/2.2.x] Set cursor properly after double/triple click in mathed

commit c492f22593deaaf85cc47b60818f2d5c7c62ce41 Author: Jean-Marc Lasgouttes Date: Mon Jun 12 18:00:43 2017 +0200 Set cursor properly after double/triple click in mathed Without this setCurrentFont() is not correctly called on the BufferView cursor and the cursor could appear

[LyX/2.2.x] When entering an inset by cursor, reset boundary

commit 5f08a1b41d89071aef99d67d24ad2aa0c72dfcb8 Author: Jean-Marc Lasgouttes Date: Wed Jun 14 15:08:27 2017 +0200 When entering an inset by cursor, reset boundary This happens when cursor-left/right enters an inset. Fixes bug #10630. (cherry picked from commit

[LyX/master] Make fixIfBroken() more robust

commit 522516d99eff64c0d1b339c951ef0e0d61a74394 Author: Jean-Marc Lasgouttes Date: Thu Jun 15 11:49:49 2017 +0200 Make fixIfBroken() more robust Chop slice when its inset is not editable. Fixes bug #10667. --- src/DocIterator.cpp |2 +- 1 files changed, 1 insertions

[LyX/master] Avoid memory reuse problems with inset-dissolve

commit 9c92494e1a486435984130fc4c8274d26682ad37 Author: Jean-Marc Lasgouttes Date: Thu Jun 15 11:37:40 2017 +0200 Avoid memory reuse problems with inset-dissolve If 1. the inset is deleted before pasting its contents in the outer text, and 2. the inset contents begins

<    1   2   3   4   5   6   7   8   9   10   >