[LyX/master] Reduce top/bottom margin for Adv F&R workareas

2020-12-01 Thread Jean-Marc Lasgouttes
commit f41ca959fd531cd955bce778f2734f2a3ff1ee14 Author: Jean-Marc Lasgouttes Date: Tue Dec 1 12:01:20 2020 +0100 Reduce top/bottom margin for Adv F&R workareas --- src/BufferView.cpp |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/BufferView.cpp b

[LyX/master] Fix disabling of widgets for (simple) Search dialog

2020-12-03 Thread Jean-Marc Lasgouttes
commit 24b71d30d56752231fb8cb8f3dc65cc21f83d614 Author: Jean-Marc Lasgouttes Date: Thu Dec 3 15:31:35 2020 +0100 Fix disabling of widgets for (simple) Search dialog This allows to remove the calls to ButtonController::addReadonly, which are placebo since 78ade7e6. --- src

[LyX/master] Disable some Adv F&R widgets for read-only documents

2020-12-03 Thread Jean-Marc Lasgouttes
commit c30b0aac4bd5baabd430c3488aa97286a9ed5b41 Author: Jean-Marc Lasgouttes Date: Thu Dec 3 18:02:40 2020 +0100 Disable some Adv F&R widgets for read-only documents --- src/Buffer.cpp |5 + src/Buffer.h|2 ++ src/frontend

[LyX/master] Move stuff

2020-12-05 Thread Jean-Marc Lasgouttes
commit e561358be936615ffd51576682e429955c59330c Author: Jean-Marc Lasgouttes Date: Sat Dec 5 19:44:54 2020 +0100 Move stuff --- src/LyXRC.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/LyXRC.h b/src/LyXRC.h index 8950ea5..530a781 100644 --- a/src/LyXRC.h

[LyX/master] Make Merge Changes dialog work in read only.

2020-12-05 Thread Jean-Marc Lasgouttes
commit f02311241afde85253aa7ad1dc631bfda0b96ce1 Author: Jean-Marc Lasgouttes Date: Sat Dec 5 19:51:07 2020 +0100 Make Merge Changes dialog work in read only. Make LFUN_CHANGES_MERGE active in read-only documents. Remove dummy call to ButtonController::addReadonly and

[LyX/master] Update handling of read-only for Thesaurus

2020-12-05 Thread Jean-Marc Lasgouttes
commit 4f8cfca1170926df08f86b1cc6eccf4c9f2e3fd1 Author: Jean-Marc Lasgouttes Date: Sat Dec 5 20:27:46 2020 +0100 Update handling of read-only for Thesaurus Remove dummy calls to ButtonController::addReadOnly(). Properly disable stuff for read-only documents

[LyX/master] Make spellchecker work in read-only document

2020-12-07 Thread Jean-Marc Lasgouttes
commit 1dcb08104cd11974111749257f955bbcb3daffa9 Author: Jean-Marc Lasgouttes Date: Mon Dec 7 17:53:40 2020 +0100 Make spellchecker work in read-only document Mistakes are visible but word replacement is disabled. Disable relevant widgets depending on the situation

[LyX/master] Overhaul (no)limits support

2020-12-09 Thread Jean-Marc Lasgouttes
commit 99fb1c7003395bf08d5523d2a8367729424de047 Author: Jean-Marc Lasgouttes Date: Wed Dec 9 09:39:49 2020 +0100 Overhaul (no)limits support - Add limits support to InsetMathScript - Add limits support to InsetMathClass - Fix bug where limits changing is disabled in inline

[LyX/master] Reduce the amount of needed boost headers

2020-12-09 Thread Jean-Marc Lasgouttes
commit d9c39232ac123000fad5b8e8abb5f552104cd4ab Author: Jean-Marc Lasgouttes Date: Wed Dec 9 14:50:18 2020 +0100 Reduce the amount of needed boost headers boost/signals2.hpp is a convenience header, it seems that boost/signals2/signal.hpp is enough for our needs. This

[LyX/master] Autotools: use C++17 mode when available

2020-12-10 Thread Jean-Marc Lasgouttes
commit bf28a2677c2ebfbaef9cffbb240aa886b9f8cbbc Author: Jean-Marc Lasgouttes Date: Thu Dec 10 10:55:09 2020 +0100 Autotools: use C++17 mode when available --- config/lyxinclude.m4 |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/lyxinclude.m4 b/config

[LyX/master] Cleanup extract.sh

2020-12-10 Thread Jean-Marc Lasgouttes
commit 78359835606620bad2782a20ecb646c12d654282 Author: Jean-Marc Lasgouttes Date: Thu Dec 10 12:13:02 2020 +0100 Cleanup extract.sh Add new option --report to create an HTML report (shows dependencies at the end). --- 3rdparty/boost/extract.sh | 36

[LyX/master] Preserve paragraph depth when dissolving.

2020-12-10 Thread Jean-Marc Lasgouttes
commit 69c46c56fe7c1f67ea89c3863fd19299fa335b65 Author: Jean-Marc Lasgouttes Date: Thu Dec 10 18:34:07 2020 +0100 Preserve paragraph depth when dissolving. It turns out that makeSameLayout() does more than we want. Fixes bug #11981. --- src/Text.cpp | 12

[LyX/master] Boost.lexical_cast is not needed anymore.

2020-12-11 Thread Jean-Marc Lasgouttes
commit d3036ca70518ba69435877a9e78457fc08f0b651 Author: Jean-Marc Lasgouttes Date: Fri Dec 11 10:11:08 2020 +0100 Boost.lexical_cast is not needed anymore. As of 9348c5c6, we use std::to_string() instead. This reduces the size of our boost copy by a couple of MB

[LyX/master] Remove signal2 from included boost

2020-12-14 Thread Jean-Marc Lasgouttes
commit dd21fae48c78f7691811141f4fa6deeaca727bb1 Author: Jean-Marc Lasgouttes Date: Mon Dec 14 18:40:58 2020 +0100 Remove signal2 from included boost This is not necessary now that we use the nod library. 3rdparty/boost/boost/aligned_storage.hpp | 18 - 3rdparty/boost

[LyX/master] Tweak nod Makefile

2020-12-14 Thread Jean-Marc Lasgouttes
commit 425a846b1474cba1c6ffb3328b2d052048a5a30e Author: Jean-Marc Lasgouttes Date: Mon Dec 14 18:58:40 2020 +0100 Tweak nod Makefile There is no inner nod/ directory. We could, but it is probably not worth it. --- 3rdparty/nod/Makefile.am |2 +- 1 files changed, 1 insertions

[LyX/master] Dialog.h and DialogFactory.h are not moc-able

2020-12-15 Thread Jean-Marc Lasgouttes
commit 209a3ce618214ed4ecacf916c6d0055c69d28e5a Author: Jean-Marc Lasgouttes Date: Tue Dec 15 11:53:06 2020 +0100 Dialog.h and DialogFactory.h are not moc-able --- src/frontends/qt/Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/frontends/qt

[LyX/master] Take label width into account for SubLabel insets

2020-12-15 Thread Jean-Marc Lasgouttes
commit 3950f054977c60cdbf73c805cbd898003974aaee Author: Jean-Marc Lasgouttes Date: Tue Dec 15 15:25:07 2020 +0100 Take label width into account for SubLabel insets The drawing of the label should not go further than inset width. Fixes bug #12046. --- src/insets

[LyX/2.3.x] Take label width into account for SubLabel insets

2020-12-17 Thread Jean-Marc Lasgouttes
commit 326eab34088b7aaf48cb52eaec6268e547ced5a5 Author: Jean-Marc Lasgouttes Date: Tue Dec 15 15:25:07 2020 +0100 Take label width into account for SubLabel insets The drawing of the label should not go further than inset width. Fixes bug #12046. (cherry picked

[LyX/2.3.x] Take right margin into account for text inset width

2020-12-17 Thread Jean-Marc Lasgouttes
commit 20c89597909ddf9bfc94d0972ce45b423a5c06bb Author: Jean-Marc Lasgouttes Date: Tue Nov 17 17:47:22 2020 +0100 Take right margin into account for text inset width This is particularly important for contents in RtL languages, where the right margin may contain the paragraph

[LyX/2.3.x] Replace QFontMetrics::width() by horizontalAdvance() in Qt>=5.11

2020-12-17 Thread Jean-Marc Lasgouttes
commit f4314b6461ad4434c4c9dd294dfe62d1879ea6ea Author: Jean-Marc Lasgouttes Date: Sat Oct 24 19:29:34 2020 +0200 Replace QFontMetrics::width() by horizontalAdvance() in Qt>=5.11 The method horizontalAdvance() replaces width() starting with Qt 5.11. To handle this, all dir

[LyX/master] Fix crash after b0937fb9.

2020-12-17 Thread Jean-Marc Lasgouttes
commit 005f69de2307712d20e42d2f84fb7aa1d78d38fb Author: Jean-Marc Lasgouttes Date: Thu Dec 17 20:32:06 2020 +0100 Fix crash after b0937fb9. Now the cursor is not left inside color inset, so it is not needed to pop_back. Fix bug #12035. --- src/mathed

[LyX/master] Fixup 005f69de: code cleanup.

2020-12-19 Thread Jean-Marc Lasgouttes
commit 405b5c04a7f86171a6a883cea94600ebb9456cd7 Author: Jean-Marc Lasgouttes Date: Sat Dec 19 15:34:20 2020 +0100 Fixup 005f69de: code cleanup. Since we are not sure of where the cursor ends up after invoking Cursor::handleNest it is safer to reset the cursor at each cell

[LyX/2.3.x] Amend c3484fa6, adapt cmake-build to new hunspell-version

2020-12-19 Thread Jean-Marc Lasgouttes
commit 3e238b6c99afb81ea7d7f9c1df17891f4fc4b643 Author: Kornel Benko Date: Wed Jun 12 19:29:46 2019 +0200 Amend c3484fa6, adapt cmake-build to new hunspell-version (cherry picked from commit cf980435b12e697b90508924cf0c82dd3c1c0b36) --- 3rdparty/hunspell/CMakeLists.txt |2 +-

[LyX/2.3.x] Update the in-source hunspell to version 1.7.0

2020-12-19 Thread Jean-Marc Lasgouttes
commit f5ae00132aa9f2c8434aa8e25f66538ecd409809 Author: Jean-Marc Lasgouttes Date: Wed Jun 12 16:38:42 2019 +0200 Update the in-source hunspell to version 1.7.0 (cherry picked from commit c3484fa6c81e14bc2a4df92c4cf0bb043ac4b99a) 3rdparty/hunspell/1.6.2/AUTHORS

[LyX/2.3.x] Re-add win_api/config.h and somewhat update CMakeLists.txt

2020-12-19 Thread Jean-Marc Lasgouttes
commit 02e81304d700de7d4ca1a5ecf53eac3e485ce978 Author: Jean-Marc Lasgouttes Date: Mon Jun 17 12:17:40 2019 +0200 Re-add win_api/config.h and somewhat update CMakeLists.txt (cherry picked from commit 91c58d9a68ca2f4fc3114fd00cb49d6486420496) --- 3rdparty/hunspell/1.7.0/src

[LyX/2.3.x] Do nothing if hunspell support is disabled

2020-12-19 Thread Jean-Marc Lasgouttes
commit 8e532435142be819a29877352648bc30df5defc1 Author: Jean-Marc Lasgouttes Date: Wed Nov 18 16:41:19 2020 +0100 Do nothing if hunspell support is disabled (cherry picked from commit 031720b66a40bd7b520b4b01d894a0244cdcc32a) --- config/spell.m4 | 13 ++--- 1 files

[LyX/master] some other stuff that should have been removed from boost

2020-12-20 Thread Jean-Marc Lasgouttes
commit 37e759bc763e5ac0b7541f081ed4eacecafe Author: Jean-Marc Lasgouttes Date: Sun Dec 20 18:05:55 2020 +0100 some other stuff that should have been removed from boost Update extract.sh to remove more thoroughly old boost files (*.h, *.pl). .../boost/function/detail

[LyX/master] Autoconf: use included boost when system boost is not available

2020-12-20 Thread Jean-Marc Lasgouttes
commit 8d0d3ea0905172b4a1fba7fbfadba83ff61671c6 Author: Jean-Marc Lasgouttes Date: Sun Dec 20 19:26:01 2020 +0100 Autoconf: use included boost when system boost is not available --- config/lyxinclude.m4 | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a

[LyX/master] Remove parsers in included hunspell

2020-12-20 Thread Jean-Marc Lasgouttes
commit d04a8cf58fee7162bfab3d57191f6059c46b8e42 Author: Jean-Marc Lasgouttes Date: Sun Dec 20 19:39:35 2020 +0100 Remove parsers in included hunspell 3rdparty/hunspell/1.7.0/src/parsers/Makefile.am| 18 -- .../hunspell/1.7.0/src/parsers/firstparser.cxx | 65

[LyX/master] Update layouts to version 90

2020-12-22 Thread Jean-Marc Lasgouttes
commit af1ab2caa947c1ee6f2d95e4332b0aaeb35364c4 Author: Jean-Marc Lasgouttes Date: Mon Dec 21 19:35:34 2020 +0100 Update layouts to version 90 lib/citeengines/basic.citeengine |2 +- lib/citeengines/biblatex-natbib.citeengine |2 +- lib/citeengines

[LyX/master] Fixup 22f599250e9: missing wildcard

2021-01-04 Thread Jean-Marc Lasgouttes
commit 69eb262721b4454fe7af683adca502451098f7fb Author: Jean-Marc Lasgouttes Date: Mon Jan 4 17:58:11 2021 +0100 Fixup 22f599250e9: missing wildcard Now all the old gcc 4.x versions (x < 9) are correctly tagged as obsolete. --- config/lyxinclude.m4 |2 +- 1 files chan

[LyX/master] Center correctly centered top labels (e.g. abstract)

2021-01-05 Thread Jean-Marc Lasgouttes
commit 6c1855313cef2fac19022ddc4c8eccaee66088e6 Author: Jean-Marc Lasgouttes Date: Tue Jan 5 14:53:15 2021 +0100 Center correctly centered top labels (e.g. abstract) Since the first row may be indented, it is necessary to find out what the left margin would be on the next row

[LyX/master] Revert "Center correctly centered top labels (e.g. abstract)"

2021-01-05 Thread Jean-Marc Lasgouttes
commit b8188e54dd6e24fa92c3844458ed41ad37b50fb8 Author: Jean-Marc Lasgouttes Date: Tue Jan 5 15:14:41 2021 +0100 Revert "Center correctly centered top labels (e.g. abstract)" This reverts commit 6c1855313cef2fac19022ddc4c8eccaee66088e6. --- lib/layouts/stdstruct.

[LyX/master] Fixup 294e4884: center correctly Abstract label when paragraph is empty

2021-01-05 Thread Jean-Marc Lasgouttes
commit 824d1c993a138d051c79149fc4b27e1c002736a4 Author: Jean-Marc Lasgouttes Date: Tue Jan 5 14:53:15 2021 +0100 Fixup 294e4884: center correctly Abstract label when paragraph is empty When a paragraph is empty, it was not possible to query what the left margin would be for an

[LyX/master] Re-implement display of MARGIN_RIGHT_ADDRESS_BOX

2021-01-05 Thread Jean-Marc Lasgouttes
commit bea482877e9c8774fad86b22bd065e213a80a3ba Author: Jean-Marc Lasgouttes Date: Tue Jan 5 14:53:15 2021 +0100 Re-implement display of MARGIN_RIGHT_ADDRESS_BOX The correct way of implementing this is at paragraph level. Once this is clear, the implementation is

[LyX/master] Remove extra spaces

2021-01-06 Thread Jean-Marc Lasgouttes
commit baae41bd05f2173ee87f3734e4bb29404ba478ee Author: Jean-Marc Lasgouttes Date: Wed Jan 6 11:09:38 2021 +0100 Remove extra spaces --- src/Text3.cpp |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Text3.cpp b/src/Text3.cpp index 61b64ef..bd6c256 100644

[LyX/master] Fix unused paramaters warnings

2021-01-06 Thread Jean-Marc Lasgouttes
commit 28bca59dec39053254787acd8f6d6a5565eeb30f Author: Jean-Marc Lasgouttes Date: Wed Jan 6 11:57:22 2021 +0100 Fix unused paramaters warnings --- src/mathed/InsetMathEnsureMath.h | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/mathed

[LyX/master] Remove some useless Row:: prefixes

2021-01-06 Thread Jean-Marc Lasgouttes
commit 51b37cd4d87200afcd5b51445a263070f72947b4 Author: Jean-Marc Lasgouttes Date: Wed Jan 6 18:14:49 2021 +0100 Remove some useless Row:: prefixes --- src/Row.cpp |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Row.cpp b/src/Row.cpp index 02923d1

[LyX/master] Style cleanup to bookmark code

2021-01-06 Thread Jean-Marc Lasgouttes
commit 9c37cb47594a5a6d57b77a313b5ddce03cf01aa1 Author: Jean-Marc Lasgouttes Date: Wed Jan 6 14:18:25 2021 +0100 Style cleanup to bookmark code --- src/Session.cpp |8 src/Session.h | 10 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src

[LyX/master] Fix use of BookmarkSection::size()

2021-01-06 Thread Jean-Marc Lasgouttes
commit b64b1aa85e18a57878c96f697317340b7db1a169 Author: Jean-Marc Lasgouttes Date: Wed Jan 6 19:18:25 2021 +0100 Fix use of BookmarkSection::size() The value was 9 instead of 10, which forced its users to use unusual code. --- src/Session.cpp |2 +- src

[LyX/master] Display bookmarks in the workarea.

2021-01-06 Thread Jean-Marc Lasgouttes
commit 99e636ae7b83dacb5acc96ae3b60a96c28339c0e Author: Jean-Marc Lasgouttes Date: Wed Jan 6 19:21:26 2021 +0100 Display bookmarks in the workarea. The bookmarks are added as virtual elements in display Rows. Bookmarks are shown with circled numbers. A new color "book

[LyX/master] fix Row::findElement when there is a Virtual element

2021-01-06 Thread Jean-Marc Lasgouttes
commit e1261817d29c4afbc36ce177cbea3114d8648ae6 Author: Jean-Marc Lasgouttes Date: Wed Jan 6 18:49:41 2021 +0100 fix Row::findElement when there is a Virtual element --- src/Row.cpp | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/Row.cpp b

[LyX/master] typo

2021-01-07 Thread Jean-Marc Lasgouttes
commit c10aa3064fe9d4009a46ce51bbdd8d3d97c62d75 Author: Jean-Marc Lasgouttes Date: Thu Jan 7 12:36:36 2021 +0100 typo --- src/Cursor.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Cursor.h b/src/Cursor.h index 6f4ac22..f549047 100644 --- a/src/Cursor.h

[LyX/master] Fixup 2a80b0ac01bed2: fix the StartupWMClass in desktop file

2021-01-08 Thread Jean-Marc Lasgouttes
commit 20e1fe4674cdcd0164c74f76882d95ea3c88 Author: Jean-Marc Lasgouttes Date: Fri Jan 8 10:11:23 2021 +0100 Fixup 2a80b0ac01bed2: fix the StartupWMClass in desktop file --- lib/lyx.desktop.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/lyx.desktop.in

[LyX/master] Move handling of LFUN_COPY to BufferView

2021-01-08 Thread Jean-Marc Lasgouttes
commit 9e1db65932b895778525c48d524adfad2ae37739 Author: Jean-Marc Lasgouttes Date: Fri Jan 8 19:27:19 2021 +0100 Move handling of LFUN_COPY to BufferView It turns out that the code is the same in texted ans mathed and that whatever is done in InsetTabular is not useful

[LyX/2.3.x] Move handling of LFUN_COPY to BufferView

2021-01-11 Thread Jean-Marc Lasgouttes
commit 9886bf96c1b0ce3c035d8b7191b2c85c252cc426 Author: Jean-Marc Lasgouttes Date: Fri Jan 8 19:27:19 2021 +0100 Move handling of LFUN_COPY to BufferView It turns out that the code is the same in texted ans mathed and that whatever is done in InsetTabular is not useful

[LyX/2.3.x] Fixup 20e1fe46: fix the StartupWMClass in desktop file

2021-01-11 Thread Jean-Marc Lasgouttes
commit 25b4920feffeae5fd86d5f2eae7f6f2ff45207de Author: Jean-Marc Lasgouttes Date: Fri Jan 8 10:11:23 2021 +0100 Fixup 20e1fe46: fix the StartupWMClass in desktop file (cherry picked from commit 20e1fe4674cdcd0164c74f76882d95ea3c88) --- lib/lyx.desktop.in |2 +- status

[LyX/master] Record undo properly when inserting math script

2021-01-13 Thread Jean-Marc Lasgouttes
commit 86191314cba5f74af233e10af70cd80a06f03a78 Author: Jean-Marc Lasgouttes Date: Wed Jan 13 11:41:29 2021 +0100 Record undo properly when inserting math script The current code did not always record undo at the right level. Fixes bug #10843. --- src/mathed

[LyX/master] Remove RenderButton::button_box_, which is unused.

2021-01-19 Thread Jean-Marc Lasgouttes
commit 4062cbd27876ca915062007299f3cec99ce85470 Author: Jean-Marc Lasgouttes Date: Tue Jan 19 11:27:54 2021 +0100 Remove RenderButton::button_box_, which is unused. --- src/insets/InsetInclude.cpp |2 -- src/insets/RenderButton.h |7 --- 2 files changed, 0 insertions(+), 9

[LyX/master] Fix off-by-one condition when right clicking over selection

2021-01-19 Thread Jean-Marc Lasgouttes
commit 566b4de5cd4d9ac2d12f3d7b8fa0af8e0f0702da Author: Jean-Marc Lasgouttes Date: Tue Jan 19 19:21:43 2021 +0100 Fix off-by-one condition when right clicking over selection Fixes bug #10429. --- src/Text3.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[LyX/master] Cleanup button handling in InsetInclude

2021-01-19 Thread Jean-Marc Lasgouttes
commit 5908bb3ea6e6962308c70bd05a7f61baa8f2e0ce Author: Jean-Marc Lasgouttes Date: Tue Jan 19 13:23:03 2021 +0100 Cleanup button handling in InsetInclude The include inset has its own button_ object, that hides the button_ object of the InsetCommand parent. Remove that

[LyX/master] Do not disable DEPM paragraph deleting when FreeSpacing is true.

2021-01-25 Thread Jean-Marc Lasgouttes
commit ea0049aec828c085c5098328900dca5efe7fd763 Author: Jean-Marc Lasgouttes Date: Thu Jan 21 15:18:43 2021 +0100 Do not disable DEPM paragraph deleting when FreeSpacing is true. This is an old issue that never got fixed. Fixes bug #10413. --- src/Text2.cpp | 141

[LyX/master] Disable respectOSkbd checkbox

2021-01-25 Thread Jean-Marc Lasgouttes
commit 6bf8a0ade8bd804f634a14cd9cd2ac61e7d3a153 Author: Jean-Marc Lasgouttes Date: Mon Jan 25 18:35:41 2021 +0100 Disable respectOSkbd checkbox This is not ready yet. See discussion in #6450. --- src/frontends/qt/GuiPrefs.cpp |3 +++ 1 files changed, 3 insertions(+), 0

[LyX/master] InsetCaption: move intialization to declaration

2021-01-26 Thread Jean-Marc Lasgouttes
commit cb3db8b4cf8529b7cd1269d0cfe8d92820e68307 Author: Jean-Marc Lasgouttes Date: Tue Jan 26 10:17:25 2021 +0100 InsetCaption: move intialization to declaration --- src/insets/InsetCaption.cpp |3 +-- src/insets/InsetCaption.h |6 +++--- 2 files changed, 4 insertions(+), 5

[LyX/master] Fix InsetCaption in RTL environment.

2021-01-26 Thread Jean-Marc Lasgouttes
commit bb8278e6ce1f0fbc90eb90d7357829ba3def17e1 Author: Jean-Marc Lasgouttes Date: Tue Jan 26 17:55:09 2021 +0100 Fix InsetCaption in RTL environment. This requires to add a new mutable member, rtl_, to remember this context. Part of bug #10531. --- src/insets

[LyX/master] Make InsetCaption label localizable

2021-01-27 Thread Jean-Marc Lasgouttes
commit 48e7b1d01ea45a18d7919d5f6a895c99a978ec59 Author: Jean-Marc Lasgouttes Date: Tue Jan 26 19:26:36 2021 +0100 Make InsetCaption label localizable Part of bug #10531. --- src/insets/InsetCaption.cpp |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a

[LyX/master] Provide translation of caption label for fr and he.

2021-01-27 Thread Jean-Marc Lasgouttes
commit 15f3e6a10bb828ad5e457c449b990031015e86d5 Author: Jean-Marc Lasgouttes Date: Wed Jan 27 10:31:20 2021 +0100 Provide translation of caption label for fr and he. Part of bug #10531. --- po/fr.gmo | Bin 572181 -> 572258 bytes po/fr.po |2 +- po/he.gmo | Bin 240

[LyX/master] Remerge strings

2021-01-27 Thread Jean-Marc Lasgouttes
commit e2d2078275c51d14fed8876d53b8c21b352ee08e Author: Jean-Marc Lasgouttes Date: Tue Jan 26 19:29:37 2021 +0100 Remerge strings po/ar.gmo| Bin 439223 -> 438333 bytes po/ar.po | 2530 +--- po/bg.gmo| Bin 335705 ->

[LyX/master] Run updateBuffer when adding/merging changes

2021-01-28 Thread Jean-Marc Lasgouttes
commit f3a0e8ff9a9b914d40eb520bb31674d1ad4eb0d0 Author: Jean-Marc Lasgouttes Date: Thu Jan 28 10:10:18 2021 +0100 Run updateBuffer when adding/merging changes Following 4a4ded22, the enabling of some change-related functions is handled in updateBuffer. However, this method is

[LyX/master] Fixup f3a0e8ff: Reset needUpdate after buffer update

2021-01-29 Thread Jean-Marc Lasgouttes
commit 911b01a3cad5d969297ad52615b24827484c9335 Author: Jean-Marc Lasgouttes Date: Fri Jan 29 14:30:21 2021 +0100 Fixup f3a0e8ff: Reset needUpdate after buffer update --- src/Buffer.cpp |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/Buffer.cpp b/src

[LyX/master] Initialise correctly branch_list_id_

2021-01-29 Thread Jean-Marc Lasgouttes
commit 90bceb65d30eaa7c240e3f0cd3d6cfcefbf48323 Author: Jean-Marc Lasgouttes Date: Fri Jan 29 18:01:08 2021 +0100 Initialise correctly branch_list_id_ Reported by coverity. --- src/BranchList.cpp |8 src/BranchList.h | 12 ++-- 2 files changed, 6

[LyX/master] No need to set background color of a newly created branch.

2021-01-29 Thread Jean-Marc Lasgouttes
commit 5145694cd067e221a661e0d6c7dce4ed5ca22e37 Author: Jean-Marc Lasgouttes Date: Fri Jan 29 18:29:55 2021 +0100 No need to set background color of a newly created branch. Fixes a null pointer dereference spotted by coverity. --- src/Buffer.cpp |2 -- 1 files changed, 0

[LyX/master] LengthValidator: initialize properly positive_

2021-01-29 Thread Jean-Marc Lasgouttes
commit dca5646163853d4c202211e6612f6fd8d38db417 Author: Jean-Marc Lasgouttes Date: Fri Jan 29 18:17:16 2021 +0100 LengthValidator: initialize properly positive_ Spotted by coverity. --- src/frontends/qt/Validator.cpp |3 +-- src/frontends/qt/Validator.h | 16

[LyX/master] FindAndReplaceOptions: initialize properly matchAtStart

2021-01-29 Thread Jean-Marc Lasgouttes
commit bbae2c8c2af8ab40637e4f69a706a35e14ca Author: Jean-Marc Lasgouttes Date: Fri Jan 29 18:35:38 2021 +0100 FindAndReplaceOptions: initialize properly matchAtStart Spotted by coverity. --- src/lyxfind.h | 26 +- 1 files changed, 13 insertions

[LyX/master] ChangesMonitor: beware of exceptions in destructor

2021-01-29 Thread Jean-Marc Lasgouttes
commit ef091ca0eadf77134afe15c6d0913a22e0d45e6b Author: Jean-Marc Lasgouttes Date: Fri Jan 29 18:45:50 2021 +0100 ChangesMonitor: beware of exceptions in destructor There may be an exception is the paragraph does not have an owner. In this case, there is nothing to do anyway

[LyX/master] Initialize properly IconInfo struct

2021-01-29 Thread Jean-Marc Lasgouttes
commit b1efc5a48e69c6f65dc01c4d58c97f0719c02483 Author: Jean-Marc Lasgouttes Date: Fri Jan 29 18:57:13 2021 +0100 Initialize properly IconInfo struct Spotted by coverity. --- src/frontends/qt/GuiApplication.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[LyX/master] Copy/paste error in BranchList::setColors

2021-01-29 Thread Jean-Marc Lasgouttes
commit 536c831b6ad726e848a60d738b57ec8b0501 Author: Jean-Marc Lasgouttes Date: Fri Jan 29 18:51:19 2021 +0100 Copy/paste error in BranchList::setColors Spotted by coverity. --- src/BranchList.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src

Re: [LyX/master] Copy/paste error in BranchList::setColors

2021-01-29 Thread Jean-Marc Lasgouttes
Le 29/01/2021 à 19:19, Jean-Marc Lasgouttes a écrit : commit 536c831b6ad726e848a60d738b57ec8b0501 Author: Jean-Marc Lasgouttes Date: Fri Jan 29 18:51:19 2021 +0100 Copy/paste error in BranchList::setColors Jürgen, please double check this. JMarc Spotted by coverity

[LyX/master] Force redraw of all bufferviews after zoom in/out

2021-02-03 Thread Jean-Marc Lasgouttes
commit 9f899a17fabb88e8e1b31da88ad6000605f26f7c Author: Jean-Marc Lasgouttes Date: Mon Feb 1 18:19:46 2021 +0100 Force redraw of all bufferviews after zoom in/out Add a new ForceAll update flag that forces to update metrics and redraw all buffer views. The situation

[LyX/master] Fix default limits value for (under|over)brace

2021-02-05 Thread Jean-Marc Lasgouttes
commit 720f439868aca21988634c52f24ef897a7030b80 Author: Jean-Marc Lasgouttes Date: Fri Feb 5 14:36:21 2021 +0100 Fix default limits value for (under|over)brace Fixes bug #12107. --- src/mathed/InsetMathDecoration.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions

[LyX/master] Fix math class code in InsetMathColor

2021-02-08 Thread Jean-Marc Lasgouttes
commit c3114515180de263597be65cc9b8724798278b7f Author: Jean-Marc Lasgouttes Date: Mon Feb 8 13:13:21 2021 +0100 Fix math class code in InsetMathColor The current code is too naïve and asserts on MC_UNKNOWN class. See discussion here: https://marc.info/?l=lyx-devel&a

[LyX/master] DEPM: do not fix cursor pit if it was in a different cell

2021-02-10 Thread Jean-Marc Lasgouttes
commit 939d25561d5345d367309b7994eaefa355072456 Author: Jean-Marc Lasgouttes Date: Wed Feb 10 10:20:34 2021 +0100 DEPM: do not fix cursor pit if it was in a different cell This bug has been here forever. Fixes bug #12117. --- src/Text2.cpp |1 + 1 files changed, 1

[LyX/master] Remove left/right spacing around top/left buttons

2021-02-10 Thread Jean-Marc Lasgouttes
commit d2f23c303cc96e74fcec480f392f3dcce334ba8f Author: Jean-Marc Lasgouttes Date: Tue Feb 9 16:12:16 2021 +0100 Remove left/right spacing around top/left buttons This makes collapsible insets look better. Fixes #10323. --- src/insets/InsetCollapsible.cpp |5 - 1

[LyX/2.3.x] DEPM: do not fix cursor pit if it was in a different cell

2021-02-12 Thread Jean-Marc Lasgouttes
commit 2079dc1b16f7eaaef497e51f9869cc8d88f214ea Author: Jean-Marc Lasgouttes Date: Thu Feb 11 16:58:28 2021 +0100 DEPM: do not fix cursor pit if it was in a different cell This bug has been here forever. Fixes bug #12117. (cherry-picked from

[LyX/master] Make sure that top/bottom margins are visible when needed

2021-02-12 Thread Jean-Marc Lasgouttes
commit a78eb4471f2577cfa2fa89b27d27013c68937a17 Author: Jean-Marc Lasgouttes Date: Fri Feb 12 15:04:58 2021 +0100 Make sure that top/bottom margins are visible when needed When the cursor is at the top, it is important to make sure that, not only its row is visible, but also

[LyX/master] Fix correction of row in getPitAndRowNearY

2021-02-12 Thread Jean-Marc Lasgouttes
commit 08a3405181aed8b4c3d60af8cc3ac785b7e189cd Author: Jean-Marc Lasgouttes Date: Thu Feb 11 17:10:28 2021 +0100 Fix correction of row in getPitAndRowNearY Now that the ascent of the paragraph metrics is not necessarily the ascent of the first row (see 907f0207), the test is

[LyX/master] Do not redraw cursor twice with Page Up/Down

2021-02-12 Thread Jean-Marc Lasgouttes
commit 1cbbe5c3aaaff79a4662b68e09260e7282cc534b Author: Jean-Marc Lasgouttes Date: Fri Feb 12 15:22:23 2021 +0100 Do not redraw cursor twice with Page Up/Down Just recompute metrics instead of triggering a full redraw. The old behavior was that, when the document was less that

[LyX/master] Fixup 051b6ce6: fix drawing of EndLabelString

2021-02-14 Thread Jean-Marc Lasgouttes
commit 8117172d8abc28c9ffb3b43746ce447e64e36208 Author: Jean-Marc Lasgouttes Date: Sun Feb 14 20:07:19 2021 +0100 Fixup 051b6ce6: fix drawing of EndLabelString Fixes bug #12122. --- src/RowPainter.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src

[LyX/master] Fix caret height when inserting new inset

2021-02-14 Thread Jean-Marc Lasgouttes
commit 5a58ca6576a1fa2d6bea8e9e7927d5779943e593 Author: Jean-Marc Lasgouttes Date: Sun Feb 14 21:34:43 2021 +0100 Fix caret height when inserting new inset For now, the simplest thing to do it to compute metrics in all cases before calling setCurrentFont(). In 2.5, a

[LyX/master] Revert "Reduce top/bottom margin for Adv F&R workareas"

2021-02-16 Thread Jean-Marc Lasgouttes
commit 810b86560a8f0cf964a5ae1f263b56e976d76e6b Author: Jean-Marc Lasgouttes Date: Tue Feb 16 10:32:36 2021 +0100 Revert "Reduce top/bottom margin for Adv F&R workareas" This reverts commit f41ca959fd531cd955bce778f2734f2a3ff1ee14. --- src/BufferView.cpp |8 +++

[LyX/master] Revert "Make sure that top/bottom margins are visible when needed"

2021-02-16 Thread Jean-Marc Lasgouttes
commit f6c87c63c1b250992aa2511b80362dafbc48de13 Author: Jean-Marc Lasgouttes Date: Tue Feb 16 09:27:11 2021 +0100 Revert "Make sure that top/bottom margins are visible when needed" This reverts commit a78eb4471f2577cfa2fa89b27d27013c68937a17. --- src/BufferView.

[LyX/master] Revert "Improve handling of top and bottom margin"

2021-02-16 Thread Jean-Marc Lasgouttes
commit a40ca1430ebe844790c69d0a4f8a1509c255a878 Author: Jean-Marc Lasgouttes Date: Tue Feb 16 10:34:40 2021 +0100 Revert "Improve handling of top and bottom margin" This reverts commit 907f020724b4d73a75644642f3e097f74c75c3b5. --- src/BufferView.cpp | 14 -

[LyX/master] Make selections vertically tighter.

2021-02-16 Thread Jean-Marc Lasgouttes
commit a7c1a39b5b35102da0fe508d4a13c88827f465cd Author: Jean-Marc Lasgouttes Date: Tue Feb 16 12:21:12 2021 +0100 Make selections vertically tighter. Introduce a new Row::contents_dim(), which height is restricted to the row contents and does not contain any extra vertical

[LyX/master] Keep the useful parts of reverted commits

2021-02-16 Thread Jean-Marc Lasgouttes
commit 090e9a6c3664e3f984cb34a57836dc8aac47abca Author: Jean-Marc Lasgouttes Date: Tue Feb 16 12:01:40 2021 +0100 Keep the useful parts of reverted commits Keep from 907f0207 the introduction of BufferView::top/bottomMargin() and the setting of the top/bottom margin of the

[LyX/master] Revert "Fix correction of row in getPitAndRowNearY"

2021-02-16 Thread Jean-Marc Lasgouttes
commit 2c2ae5ecd8abfa2b73f479dee8ae39d5bb43b237 Author: Jean-Marc Lasgouttes Date: Tue Feb 16 09:27:28 2021 +0100 Revert "Fix correction of row in getPitAndRowNearY" This reverts commit 08a3405181aed8b4c3d60af8cc3ac785b7e189cd. --- src/TextMetrics.cpp |2 +- 1 fil

[LyX/master] Fixup 824d1c99: do not change the semantics of leftMargin(pit_type)

2021-02-16 Thread Jean-Marc Lasgouttes
commit 3f093dd10397de42b6a8ae74cc52147776debb73 Author: Jean-Marc Lasgouttes Date: Tue Feb 16 20:22:46 2021 +0100 Fixup 824d1c99: do not change the semantics of leftMargin(pit_type) In the row painter, when painting a centered label, one wants to get the left/right margin of

[LyX/master] Fix a crash when closing tabs

2021-02-18 Thread Jean-Marc Lasgouttes
commit 65b674ba4eff34df1ef7a7cf0f9e6a2585294c00 Author: Jean-Marc Lasgouttes Date: Thu Feb 18 15:35:42 2021 +0100 Fix a crash when closing tabs Although I do not know how to reproduce the crash, the change makes sense. This is backported from gadmm's lyx-unstable

[LyX/master] Reduce the value of (above|below)displayskip

2021-02-21 Thread Jean-Marc Lasgouttes
commit 41d29ce3877016e813cf8ef285d63fc8c7d0c478 Author: Jean-Marc Lasgouttes Date: Sun Feb 21 20:33:57 2021 +0100 Reduce the value of (above|below)displayskip The value of 10pt is too large, use a 'mean' value of 8.5pt. Tentative fix to bug #12153. ---

[LyX/master] "12 pixels ought to be enough for anyone"

2021-02-22 Thread Jean-Marc Lasgouttes
commit a5fd5d3cd2c19592e528a8890b0f22be6c4cbbeb Author: Jean-Marc Lasgouttes Date: Mon Feb 22 19:35:08 2021 +0100 "12 pixels ought to be enough for anyone" Fixes bug #12153. --- src/mathed/InsetMathHull.cpp |8 ++-- 1 files changed, 2 insertions(+), 6 deletion

[LyX/master] Fix cursor position when undoing inset-dissolve.

2021-02-23 Thread Jean-Marc Lasgouttes
commit f59dafe898513c2466a7cd33793320ebdfe9035d Author: Jean-Marc Lasgouttes Date: Tue Feb 23 19:19:57 2021 +0100 Fix cursor position when undoing inset-dissolve. When invoking inset-dissolve with the cursor in front of the inset, add recordUndo call to make sure that the

[LyX/master] Improve HiDpi handling

2021-02-25 Thread Jean-Marc Lasgouttes
commit d7a4f47e7d42af33858ff263823bd7cdbea98b57 Author: Jean-Marc Lasgouttes Date: Thu Feb 25 17:56:11 2021 +0100 Improve HiDpi handling Add code stolen from QBitTorrent that enables properly HiDpi handling. HighDpi support is set by default starting with Qt 5.6

[LyX/master] Remove assertion that is not necessary.

2021-02-25 Thread Jean-Marc Lasgouttes
commit 3e3ad2937cbb26724eb5c898b905f882df8e3a63 Author: Jean-Marc Lasgouttes Date: Thu Feb 25 20:00:41 2021 +0100 Remove assertion that is not necessary. It may happen that there are errors when doing undo, crashing does not help in this case. Fixes bug #12163

[LyX/master] Revert "Display bookmarks in the workarea."

2021-02-26 Thread Jean-Marc Lasgouttes
commit e4ab91d802084d42a1544bf04c34754e5f9284a5 Author: Jean-Marc Lasgouttes Date: Fri Feb 26 18:07:39 2021 +0100 Revert "Display bookmarks in the workarea." This will be replaced by a different version. This reverts commit 99e636ae7b83dacb5acc96ae3b60a9

[LyX/master] Display bookmarks in the workarea (take 2).

2021-02-26 Thread Jean-Marc Lasgouttes
commit 42b23f3fb24ea38e2b40543f4822a62d492e305a Author: Jean-Marc Lasgouttes Date: Fri Feb 26 19:05:35 2021 +0100 Display bookmarks in the workarea (take 2). The bookmarks are shown with circled numbers in the right margin (or the left margin in RTL mode). A new color

[LyX/2.3.x] Remove assertion that is not necessary.

2021-03-01 Thread Jean-Marc Lasgouttes
commit cebdac4a6f759f05012c5d6bf1d58743787a0066 Author: Jean-Marc Lasgouttes Date: Thu Feb 25 20:00:41 2021 +0100 Remove assertion that is not necessary. It may happen that there are errors when doing undo, crashing does not help in this case. Fixes bug #12163

[LyX/master] Add Qt platform name in About dialog

2021-03-01 Thread Jean-Marc Lasgouttes
commit 234886f6eb438b68f72f46ed2904fd408741f777 Author: Jean-Marc Lasgouttes Date: Mon Mar 1 19:15:49 2021 +0100 Add Qt platform name in About dialog --- src/frontends/qt/GuiAbout.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/frontends/qt/GuiAbout.cpp b

[LyX/master] Cleanup High DPI support

2021-03-01 Thread Jean-Marc Lasgouttes
commit f92f2f95ffd5f0d9d9704c9d7f67e4a9e74db0f6 Author: Jean-Marc Lasgouttes Date: Tue Mar 2 08:20:39 2021 +0100 Cleanup High DPI support Disable for Qt >= 6 (this is the default now). Disable for macOS (does it in its own way). --- src/frontends/qt/GuiApplication.

[LyX/2.3.x] Add Qt platform name in About dialog

2021-03-01 Thread Jean-Marc Lasgouttes
commit 007a192faeb576f061f6ba476ae9dffa5f638f6f Author: Jean-Marc Lasgouttes Date: Tue Mar 2 08:28:47 2021 +0100 Add Qt platform name in About dialog (cherry picked from commit 234886f6eb438b68f72f46ed2904fd408741f777) --- src/frontends/qt4/GuiAbout.cpp |4 +++- status.23x

[LyX/master] Fix random scrolling inside nested insets

2021-03-02 Thread Jean-Marc Lasgouttes
commit fbf22bb3f39c2a91c2cee1d4bd560dce00871b28 Author: Jean-Marc Lasgouttes Date: Tue Mar 2 18:07:43 2021 +0100 Fix random scrolling inside nested insets Happened when the BufferView was resized (e.g. math toolbars were displayed/hidden). Backported from gadmm'

[LyX/master] Avoid pointless 'undefined flex inset' errors

2021-03-04 Thread Jean-Marc Lasgouttes
commit 009efa195bf2837a007c0b070261b34a715b9b39 Author: Jean-Marc Lasgouttes Date: Tue Mar 2 09:12:47 2021 +0100 Avoid pointless 'undefined flex inset' errors When switching class, it does not make sense to flag flex insets that are undefined if they were already

<    8   9   10   11   12   13   14   15   16   17   >