Re: src/insets/insetlist.*

2004-02-27 Thread Alfredo Braunstein
Angus Leeming wrote: I don't have the source to hand, else I would. So I'm not going to *tell* you to do anything. I would do this myself, however... Done, finally. Alfredo

Re: src/insets/insetlist.*

2004-02-27 Thread Alfredo Braunstein
Kayvan A. Sylvan wrote: Yes. I was able to compile by taking out the #include InsetList.h from both insetlabel.C and paragraph.h. Strange... you shouldn't be allowed to remove it from paragraph.h... anyway, I've removed the files. Alfredo

Re: Boost, threading and FreeBSD problem

2004-02-27 Thread Lars Gullik Bjønnes
Rob Lahaye [EMAIL PROTECTED] writes: | Hi, | There's a problem with threading since recent boost updates in CVS, | at least for my FreeBSD PC. | My make ends with: | [...] | /usr/local/bin/g++33 -g -O -fno-exceptions -W -Wall -o tex2lyx FloatList.o Floating.o counters.o lengthcommon.o

Re: [patch] de-mathe-ification + removal of Row::fill_

2004-02-27 Thread Andre Poenitz
On Wed, Feb 25, 2004 at 06:06:27PM +0100, Andre' Poenitz wrote: Row::fill_ + Row::width_ : two names for almost the same (complementary) thing. Too many opportunities to get something wrong... I think we should not store the foo_fill_ members in Row, but just the numbers of hfills etc in this

[patch] allow breaking lines after updatables

2004-02-27 Thread Alfredo Braunstein
this eliminates some weird rebreaking problems we are having [that probably didn't show in displayed inset times]. Ok? Alfredo ? insetcollapsable-save.C ? insettext-save.C Index: updatableinset.h === RCS file:

Yesterdays mail

2004-02-27 Thread Andre Poenitz
I remember reading a mail yesterday in which Jean-Marc(?) was asking for a virtual nod for an obvious bugfix. Currently I am (due to some wierd setup) able to read but not to write mail regularly. So please don't _wait_ for a reaction from me, especially for bug fixes. Andre'

Re: [patch] de-mathe-ification + removal of Row::fill_

2004-02-27 Thread Alfredo Braunstein
Andre Poenitz wrote: I think we should not store the foo_fill_ members in Row, but just the numbers of hfills etc in this row. This (a) allows us to defer the setting of the real row width to drawing time (and hence simplifies/corrects the redoParagraphInternal logic)

Re: [patch] de-mathe-ification + removal of Row::fill_

2004-02-27 Thread Andre Poenitz
On Fri, Feb 27, 2004 at 10:34:38AM +0100, Alfredo Braunstein wrote: Andre Poenitz wrote: I think we should not store the foo_fill_ members in Row, but just the numbers of hfills etc in this row. This (a) allows us to defer the setting of the real row width to drawing

Re: [patch] allow breaking lines after updatables

2004-02-27 Thread Alfredo Braunstein
On Friday 27 February 2004 10:37, you wrote: On Fri, Feb 27, 2004 at 10:31:53AM +0100, Alfredo Braunstein wrote: this eliminates some weird rebreaking problems we are having [that probably didn't show in displayed inset times]. Ok? Yes. [Well, maybe we should just change the default

Re: [patch] allow breaking lines after updatables

2004-02-27 Thread Andre Poenitz
On Fri, Feb 27, 2004 at 11:06:47AM +0100, Alfredo Braunstein wrote: On Friday 27 February 2004 10:37, you wrote: On Fri, Feb 27, 2004 at 10:31:53AM +0100, Alfredo Braunstein wrote: this eliminates some weird rebreaking problems we are having [that probably didn't show in displayed inset

Re: [patch] allow breaking lines after updatables

2004-02-27 Thread Alfredo Braunstein
Andre Poenitz wrote: On Fri, Feb 27, 2004 at 11:06:47AM +0100, Alfredo Braunstein wrote: On Friday 27 February 2004 10:37, you wrote: On Fri, Feb 27, 2004 at 10:31:53AM +0100, Alfredo Braunstein wrote: this eliminates some weird rebreaking problems we are having [that probably didn't

Re: Yesterdays mail

2004-02-27 Thread Jean-Marc Lasgouttes
Andre == Andre Poenitz [EMAIL PROTECTED] writes: Andre I remember reading a mail yesterday in which Jean-Marc(?) was Andre asking for a virtual nod for an obvious bugfix. Currently I am Andre (due to some wierd setup) able to read but not to write mail Andre regularly. So please don't _wait_ for

[patch] fix a rebreak problem

2004-02-27 Thread Alfredo Braunstein
Ok, this was it. Just a bug in rowbreakpoint. The problem is that if the first 'char' of the row is longer than available width, we were exiting with breakpoint = end, i.e. no linebreak at all. In case anyone is wondering what bug I'm solving: insert a note in a block-aligned paragraph, and write

Re: [patch] allow breaking lines after updatables

2004-02-27 Thread Jean-Marc Lasgouttes
Alfredo == Alfredo Braunstein [EMAIL PROTECTED] writes: Alfredo On Friday 27 February 2004 10:37, you wrote: On Fri, Feb 27, 2004 at 10:31:53AM +0100, Alfredo Braunstein wrote: this eliminates some weird rebreaking problems we are having [that probably didn't show in displayed inset times].

Re: [patch] allow breaking lines after updatables

2004-02-27 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: Alfredo Mmm... further investigation says that my patch is not Alfredo correct, as isLineSeparator is also used for other purposes Alfredo besides deciding if a breakpoint is allowed. Yes, this is a bit documented in http://bugzilla.lyx.org/show_bug.cgi?id=304

Re: [patch] fix a rebreak problem

2004-02-27 Thread Andre Poenitz
On Fri, Feb 27, 2004 at 12:08:30PM +0100, Alfredo Braunstein wrote: Ok, this was it. Just a bug in rowbreakpoint. The problem is that if the first 'char' of the row is longer than available width, we were exiting with breakpoint = end, i.e. no linebreak at all. In case anyone is wondering

Re: [patch] fix a rebreak problem

2004-02-27 Thread Alfredo Braunstein
Andre Poenitz wrote: On Fri, Feb 27, 2004 at 12:08:30PM +0100, Alfredo Braunstein wrote: Ok, this was it. Just a bug in rowbreakpoint. The problem is that if the first 'char' of the row is longer than available width, we were exiting with breakpoint = end, i.e. no linebreak at all. In case

Re: [patch] fix a rebreak problem

2004-02-27 Thread Andre Poenitz
On Fri, Feb 27, 2004 at 01:29:31PM +0100, Alfredo Braunstein wrote: Are you going to commit your row::fill patch from yesterday I did that already. or you will merging it with the foo_fill stuff? I have no code for this so far Andre'

Re: [patch] fix a rebreak problem

2004-02-27 Thread Alfredo Braunstein
Andre Poenitz wrote: I did that already. ah yes. Alfredo

Re: [patch] allow breaking lines after updatables

2004-02-27 Thread Jean-Marc Lasgouttes
Alfredo == Alfredo Braunstein [EMAIL PROTECTED] writes: Alfredo Agreed. Still I think that my patch is no good... For Alfredo instance, allowing linebreaks on button insets can lead to Alfredo undesired effects, like unglueing a sentence period from the Alfredo word before because of a

[patch] foo_fill - num_foo_fills

2004-02-27 Thread Alfredo Braunstein
+ a bit of fixes (like using text_.width instead of text_.textwidth_ in some places) This seems to fix a lot (most?) obvious cosmetic bugs. Still it's not very nice as a patch. I'm storing num_foo_fills = 0 when it's not applicable (i.e. for instance when there is some hfill, then the

[PATCH] creating a reasonable textclass.lst when latex is not present

2004-02-27 Thread Jean-Marc Lasgouttes
The following patch allows to create textclass.lst in the case where latex is not present or --without-latex-config has been passed to lib/configure. It adds all the claases it finds, with availability=false for latex classes, and availablility correctly computaled for the sgml classes. While

Re: [patch] foo_fill - num_foo_fills

2004-02-27 Thread Andre Poenitz
On Fri, Feb 27, 2004 at 04:55:38PM +0100, Alfredo Braunstein wrote: + a bit of fixes (like using text_.width instead of text_.textwidth_ in some places) Looks good on a quick glance. This seems to fix a lot (most?) obvious cosmetic bugs. Still it's not very nice as a patch. I'm storing

[patch] Fix bugs 605, 1231, and 1244

2004-02-27 Thread Georg Baum
This is the promised fix for bugs 605, 1231, and 1244. It is work in progress, the html export is not fixed yet. What this patch does: - maintain a list of included graphics files for the exporter, so that they can be copied for dvi output. - use always relative filenames for graphics if

Re: [patch] Fix bugs 605, 1231, and 1244

2004-02-27 Thread Jose' Matos
On Friday 27 February 2004 18:13, Georg Baum wrote: -        __import__(mode + str(fmt)).convert(header,body) +   if mode + str(fmt) == lyxconvert_229: +            __import__(mode + str(fmt)).convert(header,body,opt.input) +   else: +            __import__(mode +

Re: [patch] foo_fill - num_foo_fills

2004-02-27 Thread Alfredo Braunstein
Andre Poenitz wrote: I wonder if we really need to cache those num_foo_fills. I don't think so. I think that it wont be much slower to compute them on demand (they are used in three places : cursorX, getColumnNearX and rowPainter). And all of them are 'close to the user' i.e. most

Re: src/insets/insetlist.*

2004-02-27 Thread Alfredo Braunstein
Angus Leeming wrote: > I don't have the source to hand, else I would. So I'm not going to > *tell* you to do anything. I would do this myself, however... Done, finally. Alfredo

Re: src/insets/insetlist.*

2004-02-27 Thread Alfredo Braunstein
Kayvan A. Sylvan wrote: > Yes. I was able to compile by taking out the "#include InsetList.h" from > both insetlabel.C and paragraph.h. Strange... you shouldn't be allowed to remove it from paragraph.h... anyway, I've removed the files. Alfredo

Re: Boost, threading and FreeBSD problem

2004-02-27 Thread Lars Gullik Bjønnes
Rob Lahaye <[EMAIL PROTECTED]> writes: | Hi, > | There's a problem with threading since recent boost updates in CVS, | at least for my FreeBSD PC. > | My make ends with: > | [...] | /usr/local/bin/g++33 -g -O -fno-exceptions -W -Wall -o tex2lyx FloatList.o Floating.o counters.o lengthcommon.o

Re: [patch] de-mathe-ification + removal of Row::fill_

2004-02-27 Thread Andre Poenitz
On Wed, Feb 25, 2004 at 06:06:27PM +0100, Andre' Poenitz wrote: > > Row::fill_ + Row::width_ : two names for almost the same (complementary) > thing. Too many opportunities to get something wrong... I think we should not store the foo_fill_ members in Row, but just the numbers of hfills etc in

[patch] allow breaking lines after updatables

2004-02-27 Thread Alfredo Braunstein
this eliminates some weird rebreaking problems we are having [that probably didn't show in "displayed inset" times]. Ok? Alfredo ? insetcollapsable-save.C ? insettext-save.C Index: updatableinset.h === RCS file:

Yesterdays mail

2004-02-27 Thread Andre Poenitz
I remember reading a mail yesterday in which Jean-Marc(?) was asking for a virtual nod for an obvious bugfix. Currently I am (due to some wierd setup) able to read but not to write mail regularly. So please don't _wait_ for a reaction from me, especially for bug fixes. Andre'

Re: [patch] de-mathe-ification + removal of Row::fill_

2004-02-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > I think we should not store the foo_fill_ members in Row, but just > the numbers of hfills etc in this row. > > This > > (a) allows us to defer the setting of the real row width to > drawing time (and hence simplifies/corrects the > redoParagraphInternal

Re: [patch] de-mathe-ification + removal of Row::fill_

2004-02-27 Thread Andre Poenitz
On Fri, Feb 27, 2004 at 10:34:38AM +0100, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > I think we should not store the foo_fill_ members in Row, but just > > the numbers of hfills etc in this row. > > > > This > > > > (a) allows us to defer the setting of the real row width to > >

Re: [patch] allow breaking lines after updatables

2004-02-27 Thread Alfredo Braunstein
On Friday 27 February 2004 10:37, you wrote: > On Fri, Feb 27, 2004 at 10:31:53AM +0100, Alfredo Braunstein wrote: > > this eliminates some weird rebreaking problems we are having [that > > probably didn't show in "displayed inset" times]. > > > > Ok? > > Yes. > > [Well, maybe we should just

Re: [patch] allow breaking lines after updatables

2004-02-27 Thread Andre Poenitz
On Fri, Feb 27, 2004 at 11:06:47AM +0100, Alfredo Braunstein wrote: > On Friday 27 February 2004 10:37, you wrote: > > On Fri, Feb 27, 2004 at 10:31:53AM +0100, Alfredo Braunstein wrote: > > > this eliminates some weird rebreaking problems we are having [that > > > probably didn't show in

Re: [patch] allow breaking lines after updatables

2004-02-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Fri, Feb 27, 2004 at 11:06:47AM +0100, Alfredo Braunstein wrote: >> On Friday 27 February 2004 10:37, you wrote: >> > On Fri, Feb 27, 2004 at 10:31:53AM +0100, Alfredo Braunstein wrote: >> > > this eliminates some weird rebreaking problems we are having [that >> > >

Re: Yesterdays mail

2004-02-27 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> I remember reading a mail yesterday in which Jean-Marc(?) was Andre> asking for a virtual nod for an obvious bugfix. Currently I am Andre> (due to some wierd setup) able to read but not to write mail Andre> regularly. So please

[patch] fix a rebreak problem

2004-02-27 Thread Alfredo Braunstein
Ok, this was it. Just a bug in rowbreakpoint. The problem is that if the first 'char' of the row is longer than available width, we were exiting with breakpoint = end, i.e. no linebreak at all. In case anyone is wondering what bug I'm solving: insert a note in a block-aligned paragraph, and write

Re: [patch] allow breaking lines after updatables

2004-02-27 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> On Friday 27 February 2004 10:37, you wrote: >> On Fri, Feb 27, 2004 at 10:31:53AM +0100, Alfredo Braunstein wrote: >> > this eliminates some weird rebreaking problems we are having >> [that > probably didn't show in

Re: [patch] allow breaking lines after updatables

2004-02-27 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > Alfredo> Mmm... further investigation says that my patch is not > Alfredo> correct, as isLineSeparator is also used for other purposes > Alfredo> besides deciding if a breakpoint is allowed. > > Yes, this is a bit documented in >

Re: [patch] fix a rebreak problem

2004-02-27 Thread Andre Poenitz
On Fri, Feb 27, 2004 at 12:08:30PM +0100, Alfredo Braunstein wrote: > Ok, this was it. Just a bug in rowbreakpoint. The problem is that if the > first 'char' of the row is longer than available width, we were exiting > with breakpoint = end, i.e. no linebreak at all. > > In case anyone is

Re: [patch] fix a rebreak problem

2004-02-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Fri, Feb 27, 2004 at 12:08:30PM +0100, Alfredo Braunstein wrote: >> Ok, this was it. Just a bug in rowbreakpoint. The problem is that if the >> first 'char' of the row is longer than available width, we were exiting >> with breakpoint = end, i.e. no linebreak at all. >>

Re: [patch] fix a rebreak problem

2004-02-27 Thread Andre Poenitz
On Fri, Feb 27, 2004 at 01:29:31PM +0100, Alfredo Braunstein wrote: > Are you going to commit your row::fill patch from yesterday I did that already. > or you will merging it with the foo_fill stuff? I have no code for this so far Andre'

Re: [patch] fix a rebreak problem

2004-02-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > I did that already. ah yes. Alfredo

Re: [patch] allow breaking lines after updatables

2004-02-27 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> Agreed. Still I think that my patch is no good... For Alfredo> instance, allowing linebreaks on button insets can lead to Alfredo> undesired effects, like unglueing a sentence period from the Alfredo> word before because

[patch] foo_fill -> num_foo_fills

2004-02-27 Thread Alfredo Braunstein
+ a bit of fixes (like using text_.width instead of text_.textwidth_ in some places) This seems to fix a lot (most?) obvious cosmetic bugs. Still it's not very nice as a patch. I'm storing num_foo_fills = 0 when it's not applicable (i.e. for instance when there is some hfill, then the

[PATCH] creating a reasonable textclass.lst when latex is not present

2004-02-27 Thread Jean-Marc Lasgouttes
The following patch allows to create textclass.lst in the case where latex is not present or --without-latex-config has been passed to lib/configure. It adds all the claases it finds, with availability=false for latex classes, and availablility correctly computaled for the sgml classes. While

Re: [patch] foo_fill -> num_foo_fills

2004-02-27 Thread Andre Poenitz
On Fri, Feb 27, 2004 at 04:55:38PM +0100, Alfredo Braunstein wrote: > + a bit of fixes (like using text_.width instead of text_.textwidth_ in some > places) Looks good on a quick glance. > This seems to fix a lot (most?) obvious cosmetic bugs. > > Still it's not very nice as a patch. I'm

[patch] Fix bugs 605, 1231, and 1244

2004-02-27 Thread Georg Baum
This is the promised fix for bugs 605, 1231, and 1244. It is work in progress, the html export is not fixed yet. What this patch does: - maintain a list of included graphics files for the exporter, so that they can be copied for dvi output. - use always relative filenames for graphics if

Re: [patch] Fix bugs 605, 1231, and 1244

2004-02-27 Thread Jose' Matos
On Friday 27 February 2004 18:13, Georg Baum wrote: > -        __import__(mode + str(fmt)).convert(header,body) > +   if mode + str(fmt) == "lyxconvert_229": > +            __import__(mode + str(fmt)).convert(header,body,opt.input) > +   else: > +            __import__(mode +

Re: [patch] foo_fill -> num_foo_fills

2004-02-27 Thread Alfredo Braunstein
Andre Poenitz wrote: >> I wonder if we really need to cache those num_foo_fills. > > I don't think so. > >> I think that it wont be much slower to compute them on demand (they >> are used in three places : cursorX, getColumnNearX and rowPainter). > > And all of them are 'close to the user'