[Patch] Re: Bug 1765

2005-08-28 Thread Martin Vermeer
On Sun, 28 Aug 2005 13:30:07 +0200 Juergen Spitzmueller <[EMAIL PROTECTED]> wrote: > Martin Vermeer wrote: > > Ah. But I remember that was in a quite different part of the code, > right? > > Don't think so. These were the changes: Ah, heck. So we have to study this. First off: 1) It appears t

[patch] fix bug 1990

2005-08-28 Thread Georg Baum
See http://bugzilla.lyx.org/show_bug.cgi?id=1990. lyx2lyx does not revert pagebreak and lyxline insets and can therefore create invalid .lyx files. The attached patch fixes that by extending convert_vspace() to revert_breaks(), making it symmetric to convert_breaks(). I have tested it with file

Re: Bug 1765

2005-08-28 Thread Juergen Spitzmueller
Martin Vermeer wrote: > Ah. But I remember that was in a quite different part of the code, right? Don't think so. These were the changes: diff -u -r1.465 -r1.466 --- lyx-devel/src/insets/insettabular.C 2005/05/12 12:22:37 1.465 +++ lyx-devel/src/insets/insettabular.C 2005/06/16 15:20:09 1

Re: Bug 1765

2005-08-28 Thread Martin Vermeer
On Sun, 28 Aug 2005 12:47:10 +0200 Juergen Spitzmueller <[EMAIL PROTECTED]> wrote: > Martin Vermeer wrote: > > I don't really understand this code. Is the original bug even partly > fixed? > > Yes. Screen representation is o.k. now for non-multicolumn pwidth > cells. > > > If so, it's not my fi

Re: Tabular fixed-/non-fixed-width switch (bugs 1296, 1840)

2005-08-28 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > | Yes, I remember this behaviour... irritating. > | > | Is it easy to remove without complicating the code, and still get LaTeX > | that is compatible with on-screen? It just can be removed without affection to onscreen and

Re: Bug 1765

2005-08-28 Thread Juergen Spitzmueller
Martin Vermeer wrote: > I don't really understand this code. Is the original bug even partly fixed? Yes. Screen representation is o.k. now for non-multicolumn pwidth cells. > If so, it's not my fix (or so I assume) as there were objections against > that. You might remember that I accidentally c

Re: [patch] bug 2003

2005-08-28 Thread Andre Poenitz
On Sat, Aug 27, 2005 at 02:56:57PM +0200, Juergen Spitzmueller wrote: > http://bugzilla.lyx.org/show_bug.cgi?id=2003 > > Do not indent optarg insets. The fix is trivial. For the future, we might > consider a bool neverindent in InsetBase rather than putting each inset to > the if-clause. No, th

Re: Tabular fixed-/non-fixed-width switch (bugs 1296, 1840)

2005-08-28 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: >> What do you think? Patch not attached, because I have other pending >> fixes in >> insettabular. >> >> Jürgen > | Yes, I remember this behaviour... irritating. > | Is it easy to remove without complicating the code, and still get LaTeX that | is com

Re: Bug 1765

2005-08-28 Thread Martin Vermeer
> Reopening, because the representation is still broken for multicolumn pwidth > cells (also when a non-multicolumn pwidth cell is changed to a non-pwidth > multicolumn cell, the width is not reset), probably because of: > if (tabular.isPartOfMultiColumn(i, j)) cont

Re: Tabular fixed-/non-fixed-width switch (bugs 1296, 1840)

2005-08-28 Thread Martin Vermeer
On Sat, 27 Aug 2005 17:29:15 +0200 Juergen Spitzmueller <[EMAIL PROTECTED]> wrote: > In InsetTabular::tabularFeatures, there's the following: > > case LyXTabular::SET_PWIDTH: { > LyXLength const len(value); > tabular.setColumnPWidth(cur.idx(), len); > if