Re: [Patch] More static analysis and resulting fixes: cppcheck

2010-02-15 Thread John McCabe-Dansted
On Mon, Feb 15, 2010 at 2:49 PM, Pavel Sanda wrote: > John McCabe-Dansted wrote: >> Well, Jürgen also prefers ++i to  i++, at least in new code being >> submitted to LyX. > > we have such advice in lyx coding rules, thats true and i understand its usage > for non-POD objects, anyway using it in in

Re: Can't build lyx 1.6.5 on OpenSolaris using Sun Studio 12u1

2010-02-15 Thread Frank Thieme
On Sun, Feb 14, 2010 at 02:15, Andre Poenitz wrote: >> 3. a forgotten static_cast in src/support/FileName.cpp > > >        @@ -558,7 +558,7 @@ >                crc.process_block(beg, end); >                result = crc.checksum(); > >        -       munmap(mm, info.st_size); >        +       munma

[Patch] Remove GuiFloat from Makefile.am

2010-02-15 Thread John McCabe-Dansted
I cannot compile r33482 because it complains that GuiFloat.cpp and GuiFloat.h are missing. Removing these entries from the relevant Makefile.am seems to allow LyX to compile. -- John C. McCabe-Dansted Index: src/frontends/qt4/Makefile.am ===