Re: Reviews of commits

2013-09-07 Thread Hashini Senaratne
Hello Jean-Marc, > Identified another two bugs... > 1) When moving from the left most position of a row to the above too wide > row using left arrow, row does not get slide. (I think I found a fix for > this, have to test more) Here is what I observe: https://dl.dropboxusercontent.com/u/105510128

Re: Reviews of commits

2013-09-07 Thread Hashini Senaratne
Hello Jean-Marc, > > RowPainter rp(pi, bv.buffer().text(), cur.bottom().pit(), row, bidi, 0, > > - rp.paintOnlyInsets(); > > + //rp.paintOnlyInsets(); > > + rp.paintText(); > > I think you are right. It might also be that we should use both. For now I put only rp.paint

Re: back from vacation

2013-09-07 Thread Vincent van Ravesteijn
Sounds good. Should we switch the default UI language to de_DE before beta 2 is out then? Pavel Sorry, I don't like this kind of last-minute changes. Can you postpone this patch till after beta 2? Vincent

Re: back from vacation

2013-09-07 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > > will not have much time until the > > > German election September 22. > > > > Uwe, what will happen with LyX if you win? > > Well. of course Uwe will force every German citizen to use LyX. And we will > get some more funding. Sounds good. Sh

Re: Reviews of commits

2013-09-07 Thread Jean-Marc Lasgouttes
Le 07/09/13 18:37, Hashini Senaratne a écrit : I do not know whether this is a goo new or not. But with the following fix I could solve that problem. diff --git a/src/BufferView.cpp b/src/BufferView.cpp index c53fd1d..1dc8f51 100644 --- a/src/BufferView.cpp +++ b/src/BufferView.cpp @@ -2856,14 +

Re: Lyx2.1.0beta2 issues ?

2013-09-07 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > All I can do is to ask people to test. If no-one reports a problem, it will > be ok. I tested the patch under ubuntu & gentoo, both worked. P

Re: Why bv.getPos(cur).x_ not always giving correct x position of the text cursor?

2013-09-07 Thread Hashini Senaratne
Jean-Marc Lasgouttes lyx.org> writes: > > What happens is, the above attribute resets to the left most cursor position > > of that row. And after few mouse movements, it gives the correct value. > > These mouse movements calls drawing method of TextMetrics.cpp. > > I think that mouse movement c

Re: Reviews of commits

2013-09-07 Thread Hashini Senaratne
Hello Jean-Marc, > Le 06/09/13 13:07, Hashini Senaratne a écrit : I do not know whether this is a goo new or not. But with the following fix I could solve that problem. diff --git a/src/BufferView.cpp b/src/BufferView.cpp index c53fd1d..1dc8f51 100644 --- a/src/BufferView.cpp +++ b/src/BufferVie

Re: Reviews of commits

2013-09-07 Thread Jean-Marc Lasgouttes
Le 07/09/13 17:03, Hashini Senaratne a écrit : As I can understand here you have declared a new RowPainter and with the disabled drawing tries to pain only the insets. It is assumed that this will force the re-computation of the positions of the insets. Exactly. This will give the position when

Re: Why bv.getPos(cur).x_ not always giving correct x position of the text cursor?

2013-09-07 Thread Jean-Marc Lasgouttes
Le 07/09/13 17:32, Hashini Senaratne a écrit : I am recently involved in horizontal scrolling of rows where I work with Math insets. There I found that bv.getPos(cur).x_ is not getting updated just after entering a Math inset from left or right corners. The reason why it is not correct at first

Why bv.getPos(cur).x_ not always giving correct x position of the text cursor?

2013-09-07 Thread Hashini Senaratne
Hi all, I am recently involved in horizontal scrolling of rows where I work with Math insets. There I found that bv.getPos(cur).x_ is not getting updated just after entering a Math inset from left or right corners. What happens is, the above attribute resets to the left most cursor position of t

Re: Reviews of commits

2013-09-07 Thread Hashini Senaratne
Hello Jean-Marc, > * Recompute inset positions before checking row left edge, by > painting the row insets with drawing disabled. > > Corresponding change is: > > + // Force the recomputation of inset positions > + bool const drawing = pi.pain.isDrawingEnabled(); > + pi.p

Re: Reviews of commits

2013-09-07 Thread Hashini Senaratne
Hello Jean-Marc, > > I tried both of the above patches that you have sent me. But nothing was > > able to solve the problem I mentioned. (When entering Math inset from right > > edge, row slides unexpectedly to the left most position.) However bellow > > code solved the above mentioned problem. >

Re: back from vacation

2013-09-07 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > will not have much time until the > > German election September 22. > > Uwe, what will happen with LyX if you win? Well. of course Uwe will force every German citizen to use LyX. And we will get some more funding. Uwe, you have my vote! Jürgen

Re: back from vacation

2013-09-07 Thread Pavel Sanda
Uwe Stöhr wrote: > will not have much time until the > German election September 22. Uwe, what will happen with LyX if you win? Pavel

Re: [LyX/master] ia.po: updates from Giovanni

2013-09-07 Thread Kornel Benko
Am Samstag, 7. September 2013 um 00:41:05, schrieb Scott Kostyshak > On Fri, Sep 6, 2013 at 8:49 PM, Uwe Stöhr wrote: > > commit 5435701af19ea8745153f0498428be903d96756e > > Author: Uwe Stöhr > > Date: Sat Sep 7 02:49:27 2013 +0200 > > > > ia.po: updates from Giovanni > > I am getting er

Re: Assertion on 2.1git in instant preview

2013-09-07 Thread Kornel Benko
Am Samstag, 7. September 2013 um 01:01:06, schrieb Scott Kostyshak > Several LyX math parser warnings are fixed at 1a96a9cf > > Two warnings remain that might be serious. Attached is an MWE that can > be used to reproduce an assertion. I can reproduce on Ubuntu 13.04 on > both branch and trunk i