[patch] Combine OutlineIn and OutlineOut blocks

Two blocks of code differed very little so I combined them. I'm not sure what LyX's style norms are about this. I like this because (1) now it is not easy to change in one place and forget about the other and (2) it's easy to see exactly where the code differs between the two. Opinions? Scott

Re: [LyX/master] Per a suggestion of JMarc's, first write the saved file to a temporary name, then move it to its real location if we succeed. This prevents our over-writing the existing file with a c

On Tue, Jun 3, 2014 at 11:45 AM, Richard Heck rgh...@lyx.org wrote: commit 10364082c8351b0f4a258699742370195aadde6b Author: Richard Heck rgh...@lyx.org Date: Tue Jun 3 10:42:07 2014 -0400 Per a suggestion of JMarc's, first write the saved file to a temporary name, then move it to

Re: [LyX/master] build with mingw on Windows and Linux

Peter Kümmel wrote: commit 080fca85a8fb6714afd7c34e4070687705fa1cb2 Author: Peter Kümmel kuem...@lyx.org Date: Sat Jun 7 07:59:52 2014 +0200 build with mingw on Windows and Linux Very nice! Georg

Re: LyX 2.1.1

On 03.06.2014 18:02, Richard Heck wrote: With this patch in place, I would like to move toward a 2.1.1 release as soon as possible. This does not fix the random crash people have been seeing, but it should prevent really serious dataloss, and that is a very good reason for a release. What

[PATCH 1/1] On Linux show in crash message box the backtrace

From: Peter Kümmel kuem...@lyx.org Signed-off-by: Peter Kümmel kuem...@lyx.org --- src/LyX.cpp |2 +- src/frontends/alert.h |3 ++- src/frontends/qt4/GuiAlert.cpp| 15 +++ src/frontends/qt4/GuiProgress.cpp | 12

Re: [LyX/master] build with mingw on Windows and Linux

On 07.06.2014 11:24, Georg Baum wrote: Peter Kümmel wrote: commit 080fca85a8fb6714afd7c34e4070687705fa1cb2 Author: Peter Kümmel kuem...@lyx.org Date: Sat Jun 7 07:59:52 2014 +0200 build with mingw on Windows and Linux Very nice! Georg It even works with the C libraries from the

Re: [PATCH 1/1] On Linux show in crash message box the backtrace

--- a/src/support/CMakeLists.txt +++ b/src/support/CMakeLists.txt @@ -36,6 +36,10 @@ else() set(support_linkback_headers ) endif() +if(UNIX AND CMAKE_COMPILER_IS_GNUCC AND NOT APPLE) + add_definitions(-DLYX_CALLSTACK_PRINTING) +endif() + Automake build needs to be patched.

Re: [PATCH 1/1] On Linux show in crash message box the backtrace

This patch is for 2.1.x, but could I commit to master? --- src/LyX.cpp |2 +- src/frontends/alert.h |3 ++- src/frontends/qt4/GuiAlert.cpp| 15 +++ src/frontends/qt4/GuiProgress.cpp | 12

Re: [LyX/master] build with mingw on Windows and Linux

On Sat, Jun 07, 2014 at 11:24:07AM +0200, Georg Baum wrote: Peter Kümmel wrote: commit 080fca85a8fb6714afd7c34e4070687705fa1cb2 Author: Peter Kümmel kuem...@lyx.org Date: Sat Jun 7 07:59:52 2014 +0200 build with mingw on Windows and Linux Very nice! Note that this was

RE: #9154: Crashes when lyx window comes into focus with sloppy mouse focus.

Thanks Richard and Scott! It was the mouse. When I plug the mouse into a Windows machine, it constantly connects and disconnects. Eddie Rucker

Re: [LyX/master] Per a suggestion of JMarc's, first write the saved file to a temporary name, then move it to its real location if we succeed. This prevents our over-writing the existing file with a c

2014-06-07 9:06 GMT+02:00 Scott Kostyshak: I've been getting the following message frequently when doing a normal save (and I have not been doing anything tricky such as editing the file externally): Document xyz.lyx has been externally modified. Are you sure you want to overwrite this file?

Re: [patch] Combine OutlineIn and OutlineOut blocks

On 06/07/2014 02:16 AM, Scott Kostyshak wrote: Two blocks of code differed very little so I combined them. I'm not sure what LyX's style norms are about this. I like this because (1) now it is not easy to change in one place and forget about the other and (2) it's easy to see exactly where the

Re: [LyX/master] Per a suggestion of JMarc's, first write the saved file to a temporary name, then move it to its real location if we succeed. This prevents our over-writing the existing file with a c

On 06/07/2014 11:57 AM, Jürgen Spitzmüller wrote: 2014-06-07 9:06 GMT+02:00 Scott Kostyshak: I've been getting the following message frequently when doing a normal save (and I have not been doing anything tricky such as editing the file externally): Document xyz.lyx has been

Re: [PATCH 1/1] On Linux show in crash message box the backtrace

On 06/07/2014 05:56 AM, Peter Kümmel wrote: This patch is for 2.1.x, but could I commit to master? I'd think it would be fine for master. Richard --- src/LyX.cpp |2 +- src/frontends/alert.h |3 ++- src/frontends/qt4/GuiAlert.cpp| 15

Re: Data Saving Patch 2

Richard Heck wrote: On 06/02/2014 12:57 PM, Jean-Marc Lasgouttes wrote: Le 02/06/14 15:05, Richard Heck a écrit : I propose to commit the attached. The effect is: (i) We always create a backup file in the current directory, but in the backup directory if Make Backups is true; (ii) If we are

Re: Data Saving Patch 2

Georg Baum wrote: Some of my remarks may look like nitpicking. However, we are trying to work around a problem which does not occur very often (although it causes big damage if it occurs), and this is a central infrastructure part. Therefore we have to be extra careful not to destroy the many

[patch] Combine OutlineIn and OutlineOut blocks

Two blocks of code differed very little so I combined them. I'm not sure what LyX's style norms are about this. I like this because (1) now it is not easy to change in one place and forget about the other and (2) it's easy to see exactly where the code differs between the two. Opinions? Scott

Re: [LyX/master] Per a suggestion of JMarc's, first write the saved file to a temporary name, then move it to its real location if we succeed. This prevents our over-writing the existing file with a c

On Tue, Jun 3, 2014 at 11:45 AM, Richard Heck wrote: > commit 10364082c8351b0f4a258699742370195aadde6b > Author: Richard Heck > Date: Tue Jun 3 10:42:07 2014 -0400 > > Per a suggestion of JMarc's, first write the saved file to a > temporary name, then

Re: [LyX/master] build with mingw on Windows and Linux

Peter Kümmel wrote: > commit 080fca85a8fb6714afd7c34e4070687705fa1cb2 > Author: Peter Kümmel > Date: Sat Jun 7 07:59:52 2014 +0200 > > build with mingw on Windows and Linux Very nice! Georg

Re: LyX 2.1.1

On 03.06.2014 18:02, Richard Heck wrote: With this patch in place, I would like to move toward a 2.1.1 release as soon as possible. This does not fix the random crash people have been seeing, but it should prevent really serious dataloss, and that is a very good reason for a release. What

[PATCH 1/1] On Linux show in crash message box the backtrace

From: Peter Kümmel Signed-off-by: Peter Kümmel --- src/LyX.cpp |2 +- src/frontends/alert.h |3 ++- src/frontends/qt4/GuiAlert.cpp| 15 +++ src/frontends/qt4/GuiProgress.cpp | 12

Re: [LyX/master] build with mingw on Windows and Linux

On 07.06.2014 11:24, Georg Baum wrote: Peter Kümmel wrote: commit 080fca85a8fb6714afd7c34e4070687705fa1cb2 Author: Peter Kümmel Date: Sat Jun 7 07:59:52 2014 +0200 build with mingw on Windows and Linux Very nice! Georg It even works with the C libraries from

Re: [PATCH 1/1] On Linux show in crash message box the backtrace

--- a/src/support/CMakeLists.txt +++ b/src/support/CMakeLists.txt @@ -36,6 +36,10 @@ else() set(support_linkback_headers "") endif() +if(UNIX AND CMAKE_COMPILER_IS_GNUCC AND NOT APPLE) + add_definitions(-DLYX_CALLSTACK_PRINTING) +endif() + Automake build needs to be patched.

Re: [PATCH 1/1] On Linux show in crash message box the backtrace

This patch is for 2.1.x, but could I commit to master? > --- src/LyX.cpp |2 +- src/frontends/alert.h |3 ++- src/frontends/qt4/GuiAlert.cpp| 15 +++ src/frontends/qt4/GuiProgress.cpp | 12

Re: [LyX/master] build with mingw on Windows and Linux

On Sat, Jun 07, 2014 at 11:24:07AM +0200, Georg Baum wrote: > Peter Kümmel wrote: > > > commit 080fca85a8fb6714afd7c34e4070687705fa1cb2 > > Author: Peter Kümmel > > Date: Sat Jun 7 07:59:52 2014 +0200 > > > > build with mingw on Windows and Linux > > Very nice! Note

RE: #9154: Crashes when lyx window comes into focus with sloppy mouse focus.

Thanks Richard and Scott! It was the mouse. When I plug the mouse into a Windows machine, it constantly connects and disconnects. Eddie Rucker

Re: [LyX/master] Per a suggestion of JMarc's, first write the saved file to a temporary name, then move it to its real location if we succeed. This prevents our over-writing the existing file with a c

2014-06-07 9:06 GMT+02:00 Scott Kostyshak: > I've been getting the following message frequently when doing a normal > save (and I have not been doing anything tricky such as editing the > file externally): > "Document xyz.lyx has been externally modified. Are you sure you want > to overwrite this

Re: [patch] Combine OutlineIn and OutlineOut blocks

On 06/07/2014 02:16 AM, Scott Kostyshak wrote: Two blocks of code differed very little so I combined them. I'm not sure what LyX's style norms are about this. I like this because (1) now it is not easy to change in one place and forget about the other and (2) it's easy to see exactly where the

Re: [LyX/master] Per a suggestion of JMarc's, first write the saved file to a temporary name, then move it to its real location if we succeed. This prevents our over-writing the existing file with a c

On 06/07/2014 11:57 AM, Jürgen Spitzmüller wrote: 2014-06-07 9:06 GMT+02:00 Scott Kostyshak: I've been getting the following message frequently when doing a normal save (and I have not been doing anything tricky such as editing the file externally): "Document xyz.lyx has been

Re: [PATCH 1/1] On Linux show in crash message box the backtrace

On 06/07/2014 05:56 AM, Peter Kümmel wrote: This patch is for 2.1.x, but could I commit to master? I'd think it would be fine for master. Richard > --- src/LyX.cpp |2 +- src/frontends/alert.h |3 ++- src/frontends/qt4/GuiAlert.cpp| 15

Re: Data Saving Patch 2

Richard Heck wrote: > On 06/02/2014 12:57 PM, Jean-Marc Lasgouttes wrote: >> Le 02/06/14 15:05, Richard Heck a écrit : >>> >>> I propose to commit the attached. The effect is: (i) We always create a >>> backup file in the current directory, but in the backup directory if >>> "Make Backups" is

Re: Data Saving Patch 2

Georg Baum wrote: > Some of my remarks may look like nitpicking. However, we are trying to > work around a problem which does not occur very often (although it causes > big damage if it occurs), and this is a central infrastructure part. > Therefore we have to be extra careful not to destroy the