Math_lyx{16,21} tests failing on master

2017-04-17 Thread Scott Kostyshak
On master (17a53bbc), the command ctest -R "Math_lyx" gives ... The following tests FAILED: 1530 - export/doc/Math_lyx16 (Failed) 1531 - export/doc/Math_lyx21 (Failed) Scott signature.asc Description: PGP signature

Qt terminal message "path is empty"

2017-04-17 Thread Scott Kostyshak
I've been getting the following message on recent master: QFileSystemWatcher::removePath: path is empty One way to trigger it is to have two different LyX instances open, write "hello" in one of them and select it and copy it and paste it in the other instance. The attached patch fixes it for

Re: optional line break, ldots (patch, fileformat)

2017-04-17 Thread Jürgen Spitzmüller
Am Montag, den 17.04.2017, 21:14 + schrieb Guenter Milde: > On 2017-04-17, Jürgen Spitzmüller wrote: > > Am Montag, den 17.04.2017, 09:54 + schrieb Guenter Milde: > > The more important issue is commented on trac: Some people redefine > > \ldots > > a bad idea... Why? > > > (I do in all

Re: [LyX/master] Revert "French Tutorial.lyx: some typographic fixes"

2017-04-17 Thread Scott Kostyshak
On Mon, Apr 17, 2017 at 03:26:46PM +0200, Uwe Stöhr wrote: > commit 8c4139434fe0c4926ea261c32d2acb1df17b6ee4 > Author: Uwe Stöhr > Date: Mon Apr 17 15:26:41 2017 +0200 > > Revert "French Tutorial.lyx: some typographic fixes" In the future, can you please explain in the commit why you rever

Re: [patch] for LyX 2.2.3 - box reversion lyx2lyx

2017-04-17 Thread Scott Kostyshak
On Mon, Apr 17, 2017 at 05:30:19AM +0200, Uwe Stöhr wrote: > Hi Richard, > > the attached patch fixes several box reversion issues in lyx2lyx. Scott > could verify that the conversion to LyX 2.1.x works now as expected. Just to be clear: when I report results of ctests, it is important to underst

Re: Warning while loading PDF-form.21.lyx

2017-04-17 Thread Scott Kostyshak
On Mon, Apr 17, 2017 at 08:33:04AM +0200, Kornel Benko wrote: > Am Montag, 17. April 2017 um 05:04:29, schrieb Uwe Stöhr > > El 17.04.2017 a las 04:40, Scott Kostyshak escribió: > > > > > I tested just "PDF-form" tests and the ones that were failing pass now. > > > Thanks for the fixes. > > > >

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Tommaso Cucinotta
On 18/04/2017 01:04, Kornel Benko wrote: So, I'd be in favor of using -SIGQUIT immediately on "TestEnd" in keytest.py, falling back to "kill -9" if LyX doesn't quit within 0.5 secs ? (without adding the \Ax work-around in test cases, that should not bee needed anymore). It may be too ear

Re: Warning while loading PDF-form.21.lyx

2017-04-17 Thread Uwe Stöhr
El 17.04.2017 a las 22:04, Kornel Benko escribió: It may be that the python output is not in the messages pane, only messages created by lyx executable. I am in favour of bug report. I reported a bug: http://www.lyx.org/trac/ticket/10628 However, I am stuck. open the attached LyX file (which

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Kornel Benko
Am Dienstag, 18. April 2017 um 00:03:47, schrieb Tommaso Cucinotta > On 17/04/2017 23:35, Tommaso Cucinotta wrote: > > -) or flush lyxerr on signal, and shutdown with that signal. > > in the end, it seems to me that the best is to close the application with: > >kill -SIGQUIT > > So, I remo

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Kornel Benko
Am Montag, 17. April 2017 um 23:35:03, schrieb Tommaso Cucinotta > On 17/04/2017 21:24, Kornel Benko wrote: > >> Btw, instead of ending each test with \Ax, what about ending them with \Cq > >> ? (shortcut for File->Quit) ? > > > > Or \Axlyx-quit\[Return], this is language independent. OTOH, mayb

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Tommaso Cucinotta
On 17/04/2017 23:35, Tommaso Cucinotta wrote: -) or flush lyxerr on signal, and shutdown with that signal. in the end, it seems to me that the best is to close the application with: kill -SIGQUIT So, I removed the sleep(0.5) before kill -9, and that way tests fail. However, turning the sign

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Tommaso Cucinotta
On 17/04/2017 21:24, Kornel Benko wrote: Btw, instead of ending each test with \Ax, what about ending them with \Cq ? (shortcut for File->Quit) ? Or \Axlyx-quit\[Return], this is language independent. OTOH, maybe we have to wait before sending it. I tried, and lyx often missed some keystrokes

Re: optional line break, ldots (patch, fileformat)

2017-04-17 Thread Guenter Milde
On 2017-04-17, Jürgen Spitzmüller wrote: > Am Montag, den 17.04.2017, 09:54 + schrieb Guenter Milde: > The more important issue is commented on trac: Some people redefine > \ldots a bad idea... > (I do in all my private classes), and this will break if it will > be substituted by \dots. > I

Re: [LyX/2.2.x] French Tutorial.lyx: some typographic fixes

2017-04-17 Thread Jean-Marc Lasgouttes
I think we don't care. JMarc Le 17 avril 2017 20:25:21 GMT+02:00, Guenter Milde a écrit : >What happens in French, if the footnote refers not just to a word but a >complete sentence?

Re: [patch] for LyX 2.2.3 - box reversion lyx2lyx

2017-04-17 Thread Uwe Stöhr
El 17.04.2017 a las 21:57, Richard Heck escribió: OK. it is in. I will look these over and commit them if they're acceptable. thanks. regards Uwe

Re: Warning while loading PDF-form.21.lyx

2017-04-17 Thread Kornel Benko
Am Montag, 17. April 2017 um 21:15:12, schrieb Uwe Stöhr > El 17.04.2017 a las 19:41, Kornel Benko escribió: > > > Confirmed. Thanks Uwe. > > Thank you. I'll send the patch for LyX 2.2 now. > > Nevertheless I could not get all the errors/warnings you got with > > lyx -e lyx16x PDF-form.lyx > l

Re: [PATCH] Expansion of tilde for users home directory in prefs is broken on Mac

2017-04-17 Thread Kornel Benko
Am Montag, 17. April 2017 um 21:15:02, schrieb Stephan Witt > > > Am 17.04.2017 um 17:23 schrieb Kornel Benko : > > > > Am Montag, 17. April 2017 um 15:40:51, schrieb Stephan Witt > > > >> Am 16.04.2017 um 22:45 schrieb Scott Kostyshak : > >>> > >>> On Sat, Apr 15, 2017 at 08:44:59AM +0200, S

Re: [patch] for LyX 2.2.3 - box reversion lyx2lyx

2017-04-17 Thread Richard Heck
On 04/17/2017 03:30 PM, Uwe Stöhr wrote: > El 17.04.2017 a las 17:22, Richard Heck escribió: > >> OK. > > It is in. > > Attached is another fix fixing the box reversion from 2.0 to 1.6. > Kornel verified that it works for him too OK to go in? OK. >> You can use git blame to identify where the cha

Re: [patch] for LyX 2.2.3 - box reversion lyx2lyx

2017-04-17 Thread Uwe Stöhr
El 17.04.2017 a las 17:22, Richard Heck escribió: OK. It is in. Attached is another fix fixing the box reversion from 2.0 to 1.6. Kornel verified that it works for him too OK to go in? You can use git blame to identify where the changes come from. Then we can look at the individual commit

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Kornel Benko
Am Montag, 17. April 2017 um 20:31:07, schrieb Tommaso Cucinotta > On 17/04/2017 12:50, Kornel Benko wrote: > > Am Montag, 17. April 2017 um 12:39:26, schrieb Kornel Benko > >>> Perhaps the issue is just that we terminate LyX with "kill -9" in > >>> keytest.py [1]. Would you please try replacin

Re: Warning while loading PDF-form.21.lyx

2017-04-17 Thread Uwe Stöhr
El 17.04.2017 a las 19:41, Kornel Benko escribió: Confirmed. Thanks Uwe. Thank you. I'll send the patch for LyX 2.2 now. Nevertheless I could not get all the errors/warnings you got with lyx -e lyx16x PDF-form.lyx lyx -batch PDF-form.16.lyx In only got the Lexer.cpp warnings which led me to

Re: [PATCH] Expansion of tilde for users home directory in prefs is broken on Mac

2017-04-17 Thread Stephan Witt
> Am 17.04.2017 um 17:23 schrieb Kornel Benko : > > Am Montag, 17. April 2017 um 15:40:51, schrieb Stephan Witt >> Am 16.04.2017 um 22:45 schrieb Scott Kostyshak : >>> >>> On Sat, Apr 15, 2017 at 08:44:59AM +0200, Stephan Witt wrote: >>> > Also, do you think we should consider reverting 9b

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Tommaso Cucinotta
On 17/04/2017 12:50, Kornel Benko wrote: Am Montag, 17. April 2017 um 12:39:26, schrieb Kornel Benko Perhaps the issue is just that we terminate LyX with "kill -9" in keytest.py [1]. Would you please try replacing that "-9" with "-SIGQUIT" or similar, and see what happens ? (after rolling back

Re: [LyX/2.2.x] French Tutorial.lyx: some typographic fixes

2017-04-17 Thread Guenter Milde
On 2017-04-17, Uwe Stöhr wrote: > Le 17 avril 2017 10:54:13 GMT+02:00, "Jean-Pierre Chrétien" > a écrit : >> Sorry, but this is not true: in French, the character calling a >> footnote should >> be introduced just after the word which refers to the footnote, >> whatever the >> punctuation characte

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

2017-04-17 Thread Uwe Stöhr
El 17.04.2017 a las 19:53, Uwe Stöhr escribió: No, it introduces bugs. You also use now \paragraph_indentation "23bp" instead of the former \paragraph_indentation 23bp the quotes change the fileformat and break lyx2lyx routines. regards Uwe

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

2017-04-17 Thread Uwe Stöhr
El 17.04.2017 a las 18:32, Jean-Marc Lasgouttes escribió: I do not have time right now, but I just committed a patch for parindent. Does it help? No, it introduces bugs. Noe you use "0pt" as default value but this is not correct. We don't know the default value of parindent. Moreover you wri

Re: Warning while loading PDF-form.21.lyx

2017-04-17 Thread Kornel Benko
Am Montag, 17. April 2017 um 19:20:32, schrieb Uwe Stöhr > El 17.04.2017 a las 18:14, Uwe Stöhr escribió: > > > There is however an error in a conversion routine from 1.6.x to 2.0x > > because the length \totalheight is mangled. Therefore the opened file > > fails to compile to a PDF. > > This

Re: Warning while loading PDF-form.21.lyx

2017-04-17 Thread Uwe Stöhr
El 17.04.2017 a las 18:14, Uwe Stöhr escribió: There is however an error in a conversion routine from 1.6.x to 2.0x because the length \totalheight is mangled. Therefore the opened file fails to compile to a PDF. This bug is now also fixed: http://www.lyx.org/trac/changeset/bc0591a2/lyxgit N

Re: Warning while loading PDF-form.21.lyx

2017-04-17 Thread Kornel Benko
Am Montag, 17. April 2017 um 18:14:41, schrieb Uwe Stöhr > El 17.04.2017 a las 08:33, Kornel Benko escribió: > > >> LyX is made for users. It is impossible to use PDF forms in LyX < 2.1 so > >> there won't be users. Therefore testing this file export to LyX 1.6 is > >> senseless. > > > > Makes s

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

2017-04-17 Thread Jean-Marc Lasgouttes
Le 17/04/2017 à 18:07, Uwe Stöhr a écrit : OK, attached is a patch that would omit HSpace. I don't understand why it doesn't work: If the default value is used math_indentation is not "default" but empty. Maybe you see my mistake? In the patch I corrected also the UI enabling logic. If I coul

Re: Warning while loading PDF-form.21.lyx

2017-04-17 Thread Uwe Stöhr
El 17.04.2017 a las 08:33, Kornel Benko escribió: LyX is made for users. It is impossible to use PDF forms in LyX < 2.1 so there won't be users. Therefore testing this file export to LyX 1.6 is senseless. Makes sense. Therefore I opt to remove the test for LyX 1.6x and 2.0x for PDF-form and

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

2017-04-17 Thread Uwe Stöhr
El 15.04.2017 a las 19:07, Jean-Marc Lasgouttes escribió: Nowadays (with default lengths), the class is basically useless. OK, attached is a patch that would omit HSpace. I don't understand why it doesn't work: If the default value is used math_indentation is not "default" but empty. Maybe

Re: Tentative schedule for 2.3.0 release

2017-04-17 Thread Jean-Marc Lasgouttes
Le 17/04/2017 à 10:56, mn a écrit : On 15.04.17 19:35, Jean-Marc Lasgouttes wrote: Le 12/04/2017 à 12:31, mn a écrit : While editing spellchecker is always off, as are insets closed (well most) and source view and the like. 2.2.2 is still slow and grows slower over time. Any improvement in that

Re: [PATCH] Expansion of tilde for users home directory in prefs is broken on Mac

2017-04-17 Thread Kornel Benko
Am Montag, 17. April 2017 um 15:40:51, schrieb Stephan Witt > Am 16.04.2017 um 22:45 schrieb Scott Kostyshak : > > > > On Sat, Apr 15, 2017 at 08:44:59AM +0200, Stephan Witt wrote: > > > >>> Also, do you think we should consider reverting 9b64d7bd? I hope not, > >>> but I ask you since I think a

Re: [patch] for LyX 2.2.3 - box reversion lyx2lyx

2017-04-17 Thread Richard Heck
On 04/16/2017 11:30 PM, Uwe Stöhr wrote: > Hi Richard, > > the attached patch fixes several box reversion issues in lyx2lyx. > Scott could verify that the conversion to LyX 2.1.x works now as > expected. Could this therefore also go in for LyX 2.2.3? OK. > Another issue: when I compare lyx-2_2.py

Re: Tentative schedule for 2.3.0 release

2017-04-17 Thread Jean-Marc Lasgouttes
Le 16/04/2017 à 13:43, mn a écrit : The problem seems to be at least two-fold: - Using two much Hebrew it decelerates quickly. - But using only one (latin) language and just leaving the app open (by accident leaving the app open for three days hidden) also causes a massive slow down, so that I

Re: "early preamble"

2017-04-17 Thread PhilipPirrip
On 04/15/2017 05:58 AM, Guenter Milde wrote: I would suggest 2 tabs in Document>Settings>User preamble, where the "normal" preamble is the default and the "early" preamble gets a documentation line telling about the specifics. We should think about the right place, though: placing it before any

Re: [PATCH] Expansion of tilde for users home directory in prefs is broken on Mac

2017-04-17 Thread Stephan Witt
Am 16.04.2017 um 22:45 schrieb Scott Kostyshak : > > On Sat, Apr 15, 2017 at 08:44:59AM +0200, Stephan Witt wrote: > >>> Also, do you think we should consider reverting 9b64d7bd? I hope not, >>> but I ask you since I think at this point you have the best >>> understanding of the situation. >> >>

Re: [LyX/2.2.x] French Tutorial.lyx: some typographic fixes

2017-04-17 Thread Uwe Stöhr
Le 17 avril 2017 10:54:13 GMT+02:00, "Jean-Pierre Chrétien" a écrit : Sorry, but this is not true: in French, the character calling a footnote should be introduced just after the word which refers to the footnote, whatever the punctuation character following the word may be (sentence dot, questi

Re: [LyX/2.2.x] French Tutorial.lyx: some typographic fixes

2017-04-17 Thread Jean-Marc Lasgouttes
Agreed. This commit should be reverted. JMarc Le 17 avril 2017 10:54:13 GMT+02:00, "Jean-Pierre Chrétien" a écrit : >Sorry, but this is not true: in French, the character calling a >footnote should >be introduced just after the word which refers to the footnote, >whatever the >punctuation cha

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Kornel Benko
Am Montag, 17. April 2017 um 12:39:26, schrieb Kornel Benko > > Perhaps the issue is just that we terminate LyX with "kill -9" in > > keytest.py [1]. Would you please try replacing that "-9" with "-SIGQUIT" or > > similar, and see what happens ? (after rolling back the \Ax, which, from > > what

Re: optional line break, ldots (patch, fileformat)

2017-04-17 Thread Jürgen Spitzmüller
Am Montag, den 17.04.2017, 09:54 + schrieb Guenter Milde: > Of course I do: both, the menu entry and the keybindings were adapted > to > "unicode-insert 2026" (…). The more important issue is commented on trac: Some people redefine \ldots (I do in all my private classes), and this will break i

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Kornel Benko
Am Montag, 17. April 2017 um 12:16:18, schrieb Tommaso Cucinotta > On 17/04/2017 11:59, Kornel Benko wrote: > > I think that is because of missing flush of stderr. \Ax gives more output > > and that saves us. > > weird: when you << endl, it should auto-flush, but sometimes that behavior is > d

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Tommaso Cucinotta
On 17/04/2017 11:59, Kornel Benko wrote: I think that is because of missing flush of stderr. \Ax gives more output and that saves us. weird: when you << endl, it should auto-flush, but sometimes that behavior is disabled when redirecting to a file. Also, in such case the standard prescribes

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Kornel Benko
Am Montag, 17. April 2017 um 11:51:57, schrieb Tommaso Cucinotta > On 17/04/2017 10:37, Kornel Benko wrote: > >> So I added 'KK: \Ax' as the last command before 'TestEnd' to output mode > >> debug msgs. > >> Now this test passes. (See attached) > > > > With this, all findadv tests pass. (std-reg

Re: optional line break, ldots (patch, fileformat)

2017-04-17 Thread Guenter Milde
On 2017-04-17, Jürgen Spitzmüller wrote: > [-- Type: text/plain, Encoding: quoted-printable --] > Am Samstag, den 15.04.2017, 19:04 + schrieb Guenter Milde: >> b) Remove specialchar "ldots" (duplicate of u2026 HORIZONTAL >> ELLIPSIS):  > Please no. Unless you give the unicode char the same s

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Tommaso Cucinotta
On 17/04/2017 10:37, Kornel Benko wrote: So I added 'KK: \Ax' as the last command before 'TestEnd' to output mode debug msgs. Now this test passes. (See attached) With this, all findadv tests pass. (std-regex) cool, but I'm not seeing why adding \Ax at just before quitting makes any differe

Re: [LyX/2.2.x] French Tutorial.lyx: some typographic fixes

2017-04-17 Thread Jean-Pierre Chrétien
Le 16/04/2017 à 19:09, Uwe Stöhr a écrit : commit 2a10603c875c7936b006ac8e2bd4eb52a5ad2334 Author: Uwe Stöhr Date: Sun Apr 16 19:09:48 2017 +0200 French Tutorial.lyx: some typographic fixes - footnotes should be after the sentence dot Sorry, but this is not true: in French, the cha

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Kornel Benko
Am Montag, 17. April 2017 um 10:26:26, schrieb Kornel Benko > Wait a moment, in the mean time I found what's wrong with > keytest/findadv-re-01. > The expected message did not show in lyx-log.txt although manual retest > displays it correctly. > So I added 'KK: \Ax' as the last command before 'T

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Kornel Benko
Am Montag, 17. April 2017 um 10:08:04, schrieb Tommaso Cucinotta > On 17/04/2017 09:23, Kornel Benko wrote: > > The following tests fail using boost-regex: > > 232 - keytest/findadv-18 (Failed) > > 236 - keytest/findadv-re-01 (Failed) > > 237 - keytest/findadv-re-02 (Failed) > > 2

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Tommaso Cucinotta
On 17/04/2017 09:23, Kornel Benko wrote: The following tests fail using boost-regex: 232 - keytest/findadv-18 (Failed) 236 - keytest/findadv-re-01 (Failed) 237 - keytest/findadv-re-02 (Failed) 238 - keytest/findadv-re-03 (Failed) very useful, can you please dump

Re: [LyX/master] findadv: avoid crash when regexp-based search fails (mitigates #10625).

2017-04-17 Thread Kornel Benko
Am Montag, 17. April 2017 um 08:43:15, schrieb Kornel Benko > Am Sonntag, 16. April 2017 um 22:52:11, schrieb Tommaso Cucinotta > > > On 16/04/2017 22:22, Kornel Benko wrote: > > > Cmake: > > > In master it is set to '1' if using clang on unix like system. In all > > > other cases it is set to

Re: optional line break, ldots (patch, fileformat)

2017-04-17 Thread Jürgen Spitzmüller
Am Samstag, den 15.04.2017, 19:04 + schrieb Guenter Milde: > b) Remove specialchar "ldots" (duplicate of u2026 HORIZONTAL > ELLIPSIS):  Please no. Unless you give the unicode char the same shortcut. Jürgen signature.asc Description: This is a digitally signed message part

Re: Lyx layout for ACM Article class

2017-04-17 Thread Jürgen Spitzmüller
Am Samstag, den 15.04.2017, 09:37 + schrieb Guenter Milde: > On 2017-04-15, John Perry wrote: > > Hello > > The old ACM styles don't seem to work with the new(ish) ACM article > > class at > > www.acm.org/publications/proceedings-template > > so I've written a Lyx layout for it. It works we