Jenkins build is back to normal : Build branch "master" » ubuntu-xenial-qt4-autotools #1131

2018-12-25 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools/1131/

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 18:20, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Try again with recent master. Jürgen I'll give up. It was fun. Daniel

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 16:29, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 13:56 +0100 schrieb Daniel: Did you check whether those not on the list do actually have GBs? Yes. Daniel And some are missing from your list, like FindAndReplaceUi.ui. Thanks, added. Jürgen Okay, I'll give

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 12:35 +0100 schrieb Jürgen Spitzmüller: > Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel: > > Thanks. But I like mine more (see attached screen shot). > > I don't see the misalignment in your screenshot here on Linux. But I > saw a misalignment with your patch.

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: > Thanks. But the buttons are misaligned now (see attachment). Try again with recent master. Jürgen signature.asc Description: This is a digitally signed message part

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools #1130

2018-12-25 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools/1130/Changes: [spitz] Unify group box style across dialogs. -- [...truncated 623 lines...] GEN ui_ModulesUi.h GEN ui_NomenclUi.h GEN ui_NoteUi.h GEN

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 13:56 +0100 schrieb Daniel: > > Did you check whether those not on the list do actually have GBs? Yes. > > > > Daniel > > And some are missing from your list, like FindAndReplaceUi.ui. Thanks, added. Jürgen signature.asc Description: This is a digitally signed

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 13:43 +0100 schrieb Daniel: > > I am probably confused. Do you ask me to recreate my patch with > current > master Yes, please. > which you successfully applied before and found to be misaligned? Yes. Thanks Jürgen > > Daniel > signature.asc Description:

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 14:10, Daniel wrote: On 25/12/2018 12:51, Daniel wrote: On 25/12/2018 12:26, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). * the Cancel button needs

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 12:51, Daniel wrote: On 25/12/2018 12:26, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). * the Cancel button needs to go on a line of its own. I

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 13:46, Daniel wrote: On 25/12/2018 13:22, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel: It is not that only some of the GBs are out of line. Almost all are non-flat. I count only a minority where the flat designation was missing. Namely    

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 13:22, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel: It is not that only some of the GBs are out of line. Almost all are non-flat. I count only a minority where the flat designation was missing. Namely

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 13:26, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 13:08 +0100 schrieb Daniel: Can you show me what my patch looks like on the style you use? Then I could try to figure out what went wrong with it. If you send me a patch that applies to master, sure. Jürgen You

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 13:08 +0100 schrieb Daniel: > Can you show me what my patch looks like on the style you use? Then > I > could try to figure out what went wrong with it. If you send me a patch that applies to master, sure. Jürgen > > Daniel > signature.asc Description: This is

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel: > > It is not that only some of the GBs are out of line. Almost all are > non-flat. I count only a minority where the flat designation was missing. Namely src/frontends/qt4/ui/CharacterUi.ui src/frontends/qt4/ui/CitationUi.ui

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 12:35, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel: Thanks. But I like mine more (see attached screen shot). I don't see the misalignment in your screenshot here on Linux. But I saw a misalignment with your patch. It maybe depends on the Qt

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 12:26, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). Sorry, forgot to comment on this. That the misalignment does not happen for you is because text

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 12:26, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). * the Cancel button needs to go on a line of its own. I understand that this is a general rule of

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 12:28, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:21 +0100 schrieb Daniel: Thanks. You changed the group box style to flat, right? I still think this isn't LyX standard. It's LyX standard. We changed that some years ago. If some GBs are non- flat, we should change

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel: > Thanks. But I like mine more (see attached screen shot). I don't see the misalignment in your screenshot here on Linux. But I saw a misalignment with your patch. It maybe depends on the Qt style. Jürgen signature.asc Description: This is

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:21 +0100 schrieb Daniel: > Thanks. You changed the group box style to flat, right? I still > think > this isn't LyX standard. It's LyX standard. We changed that some years ago. If some GBs are non- flat, we should change that. Jürgen signature.asc Description:

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: > Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). > > * the Cancel button needs to go on a line of its own. > > I understand that this is a general rule of dialogs in LyX. However, > please

Re: [LyX/master] Use symbols file to lookup entities for delimiters. Fixes bug #8280.

2018-12-25 Thread Kornel Benko
Am Montag, 24. Dezember 2018 22:19:56 CET schrieb Scott Kostyshak : > On Fri, Jun 08, 2018 at 11:16:21PM -0400, Scott Kostyshak wrote: > > On Sat, Apr 28, 2018 at 09:19:41PM +, Scott Kostyshak wrote: > > > On Thu, Jun 30, 2016 at 02:40:30AM +, Richard Heck wrote: > > > > commit

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 24/12/2018 22:45, Daniel wrote: On 24/12/2018 14:48, Jürgen Spitzmüller wrote: Am Montag, den 29.10.2018, 15:16 +0100 schrieb Daniel: On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could proceed with the