Re: Trivial patch review request

2019-08-14 Thread Scott Kostyshak
On Wed, Aug 14, 2019 at 07:32:45PM -0400, Scott Kostyshak wrote: > On Wed, Aug 14, 2019 at 12:14:02PM -0600, Joel Kulesza wrote: > > > Sorry for the quick follow-up, but Riki alerted me offline that the CREDITS > > file is generated from generate_contributors.py so this fix (and the others > > I

Re: Trivial patch review request

2019-08-14 Thread Scott Kostyshak
On Wed, Aug 14, 2019 at 12:10:46PM -0600, Joel Kulesza wrote: > Riki took care of this not long after I'd sent it, so I think we're good > but I appreciate you following up! Ah good to know. > Hopefully my activity in the credits > isn't seen as too vain. Not at all. I hope my attempt at humor

Re: Trivial patch review request

2019-08-14 Thread Scott Kostyshak
On Wed, Aug 14, 2019 at 12:14:02PM -0600, Joel Kulesza wrote: > Sorry for the quick follow-up, but Riki alerted me offline that the CREDITS > file is generated from generate_contributors.py so this fix (and the others > I see you just made) are needed there. Ah good to know. I just ported the

Bug in external preamble edit

2019-08-14 Thread Paul A. Rubin
FYI, I just filed a ticket (#11640 ) on a bug in the new preamble external edit feature. For some odd reason, the file path is (tmp/lyx_tmpdir...) is passed correctly to one editor (xed), but the "t" in "tmp" is lopped off when passing it to another

Re: Trivial patch review request

2019-08-14 Thread Joel Kulesza
On Wed, Aug 14, 2019 at 12:10 PM Joel Kulesza wrote: > On Wed, Aug 14, 2019 at 11:08 AM Scott Kostyshak wrote: > >> On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: >> > LyX Developers, >> > >> > Can someone please review/incorporate the attached, trivial, patch, >> which >> >

Re: Trivial patch review request

2019-08-14 Thread Joel Kulesza
On Wed, Aug 14, 2019 at 11:08 AM Scott Kostyshak wrote: > On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: > > LyX Developers, > > > > Can someone please review/incorporate the attached, trivial, patch, which > > corrects a typo in the credits? > > > > Please let me know if a

Re: Trivial patch review request

2019-08-14 Thread Scott Kostyshak
On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: > LyX Developers, > > Can someone please review/incorporate the attached, trivial, patch, which > corrects a typo in the credits? > > Please let me know if a tracker issue is warranted. > > Otherwise, please contact me with any

Re: Some exports are currently failing on master

2019-08-14 Thread Scott Kostyshak
On Wed, Aug 14, 2019 at 02:02:20PM +0200, Jürgen Spitzmüller wrote: > Am Mittwoch, den 14.08.2019, 13:14 +0200 schrieb Jürgen Spitzmüller: > > The Japanese User Guide still does not compile with Slovak GUI since > > babel-slovak also makes ^ active, which breaks with \cprotect. > > Fixed as well.

Re: Some exports are currently failing on master

2019-08-14 Thread Jürgen Spitzmüller
Am Mittwoch, den 14.08.2019, 13:14 +0200 schrieb Jürgen Spitzmüller: > The Japanese User Guide still does not compile with Slovak GUI since > babel-slovak also makes ^ active, which breaks with \cprotect. Fixed as well. This might fix other cases that mysteriously failed with Slovak only. Please

Re: Some exports are currently failing on master

2019-08-14 Thread Jürgen Spitzmüller
Am Dienstag, den 13.08.2019, 14:21 +0200 schrieb Jürgen Spitzmüller: > Am Di., 13. Aug. 2019 um 13:35 Uhr schrieb Kornel Benko < > kor...@lyx.org>: > > fr/UserGuide.lyx and ja/UserGuide.lyx compile fine here now if not > > using Slovak or Czech gui. > > All others compile now regardless the GUI. >