IconInfo iconInfo: member call on null pointer

2021-09-24 Thread Scott Kostyshak
After building with fsanitize=undefined -fno-omit-frame-pointer, I get the following: $ cd lib/examples/ && lyx -e pdf Welcome.lyx /home/scott/lyxbuilds/master/repo/src/frontends/qt/GuiApplication.cpp:558:55: runtime error: member call on null pointer of type 'struct GuiApplication'

Re: [LyX/master] Cmake build: Unify use of sanitizer

2021-09-24 Thread Scott Kostyshak
On Tue, Sep 21, 2021 at 11:11:11AM +0200, Kornel Benko wrote: > commit 4f46c22d034b22ca80e906b97a4f0a8021f37611 > Author: Kornel Benko > Date: Tue Sep 21 11:27:13 2021 +0200 > > Cmake build: Unify use of sanitizer > > The configuration variable is LYX_DEBUG_SANITIZE > which

Re: [LyX/master] Improve (modestly) the performance of font metrics caches

2021-09-24 Thread Jean-Marc Lasgouttes
Le 24/09/2021 à 17:23, Kornel Benko a écrit : Am Fri, 24 Sep 2021 16:51:35 +0200 (CEST) schrieb Jean-Marc Lasgouttes : commit 6bbd88accfb76248d00346f308ba1f67f186e094 Author: Jean-Marc Lasgouttes Date: Fri Sep 24 16:57:05 2021 +0200 Improve (modestly) the performance of font metrics

Re: Remove underline from tracked changes?

2021-09-24 Thread Scott Kostyshak
On Fri, Sep 24, 2021 at 01:45:15PM +0200, Rasmus K. Rendsvig wrote: > On Fri, 24 Sept 2021 at 12:19, Pavel Sanda wrote: > > > The attached patch does what you asked for, at least here. > > > > Thank you! > > The patch failed to apply for me, but manually making the changes did the > trick! >

Re: [LyX/master] Improve (modestly) the performance of font metrics caches

2021-09-24 Thread Kornel Benko
Am Fri, 24 Sep 2021 16:51:35 +0200 (CEST) schrieb Jean-Marc Lasgouttes : > commit 6bbd88accfb76248d00346f308ba1f67f186e094 > Author: Jean-Marc Lasgouttes > Date: Fri Sep 24 16:57:05 2021 +0200 > > Improve (modestly) the performance of font metrics caches

Re: Remove underline from tracked changes?

2021-09-24 Thread Rasmus K. Rendsvig
On Fri, 24 Sept 2021 at 12:19, Pavel Sanda wrote: > The attached patch does what you asked for, at least here. > Thank you! The patch failed to apply for me, but manually making the changes did the trick! Thank you very much, both of you! -- lyx-devel mailing list lyx-devel@lists.lyx.org

Re: Remove underline from tracked changes?

2021-09-24 Thread Pavel Sanda
On Fri, Sep 24, 2021 at 10:59:38AM +0200, Rasmus K. Rendsvig wrote: > In any case, then I would appreciate a word of advice at this juncture. The attached patch does what you asked for, at least here. Pavel diff --git a/src/Changes.cpp b/src/Changes.cpp index 6e3bf0fff7..7608d218c1 100644 ---

Re: Remove underline from tracked changes?

2021-09-24 Thread Rasmus K. Rendsvig
On Thu, 23 Sep 2021, 19:52 Scott Kostyshak, wrote: > On Thu, Sep 23, 2021 at 06:45:51PM +0200, Rasmus K. Rendsvig wrote: > > > > > > On Thu, Sep 23, 2021 at 02:32:55PM +0200, Rasmus K. Rendsvig wrote: > > > > Hi LyX devs, > > > > > > > > I tried asking this on the users' list a few weeks ago,

Re: Compile warnings with docbook

2021-09-24 Thread Thibaut Cuvelier
On Fri, 24 Sept 2021 at 10:07, Kornel Benko wrote: > Am Fri, 24 Sep 2021 09:34:36 +0200 > schrieb Thibaut Cuvelier : > > > On Fri, 24 Sept 2021 at 09:23, Kornel Benko wrote: > > > > > Am Fri, 24 Sep 2021 01:23:50 +0200 > > > schrieb Thibaut Cuvelier : > > > > > > > Hi Kornel, > > > > > > > >

Re: Compile warnings with docbook

2021-09-24 Thread Kornel Benko
Am Fri, 24 Sep 2021 09:34:36 +0200 schrieb Thibaut Cuvelier : > On Fri, 24 Sept 2021 at 09:23, Kornel Benko wrote: > > > Am Fri, 24 Sep 2021 01:23:50 +0200 > > schrieb Thibaut Cuvelier : > > > > > Hi Kornel, > > > > > > Thanks for pointing these out, they didn't show on my side. I could quite >

Re: Compile warnings with docbook

2021-09-24 Thread Thibaut Cuvelier
On Fri, 24 Sept 2021 at 09:23, Kornel Benko wrote: > Am Fri, 24 Sep 2021 01:23:50 +0200 > schrieb Thibaut Cuvelier : > > > Hi Kornel, > > > > Thanks for pointing these out, they didn't show on my side. I could quite > > easily fix the one about the unused argument in the constructor (it's > >

Re: Compile warnings with docbook

2021-09-24 Thread Kornel Benko
Am Fri, 24 Sep 2021 01:23:50 +0200 schrieb Thibaut Cuvelier : > Hi Kornel, > > Thanks for pointing these out, they didn't show on my side. I could quite > easily fix the one about the unused argument in the constructor (it's > already pushed: dca39815), but I don't know what to do for the