Re: [patch] Removal of strfwd.h (was: When to use strfwd.h)

2024-10-01 Thread Thibaut Cuvelier
On Tue, 1 Oct 2024 at 23:02, Pavel Sanda wrote: > On Tue, Oct 01, 2024 at 07:09:03PM +0200, Jean-Marc Lasgouttes wrote: > > Le 01/10/2024 ?? 18:18, Pavel Sanda a écrit : > > > I could produce patch which ditches strfwd and let Enrico/Eugene test > it? > > > > > > From what I see it might do more

[patch] Removal of strfwd.h (was: When to use strfwd.h)

2024-10-01 Thread Pavel Sanda
On Tue, Oct 01, 2024 at 07:09:03PM +0200, Jean-Marc Lasgouttes wrote: > Le 01/10/2024 ?? 18:18, Pavel Sanda a écrit : > > I could produce patch which ditches strfwd and let Enrico/Eugene test it? > > > > From what I see it might do more harm than good in linux nowadys... > > Go for it. And do no

Re: How to underline and color hyperlinks?

2024-10-01 Thread Pavel Sanda
On Tue, Oct 01, 2024 at 01:57:16PM -0400, Richard Kimberly Heck wrote: > > It's in 601abfe9291. > > > > I propose to include it in branch. > > Go ahead. It's in f73b86132c0. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: When to use strfwd.h

2024-10-01 Thread Jean-Marc Lasgouttes
Le 01/10/2024 à 18:18, Pavel Sanda a écrit : I could produce patch which ditches strfwd and let Enrico/Eugene test it? From what I see it might do more harm than good in linux nowadys... Go for it. And do not forget to remove and/or from the cpp file. JMarc -- lyx-devel mailing list lyx

Re: 72 non accessible url's in our lyx-files

2024-10-01 Thread Jean-Pierre Chrétien
Le 01/10/2024 à 17:56, Pavel Sanda a écrit : I do not understand why 37 in particular, but whatever you fix is good :) It is one more than 36, the end of the first half :-) And yes, I intended to substitute in the lyx file directly. -- Jean-Pierre -- lyx-devel mailing list lyx-devel@lists.

Re: When to use strfwd.h

2024-10-01 Thread Jean-Marc Lasgouttes
Le 01/10/2024 à 10:50, Pavel Sanda a écrit : Hi, in GuiToolbar.h we include strfwd.h, clearly because we use std::string there (as introduced by Riki in cc4bfc7f04d). However in many different .h files we include for the same purpouse. I suspect we should be consistent but I am not sure what i

Re: 72 non accessible url's in our lyx-files

2024-10-01 Thread Pavel Sanda
On Tue, Oct 01, 2024 at 05:18:39PM +0200, Jean-Pierre Chrétien wrote: > Le 01/10/2024 ?? 17:08, Pavel Sanda a écrit : > > On Tue, Oct 01, 2024 at 04:44:31PM +0200, Jean-Pierre Chrétien wrote: > > > > "Error url": specifies the wrong url > > > > The next indented lines specify the lyx-source with th

Re: 72 non accessible url's in our lyx-files

2024-10-01 Thread Jean-Pierre Chrétien
Le 01/10/2024 à 18:29, Kornel Benko a écrit : Am Tue, 1 Oct 2024 18:12:25 +0200 schrieb Jean-Pierre Chrétien : Le 01/10/2024 à 17:56, Pavel Sanda a écrit : I do not understand why 37 in particular, but whatever you fix is good :) It is one more than 36, the end of the first half :-) And y

Re: 72 non accessible url's in our lyx-files

2024-10-01 Thread Kornel Benko
Am Tue, 1 Oct 2024 18:12:25 +0200 schrieb Jean-Pierre Chrétien : > Le 01/10/2024 à 17:56, Pavel Sanda a écrit : > > > > > I do not understand why 37 in particular, but whatever you fix is good :) > > It is one more than 36, the end of the first half :-) > > And yes, I intended to substitute

Re: When to use strfwd.h

2024-10-01 Thread Pavel Sanda
On Tue, Oct 01, 2024 at 11:12:00AM +0200, Jean-Marc Lasgouttes wrote: > Basically, for gcc >=5 and libc++, we include . Unless there is > something I do not understand, the header is not really useful IMO. Are you sure about this? I checked before sending my email and while empty file with #includ

Re: When to use strfwd.h

2024-10-01 Thread Pavel Sanda
On Tue, Oct 01, 2024 at 01:02:29PM +0200, Jean-Marc Lasgouttes wrote: > Le 01/10/2024 ?? 12:23, Pavel Sanda a écrit : > > On Tue, Oct 01, 2024 at 11:12:00AM +0200, Jean-Marc Lasgouttes wrote: > > > Basically, for gcc >=5 and libc++, we include . Unless there is > > > something I do not understand,

Re: 72 non accessible url's in our lyx-files

2024-10-01 Thread Pavel Sanda
On Tue, Oct 01, 2024 at 05:20:18PM +0200, Jean-Pierre Chrétien wrote: > BTW, corrections should go to 2.4.x, right? I think that you should fix primarily master (and then backport to 2.4.x if you feel like). And using vim or sed might be actually faster than editing manuals... :) Pavel -- lyx-d

72 non accessible url's in our lyx-files

2024-10-01 Thread Kornel Benko
Attached is the output of $ ctest -R check_accessible_urls "Error url": specifies the wrong url The next indented lines specify the lyx-source with the line number after ':[uh]' Kornel Error url: "ftp://ctan.tug.org/tex-archive/macros/latex/contrib/bibtopic/"; lib/doc/Additional.lyx:u

Re: 72 non accessible url's in our lyx-files

2024-10-01 Thread Pavel Sanda
On Tue, Oct 01, 2024 at 04:44:31PM +0200, Jean-Pierre Chrétien wrote: > > "Error url": specifies the wrong url > > The next indented lines specify the lyx-source with the line number after > > ':[uh]' > > Do you need help to check and correct these urls ? That would be nice. Pavel -- lyx-devel

Re: 72 non accessible url's in our lyx-files

2024-10-01 Thread Jean-Pierre Chrétien
Le 01/10/2024 à 17:08, Pavel Sanda a écrit : On Tue, Oct 01, 2024 at 04:44:31PM +0200, Jean-Pierre Chrétien wrote: "Error url": specifies the wrong url The next indented lines specify the lyx-source with the line number after ':[uh]' Do you need help to check and correct these urls ? That w

Re: 72 non accessible url's in our lyx-files

2024-10-01 Thread Jean-Pierre Chrétien
Le 01/10/2024 à 17:18, Jean-Pierre Chrétien a écrit : Le 01/10/2024 à 17:08, Pavel Sanda a écrit : On Tue, Oct 01, 2024 at 04:44:31PM +0200, Jean-Pierre Chrétien wrote: "Error url": specifies the wrong url The next indented lines specify the lyx-source with the line number after ':[uh]' Do y

When to use strfwd.h

2024-10-01 Thread Pavel Sanda
Hi, in GuiToolbar.h we include strfwd.h, clearly because we use std::string there (as introduced by Riki in cc4bfc7f04d). However in many different .h files we include for the same purpouse. I suspect we should be consistent but I am not sure what is correct. Is the only purpose of strfwd to av

Re: 72 non accessible url's in our lyx-files

2024-10-01 Thread Jean-Pierre Chrétien
Le 01/10/2024 à 15:18, Kornel Benko a écrit : Attached is the output of $ ctest -R check_accessible_urls "Error url": specifies the wrong url The next indented lines specify the lyx-source with the line number after ':[uh]' Do you need help to check and correct these urls ? -- Jean-Pierre

Re: When to use strfwd.h

2024-10-01 Thread Jean-Marc Lasgouttes
Le 01/10/2024 à 12:23, Pavel Sanda a écrit : On Tue, Oct 01, 2024 at 11:12:00AM +0200, Jean-Marc Lasgouttes wrote: Basically, for gcc >=5 and libc++, we include . Unless there is something I do not understand, the header is not really useful IMO. Are you sure about this? I checked before sendi