Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-29 Thread younes . a
Quoting Martin Vermeer <[EMAIL PROTECTED]>: > > Yes, if you do it, do it now. I believe drawing can be very efficient if > designed with parsimony from the ground up. Me too obviously. > > > This CRC thing was at the time considered rather a kludge ;-/ > > > > I know a lot more things in the code

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Martin Vermeer
On Wed, 29 Aug 2007 09:42:27 +0200 [EMAIL PROTECTED] wrote: > Quoting Martin Vermeer <[EMAIL PROTECTED]>: > > On Tue, Aug 28, 2007 at 10:53:09PM +0200, Abdelrazak Younes wrote: ... > Sure and I also count on you to remind those ;-) I am sure any drawing problem > will be detected in time and co

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread younes . a
Quoting Martin Vermeer <[EMAIL PROTECTED]>: > On Tue, Aug 28, 2007 at 10:53:09PM +0200, Abdelrazak Younes wrote: > > >If you don't want cursor_on_row back, consider making the row signature > > >sensitive to change tracking. > > > > > Yes, that's the proper solution even though I am not sure I can

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 10:53:09PM +0200, Abdelrazak Younes wrote: > Martin Vermeer wrote: > >On Tue, Aug 28, 2007 at 04:39:47PM +, [EMAIL PROTECTED] wrote: > > > >>Author: younes > >>Date: Tue Aug 28 18:39:46 2007 > >>New Revision: 19859 > >> > >>URL: http://www.lyx.org/trac/changeset/19859

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Abdelrazak Younes
Martin Vermeer wrote: On Tue, Aug 28, 2007 at 04:39:47PM +, [EMAIL PROTECTED] wrote: Author: younes Date: Tue Aug 28 18:39:46 2007 New Revision: 19859 URL: http://www.lyx.org/trac/changeset/19859 Log: We are not forced to redraw the row each time the cursor is moved. * TextMetrics.cpp:

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 04:39:47PM +, [EMAIL PROTECTED] wrote: > Author: younes > Date: Tue Aug 28 18:39:46 2007 > New Revision: 19859 > > URL: http://www.lyx.org/trac/changeset/19859 > Log: > We are not forced to redraw the row each time the cursor is moved. > > * TextMetrics.cpp: CursorOnRo

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 09:02:10PM +0200, [EMAIL PROTECTED] wrote: > Quoting Martin Vermeer <[EMAIL PROTECTED]>: > > > > - bool cursor_on_row = CursorOnRow(pi, pit, rit, *text_); > > > - > > > // If selection is on, the current row signature differs > > > // from cache,

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread younes . a
Quoting Martin Vermeer <[EMAIL PROTECTED]>: > > - bool cursor_on_row = CursorOnRow(pi, pit, rit, *text_); > > - > > // If selection is on, the current row signature differs > > // from cache, or cursor is inside an inset _on this row_, > > Forgot this comment? - M

Re: [Cvslog] r19859 - /lyx-devel/trunk/src/TextMetrics.cpp

2007-08-28 Thread Martin Vermeer
On Tue, Aug 28, 2007 at 04:39:47PM +, [EMAIL PROTECTED] wrote: > Author: younes > Date: Tue Aug 28 18:39:46 2007 > New Revision: 19859 > > URL: http://www.lyx.org/trac/changeset/19859 > Log: > We are not forced to redraw the row each time the cursor is moved. > > * TextMetrics.cpp: CursorOnRo