Re: [LyX/master] Unify graphics-groups inside marked block functionality.

On Wed, May 02, 2018 at 08:40:14PM +, Pavel Sanda wrote: > Pavel Sanda wrote: > > > go ahead and commit your current code and I will make the extension. > > > > Ok, will commit once back home. > > It's in the tree, feel free to modify or kill the routines for what you > need... OK sounds

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

Pavel Sanda wrote: > > go ahead and commit your current code and I will make the extension. > > Ok, will commit once back home. It's in the tree, feel free to modify or kill the routines for what you need... Pavel

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

Scott Kostyshak wrote: > current call faster on large documents. e.g. you could change > > cur.countInsetsInSelection(GRAPHICS_CODE)>1) > > to > > cur.countInsetsInSelection(GRAPHICS_CODE, 2) == 2 > > If you are not having fun, I would be happy to make this change (but That would be nice.

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

On Wed, May 02, 2018 at 01:48:49PM +, Pavel Sanda wrote: > Pavel Sanda wrote: > > Jean-Marc Lasgouttes wrote: > > >> Would this patch make you happy? > > >> The routine itself could be used for different type of insets if you > > >> intend to make a crussade against useless items in context

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

Pavel Sanda wrote: > Jean-Marc Lasgouttes wrote: > >> Would this patch make you happy? > >> The routine itself could be used for different type of insets if you > >> intend to make a crussade against useless items in context menu. > > > > Shouldn't it appear only if there are at least two graphics

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

Jean-Marc Lasgouttes wrote: >> Would this patch make you happy? >> The routine itself could be used for different type of insets if you >> intend to make a crussade against useless items in context menu. > > Shouldn't it appear only if there are at least two graphics insets? Like this. I can keep

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

Le 02/05/2018 à 15:19, Pavel Sanda a écrit : Pavel Sanda wrote: Scott Kostyshak wrote: + OptItem "Unify Graphics Groups|U" "graphics-unify" Do we want to add this unconditionally to the context menu? For example, start a new document, type "hello", select it, right-click, and

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

Pavel Sanda wrote: > Scott Kostyshak wrote: > > > + OptItem "Unify Graphics Groups|U" "graphics-unify" > > > > Do we want to add this unconditionally to the context menu? For example, > > start a new document, type "hello", select it, right-click, and you will > > see that "Unify Graphics

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

Jean-Marc Lasgouttes wrote: > Le 29/04/2018 ? 22:46, Scott Kostyshak a écrit : >> There are other irrelevant options (e.g. >> "Accept Change"), but Vincent (7108b8e4) is not around for me to complain >> to >> about it :). > > Could you elaborate? I do not see it after typing hello in an empty >

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

Le 29/04/2018 à 22:46, Scott Kostyshak a écrit : There are other irrelevant options (e.g. "Accept Change"), but Vincent (7108b8e4) is not around for me to complain to about it :). Could you elaborate? I do not see it after typing hello in an empty document. JMarc

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

Scott Kostyshak wrote: > > + OptItem "Unify Graphics Groups|U" "graphics-unify" > > Do we want to add this unconditionally to the context menu? For example, > start a new document, type "hello", select it, right-click, and you will > see that "Unify Graphics Groups" is an option even

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

On Thu, Feb 08, 2018 at 09:00:23PM +, Pavel Sanda wrote: > commit b88ed81e7f1d2f59bb606351d95e093380b4eead > Author: Pavel Sanda > Date: Thu Feb 8 21:33:37 2018 +0100 > > Unify graphics-groups inside marked block functionality. > > Fixes #11026. > >

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

On 02/15/2018 05:52 AM, Pavel Sanda wrote: > Pavel Sanda wrote: >> commit b88ed81e7f1d2f59bb606351d95e093380b4eead >> Author: Pavel Sanda >> Date: Thu Feb 8 21:33:37 2018 +0100 >> >> Unify graphics-groups inside marked block functionality. >> >> Fixes #11026. >

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

Pavel Sanda wrote: > commit b88ed81e7f1d2f59bb606351d95e093380b4eead > Author: Pavel Sanda > Date: Thu Feb 8 21:33:37 2018 +0100 > > Unify graphics-groups inside marked block functionality. > > Fixes #11026. Richard, can this go to 2.3.2? P > >

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

Pavel Sanda wrote: > >> + while (!from.empty() && from < to) { > >> + Inset * inset = from.nextInset(); > >> + if (!inset) > >> + break; > >> + if (inset->lyxCode() == GRAPHICS_CODE) { > >> +

Re: [LyX/master] Unify graphics-groups inside marked block functionality.

Jean-Marc Lasgouttes wrote: > Le 08/02/2018 ?? 22:00, Pavel Sanda a écrit : >> commit b88ed81e7f1d2f59bb606351d95e093380b4eead >> Author: Pavel Sanda >> Date: Thu Feb 8 21:33:37 2018 +0100 >> Unify graphics-groups inside marked block functionality. > > Is there a reason why