Re: [PATCH] Branch/Note "final"

2003-07-15 Thread Andre Poenitz
On Mon, Jul 14, 2003 at 09:52:12PM +0300, Martin Vermeer wrote: > int i = 0; > if (pt == "Comment") os << "%\n\\begin{comment}\n"; // remember to validate > - if (pt == "Greyedout") os << "%\n\\textcolor[gray]{0.8}{"; > + if (pt == "Greyedout") os << "%\n\\color[gray]{0.8}"; Be

Re: [PATCH] Branch/Note "final"

2003-07-14 Thread Juergen Spitzmueller
Martin Vermeer wrote: > Yellow on grey is *awful*. The yellow is surely from the association with > MMM Post-It (TM). It'd be nice if we could have a custom background color for inset buttons. > Actually why a distinction? They are a lot more similar > than different. Compared to footnote, branc

Re: [PATCH] Branch/Note "final"

2003-07-14 Thread Martin Vermeer
On Wed, Jul 09, 2003 at 09:34:45AM +0200, Juergen Spitzmueller spake thusly: > Martin Vermeer wrote: > > Note patch committed! (and I didn't forget the changelog :) > > Some comments: > > 1. greyedout code is still wrong. > You are using > \textcolor[gray]{0.8}{ > } > which breaks l

Re: [PATCH] Branch/Note "final"

2003-07-09 Thread Juergen Spitzmueller
Martin Vermeer wrote: > Note patch committed! (and I didn't forget the changelog :) Some comments: 1. greyedout code is still wrong. You are using \textcolor[gray]{0.8}{ } which breaks latex as soon as you have more than one paragraph (or a non-standard paragraph). Use \c

Re: [PATCH] Branch/Note "final"

2003-07-08 Thread Andre Poenitz
On Tue, Jul 08, 2003 at 05:54:51PM +0300, Martin Vermeer wrote: > I tried this and it works fine. Used in insetnote and insetbranch, at > least. > > Good idea or not? Not bad at least. Maybe even good ;-) Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, n

Re: [PATCH] Branch/Note "final"

2003-07-08 Thread Martin Vermeer
On Mon, Jul 07, 2003 at 11:50:25PM +0300, Martin Vermeer spake thusly: > > First bug: nested Note/Branch insets don't work properly, the right > mouse click always goes to the outermost one. > > Fix: limit the effect of button 3 to the inset's button area. This begs the question: the phrase

Re: [PATCH] Branch/Note "final"

2003-07-08 Thread Martin Vermeer
On Tue, Jul 08, 2003 at 01:15:58PM +0200, Lars Gullik Bjønnes spake thusly: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Tue, Jul 08, 2003 at 02:29:07PM +0300, Martin Vermeer wrote: > | > Ok, here an improved Note patch. Includes André's corrections and a > | > few of my own. > | > > |

Re: [PATCH] Branch/Note "final"

2003-07-08 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Jul 08, 2003 at 02:29:07PM +0300, Martin Vermeer wrote: | > Ok, here an improved Note patch. Includes André's corrections and a | > few of my own. | > | > (Is there any way to get new files included in a cvs diff file?)) | | I guess only after

Re: [PATCH] Branch/Note "final"

2003-07-08 Thread Andre Poenitz
On Tue, Jul 08, 2003 at 02:29:07PM +0300, Martin Vermeer wrote: > Ok, here an improved Note patch. Includes André's corrections and a > few of my own. > > (Is there any way to get new files included in a cvs diff file?)) I guess only after a cvs add. Not sure though. Are you comfortable with th

Re: [PATCH] Branch/Note "final"

2003-07-08 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | Ok, here an improved Note patch. Includes André's corrections and a | few of my own. | | (Is there any way to get new files included in a cvs diff file?)) yes, if you have an CVS account. (then you can "cvs add" the new files.) I'll set one up for y

Re: [PATCH] Branch/Note "final"

2003-07-08 Thread Martin Vermeer
Ok, here an improved Note patch. Includes André's corrections and a few of my own. (Is there any way to get new files included in a cvs diff file?)) Martin -- Martin Vermeer [EMAIL PROTECTED] Helsinki University of Technology Dept. of Surveying, Inst. of Geodesy P.O. Box 1200, FIN-02015 HUT,

Re: [PATCH] Branch/Note "final"

2003-07-08 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Tue, Jul 08, 2003 at 11:18:04AM +0200, Andre Poenitz spake thusly: | > > | > > You're too gracious. Cut'n paste with middle mouse button? | > | > Me? Certainly not. | > | > I don't think I've touched my mouse during the last four hours. | | What

Re: [PATCH] Branch/Note "final"

2003-07-08 Thread Martin Vermeer
On Tue, Jul 08, 2003 at 11:18:04AM +0200, Andre Poenitz spake thusly: > > > > You're too gracious. Cut'n paste with middle mouse button? > > Me? Certainly not. > > I don't think I've touched my mouse during the last four hours. What I mean is that *I* have been seen doing that at times (blush,

Re: [PATCH] Branch/Note "final"

2003-07-08 Thread Andre Poenitz
On Tue, Jul 08, 2003 at 12:35:24PM +0300, Martin Vermeer wrote: > > Indentation, but seemingly not your doing. > > You're too gracious. Cut'n paste with middle mouse button? Me? Certainly not. I don't think I've touched my mouse during the last four hours. Andre' -- Those who desire to give u

Re: [PATCH] Branch/Note "final"

2003-07-08 Thread Martin Vermeer
On Tue, Jul 08, 2003 at 10:44:08AM +0200, Andre Poenitz spake thusly: > > On Tue, Jul 08, 2003 at 11:55:04AM +0300, Martin Vermeer wrote: > > if (it->inset) { > > if (static_cast > > (it->inset)->lyxCode() == > > Inset::B

Re: [PATCH] Branch/Note "final"

2003-07-08 Thread Andre Poenitz
On Tue, Jul 08, 2003 at 11:55:04AM +0300, Martin Vermeer wrote: > if (it->inset) { > if (static_cast > (it->inset)->lyxCode() == > Inset::BRANCH_CODE) { This first static_cast is somewhere between superflous and wro

Re: [PATCH] Branch/Note "final"

2003-07-08 Thread Martin Vermeer
On Tue, Jul 08, 2003 at 12:42:22AM +0200, Lars Gullik Bjønnes spake thusly: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | Attached is the "final" version of my Note/Branch inset work. It > | works, has a decent UI and is I think cleanly coded (in Pascal-style > | C++ :-). > | > | Of course

Re: [PATCH] Branch/Note "final"

2003-07-07 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | Attached is the "final" version of my Note/Branch inset work. It | works, has a decent UI and is I think cleanly coded (in Pascal-style | C++ :-). | | Of course there are always things to improve; opening/closing all | insets of a given branch is still

Re: [PATCH] Branch/Note "final"

2003-07-07 Thread Martin Vermeer
First bug: nested Note/Branch insets don't work properly, the right mouse click always goes to the outermost one. Fix: limit the effect of button 3 to the inset's button area. Patch replacement file attached. - Martin -- Martin Vermeer [EMAIL PROTECTED] Helsinki University of Technology Dept

[PATCH] Branch/Note "final"

2003-07-07 Thread Martin Vermeer
Attached is the "final" version of my Note/Branch inset work. It works, has a decent UI and is I think cleanly coded (in Pascal-style C++ :-). Of course there are always things to improve; opening/closing all insets of a given branch is still lacking, and the UI for the set of all branches is a co