Re: [PATCH] Document->compressed menu item

2006-04-28 Thread Jean-Marc Lasgouttes
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes: >> With all these changes, I would accept this in 1.4 too (because the >> fact it cannot be changed is a bug). >> >> I would like also to have an adaptation of your patch to remove >> USE_COMPRESSION, if you can do that for me. Bo> I would assume

Re: [PATCH] Document->compressed menu item

2006-04-28 Thread Bo Peng
With all these changes, I would accept this in 1.4 too (because the fact it cannot be changed is a bug). I would like also to have an adaptation of your patch to remove USE_COMPRESSION, if you can do that for me. I would assume that you want to keep gzstream in 1.4.x, right? Bo

Re: [PATCH] Document->compressed menu item

2006-04-28 Thread Jean-Marc Lasgouttes
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes: Bo> When the menu item is selected, the status *is* changed and Bo> File->Save should be enabled. Bo> You just remind me that this menu item should be disabled for Bo> readonly file. New patch is attached. Remarks: 1/ You would have that for fre

Re: [PATCH] Document->compressed menu item

2006-04-27 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | > I do not like where it is placed, but I have no better alternatives. | | ?? | | > | + case LFUN_COMPRESSION_STATUS: | > | + // turn compression on/off | > | + BOOST_ASSERT(owner->buffer()->params().comp

Re: [PATCH] Document->compressed menu item

2006-04-27 Thread Bo Peng
> I do not like where it is placed, but I have no better alternatives. ?? > | + case LFUN_COMPRESSION_STATUS: > | + // turn compression on/off > | + BOOST_ASSERT(owner->buffer()->params().compressed == > flag.onoff(true)); > | +

Re: [PATCH] Document->compressed menu item

2006-04-27 Thread Lars Gullik Bjønnes
"Bo Peng" <[EMAIL PROTECTED]> writes: | Dear all, | | Attached patch adds Document->compressed menu item that can | 1. reflect the compression status of the current document | 2. when turned on/off, the document will be saved compressed/decompressed. | | Please comment. We can apply, until we fi

[PATCH] Document->compressed menu item

2006-04-27 Thread Bo Peng
Dear all, Attached patch adds Document->compressed menu item that can 1. reflect the compression status of the current document 2. when turned on/off, the document will be saved compressed/decompressed. Please comment. We can apply, until we find a better place for this option. Cheers, Bo Index: