Re: [PATCH] Fix crash when closing a child document when outline and Pref dialogs are opened

2007-07-09 Thread Abdelrazak Younes
José Matos wrote: On Monday 09 July 2007 14:21:58 Abdelrazak Younes wrote: Which one? The one that add a redundant updateToc() in LyXView or the one that updates the dialogs only if this is not LFUN_UPDATE_DIALOG in LyXFunc? Conceptually speaking, the later is more correct, even if this means a

Re: [PATCH] Fix crash when closing a child document when outline and Pref dialogs are opened

2007-07-09 Thread José Matos
On Monday 09 July 2007 14:21:58 Abdelrazak Younes wrote: > Which one? The one that add a redundant updateToc() in LyXView or the > one that updates the dialogs only if this is not LFUN_UPDATE_DIALOG in > LyXFunc? > > Conceptually speaking, the later is more correct, even if this means a > special c

Re: [PATCH] Fix crash when closing a child document when outline and Pref dialogs are opened

2007-07-09 Thread Abdelrazak Younes
José Matos wrote: On Monday 09 July 2007 13:55:01 Abdelrazak Younes wrote: The part below was not meant to be in the patch, please ignore: If that fixes the bug then OK. Which one? The one that add a redundant updateToc() in LyXView or the one that updates the dialogs only if this is not LF

Re: [PATCH] Fix crash when closing a child document when outline and Pref dialogs are opened

2007-07-09 Thread José Matos
On Monday 09 July 2007 13:55:01 Abdelrazak Younes wrote: > The part below was not meant to be in the patch, please ignore: If that fixes the bug then OK. -- José Abílio

Re: [PATCH] Fix crash when closing a child document when outline and Pref dialogs are opened

2007-07-09 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> The problem here is that the Toc dialog has not been Abdelrazak> reconstructed (because it comes after in the list of Abdelrazak> dialogs). Abdelrazak> This patch sho

Re: [PATCH] Fix crash when closing a child document when outline and Pref dialogs are opened

2007-07-09 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> The problem here is that the Toc dialog has not been Abdelrazak> reconstructed (because it comes after in the list of Abdelrazak> dialogs). Abdelrazak> This patch should definitely go _before_

Re: [PATCH] Fix crash when closing a child document when outline and Pref dialogs are opened

2007-07-09 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> The problem here is that the Toc dialog has not been Abdelrazak> reconstructed (because it comes after in the list of Abdelrazak> dialogs). Abdelrazak> This patch should definitely go _before_

Re: [PATCH] Fix crash when closing a child document when outline and Pref dialogs are opened

2007-07-09 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> The problem here is that the Toc dialog has not been Abdelrazak> reconstructed (because it comes after in the list of Abdelrazak> dialogs). Abdelrazak> This patch should definitely go _before_ 1.5.0; OK? I understand

[PATCH] Fix crash when closing a child document when outline and Pref dialogs are opened

2007-07-09 Thread Abdelrazak Younes
The reason is that closing a Buffer triggers an update of all opened dialogs when dispatching LFUN_DIALOG_UPDATE (hence the patch). The path is as following: setBuffer() -> updateBufferDependent() -> RestoreButton() -> LFUN The problem here is that the Toc dialog has not been reconstructed (b