[Qt patch]: label dialog

2003-03-04 Thread Angus Leeming
Attached is the minimal diff needed for Qt to have a label dialog once more. Note, however, that personally I would rename QIndex et al. as something less specific. Perhaps QText? I'll let the Qt-knowledgable apply this/redo it from scratch ;-) -- AngusIndex: src/frontends/qt2/Dialogs3.C

[Qt patch]: label dialog

2003-03-04 Thread Angus Leeming
Attached is the minimal diff needed for Qt to have a label dialog once more. Note, however, that personally I would rename QIndex et al. as something less specific. Perhaps QText? I'll let the Qt-knowledgable apply this/redo it from scratch ;-) -- AngusIndex: src/frontends/qt2/Dialogs3.C

Re: [PATCH] Label dialog

2001-08-01 Thread Dekel Tsur
On Wed, Aug 01, 2001 at 01:18:25AM +0100, John Levon wrote: ok, this one should be ok other than mathed. I've found a bug: changing the label doesn't change the references. I think the mathed thing is a missing feature, i.e. this can be applied as self-contained. Is it really necessary to

Re: [PATCH] Label dialog

2001-08-01 Thread Dekel Tsur
On Wed, Aug 01, 2001 at 10:40:31AM +0200, Jean-Marc Lasgouttes wrote: 3/ is it really necessary to replace spaces with something else? Please check this with latex. And if you need the code, a replace method can probably do the same as the awful loop wheich is there. The purpose of the loop

Re: [PATCH] Label dialog

2001-08-01 Thread John Levon
On Wed, Aug 01, 2001 at 10:40:31AM +0200, Jean-Marc Lasgouttes wrote: Could you rework it a bit? 1/ the code to create the default label should go somewhere else (in InsetLabel? or a getLabelString in lyxtext.h like what I did for index) ok 2/ the code uses bv_-text and I believe that

Re: [PATCH] Label dialog

2001-08-01 Thread John Levon
On Wed, Aug 01, 2001 at 01:21:21PM +0300, Dekel Tsur wrote: On Wed, Aug 01, 2001 at 01:18:25AM +0100, John Levon wrote: ok, this one should be ok other than mathed. I've found a bug: changing the label doesn't change the references. oh crap. let me go back over it ... the

Re: [PATCH] Label dialog

2001-08-01 Thread Juergen Vigna
I've found a bug: changing the label doesn't change the references. oh crap. let me go back over it ... the applyParamsToInset should have done that :/ While you're at it could you also have a look at: - When if you have a reference to a label inside an text inset, and the label is

Re: [PATCH] Label dialog

2001-08-01 Thread Dekel Tsur
On Wed, Aug 01, 2001 at 04:21:22PM +0200, Juergen Vigna wrote: I've found a bug: changing the label doesn't change the references. oh crap. let me go back over it ... the applyParamsToInset should have done that :/ While you're at it could you also have a look at: - When you have a

Re: [PATCH] Label dialog

2001-08-01 Thread Dekel Tsur
On Wed, Aug 01, 2001 at 01:18:25AM +0100, John Levon wrote: > > ok, this one should be ok other than mathed. I've found a bug: changing the label doesn't change the references. > I think the mathed thing is a missing feature, i.e. this can be applied > as self-contained. Is it really

Re: [PATCH] Label dialog

2001-08-01 Thread Dekel Tsur
On Wed, Aug 01, 2001 at 10:40:31AM +0200, Jean-Marc Lasgouttes wrote: > 3/ is it really necessary to replace spaces with something else? > Please check this with latex. And if you need the code, a replace > method can probably do the same as the awful loop wheich is there. The purpose of the

Re: [PATCH] Label dialog

2001-08-01 Thread John Levon
On Wed, Aug 01, 2001 at 10:40:31AM +0200, Jean-Marc Lasgouttes wrote: > Could you rework it a bit? > > 1/ the code to create the default label should go somewhere else (in > InsetLabel? or a getLabelString in lyxtext.h like what I did for index) ok > 2/ the code uses bv_->text and I believe

Re: [PATCH] Label dialog

2001-08-01 Thread John Levon
On Wed, Aug 01, 2001 at 01:21:21PM +0300, Dekel Tsur wrote: > On Wed, Aug 01, 2001 at 01:18:25AM +0100, John Levon wrote: > > > > ok, this one should be ok other than mathed. > > I've found a bug: changing the label doesn't change the references. oh crap. let me go back over it ... the

Re: [PATCH] Label dialog

2001-08-01 Thread Juergen Vigna
>> I've found a bug: changing the label doesn't change the references. > > oh crap. let me go back over it ... the applyParamsToInset should have > done that :/ While you're at it could you also have a look at: - When if you have a reference to a label inside an text inset, and the label is

Re: [PATCH] Label dialog

2001-08-01 Thread Dekel Tsur
On Wed, Aug 01, 2001 at 04:21:22PM +0200, Juergen Vigna wrote: > >> I've found a bug: changing the label doesn't change the references. > > > > oh crap. let me go back over it ... the applyParamsToInset should have > > done that :/ > > While you're at it could you also have a look at: > > -

[PATCH] Label dialog

2001-07-31 Thread John Levon
ok, this one should be ok other than mathed. I think the mathed thing is a missing feature, i.e. this can be applied as self-contained. thanks john -- I'd rather be rudely informed than politely left in the dark. labeld.diff.gz

[PATCH] Label dialog

2001-07-31 Thread John Levon
ok, this one should be ok other than mathed. I think the mathed thing is a missing feature, i.e. this can be applied as self-contained. thanks john -- "I'd rather be rudely informed than politely left in the dark." labeld.diff.gz