Re: [PATCH] Polished "missing TeX class" patch

2003-01-20 Thread Michael Schmitt
Jean-Marc Lasgouttes wrote: OK, forget about it. You are of course right (I tended to mixup the use of Update and Export). Michael> Hmmm, while thinking about it: This patch could be committed Michael> right now independently from the rest (just like the Michael> misleading alert in buffer.C)...

Re: [PATCH] Polished "missing TeX class" patch

2003-01-20 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Schmitt <[EMAIL PROTECTED]> writes: Michael> First, the top menu is called "View". Second, within menu Michael> "View" only viewable formats are listed. So I don't Michael> understand why "ASCII" should be listed in submenu Michael> "View>Update". Makes no sense to me. I

Re: [PATCH] Polished "missing TeX class" patch

2003-01-17 Thread Michael Schmitt
Andre Poenitz wrote: On Fri, Jan 17, 2003 at 04:20:51PM +0100, Michael Schmitt wrote: case LFUN_EXPORT: - disable = ev.argument == "fax" && - !Exporter::IsExportable(buf, ev.argument); + disable = !Exporter::IsExportable(buf, ev.argument); break; Why is this necessary? I want t

Re: [PATCH] Polished "missing TeX class" patch

2003-01-17 Thread Andre Poenitz
On Fri, Jan 17, 2003 at 04:20:51PM +0100, Michael Schmitt wrote: > > case LFUN_EXPORT: > >-disable = ev.argument == "fax" && > >-!Exporter::IsExportable(buf, ev.argument); > >+disable = !Exporter::IsExportable(buf, ev.argument); > > break;

Re: [PATCH] Polished "missing TeX class" patch

2003-01-17 Thread Michael Schmitt
Jean-Marc Lasgouttes wrote: IU did not test it, but here are some comments. case MenuItem::UpdateFormats: - formats = Exporter::GetExportableFormats(buf, false); + formats = Exporter::GetExportableFormats(buf, true); action = LFUN_UPDATE; break; Why is this useful? We do not want to rest

Re: [PATCH] Polished "missing TeX class" patch

2003-01-17 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Schmitt <[EMAIL PROTECTED]> writes: Michael> Hi, I have fixed a small bug in my "missing TeX class" patch, Michael> simplified the code, and changed "N/A:" to "No TeX:" (In the Michael> dialog, it looks better if we use a _short_ prefix instead of Michael> a postfix). M

[PATCH] Polished "missing TeX class" patch

2003-01-16 Thread Michael Schmitt
Hi, I have fixed a small bug in my "missing TeX class" patch, simplified the code, and changed "N/A:" to "No TeX:" (In the dialog, it looks better if we use a _short_ prefix instead of a postfix). If you like to, you can test the patch. Eagerly awaiting 1.3.1, Michael Index: lyx-devel-1.3.Xcvs