Re: [PATCH] Re: Mathinset behavior (André? )

2006-01-14 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: >> OK, here is my next try. I kind of like the code now, so I'd >> really want to commit it and be done with this bug? Andre> It looks ok. No more objections from my side. It seems you were right to complain about the code and make thin

Re: [PATCH] Re: Mathinset behavior (André?)

2006-01-11 Thread Georg Baum
Am Mittwoch, 11. Januar 2006 17:45 schrieb Jean-Marc Lasgouttes: > > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > > Georg> I could not get it to crash, but I found another related > Georg> problem (which does also occur without the patch): > > Georg> \frac > > Georg> results in the te

Re: [PATCH] Re: Mathinset behavior (André? )

2006-01-11 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> I could not get it to crash, but I found another related Georg> problem (which does also occur without the patch): Georg> \frac Georg> results in the text \frac in red, it is not recognized as a Georg> fraction as it is in 1.3.x Thi

Re: [PATCH] Re: Mathinset behavior (André? )

2006-01-11 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Tue, 2006-01-10 at 12:53 +0100, Jean-Marc Lasgouttes wrote: >> > "Andre" == Andre Poenitz >> <[EMAIL PROTECTED]> writes: >> Andre> prevAtom(). Or maybe nextAtom(). Should be near the cursor, Andre> shouldn't it? >> OK, h

Re: [PATCH] Re: Mathinset behavior (André?)

2006-01-11 Thread Martin Vermeer
On Tue, 2006-01-10 at 12:53 +0100, Jean-Marc Lasgouttes wrote: > > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: > > Andre> prevAtom(). Or maybe nextAtom(). Should be near the cursor, > Andre> shouldn't it? > > OK, here is my next try. I kind of like the code now, so I'd really > want

Re: [PATCH] Re: Mathinset behavior (André?)

2006-01-10 Thread Georg Baum
Am Dienstag, 10. Januar 2006 12:53 schrieb Jean-Marc Lasgouttes: > > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: > > Andre> prevAtom(). Or maybe nextAtom(). Should be near the cursor, > Andre> shouldn't it? > > OK, here is my next try. I kind of like the code now, so I'd really > wa

[PATCH] Re: Mathinset behavior (André?)

2006-01-10 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> prevAtom(). Or maybe nextAtom(). Should be near the cursor, Andre> shouldn't it? OK, here is my next try. I kind of like the code now, so I'd really want to commit it and be done with this bug? Can somebody test? It fixes a crash

Re: [PATCH] Re: Mathinset behavior (André? )

2006-01-09 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: >> Not really, because it is only in macroMathClose that I have >> access to the object that has been created there. How would I >> access the newly built \frac{}{} object otherwise? Andre> prevAtom(). Or maybe nextAtom(). Should be near

Re: [PATCH] Re: Mathinset behavior (André? )

2006-01-09 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> Can't you simply put the new stuff in a separate function? I Andre> always have a feeling that additional bool parameters do not Andre> improve readability, especially when the function in question Andre> basically looks like Andre

Re: [PATCH] Re: Mathinset behavior (André? )

2005-12-28 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: >> So, what do you propose? I guess I could keep mathMacroClose as it >> was, Andre> Yes. >> and put the cursor inside the new inset only when space was >> pressed? What about that one? JMarc Index: src/ChangeLog =

Re: [PATCH] Re: Mathinset behavior (André? )

2005-12-23 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> What's the actual cursor positioning problem? Andre> I'd really like to get that fixed by direct calls. The problem is that, when one types "\frac", the fraction is inserted, but the cursor is not in the first cell. So I looked at

Re: [PATCH] Re: Mathinset behavior (André? )

2005-12-20 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> I have no time to try it now, but I like this solution. OK, I applied it. JMarc

Re: [PATCH] Re: Mathinset behavior (André?)

2005-12-20 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Martin> Alternatively, put this in a method and call that from both > Martin> places. > > Yes, but insert, plainInsert and niceInsert are already taken, I do > not have any new idea for a confusing name :) What about JMInsert ;-) > I propose keep the dispatch and a

Re: [PATCH] Re: Mathinset behavior (André? )

2005-12-20 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Alternatively, put this in a method and call that from both Martin> places. Yes, but insert, plainInsert and niceInsert are already taken, I do not have any new idea for a confusing name :) I propose keep the dispatch and add a

Re: [PATCH] Re: Mathinset behavior (André? )

2005-12-20 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Yes, I see. I think your patch is precisely the right one as Martin> this method is called whenever a macro has been typed in. And Martin> it is minimal. Here is the alternative that does not use dispatch (I copied blindly the c

Re: [PATCH] Re: Mathinset behavior (André?)

2005-12-20 Thread Martin Vermeer
On Tue, 2005-12-20 at 12:44 +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> On Mon, Dec 19, 2005 at 05:39:42PM +0100, Jean-Marc Lasgouttes > Martin> wrote: > >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> .

Re: [PATCH] Re: Mathinset behavior (André? )

2005-12-20 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Martin Vermeer wrote: >> The following is perhaps lighter, and could be considered an >> alternative if there are side effects. (But this may have such as >> well.) Georg> BTW this is bug 2034: Georg> http://bugzilla.lyx.org/show_bug.

Re: [PATCH] Re: Mathinset behavior (André? )

2005-12-20 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Mon, Dec 19, 2005 at 05:39:42PM +0100, Jean-Marc Lasgouttes Martin> wrote: >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> ... Martin> Confirmed. This problem happens if you try to to type LaTeX Mart

Re: [PATCH] Re: Mathinset behavior (André?)

2005-12-20 Thread Georg Baum
Martin Vermeer wrote: > The following is perhaps lighter, and could be considered an alternative > if there are side effects. (But this may have such as well.) BTW this is bug 2034: http://bugzilla.lyx.org/show_bug.cgi?id=2034 Georg

[PATCH] Re: Mathinset behavior (André?)

2005-12-19 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Mon, 2005-12-19 at 00:42 -0500, Grag wrote: >> I noticed some difference between the behavior of the mathinset >> that is inconsistent with lyx 1.3.x >> >> For instance 1) enter math inset 2) \hat 3) \beta In lyx 1.3.x the >>