Re: [PATCH] Slow input with cross-reference window open

2007-12-31 Thread rgheck
Attached is my latest attempt at this patch. It still proceeds along the original lines. It may be that the time is being spent creating the strings, but this still seems to me like the correct approach, in general. Why update the list of labels if we don't have to do so? Anyway, it still wo

Re: [PATCH] Slow input with cross-reference window open

2007-12-30 Thread rgheck
Andre Poenitz wrote: In any event, the SignalSlot machinery seems to be unused at present, so I can't find an example of its use. Right, I got distracted. I'll have a look, but probably not before the end of next week. Not a problem. I think I got it figured out. rh

Re: [PATCH] Slow input with cross-reference window open

2007-12-30 Thread Abdelrazak Younes
Andre Poenitz wrote: On Sun, Dec 30, 2007 at 10:35:59AM +0100, Abdelrazak Younes wrote: Hum, after reading the code, I think we are on the wrong track. The reason why this is so slow is that we reconstruct a vector of full strings each time we call 'getLabelList()'. If we just reconstruct a ve

Re: [PATCH] Slow input with cross-reference window open

2007-12-30 Thread Andre Poenitz
On Sun, Dec 30, 2007 at 10:35:59AM +0100, Abdelrazak Younes wrote: > Hum, after reading the code, I think we are on the wrong track. The reason > why this is so slow is that we reconstruct a vector of full strings each > time we call 'getLabelList()'. If we just reconstruct a vector of pointer I

Re: [PATCH] Slow input with cross-reference window open

2007-12-30 Thread Andre Poenitz
On Sat, Dec 29, 2007 at 05:07:47PM -0500, rgheck wrote: > >> >> Considering multiview, I'd prefer a solution based on signal/slot. Maybe >> static signal member in InsetLabel? See attached, untested. >> > OK. I wasn't thinking that the different views had different BufferList's. > > In any event,

Re: [PATCH] Slow input with cross-reference window open

2007-12-30 Thread Abdelrazak Younes
rgheck wrote: Abdelrazak Younes wrote: In any event, the SignalSlot machinery seems to be unused at present, so I can't find an example of its use. But the moment I try to use it, I get linking errors. It's enough to add this: static Signal modified; ~InsetLabel() { modified.fire() to In

Re: [PATCH] Slow input with cross-reference window open

2007-12-29 Thread rgheck
Abdelrazak Younes wrote: In any event, the SignalSlot machinery seems to be unused at present, so I can't find an example of its use. But the moment I try to use it, I get linking errors. It's enough to add this: static Signal modified; ~InsetLabel() { modified.fire() to InsetLabel.h (wit

Re: [PATCH] Slow input with cross-reference window open

2007-12-29 Thread Abdelrazak Younes
rgheck wrote: Considering multiview, I'd prefer a solution based on signal/slot. Maybe static signal member in InsetLabel? See attached, untested. OK. I wasn't thinking that the different views had different BufferList's. No, the BufferList is common, it's just that mutiple views might h

Re: [PATCH] Slow input with cross-reference window open

2007-12-29 Thread rgheck
Considering multiview, I'd prefer a solution based on signal/slot. Maybe static signal member in InsetLabel? See attached, untested. OK. I wasn't thinking that the different views had different BufferList's. In any event, the SignalSlot machinery seems to be unused at present, so I can't

Re: [PATCH] Slow input with cross-reference window open

2007-12-29 Thread Abdelrazak Younes
rgheck wrote: Abdelrazak Younes wrote: Probably something like the bibfiles cache? Probably a good idea. All right, I had a quick look at this. The analogy is reasonable enough, but it's not quite right. In that case, we basically keep a list of timestamps and check whether the files have be

[PATCH] Slow input with cross-reference window open

2007-12-28 Thread rgheck
Abdelrazak Younes wrote: Probably something like the bibfiles cache? Probably a good idea. All right, I had a quick look at this. The analogy is reasonable enough, but it's not quite right. In that case, we basically keep a list of timestamps and check whether the files have been modified. In

[PATCH] Slow input with cross-reference window open

2007-12-28 Thread rgheck
Abdelrazak Younes wrote: Probably something like the bibfiles cache? Probably a good idea. All right, I had a quick look at this. The analogy is reasonable enough, but it's not quite right. In that case, we basically keep a list of timestamps and check whether the files have been modified. I