Re: [PATCH] Toolbars

2007-07-09 Thread Michael Gerz
Jean-Marc Lasgouttes schrieb: "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes: Michael> See it that way: I removed an obsolete non-const method for Michael> "defined" and added a _different_ non-const method for Michael> "used". There is no case in which we want to change a Mi

Re: [PATCH] Toolbars

2007-07-09 Thread José Matos
On Monday 09 July 2007 11:07:28 Jean-Marc Lasgouttes wrote: > OK, go ahead. +1 > JMarc -- José Abílio

Re: [PATCH] Toolbars

2007-07-09 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes: Michael> See it that way: I removed an obsolete non-const method for Michael> "defined" and added a _different_ non-const method for Michael> "used". There is no case in which we want to change a Michael> "defined" toolbar whereas we have

Re: [PATCH] Toolbars

2007-07-07 Thread Michael Gerz
Jean-Marc Lasgouttes schrieb: At least, I would prefer if (!tbi) to if (tbi == 0) Done. Now that I look at it (even) more closely, I have a question: we used to have two version of getToolbars, which only differred by the fact that one is const. With your patch we know ki

Re: [PATCH] Toolbars

2007-07-04 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes: Michael> In contrary, I am not responsible for "usedtoolbars" and it Michael> wasn´t my intention to clean up or refactor this area of the Michael> code. Michael> Moreover, IMHO it does not make sense to call "hasToolbar" Michael> bef

Re: [PATCH] Toolbars

2007-07-04 Thread Michael Gerz
Jean-Marc Lasgouttes schrieb: José> I was expecting Jean-Marc opinion on this. My opinion: - I do not know what this 'usedtoolbars' thing is. And the comments in ToolbarBackend.h do not help much. Edwin, is it your doing? - it seems that the problem was that we need to check whether a given

Re: [PATCH] Toolbars

2007-07-04 Thread Jean-Marc Lasgouttes
> "José" == José Matos <[EMAIL PROTECTED]> writes: José> I was expecting Jean-Marc opinion on this. My opinion: - I do not know what this 'usedtoolbars' thing is. And the comments in ToolbarBackend.h do not help much. Edwin, is it your doing? - it seems that the problem was that we need t

Re: [PATCH] Toolbars

2007-07-03 Thread José Matos
On Monday 02 July 2007 20:36:02 Michael Gerz wrote: > José? > > Michael I was expecting Jean-Marc opinion on this. -- José Abílio

Re: [PATCH] Toolbars

2007-07-02 Thread Michael Gerz
Michael Gerz schrieb: New (tested) patch attached. Any other comments and/or OKs? José? Michael

Re: [PATCH] Toolbars

2007-07-01 Thread Michael Gerz
Edwin Leuven schrieb: Michael Gerz wrote: ok by me. i don't really like all these checks: if (tbi != 0), but don't know what a nice solution would be. instead of indenting i would always try to return or break early though (see below) Ok, I changed the patch accordingly. One thing that confu

Re: [PATCH] Toolbars

2007-07-01 Thread Edwin Leuven
Michael Gerz wrote: Hi, the attached patch fixes three toolbar problems: - The toolbar name couldn't be translated in a user message - A faulty stdtoolbars.ui resulted in a failed assertion - "toolbar-toggle foobla" resulted in a state change for some dummy toolbar rather than a reasonable er

[PATCH] Toolbars

2007-06-30 Thread Michael Gerz
Hi, the attached patch fixes three toolbar problems: - The toolbar name couldn't be translated in a user message - A faulty stdtoolbars.ui resulted in a failed assertion - "toolbar-toggle foobla" resulted in a state change for some dummy toolbar rather than a reasonable error message Unfortun