Re: [PATCH-updated] Bug 3676--Citation Bug

2007-08-01 Thread Andre Poenitz
On Wed, Aug 01, 2007 at 03:12:20PM -0400, Richard Heck wrote: > > >>>Passing a std::map by value seems wrong. > >>> > >>Yes. Made it const &. This required a const_cast, but that seems ok. > >> > >Not really. > > > It's necessary because I want to use operator[] on the ma

Re: [PATCH-updated] Bug 3676--Citation Bug

2007-08-01 Thread Richard Heck
Andre Poenitz wrote: On Wed, Aug 01, 2007 at 12:19:33AM -0400, Richard Heck wrote: Yes, I agree. This is needed, IIRC (I did this a while ago), for certain constants, e.g.: static const docstring TheBibliographyRef(from_ascii("TheBibliographyRef")); which was in frontends/controllers/fron

Re: [PATCH-updated] Bug 3676--Citation Bug

2007-07-31 Thread Andre Poenitz
On Wed, Aug 01, 2007 at 12:19:33AM -0400, Richard Heck wrote: > Andre Poenitz wrote: > >On Tue, Jul 31, 2007 at 03:00:34PM -0400, Richard Heck wrote: > > > >>Index: src/Buffer.h > >>=== > >>--- src/Buffer.h(revision 19264) > >>++

[PATCH-updated] Bug 3676--Citation Bug

2007-07-31 Thread Richard Heck
Andre Poenitz wrote: On Tue, Jul 31, 2007 at 03:00:34PM -0400, Richard Heck wrote: Index: src/Buffer.h === --- src/Buffer.h(revision 19264) +++ src/Buffer.h(working copy) @@ -13,7 +13,11 @@ #define BUFFER_H #i