Re: [PATCH 13x] fonts and instant preview

2005-06-13 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Isn't it? We look for a font using various mechanisms and if Angus> all others fail we fall through to Angus> QFont::setStyleHint(QFont::Serif). That looks pretty Angus> default-like to me. Fair enough. JMarc

Re: [PATCH 13x] fonts and instant preview

2005-06-13 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> Ok to commit these to the 1.3.x tree? I'll come up with > Angus> something similar for 1.4.x too. > > Sure. Two remarks: > > + // The combobox stores only the font name; the foundary info is > + // discarded. So extract the font name from fi.family().

Re: [PATCH 13x] fonts and instant preview

2005-06-13 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > | Angus> Ok to commit these to the 1.3.x tree? I'll come up with | Angus> something similar for 1.4.x too. > | Sure. Two remarks: > | + // The combobox stores only the font name; the

Re: [PATCH 13x] fonts and instant preview

2005-06-13 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Ok to commit these to the 1.3.x tree? I'll come up with Angus> something similar for 1.4.x too. Sure. Two remarks: + // The combobox stores only the font name; the foundary info is + // discarded. So extract the font n

[PATCH 13x] fonts and instant preview

2005-06-12 Thread Angus Leeming
The attached patch fixes a couple of bugs in LyX 1.3.x: 1. It enables LyX to choose a default font when falling through to QFont::setStyleHint() because no exact match to the font name has been found. It turns out that Qt/Win Free returns "Name [Foundary]" in QFontInfo::family(), so we need to