Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Georg Baum
Abdelrazak Younes wrote: Jean-Marc Lasgouttes a écrit : What if the compiler warning goes unnoticed? Thou shalt always listen to your compiler! I really prefer to use default in this case because by default it will do the full counter update. Have you never been bitten by the problem

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread jean-marc
What if the compiler warning goes unnoticed? I really prefer to use default in this case because by default it will do the full counter update. We compile with all warnings enabled. Ignoring them is a kind of federal crime over here. JMarc

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Abdelrazak Younes
[EMAIL PROTECTED] a écrit : What if the compiler warning goes unnoticed? I really prefer to use default in this case because by default it will do the full counter update. We compile with all warnings enabled. Ignoring them is a kind of federal crime over here. Well sheriff there's a lot

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Abdelrazak Younes
Georg Baum a écrit : Abdelrazak Younes wrote: Jean-Marc Lasgouttes a écrit : What if the compiler warning goes unnoticed? Thou shalt always listen to your compiler! I always do, don't worry. I was not talking about me :-) I really prefer to use default in this case because by default it

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Martin Vermeer
On Fri, Apr 07, 2006 at 06:19:15PM +0200, Georg Baum wrote: ... Thou shalt always listen to your compiler! _thy_ compiler. :-) As Angus is retired... - Martin pgpus78PqOtZQ.pgp Description: PGP signature

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Georg Baum
Am Freitag, 7. April 2006 19:39 schrieb Martin Vermeer: On Fri, Apr 07, 2006 at 06:19:15PM +0200, Georg Baum wrote: Thou shalt always listen to your compiler! _thy_ compiler. :-) I should not pretend to know more than I actually know. As Angus is retired... You are a good substitute :-)

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Here is the patch. It took me a bit longer than I thought Abdelrazak because I did not understand the logic in the cursor in Abdelrazak breakParagraph(). With my former patch one call to

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> It is indeed late for 1.4.1, but it will definitely go in 1.4.2. Abdelrazak> OK, then please note that there are a number of other Abdelrazak> calls to updateCounters that can be optimized also but I Abdelrazak> did not have

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: It is indeed late for 1.4.1, but it will definitely go in 1.4.2. Abdelrazak> OK, then please note that there are a number of other Abdelrazak> calls to updateCounters that can

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Georg Baum
Abdelrazak Younes wrote: > Jean-Marc Lasgouttes a écrit : > What if the compiler warning goes unnoticed? Thou shalt always listen to your compiler! > I really prefer to use > "default" in this case because by default it will do the full counter > update. Have you never been bitten by the

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread jean-marc
> What if the compiler warning goes unnoticed? I really prefer to use > "default" in this case because by default it will do the full counter > update. We compile with all warnings enabled. Ignoring them is a kind of federal crime over here. JMarc

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Abdelrazak Younes
[EMAIL PROTECTED] a écrit : > What if the compiler warning goes unnoticed? I really prefer to use "default" in this case because by default it will do the full counter update. We compile with all warnings enabled. Ignoring them is a kind of federal crime over here. Well sheriff there's a

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Abdelrazak Younes
Georg Baum a écrit : Abdelrazak Younes wrote: Jean-Marc Lasgouttes a écrit : What if the compiler warning goes unnoticed? Thou shalt always listen to your compiler! I always do, don't worry. I was not talking about me :-) I really prefer to use "default" in this case because by default

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Martin Vermeer
On Fri, Apr 07, 2006 at 06:19:15PM +0200, Georg Baum wrote: ... > Thou shalt always listen to your compiler! _thy_ compiler. :-) As Angus is retired... - Martin pgpus78PqOtZQ.pgp Description: PGP signature

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Georg Baum
Am Freitag, 7. April 2006 19:39 schrieb Martin Vermeer: > On Fri, Apr 07, 2006 at 06:19:15PM +0200, Georg Baum wrote: > > Thou shalt always listen to your compiler! > > _thy_ compiler. :-) I should not pretend to know more than I actually know. > As Angus is retired... You are a good

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-07 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Here is the patch. It took me a bit longer than I thought Abdelrazak> because I did not understand the logic in the cursor in Abdelrazak> breakParagraph(). With my former patch one call to

[Patch] Paragrah creation/deletion optimisation (was Re: [PATCH] buffer_funcs cleanup)

2006-04-06 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : Jean-Marc Lasgouttes a écrit : Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Jean-Marc Lasgouttes a écrit : bool needsUpdateCounters(Buffer const buf, ParIterator it) { if (it-layout()-counter.empty()) { Abdelrazak Apparently, this is

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-06 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Here is the patch. It took me a bit longer than I thought Abdelrazak because I did not understand the logic in the cursor in Abdelrazak breakParagraph(). With my former patch one call to Abdelrazak needsUpdateCounter on

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-06 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Here is the patch. It took me a bit longer than I thought Abdelrazak because I did not understand the logic in the cursor in Abdelrazak breakParagraph(). With my former patch one call to

[Patch] Paragrah creation/deletion optimisation (was Re: [PATCH] buffer_funcs cleanup)

2006-04-06 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Jean-Marc Lasgouttes a écrit : bool needsUpdateCounters(Buffer const & buf, ParIterator & it) { if (it->layout()->counter.empty()) { Abdelrazak> Apparently,

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-06 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Here is the patch. It took me a bit longer than I thought Abdelrazak> because I did not understand the logic in the cursor in Abdelrazak> breakParagraph(). With my former patch one call to Abdelrazak>

Re: [Patch] Paragrah creation/deletion optimisation

2006-04-06 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Here is the patch. It took me a bit longer than I thought Abdelrazak> because I did not understand the logic in the cursor in Abdelrazak> breakParagraph(). With my former patch one call to

<    1   2