On Wed, Nov 11, 2020 at 04:32:57PM +1300, Sam Crawley wrote:
> I hereby grant permission to license my contributions to LyX under the GNU
> General Public License, version 2 or any later version.
Thanks, I added you to credits.
Pavel
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists
On Sat, Nov 14, 2020 at 11:28:43AM -0500, Richard Kimberly Heck wrote:
> On 11/13/20 8:24 PM, Scott Kostyshak wrote:
> > On Sat, Nov 14, 2020 at 01:43:08AM +0100, Kornel Benko wrote:
> >> Am Sat, 14 Nov 2020 13:22:39 +1300
> >> schrieb "Sam Crawley" :
> >>
> >>> On Sat, 14 Nov 2020, at 12:36, Korne
On 11/13/20 8:24 PM, Scott Kostyshak wrote:
> On Sat, Nov 14, 2020 at 01:43:08AM +0100, Kornel Benko wrote:
>> Am Sat, 14 Nov 2020 13:22:39 +1300
>> schrieb "Sam Crawley" :
>>
>>> On Sat, 14 Nov 2020, at 12:36, Kornel Benko wrote:
> Defined at development/checkurls/CMakeLists.txt:8
> find_p
On Sat, Nov 14, 2020 at 01:43:08AM +0100, Kornel Benko wrote:
> Am Sat, 14 Nov 2020 13:22:39 +1300
> schrieb "Sam Crawley" :
>
> > On Sat, 14 Nov 2020, at 12:36, Kornel Benko wrote:
> > > >
> > > > Defined at development/checkurls/CMakeLists.txt:8
> > > > find_package(Perl REQUIRED)
> > > >
> >
Am Sat, 14 Nov 2020 13:22:39 +1300
schrieb "Sam Crawley" :
> On Sat, 14 Nov 2020, at 12:36, Kornel Benko wrote:
> > >
> > > Defined at development/checkurls/CMakeLists.txt:8
> > > find_package(Perl REQUIRED)
> > >
> > > Apparently you do not have '-DLYX_ENABLE_URLTESTS:BOOL=ON'. We should
> > >
Am Fri, 13 Nov 2020 23:42:29 +0100
schrieb Kornel Benko :
> Am Sat, 14 Nov 2020 10:55:48 +1300
> schrieb "Sam Crawley" :
>
> > On Sat, 14 Nov 2020, at 00:12, Kornel Benko wrote:
> > > Running the test I get:
> > > ...
> > > Can't exec
> > > "/usr2/src/lyx/lyx-git/development/batchtests/bin/com
Am Fri, 13 Nov 2020 23:42:29 +0100
schrieb Kornel Benko :
> Am Sat, 14 Nov 2020 10:55:48 +1300
> schrieb "Sam Crawley" :
>
> > On Sat, 14 Nov 2020, at 00:12, Kornel Benko wrote:
> > > Running the test I get:
> > > ...
> > > Can't exec
> > > "/usr2/src/lyx/lyx-git/development/batchtests/bin/com
Am Sat, 14 Nov 2020 10:55:48 +1300
schrieb "Sam Crawley" :
> On Sat, 14 Nov 2020, at 00:12, Kornel Benko wrote:
> > Running the test I get:
> > ...
> > Can't exec
> > "/usr2/src/lyx/lyx-git/development/batchtests/bin/compare_custom.pl":
> > Permission denied at
> > /BUILD/BUILDMint18/BuildLyxGit
On Sat, 14 Nov 2020, at 00:12, Kornel Benko wrote:
> Running the test I get:
> ...
> Can't exec
> "/usr2/src/lyx/lyx-git/development/batchtests/bin/compare_custom.pl":
> Permission denied at
> /BUILD/BUILDMint18/BuildLyxGitQt5.9.5local-gcc8.4.0/lyx_batch.pl
> line 195.
> ...
>
> The attached dif
Am Fri, 13 Nov 2020 21:11:07 +1300
schrieb "Sam Crawley" :
> I've attached an updated patchset.
>
> As discussed, there's now a different parameter for "dialog-show compare"
> called
> "run-blocking", which is appropriate for calling from the command line. The
> tests now
> use this. A couple o
On Thu, Nov 12, 2020 at 08:57:42PM +1300, Sam Crawley wrote:
> In that case, I'll add a different parameter to the LFUN to differentiate
> between case (ii) and (iii). So instead of passing "run" (and the two file
> names), you will pass "run-sync" to indicate that you want it to block for
> the
On Thu, 12 Nov 2020, at 00:18, Pavel Sanda wrote:
> On Wed, Nov 11, 2020 at 09:10:09PM +1300, Sam Crawley wrote:
> >
> > I'm not sure I understand. When cmd_mode == true (which is always the case
> > when run() is invoked via the LFUN),
>
> Maybe I do not understand your intentions then. I thoug
On Wed, Nov 11, 2020 at 09:10:09PM +1300, Sam Crawley wrote:
> > 2) It seems that if (!cmd_mode) you will call finished(false) twice
> > thus wrongly
> >reverting the toggles from FuncRequest(LFUN_CHANGES_OUTPUT) in
> > finished(), right?
>
> I'm not sure I understand. When cmd_mode == true
On Wed, 11 Nov 2020, at 00:31, Pavel Sanda wrote:
> So I looked at the code for the command line run at this place looks
> good enough.
Thanks for having a look.
> I have another concerns though:
> 1) slotOK contains error() call which seems to be missed now. If you
> don't want it for
>com
I hereby grant permission to license my contributions to LyX under the GNU
General Public License, version 2 or any later version.
Sam Crawley.
On Tue, 10 Nov 2020, at 23:39, Kornel Benko wrote:
> Am Sun, 8 Nov 2020 11:32:59 +0100
> schrieb Pavel Sanda :
>
> > On Sun, Nov 08, 2020 at 05:14:42PM
On Mon, Nov 09, 2020 at 01:03:47AM +0100, Pavel Sanda wrote:
> > > > @@ -343,7 +348,12 @@ bool GuiCompare::initialiseParams(std::string
> > > > const &par)
> > > > if (cmd.getArg(0) == "run") {
> > > > oldFileCB->setEditText(toqstr(cmd.getArg(1)));
> > > > n
Am Sun, 8 Nov 2020 11:32:59 +0100
schrieb Pavel Sanda :
> On Sun, Nov 08, 2020 at 05:14:42PM +1300, Sam Crawley wrote:
> > Hi all,
>
> Hi Sam,
>
> welcome and thanks for working on this. Couple small things:
>
> - Please send in a separate email to our list the following GPL statement:
>
> I
On Mon, Nov 09, 2020 at 09:19:42AM +1300, Sam Crawley wrote:
> On Sun, 8 Nov 2020, at 23:32, Pavel Sanda wrote:
>
> > Git commit messages tend to have the following structure: first summary
> > line,
> > empty line and then the details. This helps with log summaries.
>
> That is the format I use
Am Mon, 09 Nov 2020 09:07:35 +1300
schrieb "Sam Crawley" :
> On Mon, 9 Nov 2020, at 01:01, Kornel Benko wrote:
> > Needed new perl module (Slurp.pm), got from package 'libfile-slurp-perl'.
>
> I think this use to be in Perl core, but it's now been taken out. I can
> easily rewrite
> if the depen
Am Mon, 09 Nov 2020 09:00:48 +1300
schrieb "Sam Crawley" :
> On Sun, 8 Nov 2020, at 22:28, Kornel Benko wrote:
> > Am Sun, 08 Nov 2020 17:14:42 +1300
> > schrieb "Sam Crawley" :
> > ...
> > > diff --git a/lib/scripts/lyx_batch.pl.in b/lib/scripts/lyx_batch.pl.in
> > > index 2d93d27c59..32ef0f974a
On Sun, 8 Nov 2020, at 23:32, Pavel Sanda wrote:
> Git commit messages tend to have the following structure: first summary line,
> empty line and then the details. This helps with log summaries.
That is the format I used, unless I'm missing something. The 'subject' line in
a git patch file is th
On Sun, 8 Nov 2020, at 22:28, Kornel Benko wrote:
> Am Sun, 08 Nov 2020 17:14:42 +1300
> schrieb "Sam Crawley" :
> ...
> > diff --git a/lib/scripts/lyx_batch.pl.in b/lib/scripts/lyx_batch.pl.in
> > index 2d93d27c59..32ef0f974a 100644
> > --- a/lib/scripts/lyx_batch.pl.in
> > +++ b/lib/scripts/lyx_b
On Mon, 9 Nov 2020, at 01:01, Kornel Benko wrote:
> Needed new perl module (Slurp.pm), got from package 'libfile-slurp-perl'.
I think this use to be in Perl core, but it's now been taken out. I can easily
rewrite if the dependency is a problem.--
lyx-devel mailing list
lyx-devel@lists.lyx.org
ht
On Sun, Nov 08, 2020 at 12:48:11PM -0500, Richard Kimberly Heck wrote:
> On 11/8/20 12:12 PM, Scott Kostyshak wrote:
> > On Sun, Nov 08, 2020 at 11:32:59AM +0100, Pavel Sanda wrote:
> >> Scott/Kornel will presumably review/check the testing part.
> > I don't have much time to review or help, althou
On 11/8/20 12:12 PM, Scott Kostyshak wrote:
> On Sun, Nov 08, 2020 at 11:32:59AM +0100, Pavel Sanda wrote:
>> Scott/Kornel will presumably review/check the testing part.
> I don't have much time to review or help, although I would be happy to take a
> look in the future (possibly not for a while t
On Sun, Nov 08, 2020 at 11:32:59AM +0100, Pavel Sanda wrote:
>
> Scott/Kornel will presumably review/check the testing part.
I don't have much time to review or help, although I would be happy to take a
look in the future (possibly not for a while though). Thanks to Pavel and
Kornel for giving
Am Sun, 8 Nov 2020 13:01:14 +0100
schrieb Kornel Benko :
> Am Sun, 8 Nov 2020 10:28:51 +0100
> schrieb Kornel Benko :
>
> > Am Sun, 08 Nov 2020 17:14:42 +1300
> > schrieb "Sam Crawley" :
> > ...
> > > diff --git a/lib/scripts/lyx_batch.pl.in b/lib/scripts/lyx_batch.pl.in
> > > index 2d93d27c59.
Am Sun, 8 Nov 2020 10:28:51 +0100
schrieb Kornel Benko :
> Am Sun, 08 Nov 2020 17:14:42 +1300
> schrieb "Sam Crawley" :
> ...
> > diff --git a/lib/scripts/lyx_batch.pl.in b/lib/scripts/lyx_batch.pl.in
> > index 2d93d27c59..32ef0f974a 100644
> > --- a/lib/scripts/lyx_batch.pl.in
> > +++ b/lib/scrip
On Sun, Nov 08, 2020 at 05:14:42PM +1300, Sam Crawley wrote:
> Hi all,
Hi Sam,
welcome and thanks for working on this. Couple small things:
- Please send in a separate email to our list the following GPL statement:
I hereby grant permission to license my contributions to LyX under the GNU
Gener
Am Sun, 08 Nov 2020 17:14:42 +1300
schrieb "Sam Crawley" :
...
> diff --git a/lib/scripts/lyx_batch.pl.in b/lib/scripts/lyx_batch.pl.in
> index 2d93d27c59..32ef0f974a 100644
> --- a/lib/scripts/lyx_batch.pl.in
> +++ b/lib/scripts/lyx_batch.pl.in
> @@ -8,11 +8,6 @@ use warnings;
> use File::Copy;
>
30 matches
Mail list logo
