Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-09 Thread Andre Poenitz
On Sat, Apr 08, 2006 at 07:04:06PM +0200, Abdelrazak Younes wrote: > Let me explain what I have in mind: > My idea is that lyx::Action would be the action backend of LyX, that is, > the unification of the toolbar and menubar backend. > lyx::frontend::Action would be the frontend specialisation of

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-08 Thread Abdelrazak Younes
Andre Poenitz a écrit : On Fri, Apr 07, 2006 at 05:26:58PM +0200, Abdelrazak Younes wrote: Andre Poenitz a écrit : On Thu, Apr 06, 2006 at 01:52:35PM +0200, Abdelrazak Younes wrote: Leuven, E. a écrit : I think we can shortcut that by using QLAction and avoid the call to "form_->controller()

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-08 Thread Andre Poenitz
On Fri, Apr 07, 2006 at 04:30:17PM +, Angus Leeming wrote: > Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > Yep, and what about creating a qt4 namespace? In due time > > lyx::frontend::qt4::Action could inherit lyx::Action. Or is that against > > your coding guidelines? > > Sounds good to

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-08 Thread Andre Poenitz
On Fri, Apr 07, 2006 at 05:26:58PM +0200, Abdelrazak Younes wrote: > Andre Poenitz a écrit : > >On Thu, Apr 06, 2006 at 01:52:35PM +0200, Abdelrazak Younes wrote: > >>Leuven, E. a écrit : > I think we can shortcut that by > using QLAction and avoid the call to > "form_->controller().d

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-08 Thread Andre Poenitz
On Fri, Apr 07, 2006 at 05:50:46PM +0200, Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | Abdelrazak Younes <[EMAIL PROTECTED]> writes: > | >> BTW, I am not too happy that we use a 'Q' prefix for _our_ Qt stuff. > | > | > Feel free to change that. I agree with with yo

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-07 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Yep, and what about creating a qt4 namespace? In due time > lyx::frontend::qt4::Action could inherit lyx::Action. Or is that against > your coding guidelines? Sounds good to me. Angus

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-07 Thread Abdelrazak Younes
Angus Leeming a écrit : Abdelrazak Younes <[EMAIL PROTECTED]> writes: BTW, I am not too happy that we use a 'Q' prefix for _our_ Qt stuff. Feel free to change that. I agree with with you but I just followed the qt2 code here. Proposal welcome for QLAction, LAction? Since it's all in namespa

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-07 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Abdelrazak Younes <[EMAIL PROTECTED]> writes: | >> BTW, I am not too happy that we use a 'Q' prefix for _our_ Qt stuff. | | > Feel free to change that. I agree with with you but I just followed the | > qt2 code here. Proposal welcome for QLAction, LAct

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-07 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> BTW, I am not too happy that we use a 'Q' prefix for _our_ Qt stuff. > Feel free to change that. I agree with with you but I just followed the > qt2 code here. Proposal welcome for QLAction, LAction? Since it's all in namespace lyx::frontend, why

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-07 Thread Abdelrazak Younes
Andre Poenitz a écrit : On Thu, Apr 06, 2006 at 01:52:35PM +0200, Abdelrazak Younes wrote: Leuven, E. a écrit : I think we can shortcut that by using QLAction and avoid the call to "form_->controller().dispatchInsert(str)". do we have access to lyxview in qmathdialog so that we can pass it to

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-06 Thread Andre Poenitz
On Thu, Apr 06, 2006 at 11:32:57AM +0200, Abdelrazak Younes wrote: > Andre Poenitz a écrit : > >On Wed, Apr 05, 2006 at 12:47:22PM +0200, Abdelrazak Younes wrote: > >>Abdelrazak Younes a écrit : > >>>Helge Hafting a écrit : > >>>Concerning the math panel, it used to work great also last time I > >

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-06 Thread Andre Poenitz
On Thu, Apr 06, 2006 at 01:52:35PM +0200, Abdelrazak Younes wrote: > Leuven, E. a écrit : > >>I think we can shortcut that by > >>using QLAction and avoid the call to > >>"form_->controller().dispatchInsert(str)". > > > >do we have access to lyxview in qmathdialog so that we can pass it to > >ql

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-06 Thread Helge Hafting
Abdelrazak Younes wrote: Hum, "Then it is a problem on Hedge side". Because toolbar icons are fully themable and get their size with the system style. Hm. They create resizeable icons, but using raster graphichs instead of vectors. A recipe for disaster. I haven't "set up" qt4 in any way,

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-06 Thread Abdelrazak Younes
Leuven, E. a écrit : I think we can shortcut that by using QLAction and avoid the call to "form_->controller().dispatchInsert(str)". do we have access to lyxview in qmathdialog so that we can pass it to qlaction? Yes: Dialog::View::kernel()->lyxview() So from QMathDialog that would be form_

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-06 Thread Abdelrazak Younes
Andre Poenitz a écrit : On Wed, Apr 05, 2006 at 12:47:22PM +0200, Abdelrazak Younes wrote: Abdelrazak Younes a écrit : Helge Hafting a écrit : Concerning the math panel, it used to work great also last time I checked (before the ui file conversion) but I see now that there's a lot of problems

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-06 Thread Andre Poenitz
On Wed, Apr 05, 2006 at 12:47:22PM +0200, Abdelrazak Younes wrote: > Abdelrazak Younes a écrit : > >Helge Hafting a écrit : > >Concerning the math panel, it used to work great also last time I > >checked (before the ui file conversion) but I see now that there's a lot > >of problems. I use exclus

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-06 Thread Andre Poenitz
On Wed, Apr 05, 2006 at 03:36:20PM +, Angus Leeming wrote: > Georg Baum <[EMAIL PROTECTED]> writes: > > > Then, would you be so kind to move them to lib/images/math and fix > > > the Xforms and Gtk frontends in consequence? Or just copy them to > > > lib/images/math if you don't have the time

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-06 Thread Abdelrazak Younes
Georg Baum a écrit : Am Mittwoch, 5. April 2006 17:36 schrieb Angus Leeming: These things were all the images that LyX needed in the dark and distant days when XForms was the only frontend. Images were originally #included as C sources, so there was no need to distribute them. I'd suggest that

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Georg Baum
Am Mittwoch, 5. April 2006 17:36 schrieb Angus Leeming: > These things were all the images that LyX needed in the dark and distant days > when XForms was the only frontend. Images were originally #included as C > sources, so there was no need to distribute them. I'd suggest that you move them > o

RE: Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Leuven, E.
> I think we can shortcut that by > using QLAction and avoid the call to > "form_->controller().dispatchInsert(str)". do we have access to lyxview in qmathdialog so that we can pass it to qlaction?

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Edwin Leuven a écrit : Abdelrazak Younes wrote: Concerning your QMAction class, I think we could merge it with my QLAction class. But this would maybe mean touching the controller... food for thought. i created QMAction because i didn't want (or didn't know how) to pass a lyxview to an objec

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Angus Leeming
Georg Baum <[EMAIL PROTECTED]> writes: > > Then, would you be so kind to move them to lib/images/math and fix the > > Xforms and Gtk frontends in consequence? Or just copy them to > > lib/images/math if you don't have the time to fix the frontends. > No, please lets not copy. We should rather fin

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Georg Baum a écrit : Abdelrazak Younes wrote: Then, would you be so kind to move them to lib/images/math and fix the Xforms and Gtk frontends in consequence? Or just copy them to lib/images/math if you don't have the time to fix the frontends. No, please lets not copy. We should rather find

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Georg Baum
Abdelrazak Younes wrote: > Then, would you be so kind to move them to lib/images/math and fix the > Xforms and Gtk frontends in consequence? Or just copy them to > lib/images/math if you don't have the time to fix the frontends. No, please lets not copy. We should rather find out why they are in

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Georg Baum a écrit : Abdelrazak Younes wrote: Georg Baum a écrit : Abdelrazak Younes wrote: I was going to. I have already committed the icons. You forgot to add the new image to the Makefile, and you broke both xforms and gtk :-( Sorry to make you a watch dog again :-( I thought those ico

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Georg Baum
Abdelrazak Younes wrote: > Georg Baum a écrit : >> Abdelrazak Younes wrote: >> >>> I was going to. I have already committed the icons. >> >> You forgot to add the new image to the Makefile, and you broke both >> xforms and gtk :-( > > Sorry to make you a watch dog again :-( > I thought those ic

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Georg Baum a écrit : Abdelrazak Younes wrote: I was going to. I have already committed the icons. You forgot to add the new image to the Makefile, and you broke both xforms and gtk :-( Sorry to make you a watch dog again :-( I thought those icons were not used at all. For those unfamiliar

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Edwin Leuven a écrit : So, do I commit them or not? yes, thanks OK, I am committing with the following hack within MathUi.ui: I have replaced "../../../../images/" with "../lib/images". This is a temporary measure so that the math panel get its icons displayed under linux and when lyx is

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Edwin Leuven
Georg Baum wrote: You forgot to add the new image to the Makefile, and you broke both xforms and gtk :-( oops For those unfamiliar with the .xpm format: This can be read as C source (and is used as such in the xforms and gtk frontends), so one may not arbitrarily change the internal image nam

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Georg Baum
Abdelrazak Younes wrote: > I was going to. I have already committed the icons. You forgot to add the new image to the Makefile, and you broke both xforms and gtk :-( For those unfamiliar with the .xpm format: This can be read as C source (and is used as such in the xforms and gtk frontends), so o

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Edwin Leuven
Abdelrazak Younes wrote: Concerning your QMAction class, I think we could merge it with my QLAction class. But this would maybe mean touching the controller... food for thought. i created QMAction because i didn't want (or didn't know how) to pass a lyxview to an object in QMathDialog. but

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Edwin Leuven
So, do I commit them or not? yes, thanks

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Edwin Leuven a écrit : Abdelrazak Younes wrote: I was going to. I have already committed the icons. If you want to give it a try for the rest please go ahead. I thought you had problem with SVN access. not atm, but i think you committed the whole bunch No, not yet. (haven't really gotten a

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Edwin Leuven
Abdelrazak Younes wrote: I was going to. I have already committed the icons. If you want to give it a try for the rest please go ahead. I thought you had problem with SVN access. not atm, but i think you committed the whole bunch (haven't really gotten around to read the svn documentation, ho

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Edwin Leuven a écrit : Abdelrazak Younes wrote: Edwin Leuven a écrit : Yep you're right, I've reached the same conclusion about qmenu at the time of the porting. Actually, that's the reason why I haven't ported the qt2 bullets yet :-( perhaps we should apply the attached in the meantime? I

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Edwin Leuven
Abdelrazak Younes wrote: Everything works fine. Good job Man! thanks I am committing this now. ok thanks Concerning your QMAction class, I think we could merge it with my QLAction class. But this would maybe mean touching the controller... food for thought. Now, let's discuss about the i

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Edwin Leuven
Abdelrazak Younes wrote: Edwin Leuven a écrit : Yep you're right, I've reached the same conclusion about qmenu at the time of the porting. Actually, that's the reason why I haven't ported the qt2 bullets yet :-( perhaps we should apply the attached in the meantime? I have committed it. yo

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Edwin Leuven a écrit : Abdelrazak Younes wrote: Edwin, I can't apply your patch cleanly. QMathUI.ui and QMathDialoc.C seem to have conflict with revision 13551. From what I see in the diff, the changes look just fine. Please commit so that we work from there. If you can't commit, please sen

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Edwin Leuven a écrit : Yep you're right, I've reached the same conclusion about qmenu at the time of the porting. Actually, that's the reason why I haven't ported the qt2 bullets yet :-( perhaps we should apply the attached in the meantime? I have committed it. Please wait for my merged p

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Edwin Leuven
Abdelrazak Younes wrote: Edwin, I can't apply your patch cleanly. QMathUI.ui and QMathDialoc.C seem to have conflict with revision 13551. From what I see in the diff, the changes look just fine. Please commit so that we work from there. If you can't commit, please send those two files. att

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Edwin, I can't apply your patch cleanly. QMathUI.ui and QMathDialoc.C seem to have conflict with revision 13551. From what I see in the diff, the changes look just fine. Please commit so that we work from there. If you can't commit, please send those two files. Thanks, Abdel. Edwin Leuven

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : Edwin Leuven a écrit : Abdelrazak Younes wrote: By the way, how are the toolbar icons for you? they are ugly, but apart from that no problems on my side Them it is a them problem on Hedge side. Hum, "Then it is a problem on Hedge side". Because toolbar icons ar

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Edwin Leuven a écrit : Abdelrazak Younes wrote: By the way, how are the toolbar icons for you? they are ugly, but apart from that no problems on my side Them it is a them problem on Hedge side. perhaps we should apply the attached in the meantime? What do you want that? I think I know wh

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Edwin Leuven
Abdelrazak Younes wrote: By the way, how are the toolbar icons for you? they are ugly, but apart from that no problems on my side perhaps we should apply the attached in the meantime? What do you want that? I think I know where you want to go but please explain it. BulletsModule is a wid

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Edwin Leuven a écrit : Abdelrazak Younes wrote: I know, this is because uic logically translates the path to the icon "as is" so the binary doesn't find them. I am playing with the generated header file to see how we could solve that. why not move the images so that they can be themeable, ins

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Edwin Leuven a écrit : Abdelrazak Younes wrote: On Windows, all the icons are spread horizontally so in for some cases some of the icons are off-screen. Is it the same for you? yes OK. By the way, how are the toolbar icons for you? it would be nice to have a widget iconpalette that we can

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Edwin Leuven
Abdelrazak Younes wrote: I know, this is because uic logically translates the path to the icon "as is" so the binary doesn't find them. I am playing with the generated header file to see how we could solve that. why not move the images so that they can be themeable, instead of finding a solut

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Edwin Leuven
Abdelrazak Younes wrote: On Windows, all the icons are spread horizontally so in for some cases some of the icons are off-screen. Is it the same for you? yes it would be nice to have a widget iconpalette that we can hook on to a toolbutton (as we use for the bullets in the qt2 frontend). it s

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Edwin Leuven a écrit : Abdelrazak Younes wrote: It seems that Qt4 ui format doesn't support embedded icons like older version did. I found similar xpm in "trunk/images". I have used those for now but I am missing the one that should come with the style PushButton. But the icons still do not sh

Re: [Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Edwin Leuven
Abdelrazak Younes wrote: It seems that Qt4 ui format doesn't support embedded icons like older version did. I found similar xpm in "trunk/images". I have used those for now but I am missing the one that should come with the style PushButton. But the icons still do not show in the math panel und

[Qt4 Patch] fixing Math panel icons (was Re: [Patch] Re: [Patch] nicefrac - test results)

2006-04-05 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : Helge Hafting a écrit : Concerning the math panel, it used to work great also last time I checked (before the ui file conversion) but I see now that there's a lot of problems. I use exclusively the math toolbar so I didn't notice. I'll try to have a look at this ove