Re: [RFC][PATCH] Next results from code analyzer - suspicious variable usage

2020-02-17 Thread Jürgen Spitzmüller
Am Montag, den 17.02.2020, 22:56 +0100 schrieb Pavel Sanda: > > Any comments or ok to apply? > > The first snippet looks fine, the second is technically correct but > it might > signalize that author (Juergen?) might have different logic in mind > and there > is some thinko in the code. I think

Re: [RFC][PATCH] Next results from code analyzer - suspicious variable usage

2020-02-17 Thread Pavel Sanda
On Mon, Feb 17, 2020 at 04:35:05PM +0100, Stephan Witt wrote: > Any comments or ok to apply? The first snippet looks fine, the second is technically correct but it might signalize that author (Juergen?) might have different logic in mind and there is some thinko in the code. Pavel -- lyx-devel

Re: [RFC][PATCH] Next results from code analyzer - suspicious variable usage

2020-02-17 Thread Kornel Benko
Am Mon, 17 Feb 2020 16:35:05 +0100 schrieb Stephan Witt : > Hi all, > > this is the next step in evaluating the code analyzing results. > > There are some problems found with useless assignments and one > uninitialized variable. > > Any comments or ok to apply? > > Or is there some flaw in

[RFC][PATCH] Next results from code analyzer - suspicious variable usage

2020-02-17 Thread Stephan Witt
Hi all, this is the next step in evaluating the code analyzing results. There are some problems found with useless assignments and one uninitialized variable. Any comments or ok to apply? Or is there some flaw in logic and the improvement not straightforward? Stephan