Re: [patch] Fix no-gui export

2000-11-21 Thread Lars Gullik Bjønnes
Angus Leeming [EMAIL PROTECTED] writes: | On Monday 20 November 2000 10:38, Dekel Tsur wrote: | On Sun, Nov 19, 2000 at 11:36:11PM +0200, Dekel Tsur wrote: | A recent change added a 'Buffer ' parameter to Inset::Clone(). | In LyXParagraph::CopyIntoMinibuffer(), the buffer reference is taken

Re: [patch] Fix no-gui export

2000-11-21 Thread Lars Gullik Bjønnes
Angus Leeming [EMAIL PROTECTED] writes: | On Monday 20 November 2000 10:51, Jürgen Vigna wrote: | [EMAIL PROTECTED] wrote: | Jean-Marc suggested at the time that LyXParagraph should store a Buffer . | This would be even cleaner, I think. | | I don't think so LyXParagraph should stay Buffer

Re: [patch] Fix no-gui export

2000-11-21 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Monday 20 November 2000 10:38, Dekel Tsur wrote: | > On Sun, Nov 19, 2000 at 11:36:11PM +0200, Dekel Tsur wrote: | > > A recent change added a 'Buffer &' parameter to Inset::Clone(). | > > In LyXParagraph::CopyIntoMinibuffer(), the buffer reference

Re: [patch] Fix no-gui export

2000-11-21 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Monday 20 November 2000 10:51, Jürgen Vigna wrote: | > [EMAIL PROTECTED] wrote: | > >Jean-Marc suggested at the time that LyXParagraph should store a Buffer &. | > >This would be even cleaner, I think. | > | > I don't think so LyXParagraph should

Re: [patch] Fix no-gui export

2000-11-20 Thread Dekel Tsur
On Sun, Nov 19, 2000 at 11:36:11PM +0200, Dekel Tsur wrote: A recent change added a 'Buffer ' parameter to Inset::Clone(). In LyXParagraph::CopyIntoMinibuffer(), the buffer reference is taken from current_view, which is not available when there is no GUI. I attached a patch that (partially)

Re: [patch] Fix no-gui export

2000-11-20 Thread Angus Leeming
On Monday 20 November 2000 10:38, Dekel Tsur wrote: On Sun, Nov 19, 2000 at 11:36:11PM +0200, Dekel Tsur wrote: A recent change added a 'Buffer ' parameter to Inset::Clone(). In LyXParagraph::CopyIntoMinibuffer(), the buffer reference is taken from current_view, which is not available when

Re: [patch] Fix no-gui export

2000-11-20 Thread Angus Leeming
On Monday 20 November 2000 10:51, Jürgen Vigna wrote: [EMAIL PROTECTED] wrote: Jean-Marc suggested at the time that LyXParagraph should store a Buffer . This would be even cleaner, I think. I don't think so LyXParagraph should stay Buffer independent, I prefer the param. Jürgen Any

Re: [patch] Fix no-gui export

2000-11-20 Thread Jürgen Vigna
[EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED] wrote: Any real reason why? The contents are buffer-dependent (eg the insets. One might argue that the text is also!) And it's a simple matter to change/check the buffer when pasting the LyXParagraph to another buffer. Or is this just "my

Re: [patch] Fix no-gui export

2000-11-20 Thread Dekel Tsur
On Sun, Nov 19, 2000 at 11:36:11PM +0200, Dekel Tsur wrote: > A recent change added a 'Buffer &' parameter to Inset::Clone(). > In LyXParagraph::CopyIntoMinibuffer(), the buffer reference is taken from > current_view, which is not available when there is no GUI. > I attached a patch that

Re: [patch] Fix no-gui export

2000-11-20 Thread Angus Leeming
On Monday 20 November 2000 10:38, Dekel Tsur wrote: > On Sun, Nov 19, 2000 at 11:36:11PM +0200, Dekel Tsur wrote: > > A recent change added a 'Buffer &' parameter to Inset::Clone(). > > In LyXParagraph::CopyIntoMinibuffer(), the buffer reference is taken from > > current_view, which is not

Re: [patch] Fix no-gui export

2000-11-20 Thread Angus Leeming
On Monday 20 November 2000 10:51, Jürgen Vigna wrote: > [EMAIL PROTECTED] wrote: > >Jean-Marc suggested at the time that LyXParagraph should store a Buffer &. > >This would be even cleaner, I think. > > I don't think so LyXParagraph should stay Buffer independent, I prefer the > param. > >

Re: [patch] Fix no-gui export

2000-11-20 Thread Jürgen Vigna
[EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED] wrote: >Any real reason why? The contents are buffer-dependent (eg the insets. One >might argue that the text is also!) And it's a simple matter to change/check >the buffer when pasting the LyXParagraph to another buffer. Or is this just

[patch] Fix no-gui export

2000-11-19 Thread Dekel Tsur
A recent change added a 'Buffer ' parameter to Inset::Clone(). In LyXParagraph::CopyIntoMinibuffer(), the buffer reference is taken from current_view, which is not available when there is no GUI. I attached a patch that (partially) fix this problem, but perhaps the problem should be fixed in a

[patch] Fix no-gui export

2000-11-19 Thread Dekel Tsur
A recent change added a 'Buffer &' parameter to Inset::Clone(). In LyXParagraph::CopyIntoMinibuffer(), the buffer reference is taken from current_view, which is not available when there is no GUI. I attached a patch that (partially) fix this problem, but perhaps the problem should be fixed in a