Several items:
Also dispatch to InsetCommands (etc) near the temp cursor tip on mouse
events (this means the label dialog is working again)
Lots of BOOST_ASSERTs to bomb early.
Shift some InsetLabel specific code from BufferView*
Shift LFUN_PARAGRAPH_APPLY handling from BV to Text.
Remove a
Again, mostly shifting stuff around. Some function to anon in the only
place they are used, rename the x/y version of edit to editXY, remove a
cursorPar() or two, make some #if 0'd chunk of code in insettabular
compilable.
Andre'
--
Those who desire to give up Freedom in order to gain
Andre Poenitz wrote:
Again, mostly shifting stuff around. Some function to anon in the
only place they are used, rename the x/y version of edit to editXY,
remove a cursorPar() or two, make some #if 0'd chunk of code in
insettabular compilable.
You know, I really like the feel of all this.
On Fri, Feb 13, 2004 at 01:27:36PM +, Angus Leeming wrote:
Andre Poenitz wrote:
Again, mostly shifting stuff around. Some function to anon in the
only place they are used, rename the x/y version of edit to editXY,
remove a cursorPar() or two, make some #if 0'd chunk of code in
Andre Poenitz wrote:
This is possible, and actually close to my prefered way out.
(Actually I'd prefer
string getPossibleLabel(LCursor cur, LyXText text)
over of your 'finer grained' version as this produces less clutter
in the user code (no need to use .paragraph() in high
Angus Leeming wrote:
So, I'll keep on mentioning it why I notice too.
s/why/when/
A
Several items:
Also dispatch to InsetCommands (etc) near the temp cursor tip on mouse
events (this means the label dialog is working again)
Lots of BOOST_ASSERTs to bomb early.
Shift some InsetLabel specific code from BufferView*
Shift LFUN_PARAGRAPH_APPLY handling from BV to Text.
Remove a
Again, mostly shifting stuff around. Some function to anon in the only
place they are used, rename the x/y version of edit to editXY, remove a
cursorPar() or two, make some #if 0'd chunk of code in insettabular
compilable.
Andre'
--
Those who desire to give up Freedom in order to gain
Andre Poenitz wrote:
>
> Again, mostly shifting stuff around. Some function to anon in the
> only place they are used, rename the x/y version of edit to editXY,
> remove a cursorPar() or two, make some #if 0'd chunk of code in
> insettabular compilable.
You know, I really like the feel of all
On Fri, Feb 13, 2004 at 01:27:36PM +, Angus Leeming wrote:
> Andre Poenitz wrote:
>
> >
> > Again, mostly shifting stuff around. Some function to anon in the
> > only place they are used, rename the x/y version of edit to editXY,
> > remove a cursorPar() or two, make some #if 0'd chunk of
Andre Poenitz wrote:
> This is possible, and actually close to my prefered way out.
> (Actually I'd prefer
>
> string getPossibleLabel(LCursor & cur, LyXText & text)
>
> over of your 'finer grained' version as this produces less clutter
> in the user code (no need to use .paragraph() in
Angus Leeming wrote:
> So, I'll keep on mentioning it why I notice too.
s/why/when/
A
On Fri, Jan 30, 2004 at 01:30:59PM -0800, Kayvan A. Sylvan wrote:
The lyx crashes situation is better. Thanks.
Lyx still crashes on:
1. C-N (New document)
2. C-M (Insert math inset)
3. type X^Y in the math inset
The ^ causes the crash on some of my machines, but the C-m causes
the
On Fri, Jan 30, 2004 at 01:30:59PM -0800, Kayvan A. Sylvan wrote:
> The lyx crashes situation is better. Thanks.
>
> Lyx still crashes on:
>
> 1. C-N (New document)
> 2. C-M (Insert math inset)
> 3. type X^Y in the math inset
>
> The "^" causes the crash on some of my machines, but the C-m
This fixes a few of the gaping holes of the previous changes (and
opens a few new ones).
On the good side:
- most (all?) of the immediate 'click on inset crashes' are fixed.
- mathed is working again (using the global cursor!)
- C-m in mathed now opens some lightweight 'real' inset MBoxInset
Andre Poenitz wrote:
[...]
If your patch does half of what you say it does: good work! ;-)
Alfredo, I certainly would not mind if you had a look at the coordinate
business. It's currently somewhere in the limbo between 'screen
absolute' and 'document absolute' and I wouldn't be surprised if
The lyx crashes situation is better. Thanks.
Lyx still crashes on:
1. C-N (New document)
2. C-M (Insert math inset)
3. type X^Y in the math inset
The ^ causes the crash on some of my machines, but the C-m causes
the crash on my Solaris box.
---Kayvan
--
Kayvan A.
This fixes a few of the gaping holes of the previous changes (and
opens a few new ones).
On the good side:
- most (all?) of the immediate 'click on inset crashes' are fixed.
- mathed is working again (using the global cursor!)
- C-m in mathed now opens some lightweight 'real' inset MBoxInset
Andre Poenitz wrote:
> [...]
If your patch does half of what you say it does: good work! ;-)
> Alfredo, I certainly would not mind if you had a look at the coordinate
> business. It's currently somewhere in the limbo between 'screen
> absolute' and 'document absolute' and I wouldn't be
The lyx crashes situation is better. Thanks.
Lyx still crashes on:
1. C-N (New document)
2. C-M (Insert math inset)
3. type X^Y in the math inset
The "^" causes the crash on some of my machines, but the C-m causes
the crash on my Solaris box.
---Kayvan
--
Kayvan A.
On Wed, Jan 21, 2004 at 08:47:47AM +0100, Alfredo Braunstein wrote:
Angus Leeming wrote:
Do whatever is easiest for you. Note that Alfredo is pretty good at
tracking down off by one errors.
I hope that with this lousy flattering you are not pretending I'll do the
dirty job.
He's not
Andre Poenitz wrote:
1. This dumps most of the rest of the mathcursor implementation into
the cursor.[Ch], globalizes a bit of them.
How likely is it that the 'non-integrated rest of the original math
cursor' will be 'generalized for texted'? I guess 'erase', 'up',
'down' can all be
On Mon, Jan 26, 2004 at 09:54:57AM +, Angus Leeming wrote:
Andre Poenitz wrote:
1. This dumps most of the rest of the mathcursor implementation into
the cursor.[Ch], globalizes a bit of them.
How likely is it that the 'non-integrated rest of the original math
cursor' will be
On Wed, Jan 21, 2004 at 08:47:47AM +0100, Alfredo Braunstein wrote:
> Angus Leeming wrote:
>
> > Do whatever is easiest for you. Note that Alfredo is pretty good at
> > tracking down off by one errors.
>
> I hope that with this lousy flattering you are not pretending I'll do the
> dirty job.
Andre Poenitz wrote:
>
> 1. This dumps most of the rest of the mathcursor implementation into
> the cursor.[Ch], "globalizes" a bit of them.
How likely is it that the 'non-integrated rest of the original math
cursor' will be 'generalized for texted'? I guess 'erase', 'up',
'down' can all be
On Mon, Jan 26, 2004 at 09:54:57AM +, Angus Leeming wrote:
> Andre Poenitz wrote:
>
> >
> > 1. This dumps most of the rest of the mathcursor implementation into
> > the cursor.[Ch], "globalizes" a bit of them.
>
> How likely is it that the 'non-integrated rest of the original math
>
Angus Leeming wrote:
Do whatever is easiest for you. Note that Alfredo is pretty good at
tracking down off by one errors.
I hope that with this lousy flattering you are not pretending I'll do the
dirty job.
Alfredo
Angus Leeming wrote:
> Do whatever is easiest for you. Note that Alfredo is pretty good at
> tracking down off by one errors.
I hope that with this lousy flattering you are not pretending I'll do the
dirty job.
Alfredo
Andre Poenitz wrote:
This reduces the mathcursor class to a namespace and moves some
stuff to LCursor and InsetBase.
There are still 2500 lines to move (1400 from amthcursor and 900
from formulabase) and it is still full of 'off-by-one' crashes but
things are snapping into place.
On Tue, Jan 20, 2004 at 01:43:39PM +, Angus Leeming wrote:
Andre Poenitz wrote:
This reduces the mathcursor class to a namespace and moves some
stuff to LCursor and InsetBase.
There are still 2500 lines to move (1400 from amthcursor and 900
from formulabase) and it is still
On Tue, Jan 20, 2004 at 03:05:56PM +0100, Andre' Poenitz wrote:
Why does LCursor::innerInsetTabular() exist? Shouldn't this be a
wrapper function in an anonymous namespace in insettabular.C?
Possibly, yes.
In fact 'innerInsetOfType' should be sufficient at some point of time.
Andre'
Andre Poenitz wrote:
What's the current_ slice? I thought that the cursor (blinking
thing) was always the top-most slice.
We are dispatching to the innermost inset willing to handle an LFUN.
This means going down the slice stack. Of course we can't just pop
slices while trying to dispatch
On Tue, Jan 20, 2004 at 02:20:52PM +, Angus Leeming wrote:
Do whatever is easiest for you. Note that Alfredo is pretty good at
tracking down off by one errors. (You've already warned people not to
use current cvs for real work.)
*grin*
As 'cvs commit' on A and 'cvs up' on B is simpler
Andre Poenitz wrote:
>
> This reduces the mathcursor class to a namespace and moves some
> stuff to LCursor and InsetBase.
>
> There are still 2500 lines to move (1400 from amthcursor and 900
> from formulabase) and it is still full of 'off-by-one' crashes but
> things are snapping into place.
On Tue, Jan 20, 2004 at 01:43:39PM +, Angus Leeming wrote:
> Andre Poenitz wrote:
>
> >
> > This reduces the mathcursor class to a namespace and moves some
> > stuff to LCursor and InsetBase.
> >
> > There are still 2500 lines to move (1400 from amthcursor and 900
> > from formulabase) and
On Tue, Jan 20, 2004 at 03:05:56PM +0100, Andre' Poenitz wrote:
> > Why does LCursor::innerInsetTabular() exist? Shouldn't this be a
> > wrapper function in an anonymous namespace in insettabular.C?
>
> Possibly, yes.
In fact 'innerInsetOfType' should be sufficient at some point of time.
Andre Poenitz wrote:
>> What's the current_ slice? I thought that the cursor (blinking
>> thing) was always the top-most slice.
>
> We are dispatching to the innermost inset willing to handle an LFUN.
> This means going down the slice stack. Of course we can't just pop
> slices while trying to
On Tue, Jan 20, 2004 at 02:20:52PM +, Angus Leeming wrote:
> Do whatever is easiest for you. Note that Alfredo is pretty good at
> tracking down off by one errors. (You've already warned people not to
> use current cvs for real work.)
*grin*
As 'cvs commit' on A and 'cvs up' on B is
This removes MathIterator by shifting the remaining bits towards the
global cursor.
Both the global cursor and the math cursor now have two CursorSlice
stacks of the same shape...
Andre'
--
Those who desire to give up Freedom in order to gain Security, will not have,
nor do they deserve,
This removes MathIterator by shifting the remaining bits towards the
global cursor.
Both the global cursor and the math cursor now have two CursorSlice
stacks of the same shape...
Andre'
--
Those who desire to give up Freedom in order to gain Security, will not have,
nor do they deserve,
40 matches
Mail list logo
