I had a chance to have a look at the bug in Toc dialog. I guess I
found the source of the error.
When the updateGui is called, the function
ControlToc::getCurrentTocItem() is called. In this routine, item is
turned by
kernel().buffer().tocBackend().item(type,ParConstIterator it);
and ParConstI
Bo Peng wrote:
Good, then apply it ;-)
The patch looks simple but I do not know that part of the code. Please
evaluate the implementation, modify and apply it. It would be best if
the 'click and move' problem Juergen and I noticed can be corrected.
OK, I've taken the time to review it and to
Good, then apply it ;-)
The patch looks simple but I do not know that part of the code. Please
evaluate the implementation, modify and apply it. It would be best if
the 'click and move' problem Juergen and I noticed can be corrected.
Cheers,
Bo
Juergen Spitzmueller wrote:
sending this again, since it doesn't seem to get through first time. Sorry for
potential double posting.
Ozgur Ugras BARAN wrote:
No problem Abdel and thanks Edwin.. To reduce confusion, I have
attached the patch.
I have tested the patch now, and it seems to fix t
Ozgur Ugras BARAN wrote:
> No problem Abdel and thanks Edwin.. To reduce confusion, I have
> attached the patch.
I have tested the patch now, and it seems to fix the remaining issues (and
yes, Abdel, this *is* an improvement ui-wise).
The only remaining glitch I see is that the tree position is
sending this again, since it doesn't seem to get through first time. Sorry for
potential double posting.
Ozgur Ugras BARAN wrote:
> No problem Abdel and thanks Edwin.. To reduce confusion, I have
> attached the patch.
I have tested the patch now, and it seems to fix the remaining issues (and
ye
Thanks, Bo. Juergen, can you also test it, to see if it is enough for
your taste? At the end, you were the one who asked for the feature.
I am not sure if this exists before the patch, but when I click on any
item, it moves to the end of the dialog. This is very distracting
since I have to re-re
Abdelrazak Younes wrote:
> Only the current top level node is opened. The lower lower level child
> nodes are kept closed. You can navigate (including collapse/open) quite
> easily using the arrow keys. I'd say that this is quicker that to use
> the mouse on the slider.
How? It can't seem to make
Ozgur Ugras BARAN wrote:
> Thanks, Bo. Juergen, can you also test it, to see if it is enough for
> your taste? At the end, you were the one who asked for the feature.
Yes. However, probably not before next week.
Jürgen
Abdel, IMO, the last patch makes the TOC slider very useful.
Otherwise, TOC collapses everytime you change the section, which is
very annoying.
On 11/22/06, Bo Peng <[EMAIL PROTECTED]> wrote:
> Sorry Ugras, but I don't have much time today to test your patch. I
> suggest that you send again the
Sorry Ugras, but I don't have much time today to test your patch. I
suggest that you send again the full patch. Then, maybe someone else can
test and commit for you (Edwin, Bo, Georg?). If not, I'll try to do that
at the end of the week.
I heard my name being called. OK, I will try this patch du
Juergen Spitzmueller wrote:
Abdelrazak Younes wrote:
The more I think about it, the more I think this slider is not useful
for any purpose in the Toc dialog. In the former qt3 dialog, the slider
was useful because the nodes won't collapse/open automatically when you
navigate within the document.
Abdelrazak Younes wrote:
> The more I think about it, the more I think this slider is not useful
> for any purpose in the Toc dialog. In the former qt3 dialog, the slider
> was useful because the nodes won't collapse/open automatically when you
> navigate within the document. This is not the case w
Abdelrazak Younes wrote:
Ozgur Ugras BARAN wrote:
On 11/17/06, Abdelrazak Younes <[EMAIL PROTECTED]>
wrote:
Ozgur Ugras BARAN wrote:
> attached patch implement slider in TOC dialog.
>
> I have implemented a getDepth function to get the model indices. In my
> opinion, somebody should derive a ne
Ozgur Ugras BARAN wrote:
On 11/17/06, Abdelrazak Younes <[EMAIL PROTECTED]>
wrote:
Ozgur Ugras BARAN wrote:
> attached patch implement slider in TOC dialog.
>
> I have implemented a getDepth function to get the model indices. In my
> opinion, somebody should derive a new qvariant class for tocMo
On 11/17/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
Ozgur Ugras BARAN wrote:
> attached patch implement slider in TOC dialog.
>
> I have implemented a getDepth function to get the model indices. In my
> opinion, somebody should derive a new qvariant class for tocModelItem
> which saves the
Ozgur Ugras BARAN wrote:
attached patch implement slider in TOC dialog.
I have implemented a getDepth function to get the model indices. In my
opinion, somebody should derive a new qvariant class for tocModelItem
which saves the string data and depth information. that will save the
depth calcula
On 11/17/06, Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
Ozgur Ugras BARAN wrote:
> attached patch implement slider in TOC dialog.
>
> I have implemented a getDepth function to get the model indices. In my
> opinion, somebody should derive a new qvariant class for tocModelItem
> which saves the
Ozgur Ugras BARAN wrote:
attached patch implement slider in TOC dialog.
I have implemented a getDepth function to get the model indices. In my
opinion, somebody should derive a new qvariant class for tocModelItem
which saves the string data and depth information. that will save the
depth calcula
attached patch implement slider in TOC dialog.
I have implemented a getDepth function to get the model indices. In my
opinion, somebody should derive a new qvariant class for tocModelItem
which saves the string data and depth information. that will save the
depth calculation.
I'll be glad somebo
20 matches
Mail list logo
