Re: [patch] another off-by-one

2004-11-14 Thread Juergen Spitzmueller
John Spray wrote: > > Attached patch accounts for this change in stringFromUnit, committing. > > Oops, I forgot that I don't have cvs write outside of frontends/gtk: can > someone else commit this please? Done. Thanks. Jürgen

Re: [patch] another off-by-one

2004-11-13 Thread John Spray
On Sun, 2004-11-14 at 01:34 +, John Spray wrote: > > > - int const num_units = int(sizeof(unit_name) / sizeof(unit_name[0])); > > > + int const num_units = int(sizeof(unit_name) / sizeof(unit_name[0]) - 1; > > Attached patch accounts for this change in stringFromUnit, committing. Oops, I forg

Re: [patch] another off-by-one

2004-11-13 Thread John Spray
> > - int const num_units = int(sizeof(unit_name) / sizeof(unit_name[0])); > > + int const num_units = int(sizeof(unit_name) / sizeof(unit_name[0]) - Attached patch accounts for this change in stringFromUnit, committing. John Index: vspace.C ==

Re: [patch] another off-by-one

2004-11-11 Thread Juergen Spitzmueller
John Spray wrote: > Hmm, I see that num_units is actually the number of units +1.  Why not > fix this in the backend instead, to make the frontend code more obvious? > > - int const num_units = int(sizeof(unit_name) / sizeof(unit_name[0])); > + int const num_units = int(sizeof(unit_name) / sizeof(u

Re: [patch] another off-by-one

2004-11-11 Thread John Spray
On Thu, 2004-11-11 at 12:04 +0100, Juergen Spitzmueller wrote: > This fixes another result of the bug1415-fix (the lengthcombo in qt has an > empty item at the end of its list). - for (int i=0; i < num_units; i++) + for (int i = 0; i < num_units - 1; i++) Hmm, I see that num_units is

[patch] another off-by-one

2004-11-11 Thread Juergen Spitzmueller
This fixes another result of the bug1415-fix (the lengthcombo in qt has an empty item at the end of its list). I'll commit this. Jürgen Index: lengthcombo.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/qt2/lengthcomb