Andre == Andre Poenitz [EMAIL PROTECTED] writes:
Andre Note the i-- is in the 'test' position.
Ha! this is what I did not see!
JMarc
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
Andre> Note the i-- is in the 'test' position.
Ha! this is what I did not see!
JMarc
Andre == Andre Poenitz [EMAIL PROTECTED] writes:
Andre I'd prefer something like
Andre for (size_t i = cur.depth(); i--; )
You have to test for i0 somewhere, don't you?
JMarc
On Thu, Mar 16, 2006 at 10:28:22AM +0100, Jean-Marc Lasgouttes wrote:
Andre == Andre Poenitz [EMAIL PROTECTED] writes:
Andre I'd prefer something like
Andre for (size_t i = cur.depth(); i--; )
You have to test for i0 somewhere, don't you?
Testing for != 0 gives the same result in
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
Andre> I'd prefer something like
Andre> for (size_t i = cur.depth(); i--; )
You have to test for i>0 somewhere, don't you?
JMarc
On Thu, Mar 16, 2006 at 10:28:22AM +0100, Jean-Marc Lasgouttes wrote:
> > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:
>
> Andre> I'd prefer something like
>
> Andre> for (size_t i = cur.depth(); i--; )
>
> You have to test for i>0 somewhere, don't you?
Testing for != 0 gives
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen Thanks. Updated patch attached.
Tested and approved. Please apply to branch and trunk.
JMarc
On Mon, Mar 13, 2006 at 06:32:52PM +0100, Juergen Spitzmueller wrote:
Jean-Marc Lasgouttes wrote:
This does not work for example when the caption is inside a minipage
inside the float (people do that!).
Of course. I forgot that.
You should look at this code snippet from setCounter
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Thanks. Updated patch attached.
Tested and approved. Please apply to branch and trunk.
JMarc
On Mon, Mar 13, 2006 at 06:32:52PM +0100, Juergen Spitzmueller wrote:
> Jean-Marc Lasgouttes wrote:
> > This does not work for example when the caption is inside a minipage
> > inside the float (people do that!).
>
> Of course. I forgot that.
>
> > You should look at this code snippet from
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen http://bugzilla.lyx.org/show_bug.cgi?id=1999 The attached
Juergen patch works perfectly for me.
Juergen What do you think?
This does not work for example when the caption is inside a minipage
inside the float (people do that!).
Jean-Marc Lasgouttes wrote:
This does not work for example when the caption is inside a minipage
inside the float (people do that!).
Of course. I forgot that.
You should look at this code snippet from setCounter (buffer_funcs.C):
Thanks. Updated patch attached.
Jürgen
Index: src/text.C
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=1999 The attached
Juergen> patch works perfectly for me.
Juergen> What do you think?
This does not work for example when the caption is inside a minipage
inside the float (people
Jean-Marc Lasgouttes wrote:
> This does not work for example when the caption is inside a minipage
> inside the float (people do that!).
Of course. I forgot that.
> You should look at this code snippet from setCounter (buffer_funcs.C):
Thanks. Updated patch attached.
Jürgen
Index: src/text.C
http://bugzilla.lyx.org/show_bug.cgi?id=1999
The attached patch works perfectly for me.
What do you think?
Jürgen
Index: src/text.C
===
--- src/text.C (Revision 13335)
+++ src/text.C (Arbeitskopie)
@@ -2264,8 +2264,18 @@ string
Am Samstag, 11. März 2006 15:34 schrieb Juergen Spitzmueller:
http://bugzilla.lyx.org/show_bug.cgi?id=1999
The attached patch works perfectly for me.
For me too.
What do you think?
Looks good. Some hardcoding, but we can't do without unfortunately.
Georg
http://bugzilla.lyx.org/show_bug.cgi?id=1999
The attached patch works perfectly for me.
What do you think?
Jürgen
Index: src/text.C
===
--- src/text.C (Revision 13335)
+++ src/text.C (Arbeitskopie)
@@ -2264,8 +2264,18 @@ string
Am Samstag, 11. März 2006 15:34 schrieb Juergen Spitzmueller:
> http://bugzilla.lyx.org/show_bug.cgi?id=1999
>
> The attached patch works perfectly for me.
For me too.
> What do you think?
Looks good. Some hardcoding, but we can't do without unfortunately.
Georg
18 matches
Mail list logo