Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-17 Thread Jean-Marc Lasgouttes
Andre == Andre Poenitz [EMAIL PROTECTED] writes: Andre Note the i-- is in the 'test' position. Ha! this is what I did not see! JMarc

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-17 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> Note the i-- is in the 'test' position. Ha! this is what I did not see! JMarc

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-16 Thread Jean-Marc Lasgouttes
Andre == Andre Poenitz [EMAIL PROTECTED] writes: Andre I'd prefer something like Andre for (size_t i = cur.depth(); i--; ) You have to test for i0 somewhere, don't you? JMarc

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-16 Thread Andre Poenitz
On Thu, Mar 16, 2006 at 10:28:22AM +0100, Jean-Marc Lasgouttes wrote: Andre == Andre Poenitz [EMAIL PROTECTED] writes: Andre I'd prefer something like Andre for (size_t i = cur.depth(); i--; ) You have to test for i0 somewhere, don't you? Testing for != 0 gives the same result in

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-16 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> I'd prefer something like Andre> for (size_t i = cur.depth(); i--; ) You have to test for i>0 somewhere, don't you? JMarc

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-16 Thread Andre Poenitz
On Thu, Mar 16, 2006 at 10:28:22AM +0100, Jean-Marc Lasgouttes wrote: > > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: > > Andre> I'd prefer something like > > Andre> for (size_t i = cur.depth(); i--; ) > > You have to test for i>0 somewhere, don't you? Testing for != 0 gives

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-15 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen Thanks. Updated patch attached. Tested and approved. Please apply to branch and trunk. JMarc

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-15 Thread Andre Poenitz
On Mon, Mar 13, 2006 at 06:32:52PM +0100, Juergen Spitzmueller wrote: Jean-Marc Lasgouttes wrote: This does not work for example when the caption is inside a minipage inside the float (people do that!). Of course. I forgot that. You should look at this code snippet from setCounter

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-15 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Thanks. Updated patch attached. Tested and approved. Please apply to branch and trunk. JMarc

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-15 Thread Andre Poenitz
On Mon, Mar 13, 2006 at 06:32:52PM +0100, Juergen Spitzmueller wrote: > Jean-Marc Lasgouttes wrote: > > This does not work for example when the caption is inside a minipage > > inside the float (people do that!). > > Of course. I forgot that. > > > You should look at this code snippet from

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-13 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen http://bugzilla.lyx.org/show_bug.cgi?id=1999 The attached Juergen patch works perfectly for me. Juergen What do you think? This does not work for example when the caption is inside a minipage inside the float (people do that!).

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-13 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: This does not work for example when the caption is inside a minipage inside the float (people do that!). Of course. I forgot that. You should look at this code snippet from setCounter (buffer_funcs.C): Thanks. Updated patch attached. Jürgen Index: src/text.C

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-13 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=1999 The attached Juergen> patch works perfectly for me. Juergen> What do you think? This does not work for example when the caption is inside a minipage inside the float (people

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-13 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > This does not work for example when the caption is inside a minipage > inside the float (people do that!). Of course. I forgot that. > You should look at this code snippet from setCounter (buffer_funcs.C): Thanks. Updated patch attached. Jürgen Index: src/text.C

[patch] bug 1999: Wrong default label in figure captions

2006-03-11 Thread Juergen Spitzmueller
http://bugzilla.lyx.org/show_bug.cgi?id=1999 The attached patch works perfectly for me. What do you think? Jürgen Index: src/text.C === --- src/text.C (Revision 13335) +++ src/text.C (Arbeitskopie) @@ -2264,8 +2264,18 @@ string

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-11 Thread Georg Baum
Am Samstag, 11. März 2006 15:34 schrieb Juergen Spitzmueller: http://bugzilla.lyx.org/show_bug.cgi?id=1999 The attached patch works perfectly for me. For me too. What do you think? Looks good. Some hardcoding, but we can't do without unfortunately. Georg

[patch] bug 1999: Wrong default label in figure captions

2006-03-11 Thread Juergen Spitzmueller
http://bugzilla.lyx.org/show_bug.cgi?id=1999 The attached patch works perfectly for me. What do you think? Jürgen Index: src/text.C === --- src/text.C (Revision 13335) +++ src/text.C (Arbeitskopie) @@ -2264,8 +2264,18 @@ string

Re: [patch] bug 1999: Wrong default label in figure captions

2006-03-11 Thread Georg Baum
Am Samstag, 11. März 2006 15:34 schrieb Juergen Spitzmueller: > http://bugzilla.lyx.org/show_bug.cgi?id=1999 > > The attached patch works perfectly for me. For me too. > What do you think? Looks good. Some hardcoding, but we can't do without unfortunately. Georg