Jean-Marc Lasgouttes wrote:
> Juergen> Thanks for the explanation. Jean-Marc, would you accept this
> Juergen> change for 1.3.7 (and for 1.4)?
>
> Yes.
Committed to both trees.
Jürgen
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Angus Leeming wrote:
>> Actually, the bug is nothing to do with the internals of searchKeys
>> which is where the reverse_iterator stuff is used. The bug is,
>> indeed fixed by Jürgen's patch
Juergen> Thanks for the expl
Angus Leeming wrote:
> Actually, the bug is nothing to do with the internals of searchKeys
> which is where the reverse_iterator stuff is used. The bug is, indeed
> fixed by Jürgen's patch
Thanks for the explanation.
Jean-Marc, would you accept this change for 1.3.7 (and for 1.4)?
Jürgen
Jean-Marc Lasgouttes wrote:
> Juergen> Jean-Marc Lasgouttes wrote: // This is correct and always
> Juergen> safe. // (See Meyer's Effective STL, Item 28.) return
> Juergen> (++rit).base();
>>> Isn't it possible to fix this instead? I agree that the code is
>>> not very clear...
>
> Juergen> I can
Jean-Marc Lasgouttes wrote:
> Juergen> Jean-Marc Lasgouttes wrote: // This is correct and always
> Juergen> safe. // (See Meyer's Effective STL, Item 28.) return
> Juergen> (++rit).base();
>>> Isn't it possible to fix this instead? I agree that the code is
>>> not very clear...
>
> Juergen> I can
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote: // This is correct and always
Juergen> safe. // (See Meyer's Effective STL, Item 28.) return
Juergen> (++rit).base();
>> Isn't it possible to fix this instead? I agree that the code is
>> not
Jean-Marc Lasgouttes wrote:
> Juergen> // This is correct and always safe. // (See Meyer's Effective
> Juergen> STL, Item 28.) return (++rit).base();
>
> Isn't it possible to fix this instead? I agree that the code is not
> very clear...
I cannot fix it, because I don't understand it (and I certai
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> The attached patch fixes bug 2002 (citation "find backwards"
Juergen> skips one entry). I'm not really sure about the cause of the
Juergen> bug, but I suppose the following line in biblio.C makes find
Juergen> backward sk
Juergen Spitzmueller wrote:
> The attached patch fixes bug 2002 (citation "find backwards" skips one
> entry).
What about this?
Jürgen
The attached patch fixes bug 2002 (citation "find backwards" skips one entry).
I'm not really sure about the cause of the bug, but I suppose the following
line in biblio.C makes find backward skip the "start" position:
// This is correct and always safe.
// (See Meyer's Effective STL, Item 28.)
10 matches
Mail list logo