Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen I have tried to enhance my witness a bit this year. Here's Juergen how I understand this case: I think the problem is in DEPM: since it deletes a paragraph, the recordUndo call should span two paragraphs (think about deleting a

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

Jean-Marc Lasgouttes wrote: I think the problem is in DEPM: since it deletes a paragraph, the recordUndo call should span two paragraphs (think about deleting a selection that spans more than a paragraph). I propose the following patch. What do you think? I think you are right. I wonder why

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen Jean-Marc Lasgouttes wrote: I think the problem is in DEPM: since it deletes a paragraph, the recordUndo call should span two paragraphs (think about deleting a selection that spans more than a paragraph). I propose the

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

Jean-Marc Lasgouttes wrote: Can you test it a little bit? I may not have thought about everything (for example the min was added after I tried to delete the last line of a paragraph with backspace). I do not have much time for testing ATM. I tested the cases that I also tested with my

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen Jean-Marc Lasgouttes wrote: Can you test it a little bit? I may not have thought about everything (for example the min was added after I tried to delete the last line of a paragraph with backspace). Juergen I do not have much

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> I have tried to enhance my witness a bit this year. Here's Juergen> how I understand this case: I think the problem is in DEPM: since it deletes a paragraph, the recordUndo call should span two paragraphs (think about

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

Jean-Marc Lasgouttes wrote: > I think the problem is in DEPM: since it deletes a paragraph, the > recordUndo call should span two paragraphs (think about deleting a > selection that spans more than a paragraph). > > I propose the following patch. What do you think? I think you are right. I wonder

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> I think the problem is in DEPM: since it deletes a paragraph, the >> recordUndo call should span two paragraphs (think about deleting a >> selection that spans more than a paragraph). >>

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

Jean-Marc Lasgouttes wrote: > Can you test it a little bit? I may not have thought about everything > (for example the min was added after I tried to delete the last line > of a paragraph with backspace). I do not have much time for testing ATM. I tested the cases that I also tested with my

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> Can you test it a little bit? I may not have thought about >> everything (for example the min was added after I tried to delete >> the last line of a paragraph with backspace). Juergen> I

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

Juergen Spitzmueller wrote: Jean-Marc Lasgouttes wrote: I'm very glad that you found the cause, but the fix doesn't look right. Too bad. Then I am at my witness end. I have tried to enhance my witness a bit this year. Here's how I understand this case: After DEPM, doRecordUndo is

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

Juergen Spitzmueller wrote: > Jean-Marc Lasgouttes wrote: > > I'm very glad that you found the > > cause, but the fix doesn't look > > right. > > Too bad. Then I am at my witness end. I have tried to enhance my witness a bit this year. Here's how I understand this case: After DEPM, doRecordUndo

[patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

http://bugzilla.lyx.org/show_bug.cgi?id=2155 The attached patch fixes a major bug (undo crash). See the verbose discussion on bugzilla for details. Comments? Jürgen Index: undo.C === RCS file:

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

I'm very glad that you found the cause, but the fix doesn't look right. JMarc

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

Jean-Marc Lasgouttes wrote: I'm very glad that you found the cause, but the fix doesn't look right. Too bad. Then I am at my witness end. Leaving now to welcome the new year. Have a nice party everybody. Jürgen

[patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

http://bugzilla.lyx.org/show_bug.cgi?id=2155 The attached patch fixes a major bug (undo crash). See the verbose discussion on bugzilla for details. Comments? Jürgen Index: undo.C === RCS file:

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

I'm very glad that you found the cause, but the fix doesn't look right. JMarc

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

Jean-Marc Lasgouttes wrote: > I'm very glad that you found the > cause, but the fix doesn't look > right. Too bad. Then I am at my witness end. Leaving now to welcome the new year. Have a nice party everybody. Jürgen