Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

2006-01-04 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> Can you test it a little bit? I may not have thought about >> everything (for example the min was added after I tried to delete >> the last line of a paragraph with backspace). Juergen> I d

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

2006-01-04 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Can you test it a little bit? I may not have thought about everything > (for example the min was added after I tried to delete the last line > of a paragraph with backspace). I do not have much time for testing ATM. I tested the cases that I also tested with my patch

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

2006-01-04 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> I think the problem is in DEPM: since it deletes a paragraph, the >> recordUndo call should span two paragraphs (think about deleting a >> selection that spans more than a paragraph). >> >>

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

2006-01-04 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > I think the problem is in DEPM: since it deletes a paragraph, the > recordUndo call should span two paragraphs (think about deleting a > selection that spans more than a paragraph). > > I propose the following patch. What do you think? I think you are right. I wonder

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

2006-01-04 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> I have tried to enhance my witness a bit this year. Here's Juergen> how I understand this case: I think the problem is in DEPM: since it deletes a paragraph, the recordUndo call should span two paragraphs (think about de

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

2006-01-02 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > Jean-Marc Lasgouttes wrote: > > I'm very glad that you found the > > cause, but the fix doesn't look > > right. > > Too bad. Then I am at my witness end. I have tried to enhance my witness a bit this year. Here's how I understand this case: After DEPM, doRecordUndo

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

2005-12-31 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > I'm very glad that you found the > cause, but the fix doesn't look > right. Too bad. Then I am at my witness end. Leaving now to welcome the new year. Have a nice party everybody. Jürgen

Re: [patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

2005-12-31 Thread Jean-Marc Lasgouttes
I'm very glad that you found the cause, but the fix doesn't look right. JMarc

[patch] bug 2155: Crash when undoing DEPM deletion of the first par (pit = 0)

2005-12-31 Thread Juergen Spitzmueller
http://bugzilla.lyx.org/show_bug.cgi?id=2155 The attached patch fixes a major bug (undo crash). See the verbose discussion on bugzilla for details. Comments? Jürgen Index: undo.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/u