Re: [patch] dispatch work

2003-10-12 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Please have a look. I wish you'd get rid of whitespace cruft before asking us to look.,, Index: po/POTFILES.in +src/support/path_defines.C while (true) { You add it; I remove it; } Could we add a check for whether file.C.in exists before adding fil

Re: [patch] dispatch work

2003-10-12 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Index: src/lyxtext.h | - InsetOld::RESULT dispatch(FuncRequest const & cmd); | Does this mean you can remove #include "insets/insetbase.h" from | lyxtext.h? I have no idea. Not part of the exercise. | Index: src/insets/insetbase.h | +protected:

Re: [patch] dispatch work

2003-10-13 Thread Andre Poenitz
On Sat, Oct 11, 2003 at 02:43:39PM +0200, Lars Gullik Bjønnes wrote: > > Please have a look. Fine with me with exception of the - virtual dispatch_result localDispatch(FuncRequest const & cmd); - /// /// Get the inset parameters, used by the GUIndependent dialog. Inse

Re: [patch] dispatch work

2003-10-13 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Sat, Oct 11, 2003 at 02:43:39PM +0200, Lars Gullik Bjønnes wrote: >> >> Please have a look. > | Fine with me with exception of the > | - virtual dispatch_result localDispatch(FuncRequest const & cmd); | - /// | /// Get the inset p

Re: [patch] dispatch work

2003-10-13 Thread Andre Poenitz
On Sun, Oct 12, 2003 at 11:53:16PM +0200, Lars Gullik Bjønnes wrote: > Are there a standard way? If there are a standard way it would be to > call the public interface "pubdispatch" and the private one > "dispatch". Boys, may I ask you not to introduce new programming tenets to LyX (right now at l

Re: [patch] dispatch work

2003-10-13 Thread Andre Poenitz
On Mon, Oct 13, 2003 at 10:00:10AM +0200, Lars Gullik Bjønnes wrote: > | with FuncResult being > > > | struct FuncResult { > | dispatch_result res; > | idx_type idx; > | pos_type pos; > | }; > > Are you sure that no dispatch ever uses the idx and pos pas

Re: [patch] dispatch work

2003-10-13 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Sun, Oct 12, 2003 at 11:53:16PM +0200, Lars Gullik Bjønnes wrote: >> Are there a standard way? If there are a standard way it would be to >> call the public interface "pubdispatch" and the private one >> "dispatch". > | Boys, may I ask you not to intr

Re: [patch] dispatch work

2003-10-13 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Oct 13, 2003 at 10:00:10AM +0200, Lars Gullik Bjønnes wrote: >> | with FuncResult being >> > >> |struct FuncResult { >> |dispatch_result res; >> |idx_type idx; >> |pos_type pos; >> |}; >> >> Are you su

Re: [patch] dispatch work

2003-10-13 Thread Angus Leeming
Andre Poenitz wrote: > On Sun, Oct 12, 2003 at 11:53:16PM +0200, Lars Gullik Bjønnes wrote: >> Are there a standard way? If there are a standard way it would be >> to call the public interface "pubdispatch" and the private one >> "dispatch". > > Boys, may I ask you not to introduce new programmin

Re: [patch] dispatch work

2003-10-13 Thread Andre Poenitz
On Mon, Oct 13, 2003 at 10:21:43AM +0200, Lars Gullik Bjønnes wrote: > | LyX has much more serious problems than not following the latest > | ideas of the greatest gurus. > > Your are off to ranting again. (why is it only your problems that are > real?) My real problem is that I probably won't be

Re: [patch] dispatch work

2003-10-13 Thread Andre Poenitz
On Mon, Oct 13, 2003 at 09:32:18AM +, Angus Leeming wrote: > > Boys, may I ask you not to introduce new programming tenets to LyX > > (right now at least)? > > Speaking for myself, I have been getting LyX's interaction with > outside files to just work. I have no idea how many 'official' bugs

Re: [patch] dispatch work

2003-10-13 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Oct 13, 2003 at 10:21:43AM +0200, Lars Gullik Bjønnes wrote: >> | LyX has much more serious problems than not following the latest >> | ideas of the greatest gurus. >> >> Your are off to ranting again. (why is it only your problems that are >> r

Re: [patch] dispatch work

2003-10-13 Thread Andre Poenitz
On Mon, Oct 13, 2003 at 11:03:50AM +0200, Lars Gullik Bjønnes wrote: > | And given a choice of implementing Yet Another Feature or > | fixing Yet Another Bug ... or ranting a bit... > but you did neither... > > | I thought it was more prudent to point to a few > | issues which hamper LyX devel

Re: [patch] dispatch work

2003-10-13 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Oct 13, 2003 at 11:03:50AM +0200, Lars Gullik Bjønnes wrote: >> | And given a choice of implementing Yet Another Feature or >> | fixing Yet Another Bug > | ... or ranting a bit... > >> but you did neither... >> >> | I thought it was more prude

Re: [patch] dispatch work

2003-10-13 Thread Andre Poenitz
On Mon, Oct 13, 2003 at 11:41:14AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Mon, Oct 13, 2003 at 11:03:50AM +0200, Lars Gullik Bjønnes wrote: > >> | And given a choice of implementing Yet Another Feature or > >> | fixing Yet Another Bug > > > | ... o

Re: [patch] dispatch work

2003-10-13 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: >> Still there are drawing bugs, cursor placement bugs, undo bugs, C&P >> bugs. I am sure all of them can be fixed, but is it easy? > | I am not talking about the core stuff. I am. And where do we have all the regressions? Where did they come from? --

Re: [patch] dispatch work

2003-10-13 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > >>> Still there are drawing bugs, cursor placement bugs, undo bugs, >>> C&P bugs. I am sure all of them can be fixed, but is it easy? >> > | I am not talking about the core stuff. > > I am. > > And where do we have all the

Re: [patch] dispatch work

2003-10-13 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Stop this point scoring and fix a bug! Can't code. Eating. When finished... I'll try to do one bug at a time, problem is of course that I do not _really_ grasp the metrics/update stuff. And it is the update stuff that I'd like to focus on first, curren

Re: [patch] dispatch work

2003-10-13 Thread John Levon
On Mon, Oct 13, 2003 at 12:51:42PM +0200, Lars Gullik Bj?nnes wrote: > Would be good if someone could go through bugzilla and check all the > bugs marked with "crash" and see if it is relevant for current CVS. > All that is relevant and all new crashing bugs should get 1.4.0CVS as > Target. I did