Re: [patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-12 Thread Bernhard Roider
What about a different idea: since the problem is the hardcoding of RasterImage, we could replace it by code like the following. After thinking about this solution again i found a crash one case: If there is no Template definition in the user defined external_templates file then the line

Re: [patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-09 Thread Jean-Marc Lasgouttes
> "José" == José Matos <[EMAIL PROTECTED]> writes: José> On Monday 09 July 2007 11:19:22 Jean-Marc Lasgouttes wrote: >> José, is this patch OK? José> Yes. Done thanks. JMarc

Re: [patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-09 Thread José Matos
On Monday 09 July 2007 11:19:22 Jean-Marc Lasgouttes wrote: > José, is this patch OK? Yes. > JMarc -- José Abílio

Re: [patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-09 Thread Jean-Marc Lasgouttes
> "Bernhard" == Bernhard Roider <[EMAIL PROTECTED]> writes: >> What about a different idea: since the problem is the hardcoding of >> RasterImage, we could replace it by code like the following. >> Bernhard> This solution looks good to me and should go in imho. José, is this patch OK? JMar

Re: [patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-06 Thread Bernhard Roider
I'm on holiday for 10 days now, so decide what to do and commit the result. I would be happy if this patch could go in for 1.5 Bernhard

Re: [patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-06 Thread Bernhard Roider
Jean-Marc Lasgouttes schrieb: "Bernhard" == Bernhard Roider <[EMAIL PROTECTED]> writes: Bernhard> Hello, with the attached patch lyx loads all Bernhard> external_template definitions from 1. user_lyxdir 2. Bernhard> build_lyxdir 3. system_lyxdir I'd rather not do it right now. We have to decid

Re: [patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-06 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> What I mean is that we should not change that 4 days before >> releasing 1.5.0. I do not understand how the same people who urge >> at releasing fast at the same time want to do far reaching changes >> now for problems nobody c

Re: [patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-06 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: I do not think we shall warn about duplicated entries. Abdelrazak> I think we should: I personally prefer different names for Abdelrazak> different things so I'd be glad if LyX warns me that a Abdelraza

Re: [patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-06 Thread Jean-Marc Lasgouttes
> "Bernhard" == Bernhard Roider <[EMAIL PROTECTED]> writes: Bernhard> Hello, with the attached patch lyx loads all Bernhard> external_template definitions from 1. user_lyxdir 2. Bernhard> build_lyxdir 3. system_lyxdir I'd rather not do it right now. We have to decide what is our policy for ha

Re: [patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-06 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> I do not think we shall warn about duplicated entries. Abdelrazak> I think we should: I personally prefer different names for Abdelrazak> different things so I'd be glad if LyX warns me that a Abdelrazak> global (maybe updated

Re: [patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-06 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I think the choice of template is an important one to the Abdelrazak> user and deserves a full warning dialog. Otherwise I have Abdelrazak> no objection to your patch, seems clean. I do not th

Re: [patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-06 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I think the choice of template is an important one to the Abdelrazak> user and deserves a full warning dialog. Otherwise I have Abdelrazak> no objection to your patch, seems clean. I do not think we shall warn about d

Re: [patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-05 Thread Abdelrazak Younes
Bernhard Roider wrote: Hello, with the attached patch lyx loads all external_template definitions from 1. user_lyxdir 2. build_lyxdir 3. system_lyxdir If there are template or preamble definitions with the same name from different sources then lyx prints a warning message to the console and t

[patch] fix Bug 3983: system external_template file is ignored when user defined external_template file exists

2007-07-05 Thread Bernhard Roider
Hello, with the attached patch lyx loads all external_template definitions from 1. user_lyxdir 2. build_lyxdir 3. system_lyxdir If there are template or preamble definitions with the same name from different sources then lyx prints a warning message to the console and the first definition (in t