Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-16 Thread Guenter Milde
On 2015-06-15, Georg Baum wrote: > Uwe Stöhr wrote: >> Am 09.06.2015 um 20:38 schrieb Georg Baum: ... >>> At least the function names (e.g. quotedWinPath) suggest that the quoting >>> is still windows specific. >> Yes, because this function is only called if the OS is Windows, for all >> other O

Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-15 Thread Georg Baum
Uwe Stöhr wrote: > Am 09.06.2015 um 20:38 schrieb Georg Baum: > >>> Attached is a better patch that does this. It also extends the fix to >>> for libreoffice. >> >> It still has this complicated quoting. I still do not understand why it >> has to be done this way. > > Could you make a proposal t

Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-15 Thread Guenter Milde
On 2015-06-14, Uwe Stöhr wrote: > could you please do me the favor and make a new patch out of mine? I'm > not good in python but then I get your idea correctly, can test it and > maybe fine-tune it for Windows. Patch uploaded to the bug report. Give it a try. Günter

Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-14 Thread Uwe Stöhr
Am 09.06.2015 um 11:03 schrieb Guenter Milde: The problem with the current code is this line: ac_word = ac_prog.split(' ')[0] Not, if you separate path and program call, e.g. (path, ac_prog) = os.path.split("path to\binary of\inkscape --help") would result in: program call ac_p

Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-14 Thread Uwe Stöhr
Am 09.06.2015 um 20:38 schrieb Georg Baum: Quoting a path with spaces is definitely needed for the command interpreter, but in every sane programming language you do not need to do it if you structure your program a bit. In this case, it means to put the path into one variable, and the program n

Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-09 Thread Georg Baum
Uwe Stöhr wrote: > Am 04.06.2015 um 18:17 schrieb Georg Baum: > >>> Could some pythionist please review this? >> >> First you need to explain why you use this complicated quoting, and what >> problem it solves. >> If such a quoting is really needed, > > Of course it is necessary otherwise I woul

Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-09 Thread Guenter Milde
On 2015-06-08, Uwe Stöhr wrote: > Am 04.06.2015 um 23:31 schrieb Guenter Milde: >> Do you really need a full path to the binary on Windows? > Yes. OK. >> Please keep the current distinction of >>program call (ac_prog) >>program name (ac_word) >>path (path) >> even i

Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-08 Thread Uwe Stöhr
Am 04.06.2015 um 23:31 schrieb Guenter Milde: Do you really need a full path to the binary on Windows? Yes. AFAIK, there is a PATH variable also on DOS, so it should be possible to call the "inkscape" program "by name" instead. No, this would only work if a program is in the PATH variable.

Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-08 Thread Uwe Stöhr
Am 04.06.2015 um 18:17 schrieb Georg Baum: Could some pythionist please review this? First you need to explain why you use this complicated quoting, and what problem it solves. If such a quoting is really needed, Of course it is necessary otherwise I wouldn't have done it that way. Since Py

Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-04 Thread Guenter Milde
On 2015-06-03, Uwe Stöhr wrote: > [-- Type: text/plain, Encoding: 7bit --] > The attached patch fixes > http://www.lyx.org/trac/ticket/7657 > for me. > Could some pythionist please review this? > If this can go in I would be able to fix the same bug for other > third-party programs. Do you re

Re: [patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-04 Thread Georg Baum
Uwe Stöhr wrote: > The attached patch fixes > http://www.lyx.org/trac/ticket/7657 > for me. > > Could some pythionist please review this? First you need to explain why you use this complicated quoting, and what problem it solves. If such a quoting is really needed, then it needs to be wrapped

[patch] fix bug 7657 - Inkscape detection in configure.py

2015-06-03 Thread Uwe Stöhr
The attached patch fixes http://www.lyx.org/trac/ticket/7657 for me. Could some pythionist please review this? If this can go in I would be able to fix the same bug for other third-party programs. thanks and regards Uwe diff --git "a/C:\\Users\\Usti\\AppData\\Local\\Temp\\TortoiseGit\\con141