Re: [patch] fix qt pref converters mess crash

2004-11-08 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen While doing this, I have also fixed the crash when adding a Juergen new file format, as described in bug 1692: Juergen http://bugzilla.lyx.org/show_bug.cgi?id=1692 The crash was Juergen cured by adding converters().update() calls

Re: [patch] fix qt pref converters mess crash

2004-11-08 Thread Jürgen Spitzmüller
Also sprach Jean-Marc Lasgouttes: This crash was 1.4.0cvs only, right? yes. Jürgen

Re: [patch] fix qt pref converters mess crash

2004-11-08 Thread Andre Poenitz
On Sun, Nov 07, 2004 at 09:30:21PM +, John Levon wrote: On Sun, Nov 07, 2004 at 09:32:50PM +0100, Andre Poenitz wrote: + connect(convertersModule-converterToCO, SIGNAL(activated(const QString)), this, SLOT(converter_changed())); LyXStyle would be 'QString const '.

Re: [patch] fix qt pref converters mess & crash

2004-11-08 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> While doing this, I have also fixed the crash when adding a Juergen> new file format, as described in bug 1692: Juergen> http://bugzilla.lyx.org/show_bug.cgi?id=1692 The crash was Juergen> cured by adding

Re: [patch] fix qt pref converters mess & crash

2004-11-08 Thread Jürgen Spitzmüller
Also sprach Jean-Marc Lasgouttes: > This crash was 1.4.0cvs only, right? yes. Jürgen

Re: [patch] fix qt pref converters mess & crash

2004-11-08 Thread Andre Poenitz
On Sun, Nov 07, 2004 at 09:30:21PM +, John Levon wrote: > On Sun, Nov 07, 2004 at 09:32:50PM +0100, Andre Poenitz wrote: > > > + connect(convertersModule->converterToCO, SIGNAL(activated(const > > QString&)), this, SLOT(converter_changed())); > > > > LyXStyle would be 'QString

[patch] fix qt pref converters mess crash

2004-11-07 Thread Juergen Spitzmueller
The attached patch tries to clear the confusion people have when trying to add a new converter with the qt frontend. Cf. http://bugzilla.lyx.org/show_bug.cgi?id=1488 The ui was just horrible. I think the xforms ui is much more intuitive in this case. I adapted it for the qt frontend. (the

Re: [patch] fix qt pref converters mess crash

2004-11-07 Thread Lars Gullik Bjønnes
Juergen Spitzmueller [EMAIL PROTECTED] writes: | The attached patch tries to clear the confusion people have when trying to add | a new converter with the qt frontend. Cf. | http://bugzilla.lyx.org/show_bug.cgi?id=1488 | The ui was just horrible. I think the xforms ui is much more intuitive in

Re: [patch] fix qt pref converters mess crash

2004-11-07 Thread Andre Poenitz
On Sun, Nov 07, 2004 at 08:00:43PM +0100, Juergen Spitzmueller wrote: OK to apply? Can't comment much on th ui as I haven't tried it out. However, I have some style comments/questions. @@ -173,6 +174,10 @@ QPrefsDialog::QPrefsDialog(QPrefs * form

Re: [patch] fix qt pref converters mess crash

2004-11-07 Thread John Levon
On Sun, Nov 07, 2004 at 09:32:50PM +0100, Andre Poenitz wrote: + connect(convertersModule-converterToCO, SIGNAL(activated(const QString)), this, SLOT(converter_changed())); LyXStyle would be 'QString const '. I know that early MOC had a problem with that, but as 3.3.3's moc

Re: [patch] fix qt pref converters mess crash

2004-11-07 Thread Juergen Spitzmueller
Also sprach Andre Poenitz: On Sun, Nov 07, 2004 at 08:00:43PM +0100, Juergen Spitzmueller wrote: OK to apply? Can't comment much on th ui as I haven't tried it out. However, I have some style comments/questions. @@ -173,6 +174,10 @@ QPrefsDialog::QPrefsDialog(QPrefs * form

Re: [patch] fix qt pref converters mess crash

2004-11-07 Thread Juergen Spitzmueller
John Levon wrote: See 1488 comment 1. Anyway, I don't think *either* interfaces are any good as it happens. But since you fixed a crash, we can use your patch I suppose. Are you sure that it really created an empty converter? That means, we had an empty item in the comboxes. That'd be no more

[patch] fix qt pref converters mess & crash

2004-11-07 Thread Juergen Spitzmueller
The attached patch tries to clear the confusion people have when trying to add a new converter with the qt frontend. Cf. http://bugzilla.lyx.org/show_bug.cgi?id=1488 The ui was just horrible. I think the xforms ui is much more intuitive in this case. I adapted it for the qt frontend. (the

Re: [patch] fix qt pref converters mess & crash

2004-11-07 Thread Lars Gullik Bjønnes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: | The attached patch tries to clear the confusion people have when trying to add | a new converter with the qt frontend. Cf. | http://bugzilla.lyx.org/show_bug.cgi?id=1488 | The ui was just horrible. I think the xforms ui is much more intuitive

Re: [patch] fix qt pref converters mess & crash

2004-11-07 Thread Andre Poenitz
On Sun, Nov 07, 2004 at 08:00:43PM +0100, Juergen Spitzmueller wrote: > OK to apply? Can't comment much on th ui as I haven't tried it out. However, I have some style comments/questions. @@ -173,6 +174,10 @@ QPrefsDialog::QPrefsDialog(QPrefs * form

Re: [patch] fix qt pref converters mess & crash

2004-11-07 Thread John Levon
On Sun, Nov 07, 2004 at 09:32:50PM +0100, Andre Poenitz wrote: > + connect(convertersModule->converterToCO, SIGNAL(activated(const > QString&)), this, SLOT(converter_changed())); > > LyXStyle would be 'QString const &'. > > I know that early MOC had a problem with that, but as

Re: [patch] fix qt pref converters mess & crash

2004-11-07 Thread Juergen Spitzmueller
Also sprach Andre Poenitz: > On Sun, Nov 07, 2004 at 08:00:43PM +0100, Juergen Spitzmueller wrote: > > OK to apply? > > Can't comment much on th ui as I haven't tried it out. > > However, I have some style comments/questions. > > @@ -173,6 +174,10 @@ QPrefsDialog::QPrefsDialog(QPrefs * form

Re: [patch] fix qt pref converters mess & crash

2004-11-07 Thread Juergen Spitzmueller
John Levon wrote: > See 1488 comment 1. Anyway, I don't think *either* interfaces are any > good as it happens. But since you fixed a crash, we can use your patch I > suppose. Are you sure that it really created an empty converter? That means, we had an "empty" item in the comboxes. That'd be no