Re: [patch] selection in source panel

2007-08-25 Thread Jürgen Spitzmüller
Alfredo Braunstein wrote: > I fixed some glitches and I have positive reports from Enrico and Bo. Even > if the patch seems safe, this is just a small feature. I'll wait a little > bit longer if everything works as expected for everyone. OK. Jürgen

Re: [patch] selection in source panel

2007-08-25 Thread Alfredo Braunstein
Jürgen Spitzmüller wrote: > Alfredo Braunstein wrote: >> > Yes for trunk. Wait for Juergen if you want branch too. >> >> Commited. If there are no problems with the new feature in the next days >> I'll ask Juergen. > > OK if everything works as expected and you are confident about it. I fixed so

Re: [patch] selection in source panel

2007-08-25 Thread Jürgen Spitzmüller
Alfredo Braunstein wrote: > > Yes for trunk. Wait for Juergen if you want branch too. > > Commited. If there are no problems with the new feature in the next days > I'll ask Juergen. OK if everything works as expected and you are confident about it. Jürgen

Re: [patch] selection in source panel

2007-08-17 Thread Alfredo Braunstein
Bo Peng wrote: > Just let you know that after the layout files are correctly installed, > the view panel works fine. Niiice I don't have to install qt 4.1 (or trick someone into fixing it) ;-) A/

Re: [patch] selection in source panel

2007-08-17 Thread Bo Peng
Just let you know that after the layout files are correctly installed, the view panel works fine. Cheers, Bo

Re: [patch] selection in source panel

2007-08-16 Thread Enrico Forestieri
On Thu, Aug 16, 2007 at 02:04:02PM +0200, Alfredo Braunstein wrote: > Ugh. We could set the font explicitly I guess, don't know if this makes > sense. Here you can change font size on the widget with C-MouseWheel. Cool! Didn't know that trick. It works with all Qt versions, the only difference b

Re: [patch] selection in source panel

2007-08-16 Thread Alfredo Braunstein
Enrico Forestieri wrote: > We can also rule out 4.1.4, as it differs from 4.1.5 by an epsilon. Ok. >> Wrt. to the glitch, the attached should fix it, hopefully without >> introducing other glitches. It turns out it is trickier than it may seem >> to get all corner cases right (1 position -> mul

Re: [patch] selection in source panel

2007-08-16 Thread Enrico Forestieri
On Thu, Aug 16, 2007 at 10:53:54AM +0200, Alfredo Braunstein wrote: > Enrico Forestieri wrote: > > > I don't know what exactly does not work. I am testing it with Qt 4.1.5 > > Neither do I unfortunately :-( It seems only some qt (sub)versions are > affected? Bo, could you give a specific (small)

Re: [patch] selection in source panel

2007-08-16 Thread Alfredo Braunstein
Enrico Forestieri wrote: > I don't know what exactly does not work. I am testing it with Qt 4.1.5 Neither do I unfortunately :-( It seems only some qt (sub)versions are affected? Bo, could you give a specific (small) test case? > on cygwin. After opening the View Source window, when I position t

Re: [patch] selection in source panel

2007-08-15 Thread Enrico Forestieri
On Thu, Aug 16, 2007 at 05:42:26AM +0200, Enrico Forestieri wrote: > Rather, there's a problem with Qt 4.3. The line in the View Source > window is highlighted only when clicking on the View Source scroll > bar. However, when doing so, the cursor in the main window disappears, > such that you visu

Re: [patch] selection in source panel

2007-08-15 Thread Enrico Forestieri
On Thu, Aug 16, 2007 at 12:38:28AM +0200, Alfredo Braunstein wrote: > Bo Peng wrote: > > >> > qt422, I am trying 4.1. > >> > >> qt-4.2.3 here. > > > > Qt 4.1 does not work here. Please try 4.1 (the version lyx uses) if > > possible. > > Assuming the problem is the qt version, for me installing

Re: [patch] selection in source panel

2007-08-15 Thread Alfredo Braunstein
Bo Peng wrote: >> > qt422, I am trying 4.1. >> >> qt-4.2.3 here. > > Qt 4.1 does not work here. Please try 4.1 (the version lyx uses) if > possible. Assuming the problem is the qt version, for me installing qt 4.1 is a real PITA, and I would like to avoid it if possible. So if someone with qt4.

Re: [patch] selection in source panel

2007-08-13 Thread Jean-Marc Lasgouttes
"Bo Peng" <[EMAIL PROTECTED]> writes: >> What? Do we require qt=4.1, not qt>=4.1 nowadays? > > Yeap. No, we require >= 4.1. JMarc

Re: [patch] selection in source panel

2007-08-13 Thread Alfredo Braunstein
Bo Peng wrote: >> What? Do we require qt=4.1, not qt>=4.1 nowadays? > > Yeap. That's kind of absurd... what other problems qt>4.1 gives? A/

Re: [patch] selection in source panel

2007-08-13 Thread Bo Peng
> What? Do we require qt=4.1, not qt>=4.1 nowadays? Yeap. Bo

Re: [patch] selection in source panel

2007-08-13 Thread Alfredo Braunstein
Bo Peng wrote: >> > qt422, I am trying 4.1. >> >> qt-4.2.3 here. > > Qt 4.1 does not work here. Please try 4.1 (the version lyx uses) if > possible. What? Do we require qt=4.1, not qt>=4.1 nowadays? A/

Re: [patch] selection in source panel

2007-08-13 Thread Bo Peng
> > qt422, I am trying 4.1. > > qt-4.2.3 here. Qt 4.1 does not work here. Please try 4.1 (the version lyx uses) if possible. Bo

Re: [patch] selection in source panel

2007-08-13 Thread Alfredo Braunstein
Bo Peng wrote: >> It all looks fine here, could you give a detailed explanation for a very >> short document? >> >> Btw, what's your qt version? > > > qt422, I am trying 4.1. qt-4.2.3 here. A/

Re: [patch] selection in source panel

2007-08-13 Thread Bo Peng
> It all looks fine here, could you give a detailed explanation for a very > short document? > > Btw, what's your qt version? qt422, I am trying 4.1. Bo

Re: [patch] selection in source panel

2007-08-13 Thread Alfredo Braunstein
Bo Peng wrote: >> >> Ah yes, forgot one problem with the very last line of source code, could >> you try the attached? > > Does not work either. It helps a little bit but the gray cursor either > covers the first source line, or the whole paragraph. It all looks fine here, could you give a detai

Re: [patch] selection in source panel

2007-08-13 Thread christian . ridderstrom
On Mon, 13 Aug 2007, Bo Peng wrote: But you get WYSIWYGI rather than WYSIWYM, right? What is that 'I' after WYSIWYG? bakoma can do WYSIWYG (of course with My typo, ignore the 'I' :-) /C -- Christian Ridderström, +46-8-768 39 44 http://www.md.kth.se/~chr

Re: [patch] selection in source panel

2007-08-13 Thread Bo Peng
> > Ah yes, forgot one problem with the very last line of source code, could you > try the attached? Does not work either. It helps a little bit but the gray cursor either covers the first source line, or the whole paragraph. Bo

Re: [patch] selection in source panel

2007-08-13 Thread Bo Peng
> > I recently tested a WYSIWYG latex application called bakoma. It hacks > > dvi viewer and allow edition in dvi mode, and in latex source window. > > Using a dvi viewer/editor avoids all our layout troubles. Pretty > > impressed. > > But you get WYSIWYGI rather than WYSIWYM, right? What is that

Re: [patch] selection in source panel

2007-08-13 Thread Alfredo Braunstein
Bo Peng wrote: >> Commited. If there are no problems with the new feature in the next days >> I'll ask Juergen. > > This feature does not work in the trunk. Ah yes, forgot one problem with the very last line of source code, could you try the attached? A/ Index: TexRow.cpp =

Re: [patch] selection in source panel

2007-08-13 Thread christian . ridderstrom
On Mon, 13 Aug 2007, Bo Peng wrote: Not in the near future but... Yes! And I think that Andre's work (TeXStream) may help in this direction. In principle the TeXStream (or a class derived from it) could store the 1:1 table of correspondence between cursor positions and chunks of latex. The expor

Re: [patch] selection in source panel

2007-08-13 Thread Bo Peng
> Not in the near future but... Yes! And I think that Andre's work (TeXStream) > may help in this direction. In principle the TeXStream (or a class derived > from it) could store the 1:1 table of correspondence between cursor > positions and chunks of latex. The export function could call something

Re: [patch] selection in source panel

2007-08-13 Thread Bo Peng
> Commited. If there are no problems with the new feature in the next days > I'll ask Juergen. This feature does not work in the trunk. Bo

Re: [patch] selection in source panel

2007-08-13 Thread Alfredo Braunstein
Bo Peng wrote: >> Commited. If there are no problems with the new feature in the next days >> I'll ask Juergen. > > Just curious, do you have further plan for this feature such as > accurate cursor matching? This will help if someday we want to turn > view source to edit source. Not in the near

Re: [patch] selection in source panel

2007-08-13 Thread Bo Peng
> Commited. If there are no problems with the new feature in the next days > I'll ask Juergen. Just curious, do you have further plan for this feature such as accurate cursor matching? This will help if someday we want to turn view source to edit source. Cheers, Bo

Re: [patch] selection in source panel

2007-08-13 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > Alfredo Braunstein <[EMAIL PROTECTED]> writes: > >> Is this the right time for this patch? > > Yes for trunk. Wait for Juergen if you want branch too. Commited. If there are no problems with the new feature in the next days I'll ask Juergen. A/

Re: [patch] selection in source panel

2007-08-09 Thread Jean-Marc Lasgouttes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: > Is this the right time for this patch? Yes for trunk. Wait for Juergen if you want branch too. JMarc

Re: [patch] selection in source panel

2007-08-09 Thread Bo Peng
> > > >> On 8/8/07, Alfredo Braunstein <[EMAIL PROTECTED]> > >> wrote: > >>> Is this the right time for this patch? > > Is it? Not exactly, because many are drunk at Bromarv, and the rest are watching what they will do after they get drunk. > What the... In any case I'll apply the thing as soon a

Re: [patch] selection in source panel

2007-08-09 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > "Bo Peng" <[EMAIL PROTECTED]> writes: > >> On 8/8/07, Alfredo Braunstein <[EMAIL PROTECTED]> >> wrote: >>> Is this the right time for this patch? Is it? >> Using a vector and remove count in class TexRow() simplify the code a >> lot, but this makes me wonder why a

Re: [patch] selection in source panel

2007-08-08 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > "Bo Peng" <[EMAIL PROTECTED]> writes: > >> On 8/8/07, Alfredo Braunstein <[EMAIL PROTECTED]> >> wrote: >>> Is this the right time for this patch? >> >> Using a vector and remove count in class TexRow() simplify the code a >> lot, but this makes me wonder why a list w

Re: [patch] selection in source panel

2007-08-08 Thread Jean-Marc Lasgouttes
"Bo Peng" <[EMAIL PROTECTED]> writes: > On 8/8/07, Alfredo Braunstein <[EMAIL PROTECTED]> wrote: >> Is this the right time for this patch? > > Using a vector and remove count in class TexRow() simplify the code a > lot, but this makes me wonder why a list was used in the first place. > Is there a

Re: [patch] selection in source panel

2007-08-08 Thread Bo Peng
On 8/8/07, Alfredo Braunstein <[EMAIL PROTECTED]> wrote: > Is this the right time for this patch? Using a vector and remove count in class TexRow() simplify the code a lot, but this makes me wonder why a list was used in the first place. Is there a lot of insertion going on? Bo

[patch] selection in source panel

2007-08-08 Thread Alfredo Braunstein
Is this the right time for this patch? Buffer.cpp | 14 -- TexRow.cpp | 59 +++- TexRow.h| 29 ++--- frontends/controllers/ControlViewSource.cpp | 15 +