Re: A possible patch. Opinions solicited.

2001-09-24 Thread Juergen Vigna
On 21-Sep-2001 Jean-Marc Lasgouttes wrote: Angus It's a one-line fix, but I don't know if it's the right fix. Angus Perhaps someone with some knowledge of this part of the code Angus would cast their beady eyes over it. I think it is good enough. Anyway selectNextWord is only used by No

Re: A possible patch. Opinions solicited.

2001-09-24 Thread Angus Leeming
On Monday 24 September 2001 10:21, Jean-Marc Lasgouttes wrote: Juergen == Juergen Vigna [EMAIL PROTECTED] writes: Juergen No IMO this should be solved in the ERT-Inset, by overriding Juergen the functions for selectNextWord, otherwise we soon will have Juergen a big switch there with all

Re: A possible patch. Opinions solicited.

2001-09-24 Thread Juergen Vigna
On 24-Sep-2001 Angus Leeming wrote: InsetERT::selectNextWordToSpellcheck now returns string(). Well does it unlock itself? The function should look like: string const InsetERT::selectNextWordToSpellcheck(BufferView * bv, float ) const { bv-unlockInset(const_castInsetERT *(this));

Re: A possible patch. Opinions solicited.

2001-09-24 Thread Angus Leeming
On Monday 24 September 2001 15:05, Juergen Vigna wrote: On 24-Sep-2001 Angus Leeming wrote: InsetERT::selectNextWordToSpellcheck now returns string(). Well does it unlock itself? No it didn't. The function should look like: string const

Re: A possible patch. Opinions solicited.

2001-09-24 Thread Juergen Vigna
On 24-Sep-2001 Angus Leeming wrote: Does this help? Yes it does! All works correctly, so I've committed it. Good! :) Jürgen -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax:

Re: A possible patch. Opinions solicited.

2001-09-24 Thread Juergen Vigna
On 21-Sep-2001 Jean-Marc Lasgouttes wrote: > Angus> It's a one-line fix, but I don't know if it's the "right" fix. > Angus> Perhaps someone with some knowledge of this part of the code > Angus> would cast their beady eyes over it. > > I think it is good enough. Anyway selectNextWord is only

Re: A possible patch. Opinions solicited.

2001-09-24 Thread Angus Leeming
On Monday 24 September 2001 10:21, Jean-Marc Lasgouttes wrote: > > "Juergen" == Juergen Vigna <[EMAIL PROTECTED]> writes: > > Juergen> No IMO this should be solved in the ERT-Inset, by overriding > Juergen> the functions for selectNextWord, otherwise we soon will have > Juergen> a big switch

Re: A possible patch. Opinions solicited.

2001-09-24 Thread Juergen Vigna
On 24-Sep-2001 Angus Leeming wrote: > InsetERT::selectNextWordToSpellcheck now returns string(). Well does it unlock itself? The function should look like: string const InsetERT::selectNextWordToSpellcheck(BufferView * bv, float &) const { bv->unlockInset(const_cast(this));

Re: A possible patch. Opinions solicited.

2001-09-24 Thread Angus Leeming
On Monday 24 September 2001 15:05, Juergen Vigna wrote: > On 24-Sep-2001 Angus Leeming wrote: > > > InsetERT::selectNextWordToSpellcheck now returns string(). > > Well does it unlock itself? No it didn't. > The function should look like: > > string const

Re: A possible patch. Opinions solicited.

2001-09-24 Thread Juergen Vigna
On 24-Sep-2001 Angus Leeming wrote: >> Does this help? > > Yes it does! All works correctly, so I've committed it. Good! :) Jürgen -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N

A possible patch. Opinions solicited.

2001-09-21 Thread Angus Leeming
From Michael's bug list: - The spellchecker should ignore ERTs The patch attached achieves this by modifying LyXText::selectNextWord. A word is not selected if it is inside an ERT inset. It's a one-line fix, but I don't know if it's the right fix. Perhaps someone with some knowledge of this

Re: A possible patch. Opinions solicited.

2001-09-21 Thread Angus Leeming
On Friday 21 September 2001 15:41, Jean-Marc Lasgouttes wrote: Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus From Michael's bug list: - The spellchecker should ignore ERTs Angus The patch attached achieves this by modifying Angus LyXText::selectNextWord. A word is not selected

A possible patch. Opinions solicited.

2001-09-21 Thread Angus Leeming
From Michael's bug list: - The spellchecker should ignore ERTs The patch attached achieves this by modifying LyXText::selectNextWord. A word is not selected if it is inside an ERT inset. It's a one-line fix, but I don't know if it's the "right" fix. Perhaps someone with some knowledge of

Re: A possible patch. Opinions solicited.

2001-09-21 Thread Angus Leeming
On Friday 21 September 2001 15:41, Jean-Marc Lasgouttes wrote: > > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> From Michael's bug list: - The spellchecker should ignore ERTs > > Angus> The patch attached achieves this by modifying > Angus> LyXText::selectNextWord. A word