Re: Bug #3812: Comments on patch

2007-06-10 Thread Jürgen Spitzmüller
Michael Gerz wrote: Maybe I was talking nonsense. I just looked at the patch (without the surrounding code). It looked like you check for the first character and then match(...) tries to match the complete string. On a second thought, you might be right. The attached patch does what you

Re: Bug #3812: Comments on patch

2007-06-10 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: On a second thought, you might be right. The attached patch does what you propose and works for me. OK to apply? This patch also fixes bug 3160: http://bugzilla.lyx.org/show_bug.cgi?id=3160 Jürgen

Re: Bug #3812: Comments on patch

2007-06-10 Thread Alfredo Braunstein
Jürgen Spitzmüller wrote: Jürgen Spitzmüller wrote: On a second thought, you might be right. The attached patch does what you propose and works for me. OK to apply? This patch also fixes bug 3160: http://bugzilla.lyx.org/show_bug.cgi?id=3160 This patch looks fine. Regards, A/

Re: Bug #3812: Comments on patch

2007-06-10 Thread Jürgen Spitzmüller
Alfredo Braunstein wrote: This patch looks fine. committed now. Jürgen

Re: Bug #3812: Comments on patch

2007-06-10 Thread Jürgen Spitzmüller
Michael Gerz wrote: > Maybe I was talking nonsense. I just looked at the patch (without the > surrounding code). It looked like you check for the first character and > then match(...) tries to match the complete string. On a second thought, you might be right. The attached patch does what you

Re: Bug #3812: Comments on patch

2007-06-10 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > On a second thought, you might be right. The attached patch does what you > propose and works for me. > > OK to apply? This patch also fixes bug 3160: http://bugzilla.lyx.org/show_bug.cgi?id=3160 Jürgen

Re: Bug #3812: Comments on patch

2007-06-10 Thread Alfredo Braunstein
Jürgen Spitzmüller wrote: > Jürgen Spitzmüller wrote: >> On a second thought, you might be right. The attached patch does what you >> propose and works for me. >> >> OK to apply? > > This patch also fixes bug 3160: > http://bugzilla.lyx.org/show_bug.cgi?id=3160 This patch looks fine. Regards,

Re: Bug #3812: Comments on patch

2007-06-10 Thread Jürgen Spitzmüller
Alfredo Braunstein wrote: > This patch looks fine. committed now. Jürgen

Bug #3812: Comments on patch

2007-06-09 Thread Michael Gerz
Jürgen, your patch looks nice in general. I can imagine that it even fixes #3160. Below please find some additional comments. Michael Index: src/lyxfind.cpp === --- src/lyxfind.cpp (Revision 18711) +++ src/lyxfind.cpp

Re: Bug #3812: Comments on patch

2007-06-09 Thread Jürgen Spitzmüller
Michael Gerz wrote:   for (; cur; cur.forwardChar()) - if (cur.inTexted() match(cur.paragraph(), cur.pos())) + if (cur.inTexted() +     (find_del || !cur.paragraph().isDeleted(cur.pos())) +     match(cur.paragraph(), cur.pos()))    

Re: Bug #3812: Comments on patch

2007-06-09 Thread Michael Gerz
Jürgen Spitzmüller schrieb: Michael Gerz wrote: for (; cur; cur.forwardChar()) - if (cur.inTexted() match(cur.paragraph(), cur.pos())) + if (cur.inTexted() + (find_del || !cur.paragraph().isDeleted(cur.pos())) +

Bug #3812: Comments on patch

2007-06-09 Thread Michael Gerz
Jürgen, your patch looks nice in general. I can imagine that it even fixes #3160. Below please find some additional comments. Michael Index: src/lyxfind.cpp === --- src/lyxfind.cpp (Revision 18711) +++ src/lyxfind.cpp

Re: Bug #3812: Comments on patch

2007-06-09 Thread Jürgen Spitzmüller
Michael Gerz wrote: > >   for (; cur; cur.forwardChar()) > > - if (cur.inTexted() && match(cur.paragraph(), cur.pos())) > > + if (cur.inTexted() && > > +     (find_del || !cur.paragraph().isDeleted(cur.pos())) && > > +     match(cur.paragraph(),

Re: Bug #3812: Comments on patch

2007-06-09 Thread Michael Gerz
Jürgen Spitzmüller schrieb: Michael Gerz wrote: for (; cur; cur.forwardChar()) - if (cur.inTexted() && match(cur.paragraph(), cur.pos())) + if (cur.inTexted() && + (find_del || !cur.paragraph().isDeleted(cur.pos())) && +